- 07 Oct, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c59193cb7ce..44a55afebe67 Created with: gclient setdep -r src-internal@44a55afebe67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib3ca54a810749f2be18c20d600a1bddc785bccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844360Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703264}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ddbd321fd7d7..939454821c49 git log ddbd321fd7d7..939454821c49 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 rmhasan@google.com Revert "[Telemetry] Remove --verbose option and Popen hook" 2019-10-07 rmhasan@google.com [typ] Add optional file manager arugment to Artifacts constructor 2019-10-04 khokhlov@google.com [Telemetry] Remove --verbose option and Popen hook Created with: gclient setdep -r src/third_party/catapult@939454821c49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:985712,chromium:982208,chromium:985712 Change-Id: I237c5d466adb3e4cbaae65839fda056390f5cc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703263}
-
Ulan Degenbaev authored
This adds IDL files and an experimental feature flag for the API. The implementation simply forwards to v8::Isolate::MeasureMemory. Bug: 973627 Change-Id: I80ac8b78e81a6fad6b25370b419a0392f6589cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796364Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703262}
-
Peter Kasting authored
Bug: 82078 Change-Id: Iebfc438ca750766748023d2ea2acfc59c3fb2803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842960 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703261}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I02d90db13767179c8286e9febf4fbdfa459824ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703260}
-
arthursonzogni authored
There is a weird code: ~~~ if (!find_in_page_ || !find_in_page_.is_bound() || !find_in_page_.is_connected()) GetRemoteAssociatedInterfaces()->GetInterface(&find_in_page_); ~~~ The functions: AssociatedRemote::(operator bool) AssociatedRemote::is_bound() are the same. So there is no need call both. Moreover, using AssociatedRemote::is_connected() here is risky. It means it can call GetInterface on an already bound AssociatedRemote, which will trigger a DCHECK. I can reproduce this depending on race conditions. To make things correct and simpler here, we just reproduce the same pattern used by the other AssociatedRemote stored in the RenderFrameHostImpl. Change-Id: I81507242853691de6ff4ee75f54e6911983e3f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841471Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703259}
-
Benedikt Meurer authored
Previously background parsing and compilation was always labeled "Parse Script" whereas foreground parsing and compilation was always labeled "Compile Script". But in either case the engine might parse and/or compile, so we should be consistent here. Also for developers it doesn't really matter whether V8 is parsing or compiling to bytecode. Bug: chromium:940958 Change-Id: I320095e10613d7cc1405069345e0dd0613a7130a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844993Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703258}
-
Huanzhong Huang authored
Introduce a toggle in the incognito ntp that links to cookie controls setting. Layout should be fixed in a subsequent cl. Bug: 967668 Change-Id: Icedcae6575ae84b1ed6ef2feb353e0f0ae1b37c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826900 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#703257}
-
Roman Sorokin authored
Also removed paddings overrides from the sync consent screen and fingerpring setup screen. Bug: 1009531, 1000606, 1011284 Change-Id: I1b22cd2619691d628feb5a5bb084105ee41a4d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844952 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#703256}
-
Mathias Bynens authored
Explicitly passing `'no-preference'` as a CSS media feature value has different semantics than passing the empty string (which clears the emulation override), causing difficult-to-debug issues. Bug: chromium:1011722, chromium:1004246 Change-Id: I371681ba646306d4f5e8bff10e8c502329a87093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844816Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#703255}
-
Mikel Astiz authored
This reverts commit c305a2ba. Reason for revert: DCHECK failures observed on ios. Original change's description: > Send variation headers to sync server > > This information is already sent to other servers such as the one used > for omnibox personalization, hence the patch doesn't upload additional > information but allows measuring the impact variations have on the sync > server and debug errors caused by client-side experiments. > > Bug: 887521 > Change-Id: I3358956639bf96260bb5010279012195086eec37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700678} TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 887521, 1011088 Change-Id: I07fb576d156cf9efd334ce89617e9a823db61662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844814Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703254}
-
Edward Jung authored
will-change property causes the page background not to respond to the background colour change. The CL scopes that property away from iOS devices. Bug: 1008776 Change-Id: I4bc2bd8fde0e9f60389be8be55108ad77b8bf8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834228Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#703253}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01fdeab2a3a2..df2a8385c33d git log 01fdeab2a3a2..df2a8385c33d --date=short --no-merges --format='%ad %ae %s' 2019-10-06 ilkos@google.com Scrape real uid at onPids Created with: gclient setdep -r src/third_party/perfetto@df2a8385c33d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141914164 Change-Id: I6590b88a1a3928b3b5aa2250efcab01e23472ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703252}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/523df09a..6413c178 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I63d7e5e45af42089f5068280e42ba029a5856590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703251}
-
Javier Ernesto Flores Robles authored
Bug: 1834141 Change-Id: I67f95f6ffd9f35b8197b0cb9c8021eaaa62aa1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834147 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#703250}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 181fcf74. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 69c11064 "[WPT/upgrade-insecure-requests] Regenerate files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I73071fffd365d907f534a7ef984340c13235819a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844393Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703249}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5e9d4ee99ea1..23d6a0e668bf git log 5e9d4ee99ea1..23d6a0e668bf --date=short --no-merges --format='%ad %ae %s' 2019-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 135e3e35ea87..4b97a1108114 (1 commits) Created with: gclient setdep -r src/third_party/angle@23d6a0e668bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I25840131d002ef731947ea2e8708df06f3050f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844233Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703248}
-
Mario Sanchez Prada authored
This file was out-of-sync after recent migrations, let's fix it. Bug: 955171, 978694 Change-Id: Id6a85b66c50cd36d64bf9b4d8e1c04860959a48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844973Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#703247}
-
Patrik Höglund authored
Tbr: rogerta@chromium.org Bug: 1011193 Change-Id: I3a3abad10e5b75a7e5c0bb1aadf6ea7415e0fd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844976Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703246}
-
Fredrik Söderquist authored
This adds a |is_updating_intervals_| flag to SMILTimeContainer, and sets it in UpdateIntervals() and when calling Reset() on the sandwiches. When this flag is true SMILTimeContainer::ScheduleIntervalUpdate() will not schedule an update since UpdateIntervals() (in both cases) will handle the update. This should allow getting rid of the SVGImage::ScheduleTimelineRewind() hack. Bug: 998526 Change-Id: Iad31f2684db40dc71f254d7d19f57a4538272a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841332 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703245}
-
Benedikt Meurer authored
Previously the DevTools UI would strip out //# sourceURL=... and //@ sourceURL=... lines from the script in the frontend no matter where they showed up in the source code, which means that all the positions after this line will be off by 1 between frontend and backend. It's generally also very confusing to developers that we're removing code from the script before showing it. In general, we should just display exactly the code that the developer wrote (similar to Firefox DevTools and Safari WebInspector), however there's quite a bit of internal logic relying on the special handling of sourceURL comments (at the end), for example when it comes to snippets. So meanwhile we only remove the comments when they are found at the end of the source code, which is where tools put them. Bug: chromium:1003497 Change-Id: I4404e2f7b6b61d50f85e44bbd9e0ae56675670af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840512 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703244}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8fa0f1a6567c..c18c9ff6bc30 git log 8fa0f1a6567c..c18c9ff6bc30 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 stevenperron@google.com Handle OpKill better (#2933) 2019-10-04 greg@lunarg.com Generate null pointer by converting uint64 zero to pointer. (#2935) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c18c9ff6bc30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I31896afdb0faf401a9cb53270856885b14e67a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703243}
-
Kenichi Ishibashi authored
To generate better trace log for performance investigation. Bug: 1011214 Change-Id: I7dc2e5d0c06674e1e11322d3d41975f040b68825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844522 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703242}
-
Colin Blundell authored
This value has no meaningful usage in the codebase. Its removal has ripple effects: - chrome_extension_messages.h is no longer needed and is removed - cast_extension_messages.{cc, h} are no longer needed and are removed This CL is part of the ongoing effort to eliminate the legacy IPC system. Change-Id: Icc8a679d0da0f58df99f9692ba2be5ebee42966b Bug: 1007300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834091 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#703241}
-
Dave Tapuska authored
These definitions are no longer needed. BUG=978694 Change-Id: Ia066b668bc60754101d0e267e9669f082a7bb5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842036 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#703240}
-
Rohit Agarwal authored
This reverts commit ca5efa8e. Reason for revert: A regression bug was crbug.com/1009377 created because of this CL. Original change's description: > Restart in the profile type that invoked it. > > If the user started the browser in incognito mode and > triggered a restart in regular mode, the browser was started > in the incognito mode. Similarly, if the user started in the > regular mode and triggered a restart in the incognito mode, > the browser was started in the regular mode. > > The fix is to find the profile type that invoked the restart. > Then use this type to modify old switch arguments which are used > to create the new cmd line arguments for restart. > > Bug: 999085 > Change-Id: Ide6e86aabb90b5a333ec10ea23e3add62a3d0e34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789582 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694717} TBR=vasilii@chromium.org,rhalavati@chromium.org,roagarwal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 999085 Change-Id: Ie3351c13cdb8f01f1e5c5088c7c6e72f936d569f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839793Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703239}
-
Patrik Höglund authored
This should be re-enabled when the root cause is found. Tbr: mythria@chromium.org Bug: 1011515 Change-Id: I563e102241896021f1b0837953db00c958097aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844953Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703238}
-
Ewann authored
-call |-removeEmptySections| in |-setEditing:animated:| before resetting the property. needsSectionCleanupAfterEditing needs to be removed when dropping iOS 12. Bug: 998491 Change-Id: I38cef305e1763120b402f1904f21c29c48ce024a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832273Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#703237}
-
Yuki Shiino authored
Bug: 1011723 Change-Id: Ib87b425eebfb43234f54b5d696856a59b9b33cb1 Tbr: aaronhk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844753Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#703236}
-
Patrik Höglund authored
Appears someone attempted to disable this, but it's DISABLED, not DISABLE. Tbr: emaxx@chromium.org Bug: 1011606 Change-Id: I00e8dc774029c811fbce4ab4874135f749ff5013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844812Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703235}
-
Peter Kasting authored
Also other misc. cleanup, e.g. use make_unique more. Bug: 82078 Change-Id: Ibe4384e74b905d4fc60392edf258663ddc6bc5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844339 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#703234}
-
Andreas Haas authored
We want to reduce direct uses of WTF::ArrayBuffer and co in the context of a refactoring. R=hongchan@chromium.org Bug: chromium:1008840 Change-Id: I3d5ec9c4484821cb9954ecbcafb27091e597d03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828906Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#703233}
-
Kenichi Ishibashi authored
This CL introduces yet another variant of FetchClientSettingsObject which is used for passing FetchClientSettingsObject between blink and content. For now it is only used for dedicated workers but we plan to use WebFetchClientSettingsObject for service workers too. Ideally WebFetchClientSettingsObject shouldn't be needed. Once the Onion Soup is done we should just use mojom::FetchClientSettingsObject. This CL does not change existing behavior. Bug: 937177 Tbr: kinuko@chromium.org Change-Id: I224eadeca49ac4a18c3fdf4ef8507e7eb2be4d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843995 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703232}
-
Francois Buergisser authored
Currently, the picture size is set to the CAPTURE buffer but CAPTURE buffer references the picture size of the OUTPUT buffer. If the picture size if set to CAPTURE, Hantro will ignore it and use the OUTPUT picture size which is not set, therefore using the minimum size available (48x48). This patch sets the picture size to the OUTPUT buffer instead of the CAPTURE buffer following the initialization specification for m2m stateless video decoder [1]. [1] https://hverkuil.home.xs4all.nl/codec-api/uapi/v4l/dev-stateless-decoder.html#initialization BUG=chromium:1009935 TEST=ran video_decode_accelerator_tests with test-25fps.h264 and test-25fps.vp8 on veyron_minnie-kernelnext. Signed-off-by:
Francois Buergisser <fbuergisser@chromium.org> Change-Id: Ib343d8a0b177470aa39018141170212c1f524979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832851Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#703231}
-
Hiroshige Hayashizaki authored
Initially we considered forbidding scripts moved between different *context* documents, but it might be be helpful for code health to also forbid scripts moved between different *element* documents. In order to investigate its feasibility, this CL adds a use counter for such scripts. Bug: 721914 Change-Id: I09a984dab98f615ee9a75d72edb1220cba42627f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843509Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#703230}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e92ee0ae0d32..d9301feae3fd git log e92ee0ae0d32..d9301feae3fd --date=short --no-merges --format='%ad %ae %s' 2019-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5549ef0451f9..5e9d4ee99ea1 (14 commits) 2019-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6021fbd09b1c..036463457e5f (8 commits) 2019-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 24e29940..78225ef2 (481 commits) Created with: gclient setdep -r src/third_party/skia@d9301feae3fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I1c028318152cf8e89307011cd9a261abbef4161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703229}
-
Koji Ishii authored
Ran rebaseline-cl twice but this test doesn't stabilize only on Mac10.10. TBR=yukishiino@chromium.org NOTRY=true Bug: 1011453, 1010662 Change-Id: I147d1c81d3a5c4be0a36c173109cd25ddb67a22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843799Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703228}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7eb4caf5..523df09a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7c72a0e1d2043de6dbdb2683e824e3e14ca0279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1f4e5bcb19ea..1167bff3e9a6 git log 1f4e5bcb19ea..1167bff3e9a6 --date=short --no-merges --format='%ad %ae %s' 2019-10-06 wl@gnu.org * src/sfnt/sfwoff2 (reconstruct_glyf): Fix reallocation. 2019-10-06 wl@gnu.org Improve memory debugging. 2019-10-06 wl@gnu.org docs/DEBUG: Document environment variable `FT2_KEEP_ALIVE'. Created with: gclient setdep -r src/third_party/freetype/src@1167bff3e9a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Idbeb0c24828d6bf779664f0778c0805ed8373415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#703226}
-
Chromium WPT Sync authored
Using wpt-import in Chromium da0efe3e. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 69c11064 "[WPT/upgrade-insecure-requests] Regenerate files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie8f3ff9b2682db625b275e78ed02dac29e6cb3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844032Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703225}
-