- 01 Sep, 2020 40 commits
-
-
Anatoliy Potapchuk authored
We did not have proper checks for |app_launcher_| previously, causing it to behave unexpectedly/crash for cases of ARC kiosk, when this variable was not set. Now, we are setting this value properly and there should be no failures. Also making KioskLaunchController tests generic. Bug: 1121911 Change-Id: I1acec49f251391c4060ba46725a754ed6de48cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385379 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#803437}
-
Takashi Toyoshima authored
This patch removes a runtime enabled feature OutOfBlinkCors as the feature was fully launched and the runtime flag should be always enabled in Blink. This patch contains only trivial changes, and will leave TODOs for additional works to remove some more functions. As blink unit tests run without the runtime flag enabled, following tests do not work with OOR-CORS and do not make much sense any more. They are removed in this patch too. - ThreadableLoaderTest::DidFailRedirectCheck - ThreadableLoaderTest::CancelInDidFailRedirectCheck - ThreadableLoaderTest::ClearInDidFailRedirectCheck Redirect limits are not handled in the ThreadableLoader any more. Redirect-loop emulated at the mock layer does not make sense, and does not generate any error and these tests just hang-up. This is part of the work to remove the kOutOfBlinkCors feature. - WebAssociatedURLLoaderTest::CrossOriginWithAccessControlSuccess - WebAssociatedURLLoaderTest::CrossOriginWithAccessControlFailure - WebAssociatedURLLoaderTest::RedirectCrossOriginWithAccessControlFailure These tests verify very basic CORS functionalities for BlinkCORS. As ThreadableLoader does not handle CORS checks any more, these unit tests are not a right place to ensure that. We already have similar tests for CorsURLLoader in the network service, and wpt provides enough integration tests. - ResourceLoaderTest::ResponseType This test verifies if ResourceLoader can calculate response tainting for BlinkCORS. As CORS checks are disabled in ResourceLoader and we just use the type provided via network service, we don't need this test. Bug: 1053866, 1003943 Change-Id: I656a86a42873ddbeafeae70d611b3072b6926c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379336Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#803436}
-
Kent Tamura authored
Fold it into LayoutFlexibleBox, which is the current super class. This CL has no behavior changes. Bug: 1040826 Change-Id: I8ebdf9b508e0253f3ac6781a340c15cf4b3b1e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386440 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803435}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f428aa39ca2b..8a0ebd40f86d 2020-08-31 jaebaek@google.com Correctly replace debug lexical scope of instruction (#3718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I892ea85a32811293d000362f56cb4b89f3e25dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803434}
-
Side Yilmaz authored
This CL corrects the bug number in TODO that states need for using correct profile in KeyboardAccessoryIPHUtils. Since TrackerFactory returns same instance for both regular and off-the-record profile, the code blocks work correct, but they are not safe in case of future change in underlying code. This CL makes the correction on comment as well. Bug: 1041781 Change-Id: If989ff26ddef811ab82d8eeb954054e507c01f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385376Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#803433}
-
Benoit Lize authored
base::LockImpl should not be used directly, and is no longer used outside of base. Make its member functions private to enforce that. Bug: 1061437 Change-Id: I4797e08a548edb4d1e77e969071955c8759a1ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379682Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803432}
-
Henrik Boström authored
As of implementing Perfect Negotiation these WPTs have been timing out on some bots. Running locally, the tests are very slow to run (because some of them are stress tests) and anecdotally it takes 20-30 seconds; but I've never been able to repro a real failure locally. I can't tell if the Timeouts on the bots are due to real bugs or due to the tests simply being too slow to run on bot infra. This CL splits the tests up into separate files, giving each test more time to run. This CL also makes the stress tests run for less iterations. With these changes, it is reasonable to assume that the bots will be able to run them unless we have a real bug. Let's re-enable the tests with these changes and keep an eye on the bots... TBR=hta@chromium.org Bug: chromium:1123832 Change-Id: Ief43b998479caf91f9216718d6b7259e01256202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386796Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803431}
-
Koji Ishii authored
The regression was only for |NGPaintFragment|, and it works as expected when |FragmentItem| is enabled. This patch adds a test to avoid possible regressions in future. Bug: 1123375 Change-Id: Ic7e1f941e8ae887b5b571e7f510cf3d8d9870e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387464 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#803430}
-
Friedrich Horschig authored
By resizing the fields for origin and username, they are properly aligned if the layout direction changes. Screenshots in the linked bug. Bug: 1122517, 1092444 Change-Id: I4aecec81ad84bd71072eacbd87ca63bc2bab3cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377815Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803429}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1598857126-da6d6f9c34b393846886ccd27545501972c5d864.profdata to chrome-win32-master-1598908665-e5f1c62a762858adc54e97055fdde89a186c58c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I57aec5bb014560f722177c5741a99b9ecb458a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386674Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGInlineNodeDataEditor::VerifyItem()| not to crash when there are no inline items after editing. This situation can be happend when editable contains only an editing text node holds only collapsed spaces, e.g. "ab" => " ". When Text node contains only collapsed space, we don't attach layout object then we don't call |LayoutText::SetTextWithOffset()|. But when Text node is editing text, we attach layout object then |VerifyItem()| is called for no inline items. Bug: 1123251 Change-Id: I7e88e461d7cb3f1a37cfae8a9a4a196ef2cbc02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386917 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Philipp Hancke authored
the related standard currentRoundTripTime is defined in seconds: https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime and having the calculated stat on a different timescale is confusing. BUG=None Change-Id: Iac04deef1bb0c346c5bd7e08a944764b4c29e845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300100Reviewed-by:
-
Alice Wang authored
TBR=estade@chromium.org Bug: 1123852 Change-Id: I2205c0c8e20a01d757c45b85c71495346382f39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387568Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#803425}
-
Gauthier Ambard authored
about_flags.* is already owned by everyone to allow for easy addition of flags. This CL is doing the same for its BUILD.gn file to allow for easier addition of new flags. Bug: None Change-Id: I343351d361620b1977951d0769db54cde8444b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385301 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#803424}
-
Eugene But authored
After crrev.com/c/953723 the code on iOS and non-iOS platforms has diverged and there is no code that can be shared. Bug: None Change-Id: Ib80dcda88904df5a0d50a392d5d0c3dbbac60c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385888 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#803423}
-
Justin Cohen authored
Change-Id: I49d19a57d9cafab3d6986f5e3beb15dfcc8dbe4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379950Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803422}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598831810-48c324362c2be2fbbcf6a178b22d323ccaa14725.profdata to chrome-mac-master-1598939551-edd6085454846bcef7c23e82dabdb750adc99d31.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie1e4f568f6bd58c7a1f6aaa77d488d5cc78282c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387379Reviewed-by:
-
Mohamed Amir Yosef authored
This reverts commit 252fed6f. Reason for revert: This test testMinidumpFromRendererHang is consistenly failing in many builders e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-arc-r-chrome Original change's description: > Add hung renderer minidump test > > Adds a test for exercising Telemetry's hung renderer detection/crashing > code. If Telemetry detects a hung renderer, it should crash the hung > renderer process and the GPU process so that we can get minidumps to > diagnose the root cause. > > Bug: 1119564 > Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803200} TBR=bsheedy@chromium.org,johnchen@chromium.org Change-Id: I98f3e0e3d62c6f1c291105bdb8f7990381879749 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386797Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#803420}
-
Alex Ilin authored
The workaround to hide the profile menu view before showing the ProfileSigninConfirmationDialog is no longer needed. The dialog is now modal on all platforms and takes the focus away from all other menus. * Original bug: https://crbug.com/404711 Change-Id: I3b2dc4cfe2b0f8f36e8539ff6ee52024fe78b8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386736 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#803419}
-
Alex Ilin authored
Modal dialogs shouldn't have the X close button. This button is redundant as the dialog already has the Cancel button. Screenshot: https://drive.google.com/file/d/1eYpxgg4HuPjdpXs2Ea6FeRp3KPGFRWnF/view?usp=sharing Fixed: 1122471 Change-Id: I179e34e8bceac980d9835332e2d7dc521a67f4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387015 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Mathias Bynens authored
Prior to a recent change [1], `InspectorOverlayAgent::SetInspectTool` would call `InspectorOverlayAgent::LoadFrameForTool` which assigns to `overlay_page_`. With the patch, that no longer happened, resulting in `STATUS_ACCESS_VIOLATION` “oh snap” errors when using the “capture area screenshot” functionality in DevTools. This patch moves the “is the inspector agent enabled” check around so that we don’t hit any `nullptr`s while still getting the desired behavior of not rendering inspector overlays while taking screenshots. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2235553 Bug: chromium:1091037, chromium:1122038 Change-Id: I36ab8b883f1e643bcc89ebaed4063cc1409ee466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387560Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#803417}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d325ca00b9a..af609dca0136 2020-09-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I838df6edea4612318fcf46164c37657f37952850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387372Reviewed-by:
-
Karel Král authored
Remove a TODO asking to support more kinds as this todo is no longer actual. All types are supported except two deprecated ones (covered by another comment) and typemapped types which should be supported in |base/trace_event/trace_conversion_helper.h|. Bug: 1103623 Change-Id: I5c2e44cc46e6b4b83be8c175b07a2f785dc805d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385278 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803415}
-
Ewann authored
This CL is developed under a flag. It adds an action sheet that asks for confirmation when 'Close All' button is tapped on the tab grid to avoid unwanted clearing Metrics related to the "Close all" button have been moved in the mediator. Bug: 1119319 Change-Id: Ie1901b7f24faf63745290310efef805d11859940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362925 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#803414}
-
Chris Lu authored
When a presenting popup infobar is replaced, the request is removed from the queue, set as removed_request_awaiting_dismissal_ in OverlayPresenter, and UI is dismissed. But, dismissal logic is async and resetting the request_ property of OverlayPresentationContext requires waiting for OverlayUIWasDismissed() callback. In the meantime, changing active WebStates causes the OverlayPresenter to ask the OverlayPresentationContext to hide its presented request by calling HideOverlayUI and passing the current front of the queue as the request to hide. This is where there is a discrepancy and a DCHECK on request_ fails. Check for removed_request_awaiting_dismissal_ before assuming the front request is the currently presenting request. Bug: 1120786 Change-Id: Icb25572bfcf9fb7450c2b7ce6d00eb3a3915e8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383011Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#803413}
-
Ewann authored
This CL adds the following metrics: - IOS.OpenIn.Presented (user action) - IOS.OpenIn is renamed in IOS.OpenIn.Tapped" (user action) - IOS.OpenIn.MIMEType (histogram) And removes support for USDZ files. Bug: 1117398 Change-Id: Id7fbe91c73a8fc7859392b4cd492c283020c13f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377925Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1598262024-benchmark-87.0.4247.0-r1 to 87-4183.74-1598869788-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I561b135ccc229e4ee59eaf03be714c02b1938cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387373Reviewed-by:
-
Rachel Carpenter authored
This reverts (part of) commit 6c131c38. Reason for revert: pak file got wrongly included Original change's description: > Use common App Service profile checks for incognito redirect. > > https://crrev.com/c/2318888 added a "GetOriginalProfile" call to fix a > crash in incognito. Unfortunally that introduced a new crash for Guest > sessions. GetOriginalProfile() returns something that crashes when > trying to open a browser - see https://crbug.com/1121553. Add a new > method to AppService to handle the profile redirects correctly and in a > single place. > > Also adds more tests. > > Bug: 1122480 > Change-Id: I63e3d2766d61b416d1e7590bc67a937b817848ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381230 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803399} TBR=tapted@chromium.org,dominickn@chromium.org,carpenterr@chromium.org Change-Id: If4f71581eddd4cffbd4a61ccef6bdee9f3c891f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386909 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803410}
-
Rachel Wong authored
This histogram was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2374466 but the names were mismatched. Since no data has ever been emitted to this histogram, we can change the name in histograms.xml. Bug: 1113960 Change-Id: Ie04a48c197a8217d2957837d828050522ca9c084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386686Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#803409}
-
sauski authored
Added JS type checking for: - privacy_page_test.js - clear_browsing_data_browser_proxy.js Bug: 1000989 Change-Id: I98d2a388a150af153c50118a994fa3c9e83ac37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377722Reviewed-by:dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#803408}
-
Kent Tamura authored
Fold it into LayoutBox and NGBlockNode like other controls. This CL has no behavior changes. Bug: 1040826 Change-Id: I7b54724afbaca12d300d2c27a4dd5f7068770ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386904Reviewed-by:
-
Weilun Shi authored
Besides normalizing the histograms paths in the index file, we also need to normalize all paths in the |histogram_paths.HISTOGRAMS_XMLS_RELATIVE| because it contains a hardcode path. Change-Id: I820de86efc7b816c0dba52e42838cbc55b5319c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386837 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#803406}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/59d28532a179..c0dda02196e8 2020-09-01 cclao@google.com Vulkan: release the ImageHelper's staging buffer after flush If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: If1b1ba4c61bf1efdae6dcde3beea4e970f038085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387304Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-87.0.4247.0-r1 to 87-4183.84-1598867895-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ica9d3a5a48e3dbe074836bacefef6f702fc53681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387371Reviewed-by:
-
Makoto Shimazu authored
Bug: n/a Change-Id: I2fc0288c129276b19757f74044be6169ce0915e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384690Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803403}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3913d3e137ed..a551fd288101 2020-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2f291c0bd181 to c0dda02196e8 (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I5492a01e0e0d3186a5101cb28e3f13d30b7d2363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387314Reviewed-by:
-
Minggang Wang authored
Recently, the SplitCacheDedicatedWorkersScripts test becomes flaky because of memory leak reported on ASan Linux build. The reason is that the nested dedicated worker thread blocks its parent dedicated worker termination when shutting down, as the parent thread will wait all its child threads to be terminated and terminate itself in the end. But the render main thread won't wait any worker thread, so the main thread may terminate earlier than the worker thread, which causes the memory leak sometimes. This patch changes the test case to close the nested dedicated worker in advance, so it will not block its parent thread when shutting down, also, re-enables the cases. Change-Id: I5c7ae0bb875862ab81a2ab76c429ebd40d46b302 Bug: 1104847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352509 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-87.0.4247.0-r1 to 87-4183.84-1598870250-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5ae2f77db5625965ceb0b4b406b060e4ddd388b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387370Reviewed-by:
-
Rachel Carpenter authored
https://crrev.com/c/2318888 added a "GetOriginalProfile" call to fix a crash in incognito. Unfortunally that introduced a new crash for Guest sessions. GetOriginalProfile() returns something that crashes when trying to open a browser - see https://crbug.com/1121553. Add a new method to AppService to handle the profile redirects correctly and in a single place. Also adds more tests. Bug: 1122480 Change-Id: I63e3d2766d61b416d1e7590bc67a937b817848ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381230Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#803399}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I641c684321d8506afa936293f7e706e9e6ba24ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387312Reviewed-by:
-
