- 02 May, 2018 40 commits
-
-
Joel Einbinder authored
When a RuntimeModel with multiple execution contexts was removed, some of the execution contexts could be unintentionally left in the ConsoleContextSelector. Change-Id: I8fea191af5a2f02c1de350866d29ddffe24338f6 Reviewed-on: https://chromium-review.googlesource.com/1038794Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#555296}
-
sangwoo.ko authored
In order to set proper bounds for active tab which is being dragged, TabStrin::StartedDraggingTabs() should be called after ResetSelection(). Bug: 836004 Change-Id: I7243bf75b1d3243e55892386f2a5debc092bf925 Reviewed-on: https://chromium-review.googlesource.com/1027590 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555295}
-
Alexei Filippov authored
The agent is going to be removed soon. The ExecutionContextWorkerRegistry is made responsible for reporting workers. Each worker is reported as a trace event when a worker starts. Also all previously registred workers are reported on trace start. Change-Id: I3cde31ae74e991ad522c476b606bee3c0a5f8587 Reviewed-on: https://chromium-review.googlesource.com/1038684Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#555294}
-
Ken Rockot authored
Using a normal skia Bitmap mojom type means that large frames may be transmitted as shared memory regions, which in turn means that animations with more than 64 large frames can cause DecodeAnimation's reply to exceed Mojo's self-imposed per-message handle limitation. This is a temporary solution which restores DecodeAnimation to using inline bitmap data (which it did prior to CL:1004598). Bug: 838706 Change-Id: I53542a0070b6d554b52c6b0e3576b94af233a9f4 Reviewed-on: https://chromium-review.googlesource.com/1038760Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555293}
-
Kent Tamura authored
Bug: 836071 Change-Id: Icf7069a6c58d395edae8fddcdb84d07854e8d341 Reviewed-on: https://chromium-review.googlesource.com/1039103Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555292}
-
chrome://discardsMichael Giuffrida authored
Load the favicons shown in chrome://discards via cr.icon instead of doing a direct network request from WebUI. Remove LifecycleUnit::GetIconURL() which is now unused. Bug: 837420 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0ce123cdf944ace2e03b2b56feb18402848f875d Reviewed-on: https://chromium-review.googlesource.com/1031783 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555291}
-
Kent Tamura authored
generate_event_interfaces.py should produce paths relative to the repository root. Bug: 836071 Change-Id: Ibcb9fbe2cdb1e6e0e8f46ad1c0caec11c23123f3 Reviewed-on: https://chromium-review.googlesource.com/1038984Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555290}
-
https://pdfium.googlesource.com/pdfium.git/+log/9294ffdf371f..c9cd2874278e $ git log 9294ffdf3..c9cd28742 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 hnakashima Transform float out params from reference to pointer in CXFA_Node. 2018-05-01 tsepez Add CPDF_Document::Extension::DeletePage() 2018-05-01 tsepez Avoid perpetual spins for parserless CPDF_Pages 2018-05-01 hnakashima Transform size out param from reference to pointer in CXFA_Node. 2018-05-01 hnakashima Transform rect out param from reference to pointer in XFA code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia3177603cfe492a853b4aa4903c52473995b84ef Reviewed-on: https://chromium-review.googlesource.com/1038686Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555289}
-
Kent Tamura authored
Also, fix include guards. This CL has no behavior changes. Bug: 836071 Change-Id: I21d78c16c302405e9fb375843388aaaaaf093500 Reviewed-on: https://chromium-review.googlesource.com/1037047Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555288}
-
Michael Giuffrida authored
WindowActivityWatcher logs the WindowMetrics UKM event for a browser window, with features like window show state and tab count. Replace the WindowMetrics struct with a public WindowFeatures struct. The UKM logging function forwards info from the new struct to the UKM event. Later we will use the same CreateWindowFeatures function to calculate tab scores with an ML model. Encapsulating the logic for these features in a single function ensures that we use the same logic for logging as we will for inference, and makes the inferencing CL smaller. Bug: 791824 Change-Id: I940b7fc3d9b6d71d2c23f3a6b054b4f0eb74894a Reviewed-on: https://chromium-review.googlesource.com/1028563 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#555287}
-
Saman Sami authored
Currently we send the default CompositorFrameMetadata with the first VideoFrame. This makes inspecting a remote target in DevTools buggy when viz is enabled. Bug: 837362 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie57e4bb290c1fa683839f7e5f09be1d5c2472b3a Reviewed-on: https://chromium-review.googlesource.com/1035365 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555286}
-
Hirokazu Honda authored
Introduce GLRenderingVDAClient::Config and pass arguments to GLRenderingVDAClient's constructor with it. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5db1cbd9140f9a347f45f89b3903b3f1334b36e1 Reviewed-on: https://chromium-review.googlesource.com/1027490 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555285}
-
Noel Gordon authored
Many tear-down can occur if this is not the case: bug references can be for the curious. Tbr: slangley, yamaguchi No-Presubmit: true Bug: 833834 Change-Id: I5e795f7ef5b5e28af4050c9506640d8f6df8941a Reviewed-on: https://chromium-review.googlesource.com/1038983Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555284}
-
David Black authored
State is simplified to {kInactive, kActive} for now but will need more granularity later on. Bug: b:78913434 Change-Id: I558c4f2c9b2b266a621a36fc67ecd5af1d28eed6 Reviewed-on: https://chromium-review.googlesource.com/1036729Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#555283}
-
Kevin Marshall authored
Shared libraries are now spread over two directories in the SDK, causing some libraries to be omitted from packages, rendering the libraries non-executable. This CL registers $sysroot/dist as a library data dependency. Bug: 707030 Change-Id: Ie05e1b5dacf8924475576c3c53bf0d8d460db1f3 Reviewed-on: https://chromium-review.googlesource.com/1039026 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555282}
-
Paul Miller authored
Chrome stores the seed in preferences, but WebView doesn't persist preferences. WebView must save save seeds separately. Serialize with protos, and add aw_variations_seed.proto to mirror the fields in VariationsSeedFetcher.SeedInfo. Since writing might not complete successfully, the file format must make truncation unambiguous. The proto wire format is such that truncation in the middle of a field will be detected, but truncation between fields is permitted. But by requiring in code that all SeedInfo fields are present, any truncated seed file will fail to load. BUG=733857 Change-Id: I7f8d787afed83019c2d891aef419cdf7d593b71c Reviewed-on: https://chromium-review.googlesource.com/1033823 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555281}
-
Steven Bennetts authored
Bug: 682402 Change-Id: I6502a46e7dfa5293e8e5b29fefd44b3c3034db2c Reviewed-on: https://chromium-review.googlesource.com/1011547 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555280}
-
Ben Pastene authored
This will add a positional arg to run_vm_test.py that can take one of two values: - "host-cmd": Runs a command on the host. Just launches the vm then immediately calls the passed in cmd on the host. It's assumed the cmd will handle data deps, ssh commands, etc. - "vm-test": Runs a test in the vm. Takes care of spawning the vm, pushing the test and its deps to the vm, executing the test, and tears down the vm. (This is the current default behavior.) Bug: 832374 Change-Id: Ib8bd1b2e7dd393f8a4578979fa164381a8342ef2 Reviewed-on: https://chromium-review.googlesource.com/1038747 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555279}
-
Xida Chen authored
We have completed the experiment of "turning off compositing for 2D transform & opacity animations". We have data to show that running opacity and 2d transform animations makes them multiple times slower without significant GPU memory savings. This CL remove related code for that experiment. Bug: 754471 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib933deeef82fb05632d09e530356769e2d23befb Reviewed-on: https://chromium-review.googlesource.com/1034283Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555278}
-
Albert J. Wong authored
Now that the module boundaries are clear, refactor some functions to make a clear layer separation for types and remove the -inl.h files. Yay! \o/ Bug: 766882 Change-Id: I17934666c640c8f5daed40c2c8435b2e220b7b79 Reviewed-on: https://chromium-review.googlesource.com/1008964 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555277}
-
Kyle Horimoto authored
This CL creates a new directory in //chromeos/services for the upcoming SecureChannel service (see go/chrome-os-multi-device-apis). Additionally, this CL adds the secure_channel.mojom file which will be used to implement the service. Currently, that file only defines the ConnectionDelegate interface, which is intended to be implemented by clients of the service. This CL adds a test double for that class, to be used in a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1038649 Bug: 824568, 752273 Change-Id: I9ce9d7d7bff02464e1eec71d3193c63602e27477 Reviewed-on: https://chromium-review.googlesource.com/1033509Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555276}
-
Tien-Ren Chen authored
There was a mistake in PaintPropertyTreeBuilder::UpdateClipPathClip() to early exit when properties didn't change. However in that case we still have to update the context for descendants to inherit. This CL removed the early exit. BUG=836127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I38b229b86bd9c2106ac32bf54d520d39cb892e0c Reviewed-on: https://chromium-review.googlesource.com/1038705Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555275}
-
Chris Lu authored
TableViewTextItem text used to be a single line that was cropped once it reached the end of the screen. Also sets the right color for the cells. Screenshots: https://drive.google.com/file/d/1ZS_bk01JU38rbC5nxMKK76yhj62VU_XU/view?usp=sharing https://drive.google.com/file/d/1p1Qv27DOP1ZP97F2ZR7X8yg2DpKDSOIC/view?usp=sharing https://drive.google.com/file/d/1f4gigdxaV58Scbfeuz-3GexEPxLNCCY4/view?usp=sharing https://drive.google.com/file/d/1eet07y_X2UXXk15x0Tcwm3xCw1SlH_bt/view?usp=sharing Bug: 822988 Change-Id: If5f7a25505e6014adbd3068f9c4f5b1868cd4f18 Reviewed-on: https://chromium-review.googlesource.com/1026807 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#555274}
-
https://chromium.googlesource.com/catapult.git/+log/faa15b5e1038..5b642efe8459 $ git log faa15b5e1..5b642efe8 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 dtu [pinpoint] Add isolatedserver field to Swarming tasks. Created with: roll-dep src/third_party/catapult BUG=chromium:822008 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If2833a7f56032c662d39efa25791a9f2dd100c18 Reviewed-on: https://chromium-review.googlesource.com/1038843Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555273}
-
Tarun Bansal authored
Change-Id: Ia4ad8b4647432352928e23e5cbc6e4c29cfa0443 Bug: 826558 Reviewed-on: https://chromium-review.googlesource.com/1035444Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#555272}
-
rbpotter authored
Add a test for the destinations dialog that verifies destinations are correctly displayed in the destinations lists, like the PrinterList test for the old UI. Bug: 814860 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib90a78d1bacc263f00e5dc0090c17c2c3a94ec6c Reviewed-on: https://chromium-review.googlesource.com/1037543Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555271}
-
Stephen Martinis authored
Capacity seems ok to at least re-enable the CI bots. Not sure about CQ experimental just yet. Bug: 790648 Change-Id: If02f233778db02ca339ec28c8975968eb0b35ea4 Reviewed-on: https://chromium-review.googlesource.com/1038816Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#555270}
-
Erik Luo authored
This reverts commit fcaafdd7. Reason for revert: we'd like to be more strict about side effects Original change's description: > DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect > > Allow Console to evaluate without throwOnSideEffect when the entire > expression meets the same strict conditions used by JSAutocomplete. > > Bug: 810176 > Change-Id: If5c80250cd75d81eec1e495d0414903213fac930 > Reviewed-on: https://chromium-review.googlesource.com/1028934 > Commit-Queue: Erik Luo <luoe@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555142} TBR=dgozman@chromium.org,einbinder@chromium.org,luoe@chromium.org Change-Id: Iec31996445e98945a0a9a9b67e572d17bafdcbeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 810176 Reviewed-on: https://chromium-review.googlesource.com/1039063Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#555269}
-
Paul Irish authored
Bug: 747349 Change-Id: I66b8eed3b9652d33122c97c33319373088ab9347 Reviewed-on: https://chromium-review.googlesource.com/1030756Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#555268}
-
Tommy C. Li authored
On Windows, Widgets with shadow_elevation specified are currently drawn incorrectly. This is because we spawn a native top-level window, which ignores shadow_elevation. This is to be expected, since the Windows window manager has no concept of Material shadow elevation. This CL forces those Widgets with shadow_elevation to use an Aura non-toplevel window. The caveat is that these widgets are now clipped to the root browser window. (It can't be bigger.) But it has the benefits of being: 1. Low maintainence 2. Click-through shadow 3. Proper hit testing Bug: 823535, 838667 Change-Id: I008ab64d0f3b7c2811d11ac94f00d041c45bf730 Reviewed-on: https://chromium-review.googlesource.com/1028833 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#555267}
-
Nasko Oskov authored
This test currently isn't testing what it is aiming for, so disable it until it can be updated correctly. Bug: 838743 Change-Id: I5fbea2519627d9f7e3524832e2b99b866445eae3 Reviewed-on: https://chromium-review.googlesource.com/1038787 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555266}
-
Hirokazu Honda authored
In additon to moving those declaration places, changes the type of kMinSupportedNumConcurrentDecoders to const size_t from enum. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5b343adb64811f8f6dde2699af60542c666890af Reviewed-on: https://chromium-review.googlesource.com/1027333 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555265}
-
Kristian H. Kristensen authored
The GL_EXT_texture_format_BGRA8888 only calls out two entry points that accept the new GL_BGRA_EXT internalformat: Accepted by the <format> and <internalformat> parameters of TexImage2D and the <format> parameter of TexSubImage2D: GL_BGRA_EXT 0x80E1 Some drivers seem to silently allow the format in CopyTexImage2D, but others throw GL_INVALID_ENUM. We allow this for clients, by taking the existing TexImage2D+TexCopySubImage path when internalformat is GL_BGRA_EXT. Bug: 834006 Change-Id: I99dafd113a0320a83a171f83455cf9d93a38a2c3 Reviewed-on: https://chromium-review.googlesource.com/1036467 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555264}
-
Dirk Pranke authored
In order to roll GN 8b9e025d..0fbf0789 (r554932:r555198) and pick up the following changes: 9e71c94d Show error with gn desc when no matches are made 3d36fd0d Make `gn refs out/foo //out/foo/gn` work. TBR=brettw@chromium.org Change-Id: I80855424152094f952a8ee2f575112288c0bdffe Reviewed-on: https://chromium-review.googlesource.com/1038753Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555263}
-
Hirokazu Honda authored
Move Convert from RGBA to RGB part into helper files. Change the function to read known md5s and use base::ContainsValue to verify it. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic965ee1668af67ecd04956bc89a29bf7a7de5f84 Reviewed-on: https://chromium-review.googlesource.com/1025535 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555262}
-
Patrick Noland authored
Add Java PeekConditions class and equivalent C++ struct. Parse AutoPeekConditions and plumb from fetch through to bridge. Create and use ContextualSuggestionsResult to encapsulate all response data. Add contextual_suggestions_test_utils and move common test code there. Change-Id: I5cd8eb83c6a321377924bf14a2e71d2fefd9b98c Reviewed-on: https://chromium-review.googlesource.com/1034015 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#555261}
-
Becky Zhou authored
+ Add show/dismiss/suspend logic to prioritize app modal dialogs + Refine some callback logic - OnDismiss should also be called on dissmiDialog when dialog is in pending list - OnDismiss should be called on cancelling dialogs on pending list - OnDismiss/OnCancel should not be called during suspend dialog + Make AppModalPresenter not to observe Activity life cycle but let the Manager handles the Activity life cycle change. Bug: 838261 Change-Id: Ic843737b0d82209ad563671a4bd7f53c53a76cc2 Reviewed-on: https://chromium-review.googlesource.com/1034102Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555260}
-
Hirokazu Honda authored
Originally, it was hard to understand Reset test case workflow, since a variable named reset_after_frame_num can mean either ResetPoint or the number of frames. This simplifies the workflow by introducing a variable to describe ResetPoint, so that reset_after_frame_num can only be meaningful for MID_STREAM_RESET. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5c0b5a6b3ea99c98f54eb244a6fed5059f77c102 Reviewed-on: https://chromium-review.googlesource.com/1025531 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555259}
-
Chris Blume authored
Previously, ParentLocalSurfaceIdAllocator would default to an invalid LocalSurfaceId. A new LSI had to be explicitly allocated before the normal behavior could use it. With ParentLocalSurfaceIdAllocator now default initializing a valid LSI, the various call sites no longer need to explicitly check for the uninitialized state. RenderThreadImpl is one of those call sites. BUG=837030 Change-Id: Ia1ee9524027d512980f97d08bfc61e93536e3b26 Reviewed-on: https://chromium-review.googlesource.com/1038060Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#555258}
-
chcunningham authored
Encoders may use "phase inversion" to improve stereo compression. But this creates artifacts if the decoded stereo is later down-mixed to mono. This CL sets a flag on the decoder to disable the phase inversion decode step whenever the HW is detected as mono. Bug:806219 TBR:dalecurtis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icff0387c7fc0fc0e0e31657176721cee5abf6fd9 Reviewed-on: https://chromium-review.googlesource.com/1038617Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#555257}
-