- 30 Sep, 2020 40 commits
-
-
Ian Struiksma authored
Match proper mb configs for win10 1909 fyi and trybot Bug: 1132195 Change-Id: Ie40149eb07bd1298cebd83bbbc31dcc4e916714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433999Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#812324}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5b238b2e5f6e..95c77a92cd84 2020-09-30 bingler@chromium.org Show Schemeful Same-Site Issues for unspecified SameSite 2020-09-30 andoli@chromium.org [ts] Typecheck components/Linkifier.js with TypeScript 2020-09-30 tvanderlippe@chromium.org Typecheck elements/DOMPath.js with TypeScript 2020-09-30 petermarshall@chromium.org [typescript] TypeScript-ify timeline/PerformanceModel.js 2020-09-30 petermarshall@chromium.org [typescript] TypeScript-ify timeline/ExtensionTracingSession.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1133612 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9000eb19926d44080cade8ac69f92f7797e185b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 649c62d4. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I18b5f9c3eb08d07571a388a25b3de9a793e9e597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441247Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812322}
-
Jarryd authored
The corresponding instrumentation was removed in M67, however, this histogram was never marked as obsolete. This change only marks the histogram as obsolete, completing the histogram removal. CL that removed instrumentation: https://crrev.com/c/940525 Bug: 1089336 Change-Id: Iad9ab4b5d65a467ba70d4af74038bff069c639fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436776 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#812321}
-
Peter Boström authored
Fixes an instance where BubbleDialogDelegateView claims to be a child of DialogDelegateView. It's in fact a child of BubbleDialogDelegate and View. Bug: None Change-Id: Ie5c123d6e4d2ee695b3e4c34ce1d61e35a55d32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440967 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812320}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601451302-74bafe020c79028d442bb7dcedaaf977604dc6fc.profdata to chrome-mac-master-1601488745-21956df111f44074edeba5bc0b298067a5c332e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6eabaad319036cd8f0a08efa4644ae5c5ad1d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441335Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812319}
-
Ken Rockot authored
Each switch is either deleted because it's no longer used, or migrated to a more appropriate layer (generally Content). Bug: 977637 Change-Id: I9c4a74d4d99f4f7e7df8319d95b4ac4f55f11165 Tbr: caseq@chromium.org Tbr: dschuff@chromium.org Tbr: finnur@chromium.org Tbr: halliwell@chromium.org Tbr: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440908 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812318}
-
Kyle Milka authored
When populating the bottom row filter out any activities that have the same package name as the application. Bug: 1129175 Change-Id: I0ad7b66a0df89022b9abe1118e8324f452595561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417212Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#812317}
-
Yue Li authored
Bug: b/150034512 Test: Manual Test Change-Id: I86b9bd86fecb41f57de604cc1bfb5806b7494cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439027 Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#812316}
-
Dominik Röttsches authored
Ship text-decoration-thickness, text-underline-offset and from-font keyword for text-underline-position. Intent-to-ship approved in https://groups.google.com/a/chromium.org/g/blink-dev/c/9OzS90KISXI/m/q5KYyyWBCAAJ In collaboration with schenney@ for resolving blocking paint invalidation issues and important refactorings in the paint code. Big thanks! Bug: 785230 Change-Id: I235a8e01fef8d8e9c4abd921190ce0023cf5bc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440615Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#812315}
-
Joe DeBlasio authored
This CL changes target embedding to: 1. Allow a domain to embed itself (e.g. example.com.example.com). 2. Detect embeddings where the embedding happens at the end (e.g. www-example.com). Fixed: 1116859 Fixed: 1130843 Change-Id: Ic8e45bb7cf17a7f3473b859709b375bfc0eca44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437914Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#812314}
-
Marijn Kruisselbrink authored
As it turns out Chrome OS guest mode is violating the assumption <webview> made that a chrome app's storage partition is always on disk. Because of this, before the change that added the blob url fallback mechanism a <webview> with no explicit partition name set would (incorrectly) share the storage partition with the app that embeds it. Adding the blob url fallback flag fixed that (by making them separate configs only differing in the fallback flag), but the fallback mechanism also assumed that a chrome app's storage partition always was on disk. This CL fixes loading blob URLs in a <webview> in guest mode by changing StoragePartitionConfig to store a tri-state enum rather than a simple bool for its blob url fallback mode. This way we can support fallback regardless of if the chrome app's storage is in memory or on disk. Bug: 1128330 Change-Id: I518cd5d1e89491eaf1cc6e2ed9ddb5cd3f0b9e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439110Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812313}
-
Haben Foto authored
Enable SystemWebAppManagerAdditionalSearchTermsTest on ChromeOS only as it is targeting ChromeOS specific feature and is flaky on Windows. Bug: 1133012 Change-Id: Id73da9a387dbbb8f6781998a06b9b69361b3b366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436321Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Haben Foto <v-habenfoto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812312}
-
Yi Gu authored
We currently use a map to store "origin, subscribers" pairs. Multiple pending origins may be rare in practice. e.g. a user visits origin A, while waiting for an SMS by WebOTP, they visit origin B and wait for another SMS. We want to measure the frequency of the multiple pending origins occurrenceto to evaluate other metrics. e.g. when an sms from one origin cannot be parsed, or the prompt is canceled/timeout, The simplest most practical approach is to report it on all existing pending origins which could lead to over-counting if multiple pending origins are a common occurrence. Bug: 1127397 Change-Id: Ife092d8e038b96977b34740854e5ed0a690083af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426974 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#812311}
-
Nohemi Fernandez authored
Allows manual testing of the GAIA refresh feature by reducing the delay between polls to verify if GAIA cookies are available for a signed-in user. Bug: 1131027 Change-Id: Ib163a91ec3e5b922d652cff68c60b4e08708a828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440505 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#812310}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/aef20f06..aba3f0dfe aba3f0d Add rbns/zh.res rbns/ja.res to fix DateTimeFormat by Frank Tang · 11 minutes ago master 3c77cb5 Pass -fvisibility=hidden on Fuchsia by Fabrice de Gans-Riberi · 4 days ago Bug: v8:10960 Change-Id: Iec6f6d59131ec535ef3da369e7771d523734527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437820Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812309}
-
Maksim Sadym authored
rebase CL 2044170 part 1: Adds a new `FrameNavigationControl::JavaScriptMethodExecuteRequest` method. Previously every message was turned into an object literal in a new script and sent to the renderer process executing the front-end, which was very costly and leads to a lot of unnecessary script executing in the V8 engine. Bug: chromium:1029427 Change-Id: I9e803ea9d32ce333c4eea1d2cb06f1b2eaffaf02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431864Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#812308}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0f6ed710764d..1e5bef446919 2020-09-30 jbudorick@chromium.org devil: remove deprecated arguments. 2020-09-30 johnchen@chromium.org Revert "[Fuchsia] Allow passing through ssh_config file directly, make port optional." 2020-09-30 jleconte@google.com Fix Android swarming command line in WebRTC quest. 2020-09-30 a.pereira@eyeo.com Changed mint certificate expiration date to no more than 12 months 2020-09-30 jbudorick@chromium.org telemetry: update to denylist. 2020-09-30 johnchen@chromium.org Reland "[Catapult] Fix Mac CQ resource error" 2020-09-30 chonggu@google.com [Fuchsia] Allow passing through ssh_config file directly, make port optional. 2020-09-30 johnchen@chromium.org Revert "[Catapult] Work around dashboard test failures on Mac" 2020-09-30 johnchen@chromium.org [Catapult] Disable dashboard test on canary/Mac 2020-09-30 johnchen@chromium.org [Catapult] Work around dashboard test failures on Mac 2020-09-29 jleconte@google.com Revert "[Catapult] Fix Mac CQ resource error" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097306,chromium:1123318,chromium:1128481,chromium:1132884 Tbr: skyostil@google.com Change-Id: I4bba362d4d851db02c5aeeb731da4a515af04668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812307}
-
Maria Kazinova authored
Bug: 1075444, 1131038 Change-Id: Id5aa1c9d1e3a18d432d460c1a45878a945d018c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435092 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812306}
-
Zhenyao Mo authored
except for RGB32F. This is true since ES3 and most of Android devcies are on ES3+, and histogram data confirmed this: 100% renderable for all formats, except RGB32F, which is 99.99%+ unrenderable. Avoid runtime check - this is a minor optimization in validating command buffer on Android. BUG=1127837 TEST=bots R=kbr@chromium.org Change-Id: I9ac1c0c87ae197d6883e9167068bd81fc4e0d844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438313Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#812305}
-
chinsenj authored
With the ongoing interactivity improvements to the window cycle list (alt-tab) three finger horizontal trackpad scrolling was introduced as a way for users to cycle the window cycle list. However, if the user's most recent active window was a chrome window with multiple tabs, the three finger swipes would also tab scrub. To prevent both tab scrubbing and window cycle list cycling, this CL disables tab scrubbing while a user is cycling windows. Tests: manual + added test Bug: 1067327 Change-Id: Ic1ffd1152c3082c2cbc4ab198f5bf0f0c4540037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437155 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812304}
-
Weilun Shi authored
Put the real command-line flag `--enable-features=` in the comment of InitializeFromCommandLine to avoid confusion. Change-Id: I9bb542faebf2d0d8fe618142ebfbab56bc2c270e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430363 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812303}
-
John Palmer authored
Bug: 1060433 Change-Id: I77cc133461fe5f6336bb843184d387565b8a7d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428266 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#812302}
-
James Vecore authored
The change ensure that the device name change callback is only called if the device name actually changes. Previously it was spamming the log andy time the device changed. Fixed: 1133045 Change-Id: I0b1e11741e83a180c9977fc0f01bf63a249fd91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441307Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#812301}
-
Fabrice de Gans-Riberi authored
This removes a TODO in amber_repo.py since we are no longer pursuing checking if "fx serve" is running, considering this is a user error. Bug: 1104411 Change-Id: I300f61e7b053f27ed6752409899f70f32c061c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427350Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#812300}
-
Xinghui Lu authored
Fixed: 1126112 Change-Id: I189b4971e6382c28298e62b7e9ccd139c1384cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437315 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812299}
-
shivanigithub authored
Bug: 910708 Change-Id: Ib2702d8600c5c14e2d7290a61eaeb0687b7422b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441113Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#812298}
-
Mugdha Lakhani authored
Bug: 1131870 Change-Id: I9793f21468cd2a3f7e879017ea0037c292761d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438491 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#812297}
-
Jeroen Dhollander authored
If the quick answer consent view is discarded 3 times, we no longer show it and start showing the quick answers. This was previously not tested. Bug: b/169362551 Tests: ash_unittests --gtest_filter="QuickAnswers*" Change-Id: I7352b45a724980ac169e0d250f06e7b46a7c2440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436316Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812296}
-
Xinghui Lu authored
Bug: 1132076 Change-Id: Ic40b79a2068b60aa8baaab23109a85ac52edc6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438851Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812295}
-
Michael Moss authored
This fixes the signing failures like: remoting-me2me-host-mac/PrivilegedHelperTools/ChromeRemoteDesktopHost.app/Contents/MacOS//remoting_me2me_host_service: is already signed BUG=1117247 Change-Id: I184bc8f6c0c0f4476cd174db0a5a693c03fca271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438206 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812294}
-
Alex Newcomer authored
When FadeImageView changes images, update the image size. This will prevent distorted images when HTML renders. Bug: 1128721 Change-Id: I3144c4489fd667c3287cd24dbb069e748e7e8613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436861 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812293}
-
Michael Thiessen authored
QrCodeShareActivity was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1848370, but the Manifest entry was not cleaned up. Bug: 1022172 Change-Id: I51b235728deafa2d884c7174449ef91d715e4c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438884Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#812292}
-
David Grogan authored
This is a test only, no behavior change. Fixed: 750631 Change-Id: Ia51278bd0a1420d9821b52716b2ace238c6ad7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434744Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812291}
-
Taylor Bergquist authored
While the tabstrip is not visible, TabStripRegionView has zero width. If any model change happens while the tabstrip is not visible, the tabstrip calculates the ideal bounds for tabs based on this available width. The bug was that the tabstrip was ignoring the first layout after being restored to visibility because it believed that its cached layout was still up-to-date. I.e. this was the timeline: Layout() at width and available width 1340. Enter fullscreen. Available width is now -78. Insert a tab. Ideal bounds are as small as possible to fit -78 width. Exit fullscreen. Available width is now 1340. Layout() at width and available width 1340. Layout() is ignored because there's been no change in width or available width, when in fact the ideal bounds are stale. This wasn't happening pre-suspect change because it was calling Layout() while TabStripRegionView's width was zero (since it called Layout() to calculate the available width for calculating ideal bounds), so the first layout after the size was normal again went through. The fix I went with was to update |last_available_width_| whenever ideal bounds are calculated. This more correctly reflects the current calculated layout's dependency on available width. Bug: 1132832 Change-Id: I5487a99bceb7267cab1e00e2163ba86e2a93b0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438774 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812290}
-
Daniel Rubery authored
This CL removes the functionality for sending a CSD ping when an interstitial was previously shown on the page. This is the minimal CL to do so, and is intended to be merged. Future CLs will clean up useless code introduced by this CL. Bug: 1132060 Change-Id: I9f3e163268254cf79eee60b30b2d3da025293abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429809Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#812289}
-
Dave Tapuska authored
The API is still needed in the content level for some conversions, but blink now no longer needs to call into the content layer to do these conversions. BUG=1097816 Change-Id: I004e218a2145db26ff0ec15a35e82376dadd7740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432186 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#812288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9418e43a9c9d..36477e478d39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,xidachen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128771,chromium:1133700 Tbr: jianli@google.com,xidachen@google.com Change-Id: I530fb434931e9d08bd23761d2a750310229a3ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812287}
-
Thomas Lukaszewicz authored
This CL updates TabSearchButtonBrowserTest to assert that the tab search button is not present in an incognito browser. Bug: 1099917 Change-Id: Ib2bc7c3142521f12613c7721d2b891efb0beb030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438985Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812286}
-
David Dorwin authored
This enables LoggingTest.FuchsiaSystemLogging to pass when run with run_test_component. Bug: 1132146 Test: fx shell run_test_component fuchsia-pkg://fuchsia.com/base_unittests#meta/base_unittests.cmx Change-Id: I77a69bc925593c127efbe2e66af1c637d9269197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433108 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#812285}
-