- 24 Oct, 2019 40 commits
-
-
Yun Liu authored
JaCoCO instruments jar file will change zero'ed out timestamps in original jar. Changed to extract all, instrument class files and zip using build_utils.ZipDir. Bug: 985581 Change-Id: I79ccdfc474c210af4b71847567c6406f91778505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876086 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708910}
-
Hajime Hoshi authored
This reverts commit 16980f14. Reason for revert: test failures: crbug.com/1017573 Original change's description: > Ensure consistent focus status of some form tests > > The tests were flaky because of inconsistent forcus status. > > Change-Id: Idb494efcc489a441446c4a9b12968cde86faf8e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872991 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708675} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I04e8ff32caf0719c12552f51d6611b7e41fb4598 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877871Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708909}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea98ebbe654a..76c2e50d3bb9 git log ea98ebbe654a..76c2e50d3bb9 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vapier@chromium.org simplify the chromite wrappers 2019-10-24 tandrii@google.com vpython: e317c7d2c17d4c3460ee37524dfce4e1dee4306a. 2019-10-23 ehmaldonado@chromium.org Revert "presubmit_support: Fix tests on Python 3." 2019-10-23 tandrii@google.com vpython: new release 10e1d79ac9ced2b819221e06535f457093b2a14c. 2019-10-23 ehmaldonado@chromium.org depot_tools: Always use depot_tools .vpython to execute presubmit recipes. Created with: gclient setdep -r src/third_party/depot_tools@76c2e50d3bb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:None,chromium:869227,chromium:1009814,chromium:869227,chromium:1002153 Change-Id: Icd50d02cb4028cfe9236cfb1acaaf1c8ee5904fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708908}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e83f334d45d6..3f4e52c4071b git log e83f334d45d6..3f4e52c4071b --date=short --no-merges --format='%ad %ae %s' 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@3f4e52c4071b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ic9d9e47f035cb0821a6720b22a09cc477377fde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877573Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b4bcf993ef5..99d9ab0ed6c2 git log 2b4bcf993ef5..99d9ab0ed6c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vapier@chromium.org outcap: move OutputCapturer out of cros_build_lib Created with: gclient setdep -r src/third_party/chromite@99d9ab0ed6c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I21918c4180c8f1ecffa1842f65c0dd5059a0b51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877690Reviewed-by:
-
Alex Cooper authored
This change removes all WebVr flags and almost all WebVr blink code. Future work will begin to remove the device side WebVr code, and then mojo refactors will be investigated. Bug: 960132 Change-Id: I3e14b6f20b43c0580a39c0692be1d657ea00ab0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869673 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708905}
-
Chris Lu authored
The translate badge should not be marked as accepted until the translate has finished, not immediately when the action button in the banner is tapped. A InfobarCoordinatorImplementation method isInfobarAccepted will allow specific Infobars to decide whether to call infobarWasAccepted: when the button is tapped. Bug: 1014959 Change-Id: I544395077845dd89c9909afe38a11801df5fbf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872759 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#708904}
-
Hajime Hoshi authored
This reverts commit 0bc500aa. Reason for revert: test failures: crbug.com/1017548 Original change's description: > Fix emission of AtkValue property change signal > > The introduction of text-change signals for the omnibox included a > regression that prevented the emission of AtkValue property change > signals. Fix this error and also add an implementation of > atk_value_set_value. The implementation is used in a test to verify the > correct behavior. > > The fix is that we correct the misuse of a logical operator and now > always try to emit AtkValue property change events when receiving the > kValueChanged event in AXPlatformNodeAuraLinux. > > Bug: 1015387 > Change-Id: I18baa44a52190913ff70708bd5133bdcdea83b9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871692 > Auto-Submit: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#707820} TBR=mrobinson@igalia.com,jdiggs@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015387 Change-Id: I621fc94f48a55596ea9117b9a7106be946465b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875894Reviewed-by:
-
v.paturi authored
The issue mentioned in the comment is regarding the unexpected inversion of images when |mode| in DarkModeSettings is set to kOff. This issue is no longer reproducible in the latest code. Currently the code is structured in such a way that |image_filter_| is always nullptr when the mode is set to kOff. Unit tests are added to check this behaviour in dark_mode_filter_test.cc. The default value for |image_policy| in DarkModeSettings is currently kFilterAll. Even though this does not break any functionality, its better to have the default value to be kFilterNone which is more consistent with the other default values in the structure. Change-Id: Ia37dbf24fff99cf3ab3cc6930a441a8b2800e44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874993Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Cr-Commit-Position: refs/heads/master@{#708902}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=true Bug: 1015331 Change-Id: Ie102e157e4707326f9ef15fc834a63594a75bb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877333Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708901}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=true Change-Id: Idfc74436d24edc164e2cbdba3a45137de5b3e7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877492Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts CellularSetup from cellular_setup.mojom to new Mojo types using PendingRemote, ReceiverSet, and Remote. Bug: 955171 Change-Id: I8d87490e32c5ef1228fc6db1ddd73324b98a5f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872214 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#708899}
-
Naoki Fukino authored
I ran tools/resources/optmize-png-files.sh on: ui/file_manager/audio/assets/ ui/file_manager/file_manager/foreground/images ui/file_manager/gallery/images ui/file_manager/video_player/images The resource size (/opt/google/chrome/resources.pak) changes from 42641939 bytes to 42417396 bytes (219KB saved) The image quality should stay the same as the optimization process doesn't lose any information. Bug: 1017111 Test: Manually confirmed images look same on the device (not all the images, though) Change-Id: Id37286924fcd94440791e2dd31a883437eb7f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875861Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#708898}
-
Andrii Shyshkalov authored
Includes 2019-10-23 tandrii@google.com vpython: more logging when incomplete virtualenv dir can't be removed. R=bpastene Bug: 869227 Change-Id: I5c736089176473ef9ba8cbf1bc8b3791c7ada393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877650 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#708897}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbf7cb0e..71f4ff16 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I07c4dd8664bd0f74a8f8e3fbc4670bcfa56a968c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877369Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708896}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iec3984d64b4c0421ff25b5759f5fa21bc4102efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877910Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708895}
-
Koji Ishii authored
This patch removes |NGLineInfo::LineEndFragment|, which was introduced to support hyphens and ellipsis with the single code. However, ellipsis was changed to use different code, and |LineEndFragment| ended up with non-optimal way to handle hyphens. Although hyphens appear at most once in a line, storing this to |NGLineInfo| makes harder to keep it in sync with the hyphenated item. This patch changes it to a field in |NGInlineItemResult|. Bug: 1015297 Change-Id: I0706cf54bebfa967661dc40123c6dfd5887ff59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868534 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708894}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1a8abc0a3e7..bd2007738e5a git log c1a8abc0a3e7..bd2007738e5a --date=short --no-merges --format='%ad %ae %s' 2019-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 510c0ca3..f656c810 (708742:708845) 2019-10-23 mbonadei@webrtc.org RTC_EXPORT webrtc::DesktopCapturerDifferWrapper. Created with: gclient setdep -r src/third_party/webrtc@bd2007738e5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I8b8b4d63b6113eb1c4810379d57fbe752c478afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877818Reviewed-by:
-
Alex Cooper authored
In preparation for removing the code for WebVr, the remaining tests must also be removed, both browser tests and perf tests. Future work will remove the actual blink side code that allows WebVr to be accessed from a runtime feature flag. Bug: 960132 Change-Id: I6ba70e2798401a6c76d7eed338967e77d0f5fdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867257 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708892}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::RendererHost. It uses AssociatedRemote and AssociatedReceiver instead of RendererHostAssociatedPtr and AssociatedBinding. Bug: 955171 Change-Id: If977953c0cecfa6462b01fc4f51612411fdca2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872579Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#708891}
-
Miyoung Shin authored
This CL cleans up TODOs of |associated| in fake_bluetooth_chooser.mojom and hid.mojom since JS generator for PendingAssociated is supported by crrev.com/c/1847331, and converts FakeBluetoothChooserClientAssociatedPtrInfo and HidManagerClientAssociatedPtrInfo to new Mojo types. Bug: 955171 Change-Id: I505d74b8888dd7e4153ddb65c159a5c2efef25e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872216Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Joel Hockey authored
Add new restarter observer functions: * OnStageStarted(mojom::InstallerState stage) * OnContainerMounted(bool success) These functions will be used by terminal during startup. OnStageStarted allows terminal to notify users as each stage starts without having to have intimate knowledge of each stage that will be run and the ordering. OnContainerMounted completes the set of callbacks. Bug: 1016680 Change-Id: I063390727db99aeb701b3e96d909cb85451bd328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876291 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708889}
-
Peter Kasting authored
Bug: 82078 Change-Id: I7cae2dbd48a7ca1abbb1ec4ac34a798a7f218a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867812 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708888}
-
Fergal Daly authored
I ran the listed tests with --repeat 100. Some of them are slow and didn't complete 100 with the 1200s swarming timeout. Tests that passed 100 times NavigationControllerBrowserTest.ReplacedNavigationEntryData_Back NavigationControllerBrowserTest.BackOnBrowserInitiatedErrorPageNavigation NavigationControllerBrowserTest.BrowserInitiatedLoadPostCommitErrorPageForSubframe NavigationControllerBrowserTest.PageStateAfterForwardInCompetingFrames TouchpadPinchBrowserTest.* RenderViewHostTest.IsFocusedElementEditable NavigationControllerBrowserTest.BackSameDocumentAfterBlockedSubframe TouchInputBrowserTest.* Their logs https://chromium-swarm.appspot.com/task?id=480f3577f603df10 https://chromium-swarm.appspot.com/task?id=480f35af96d38810 https://chromium-swarm.appspot.com/task?id=480f3529b3cb5b10 https://chromium-swarm.appspot.com/task?id=480f3560f9248710 https://chromium-swarm.appspot.com/task?id=480f3620d07eea10 https://chromium-swarm.appspot.com/task?id=480f35a40c170a10 https://chromium-swarm.appspot.com/task?id=480f35c19a626c10 https://chromium-swarm.appspot.com/task?id=480f35df2a874410 Tests that passed 100% but only ran ~30 times MSE_ExternalClearKey/EncryptedMediaTest.* IndexedDBBrowserTest* MSE_ClearKey/EncryptedMediaTest.* MHTMLGenerationTest/MHTMLGenerationTest.* Their logs Task: https://chromium-swarm.appspot.com/task?id=480f58227f406610 Task: https://chromium-swarm.appspot.com/task?id=480f351ac8bdb010 Task: https://chromium-swarm.appspot.com/task?id=480f580b0085c010 Task: https://chromium-swarm.appspot.com/task?id=480f5ec378dd1210 Bug: 1016230 Change-Id: Iad60171b7f8f3a54af4f76e4755e6568ac73514c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874070 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#708887}
-
Ricky Liang authored
This CL enables the blink ImageCapture.grabFrame() implementatio to grab video frames backed by GpuMemoryBuffer. Bug: 982201 Test: https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html Change-Id: I9eada1924aaeffd447f55140cd0a166e88f9582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864759Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708886}
-
Eero Häkkinen authored
This changes NativeFileSystemDirectoryHandle.GetEntries to be asynchronous like the web-exposed API and the storage implementation. This should make directory iteration more efficient. Bug: 970059 Change-Id: I43bdd4950a70abc8d7cd8dcc890963655d49fdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867150Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708885}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1faae79f67ac..e8d14c45f873 Created with: gclient setdep -r src-internal@e8d14c45f873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43b543a0063cca5e5b0ae69029e2be33f5c31c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708884}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fd1b164088d5..e83f334d45d6 git log fd1b164088d5..e83f334d45d6 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e83f334d45d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ie8405f88dfbcaba7e577b0251ec90219da747eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877405Reviewed-by:
-
Chris Lu authored
Creates a new BadgeType for the Save Credit Card Infobar. Adds support for the badge in BadgePopupMenuItem and BadgeButtonFactory. Bug: 1014959 Change-Id: I3052c0a17ea4e5f68db3a16ead997605b58aaacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872014 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ActivationDelegate from cellular_setup.mojom to new Mojo types using PendingRemote, ReceiverSet, and Remote. Bug: 955171 Change-Id: I95085ca9a9d9759bf71366be043adb7223a9a32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872093 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Yun Liu authored
Android instrumentation tests and gtests cannot be separated at mb so we pass '--coverage-dir' to both if any coverage turned on and tackle it at runner side for '--coverage-dir'. Also changed 'java_coverage' to 'use_java_coverage' to be consistent. Bug: 985574 Change-Id: Ia3d99f07292b49714196e3c296d3234420bee0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876492 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e8378a666b73..2b4bcf993ef5 git log e8378a666b73..2b4bcf993ef5 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org wrapper: use importlib if available Created with: gclient setdep -r src/third_party/chromite@2b4bcf993ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I745380dfa4cfea386914b694747647fdbeb89b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877612Reviewed-by:
-
Chris Lu authored
This change implements presenting InfobarBannerViewController when InfobarTranslateCoordinator starts and the button action. Some constants from TranslateInfobarController are moved to a constants so that they can be shared. Screenshot of what it will look like when activated: https://drive.google.com/open?id=11W6HznODlJduMCZgNOSR1b8Gi_crfQl0 Bug: 1014959 Change-Id: I4e5e2859d20e3f04cd477f65e23889d2aa5b37e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872013 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
M77 has reached stable and there have been no major issues with the new names. Bug: 968369 Change-Id: I2de8132b9ac233a982c3e0d01bafd1c53e80d412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816251Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts WebContentsNSViewHost and WebContentsNSViewHost from web_contents_ns_view_bridge.mojom to new Mojo types using PendingAssociatedRemote, PendingAssociatedReceiver, AssociatedReceiver, and AssociatedRemote. Bug: 955171 Change-Id: Ib6770e5030ee68c9882f7f5f2d3654e6cda79d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872215Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
kdillon authored
Change-Id: I9236718df91559319cc1e52992713a1ee0112952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822877Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708875}
-
Mohamed Heikal authored
Change-Id: I349a83d51452b4c55480fe079a7e1c732dd10f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876970Reviewed-by:
-
Fergal Daly authored
All of these passed in this run on linux debug shards/0:Task: https://chromium-swarm.appspot.com/task?id=480b070d14519110 shards/1:Task: https://chromium-swarm.appspot.com/task?id=480b07300c6b9710 shards/2:Task: https://chromium-swarm.appspot.com/task?id=480b0756649ce610 shards/3:Task: https://chromium-swarm.appspot.com/task?id=480b0788b3c15e10 shards/4:Task: https://chromium-swarm.appspot.com/task?id=480b07cc5f172610 shards/5:Task: https://chromium-swarm.appspot.com/task?id=480b07d051ded010 shards/6:Task: https://chromium-swarm.appspot.com/task?id=480b0808d3319210 shards/7:Task: https://chromium-swarm.appspot.com/task?id=480b08113378bb10 shards/8:Task: https://chromium-swarm.appspot.com/task?id=480b084685625110 shards/9:Task: https://chromium-swarm.appspot.com/task?id=480b088bbb9ab510 and on android debug android-shards/0:Task: https://chromium-swarm.appspot.com/task?id=480adbf31c911d10 android-shards/1:Task: https://chromium-swarm.appspot.com/task?id=480adbfb629e4110 android-shards/2:Task: https://chromium-swarm.appspot.com/task?id=480addfec56a7110 android-shards/3:Task: https://chromium-swarm.appspot.com/task?id=480adbfe38c2a210 android-shards/4:Task: https://chromium-swarm.appspot.com/task?id=480ade00c0c16c10 android-shards/5:Task: https://chromium-swarm.appspot.com/task?id=480adbf515c64f10 android-shards/6:Task: https://chromium-swarm.appspot.com/task?id=480adbfcd1f37b10 android-shards/7:Task: https://chromium-swarm.appspot.com/task?id=480ade0fee6ffb10 android-shards/8:Task: https://chromium-swarm.appspot.com/task?id=480adbfe8d557810 android-shards/9:Task: https://chromium-swarm.appspot.com/task?id=480ade012ccd8a10 Sadly, I haven't figured out a nice way to aggregate these into friendly test reports. Tests noted as being flaky will be handled in a different CL. Change-Id: I84df1dc4be6efa13b911c2ae3232e76abd35b925 Bug: 1016230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862137Reviewed-by:
-
Aaron Colwell authored
- Create a common function for generating the killed_process_origin_lock crash key value so we get consistent results no matter what causes this key to get logged. - Introduce can_access_data_failure_reason crash key to make it easier to determine the reason for access failures. Citadel enforcement was trying to use the killed_process_origin_lock key to convey this info but that is no longer possible now that values for that key are consistent across all code paths. Bug: 1015882 Change-Id: I892ee47ca50ac1739eeebdbfb91425342df742dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876745 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708872}
-
Jinsuk Kim authored
AssertionError-based tests are not guaranteed to work. This CL changes the assertion exception used in UserDataHost class to runtime exceptions to make it test-friendly. Items tested in the tests now throw IllegalStateException or IllegalArgumentException. Bug: 877918 Change-Id: I0f1d8c7d9b49a7b8c4020bdfaaf3e15479110b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1192484 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#708871}
-
