- 17 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1ca6504eb7bb..1cc5b3357d2f 2020-12-17 amaiorano@google.com Optimize reciprocal sqrt operation 2020-12-17 amaiorano@google.com Optimize reciprocal operation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I73d3d1677653c69b3bcd35c60a227938018b480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838219}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608206305-43a406c5421ed694ad09e180106f1be95f3f52fa.profdata to chrome-mac-master-1608228003-46045c0c93c49596749cbb8f995ccd6fff023e1f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib231082fe1ad63d1e46325c83371de32a90cc6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595394Reviewed-by:
-
Shimi Zhang authored
This is only available on S and above to make the whole platform consistent. The newly added flag and all the plumbing are for this purpose, so we could write the check in Android specific code. One issue still left for this feature, when the selection direction is changed, we need to pass a right position to magnifier. However the way we handling this case for teardrop handle selection change isn't working in some cases. We need to plumbing the direction information from renderer to browser. I'll do that in a separate CL. Bug: 1157372 Change-Id: I1c7edadad74dbef79a5b6ecf2c01f172bee097e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582521 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#838217}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7df55c21d64b..0b514ec56375 2020-12-17 brgoddar@microsoft.com Add basic Har importer unit test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159439 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia174393301e59dc147a22c1e3697646474f13196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597716Reviewed-by:
-
Hidehiko Abe authored
We do not want to have runtime global static initialization. Currently, EnumTable hits the error, and the any code change for the files including EnumTable::instance causes bot failure, even if it is totally independent. This CL is the short term fix of the problem by changing instance fields to GetInstance methods. For the long term, we're switching to code generation. Thus, this CL tries to minimize the effort of the fix, rather than entier refactoring related constexpr. BUG=1158681 TEST=Ran on bots. Change-Id: Ia3400dd178ba9d5056e6543ccaf8a754559484b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594830Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
John Williams <jrw@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#838215}
-
Brian Sheedy authored
Updates the GPU unexpected pass finder script to output a list of bugs associated with removed stale expectations in several formats. This will make it easier to close out any necessary bugs and include the affected bugs in the CL description. Bug: 998329 Change-Id: Ia426974eb63c4123505787cd8bc010d6ccea1b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594368 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#838214}
-
Evan Stade authored
Bug: 1147268 Change-Id: I78cf9a52db2e86004a113581544959711d212340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594188 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#838213}
-
Clemens Arbesser authored
Starting with M-88, this new parameter must be explicitly set by all autofill_assistant triggers. The goal is to ensure that we will only show the bottom sheet immediately if the caller specifically requests this. While this was implicitly the case even before this change, it was more difficult to read and, more importantly, maintain. The corresponding change in the backend is currently under review, see cl/347804327. Bug: b/175677469 Change-Id: I7ed095e50af1a1f03d1fe49dc3fb67986859a059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595427 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#838212}
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: I61798b274718a4de4e40fa4eb2af7a5ec8536b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596825Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838211}
-
Ahmed Mehfooz authored
Bug: 1156228 Change-Id: Ibdb45ebbd6b54d3316e16844e75ebf4a12560757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597739Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#838210}
-
Jan Wilken Dörrie authored
This change simplifies the implementation of base::CharTraits and adds a specialization for wchar_t, leveraging clang's builtins if available. Bug: None Change-Id: Icedc3f8dc65a507552703ac5a30e062cc248e847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596151Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#838209}
-
Joey Arhar authored
Without this patch, anchors can be stuck in the :active state if contenteditable is enabled before :active is removed. The special logic for anchors and contenteditable was added a long time ago [1], and the purpose was to prevent anchors from being clicked and navigating the page while in contenteditable. This patch makes SetActive capable of removing :active during contenteditable, which preserves the original intention of preventing anchors from navigating during contenteditable. [1] http://crrev.com/1d651243ad5b85bac9ebc8611a991a23d72d2f95 Fixed: 1007941 Change-Id: Ib51b846e99fd212a478f1278b3568bda4e5886a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595978 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#838208}
-
Chan Li authored
Change-Id: I776a940ec14c265af90d55517296222ba484741f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597186Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#838207}
-
Leonard Grey authored
Bug: 1152274 Change-Id: Id9df3bf030c8f979c8332beefe00880d50566d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596133Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#838206}
-
Stepan Khapugin authored
Swap temporary strings for final ones. Bug: 1138892 Change-Id: Id74a69a4932539a0c69cda3b2b35136bdab42789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596265Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838205}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc4ac702..63b0f421 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib759877a9d2fe3b27fe3a0395ec545041e95ad7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595683Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838204}
-
Mikel Astiz authored
This patch allows the signin web page in the webview to post a message (method 'syncTrustedVaultKeys') that allows propagating the sync trusted vault encryption keys to the login-related code in the browser (GaiaScreenHandler), as part of the user authentication procedure. Messages are ignored if the client is not actually interested in these keys, which is controlled via feature toggle (disabled by default). A URL parameter is used to let the server know whether this API is enabled. The actual logic to implement this API is not included in this patch and instead a TODO is added for follow-up patches. Change-Id: I388f163e945551b1689f4d1ced3486a40511d22b Bug: 1081651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589854 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#838203}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1762dd71. With Chromium commits locally applied on WPT: 45a15b95 "Cannot balance columns based on overflow block-size." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iff34f3051d4b61c7e9e79c9d7d8f1fb92a0a9793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597539Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838202}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608206305-4389a6a6a359fb8abf452a6f4bc1a98be145b6cd.profdata to chrome-linux-master-1608228003-2821a99b00a027cd64fd6af5e6dc909e05bfef5c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3676796359ceb47b47d773032f085abf6a7afd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595393Reviewed-by:
-
Yi Gu authored
Bug: 1152282 Change-Id: I338c7a2cfb25348dda524a75fe0dc82483f8abb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595620 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#838200}
-
Daniel Cheng authored
When swapping in a new frame, the only frame tree pointer that will be set to a valid value is the parent. As such, `Swap()` is more about completing linkage of the new frame into the frame tree. Take advantage of that fact to eliminate: - the conditional branches for unlinking new frame from its previous and next siblings (as it will never have any siblings) - the conditional branches for updating the new frame's parent's first and last child (as the parent will never be aware of the new frame yet) In addition, `Detach()` already intentionally skips updating the frame tree pointer fields that `Swap()` needs, so skip the caching of the old frame's frame tree pointer values. The old values could become incorrect if JS dispatched during teardown of the old frame mutates the frame tree (e.g. mutations that affect adjacent siblings). Finally, `Swap()` was capturing `new_frame->parent_` at the beginning of `Swap()`: however, it may not even be set when initially calling into `Swap()`. Instead, since the conditional branches that consumed this value have been eliminated, skip caching this value as well. Bug: 1139872 Change-Id: I099e2486d532e4c784def583b70cd50ecca76326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597190 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#838199}
-
Shakti Sahu authored
Bug: None Change-Id: I347e159bf8913e36239019f227bacb6389ed3122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594182Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838198}
-
Sven Zheng authored
Bug: 1157567 Change-Id: Icebc4367286fcb7372b9c6e7c8909b84d9dc9917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591487 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#838197}
-
Jamie Madill authored
Re-land #2 includes update to licenses.py and removes stale files. Re-land includes missing headers directory. This replaces several grouped dependencies with one meta-repo. The meta-repo will allow us to group multiple inter-dependent deps rolls into one single roll. This solves the problem of separate rollers breaking because of the inter-dependencies. It also allows ANGLE and Chrome to share common bits like the README and .gitignore files. Bug: angleproject:5390 Bug: 1153258 Change-Id: Ie425e232096a25711dd90e84a6d91bf3324903ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595457 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Guillaume Jenkins authored
Adds logic to the settings view controller to replace the sign-in item with an info button item that grays out the sign-in option. The info button's popover menu explains that sign-in is disable by the managed browser's organization, and provides a link to the chrome://management page for more information. As part of this change, the TableViewInfoButtonItem class was modified to support changing the color of the cell's main text and letting callers provide a pre-instantiated UIImage. Passing an image rather than an image name is necessary in the case of sign-in, because the image must be created by the SigninResourcesProvider. In addition, the EnterpriseInfoPopoverViewController was modified to enable one of the disabled constructors, which lets callers provide the primary text message. Screenshots of the new UI when sign-in is disabled: https://screenshot.googleplex.com/38X86W24GXm2Ej5 https://screenshot.googleplex.com/9yee95xBSJ7u3D6 UI mocks: go/bling-enterprise-q42020 (slide 6) Bug: 1155745 Change-Id: I099c67b93023fb3f78181bdfeae13dcb73a0e59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591388 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#838195}
-
Chris Fredrickson authored
This TODO was addressed in https://crrev.com/c/2571806. Change-Id: I0c0b28e8cc9af0a6662a3da02f8550d86dd23733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595718 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#838194}
-
Koji Ishii authored
These classes are no longer used when |NGFragmentItem| is enabled. Functions that are marked "to be moved in future" in |ng_physical_text_fragment.cc| are moved to |ng_fragment_item.cc|. Bug: 1154531 Change-Id: I5f4d2411b5c3d5f131c2f09420e67224624aa1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596656Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#838193}
-
Benjamin Beaudry authored
In some cases, we can give a new AXTreeID to an existing AXTree, replacing the key associated to the tree's AXTreeManager in the AXTreeManagerMap for the new tree id. This happens on a page reload or on same-page navigation. We store a AXPlatformNodeTextRangeProviderWin::TextRangeEndpoints - which is an AXTreeObserver on the AXTree. When such a scenario happens, the AXPlatformNodeTextRangeProviderWin loses its access to the access because its nodes are not referencing the new tree id. we then start our destruction process and try to remove the observer from the tree's obersers list - without success, because we can't get the AXTreeManager from the previous tree id. This causes us to keep a reference to a destroyed object in the observers list. To avoid this issue, the AXTreeManagerMap is now notifying the observers about its removal right before it happens. This allows us to remove the observer before if needed. Bug: N/A AX-Relnotes: Fix crash occurring on page reload with UIA enabled. Change-Id: I6fe6b35764e3c7c3e7391733217b84bb43201a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596013 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838192}
-
Xinghui Lu authored
Metrics added in this CL: PasswordProtection.RequestReferringAppSource Bug: 1154860 Change-Id: I4707a6c95e7702f29760d0331f24d6954bd9094d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592630Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838191}
-
Side Yilmaz authored
Bug: 1048632 Change-Id: Idd21c222dcfeff9bd901788823dac392da0da1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597579Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#838190}
-
Stefan Zager authored
Re-landing after revert: https://chromium-review.googlesource.com/c/chromium/src/+/2593096 IntersectionObserver may require sticky position information, so if a lifecycle update is forced by IntersectionObserver, make sure it proceeds far enough to update sticky position. As noted in the code comments, even if sticky position update is moved up to the layout phase (which is planned, I think), if the document is servicing any IntersectionObservers with track_visibility=true (i.e. V2 features), then we will still need to force the lifecycle update to continue far enough to enable hit testing. That's the root cause of the bug. Bug: 1156937 Change-Id: Ibbb7025d5dd5d1b1dd0d93e027cd5fb6d3d04ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595477Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838189}
-
Xinghui Lu authored
If a cache is hit during real time URL check, we'll fall back to hash-based check. We'd like to know how often that the cache is safe while the response from hash-based check is unsafe. Metrics added in this CL: SafeBrowsing.RT.GetCache.FalsePositive Bug: 1157331 Change-Id: Ib91e8c6ae2149645f31e69252d5f2f74594cb6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594095Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#838188}
-
Hans-Filip Elo authored
The file xr_cube_map.cc contains a line using the C library function pow with floats as input arguments. The C lib function "pow" returns a double, while the rest of the arguments to base::ClampToRange on the same line are floats. It looks like the intention here is to either use "powf" or "std::pow", which would not return a double. This line was introduced by the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/2535915 This line builds fine against libc++, however it does not with libstdc++ where it causes a template deduction error. This patch changes the function call in question to std::pow in order to avoid said template deduction error. Bug: 957519 Change-Id: I1907f85acd475a48ea12d8c476004d2c09abb579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595280Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Hans-Filip Elo <helo@vewd.com> Cr-Commit-Position: refs/heads/master@{#838187}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4052510f0b7a..860d01ca8bae 2020-12-17 reed@google.com Idea: implement drawImageNine by calling drawImageLattice 2020-12-17 reed@google.com Revert "Revert "Reland "Rename getTopDevice/getDevice to topDevice/baseDevice""" 2020-12-17 bsalomon@google.com Fix images used in orientation GMs 2020-12-17 egdaniel@google.com Update creating GrProgramDesc for vulkan resolve loading. 2020-12-17 kjlubick@google.com [canvaskit] Update to 0.22.0 2020-12-17 jlavrova@google.com Remove static allocattion of UText 2020-12-17 kjlubick@google.com [canvaskit] Modify drawImageNine API to handle Filter quality 2020-12-17 bsalomon@google.com Support luminance-alpha GL format for YUVA planes 2020-12-17 reed@google.com Remove obsolete dox w.r.t. filter-quality 2020-12-17 michaelludwig@google.com Revert "Reland "Rename getTopDevice/getDevice to topDevice/baseDevice"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I581aa92486d52248cd468ebc158c00d02c72f550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595681Reviewed-by:
-
Xida Chen authored
It seems that this needs to be a RepeatingCallback instead of a OnceCallback. Because at the: chrome/browser/media_galleries/win/snapshot_file_details.h, this callback is used by SnapshotRequestInfo which is then owned by SnapshotFileDetails. The SnapshotFileDetails need to have const access to the SnapshotRequestInfo and hence the callback cannot be a OnceCallback. This is a code health CL, no behaviour change is expected. Bug: 1152278 Change-Id: Ia5eb65521cf100c38b47ae288daa41e2e432e897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595928 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#838185}
-
Hans-Filip Elo authored
The file ax_tree_formatter.h does not include <memory> and <string> while they are used there - but still seems to compile with libc++. For libstdc++ - this does not compile. This patch adds the missing includes. AX-Relnotes: n/a. Bug: 957519 Change-Id: I45f0a474b67c0b26729a24bc9028e75fbfa25729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597306Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Hans-Filip Elo <helo@vewd.com> Cr-Commit-Position: refs/heads/master@{#838184}
-
Donn Denman authored
Adds a new Feature to control whether to show a help section inside the Panel as a promo for the Longpress experiment. The Feature implementation is stubbed out. BUG=1158621 Change-Id: I1dd09eec35ff158a8268ca6d031299412d72a72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592393Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#838183}
-
Aaron Colwell authored
This patch updates test expectations so that they pass when the ProcessSharingWithStrictSiteInstances process model is enabled instead of ProcessSharingWithDefaultSiteInstances. Most of the changes just rearrange the existing expectations to make it clearer which ones apply to the default SiteInstance mode and which ones apply to "strict SiteInstance" modes where we don't allow multiple sites to be assigned to a single SiteInstance. Several helper functions were added to make it easier to update expectations as the process model changes in future CLs. - Added AreStrictSiteInstancesEnabled(),and IsIsolatedOriginRequiredToGuaranteeDedicatedProcess() helper functions to make it easier to express differences in test expectations. - Updated TestWebContents::CrossProcessNavigationPending() to actually verify that the navigation is cross process instead of just verifying whether a speculative RenderFrameHost was created. This is needed for ProcessSharingWithDefaultSiteInstances because this mode can trigger speculative RenderFrameHosts creation for a navigation that will stay in the same process. - Updated many test expectations that compare SiteInstance pointers. Many cases only should expect pointers to match when the default SiteInstance mode is enabled. Logic related to these comparisons were reorganized to make this more clear. - Updated several tests to explicitly isolate origins when ProcessSharingWithStrictSiteInstances is enabled, just like they are for ProcessSharingWithDefaultSiteInstances. This is needed because these two modes might allow sites to share a process when the tests explicitly want them to have dedicated processes. Bug: 1158650 Change-Id: I4cb361e1105ebab800ebc94b51aeda416e37f40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551275Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#838182}
-
sczs authored
-Adds methods to record the un/succsessful network duration of articles fetch, more articles fetch and actions upload. -Creates a new Histogram for un/succsessful actions upload Bug: 1159119 Change-Id: Id83b824be73d7340876a968016426187eebd1001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593743 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc9b7694ce3d..0d23e521cc40 2020-12-17 dsrbecky@google.com Merge "Reuse libunwindstack buffers between consecutive unwinds." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7e76bac499791e2e466229fe8e881c917b5f6719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597620Reviewed-by:
-
