- 19 Feb, 2020 40 commits
-
-
Kenneth Russell authored
This reverts commit 315a40c5. Reason for revert: should have been RetryOnFailure on "win nvidia debug" only - will cause regressions to be missed. Original change's description: > gpu: Mark maps pixel test as flaky on Win10 NVIDIA > > TBR=zmo@chromium.org > > Bug: 1053892 > Change-Id: Id0fd2c696d1982101b849490bc899e3393dd84dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063014 > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742580} TBR=zmo@chromium.org,poromov@chromium.org Change-Id: I05726206aeaa64a6eb6bf66be679bb2d851693f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1053892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062577Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742741}
-
Wei-Yin Chen (陳威尹) authored
http://crrev.com/c/2036513 introduced a test dependency. It requires TabAttributeCacheUnitTest to run before TabListMediatorUnitTest, or TabListMediatorUnitTest would fail. This was due to different handling of shared preference in these two tests. TabAttributeCacheUnitTest treats shared preference as a real object, while TabListMediatorUnitTest uses a mocked one. In this CL, the shared preference in TabListMediatorUnitTest is converted to a real object. After this fix, when running in a per-class way as described in https://crbug.com/1032883#c3, there are no failures. Bug: 1032883, 1048255 Change-Id: I73d7bf723b3d039e3b494abb5d5bd0013d710ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060909Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742740}
-
Ben Pastene authored
This reverts commit edbc09da. Reason for revert: broke bot_update on internal bots https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3328 Original change's description: > Pull libunwind, libcxx, libcxxabi from a different mirror. > > The current mirror has been stale since LLVM moved to github. > > This checks out the same revisions as previously, so this should > be a no-op. > > Bug: 1048253 > Change-Id: I589991a315c2ea178dc4c2dde834943d1afd9bcd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062879 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742720} TBR=thakis@chromium.org,thomasanderson@chromium.org Change-Id: I0db1d8eddbf5531dc547d6375576a5c6b2ac2976 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064812Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#742739}
-
Yusuf Sengul authored
Bug: 1052627 Change-Id: I85d831091bba67c30cd0a4ceeec9594ea7fc8e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058788Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#742738}
-
Marc Treib authored
When signin cookies are cleared, then related data like the opt-in for using the account-scoped password storage should be cleared too. This CL implements that by adding a function ClearAccountStorageSettingsForAllUsers() and calling it at the appropriate times (i.e. IdentityManager::Observer::OnAccountsCookieDeletedByUserAction). (This is analogous to autofill::prefs::ClearSyncTransportOptIns().) Bug: 1052005 Change-Id: I9a1c628900b8d64573ff0eec206f151a4a128abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062278 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#742737}
-
Avi Drissman authored
Bug: 1053786, 1054063 Tbr: mattm@chromium.org Change-Id: I5d681515d55737198caaad3e3c183904be260f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064829Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742736}
-
Peter Kasting authored
Bug: 1053845 Change-Id: Id8fbf754a28ec542a5958f0ee5846d6699550003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062700Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742735}
-
Abhijeet Kandalkar authored
This CL implements MediaInternalLogRecordsImpl which works as a receiver of batched media logs sent from renderer process using class BatchingMediaLog::EventHandler. MediaLog messages are grouped together in renderer and then send to browser in bulk in order to reduce IPC pressure. Bug: 1047457 Change-Id: Iadd747a5c17ef0572744ba3c6a4366974ed5785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051877 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742734}
-
Pete Williamson authored
Bug: 1992269 Change-Id: I6223388011d6d54e428a3f5d0228089751351d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047497Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#742733}
-
Jonathan Backer authored
Two fixes: (a) Change how we create SkSurface so that we can get a texture ID from it. (b) Map the AHB for readback with ScopedSurfaceToTexture. Change-Id: I16f692b5f1ae8ada0d592944fe74902484f56975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062918 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#742732}
-
Varun Khaneja authored
Bug: 1004470 Change-Id: Iddc66a93a9102b4b514dbb7236846c22ce3d5e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062718 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#742731}
-
Lan Wei authored
We should try to use Testdriver Action API (an implementation of Webdriver Action API) in all the web platform tests, not gpuBenchmarking any more, because we are using Webdriver Action API on wpt serve to run all the wpt tests. Bug: 1054022 Change-Id: Id70be3776a2935e95de7e0a32e73f65cda009e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064182Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#742730}
-
Rohit Rao authored
Removes code that is related to the DeviceManagementService and cloud policy. That code will be brought back later, when we are ready to bring up cloud policy support. For now, BrowserPolicyConnectorIOS only supports device-local policies. BUG=1024115 Change-Id: Ia3ace77846a500dd56258649955023baaff78777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063149Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#742729}
-
Chris Lu authored
- self.offTheRecordBadge is the only fullscreen badge, it doesn't have to be added to self.badges in BadgeMediator. - animates the changing of the displayed badge in a spring/zoom in motion. - change color of unread indicator to blue instead of grey. Bug: 1050781 Change-Id: I705baf6d65f04b08cb8e5b446cb7f8f0a580c537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045192 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742728}
-
Matthew Mourgos authored
This CL adds the initial screen code for the oobe gesture navigation education. The four pages within the new screen are mostly empty and only contain a title, subtitle, and next button. For now, the new gesture screen is hidden behind ShelfConfig::shelf_controls_shown(), which means the flag kHideShelfControlsInTabletMode must be active and tablet mode must be enabled to see the new gesture oobe screen. Bug: 976949 Change-Id: I66c8271b3c865610e7a2de85d7d68a5e4a41302c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043089 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742727}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90c9f66cc4cc..38bb9fdf36e8 git log 90c9f66cc4cc..38bb9fdf36e8 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 cwallez@chromium.org Revert "Move sampleAlphaToCoverage out of blendState" Created with: gclient setdep -r src/third_party/angle@38bb9fdf36e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I2a80ee7792b4303b5cb0582fb2e0f53b418b2375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742726}
-
Nate Fischer authored
This increases the clickable area of the Spinner, so the user can click the word "Default" (or any of the blank space to the right of it), instead of being restricted to clicking the arrow. The issue was the TextView was intercepting touch events. Marking this as non-clickable means the framework will pass touch events to the Spinner (which sits just beneath it), which responds by bringing up the menu of flag states. This also marks the TextView as singleLine, to follow simple_spinner_item.xml. This should be helpful if we ever display longer text, since we don't ever want the Spinner to take up multiple lines. Bug: 1052356 Test: Manual - click "Default" and observe the menu pops up Change-Id: I0a0f090d2c525ac26ded7c1a5a3e35b5e5ac9eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063812 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742725}
-
Javier Ernesto Flores Robles authored
Add consent screen view controller Bug: 1045453 Change-Id: Ia746f587f1a80ae62c77bfebfe37042917ddef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063260 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742724}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/3651f6c52037..530e1f0dae34 git log 3651f6c52037..530e1f0dae34 --date=short --first-parent --format='%ad %ae %s' 2020-02-19 thakis@chromium.org pnacl driver: add support for non-joined -fdebug-compilation-dir flag Created with: gclient setdep -r src/native_client@530e1f0dae34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: Iad526a2fdc82130b5ed950c11ef5211bce0b7bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064430Reviewed-by:
-
Guohui Deng authored
Unit test BaselinePolicy.SystemEperm in sandbox_linux_unittests fails on internal build infra and it blocks some CLs. Bug: b/148974697 Test: Internal CQ. Change-Id: Ieb8f355910f46a7aae4ab4a42e8d1e7fbf4eb2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063537 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#742722}
-
Jarryd authored
Add a new enum histogram, WebsiteSettings.AllSitesActions2, and userActions for the new AllSites UI surface. Bug: 997258 Change-Id: Iec1fdfd80bcd9ee360babb642876836cc3617e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057444Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742721}
-
Nico Weber authored
The current mirror has been stale since LLVM moved to github. This checks out the same revisions as previously, so this should be a no-op. Bug: 1048253 Change-Id: I589991a315c2ea178dc4c2dde834943d1afd9bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062879 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#742720}
-
Roman Sorokin authored
Fixed: 1052911, 1052910 Change-Id: If17c90c77de711794c0c34039f85dcd9488a4a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062415 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742719}
-
Alex Cooper authored
Bug: 1042445 Change-Id: I67e4920f6d0e1d98f51a6392460a8cb9622390eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063071 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Mike Wittman authored
Requests that the sampling profiler apply metadata to samples between navigation start and first contentful paint, at the time when first contentful paint is sent to the browser process. This metadata will support analysis of execution during page load. This change introduces monotonic time interfaces for the required metrics because the existing interfaces are limited to 1ms resolution. If used they would result in up to 2% of samples being misidentified as occurring during loading when they weren't, or vice versa. Bug: 1034756 Change-Id: Ibb39877ecfc52a1e5327204c39c3b0ce0f1b8ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042324Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#742717}
-
Felipe Andrade authored
Update owners of one authpolicy histogram. Also, extends the expiration date of some authpolicy and kerberos histograms. Justification: kerberos feature is still in Trusted Testers phase and authpolicy doesn't send enough data to the server to provide data for usage of the feature. Bug: 1052920, 1052970 Change-Id: I5356a733bd860916ec6d073d93742830170f399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063169Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#742716}
-
Paul Moy authored
Add a new device command to run a diagnostic routine on the device. DeviceCommandRunRoutineJobTest.* Bug: chromium:1049762 Test: unit_tests --gtest_filter= Change-Id: I1234854ecc6e8d3c7a452519c865402f74bfe1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055807 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#742715}
-
bttk authored
Bug: 1046181 Change-Id: I7522217f65a602433d8627d7eec4b9957e14148f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024411 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#742714}
-
Nohemi Fernandez authored
Implements the add account button tap event in the UnifiedConsentCoordinator, which opens the add account flow. See go/chrome-ios-signin-migration for more information. Bug: 971989 Change-Id: I51b167da48deb8092bbab139ed2fce34a4cac194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062410 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#742713}
-
Regan Hsu authored
This CL adds recordSettingChange() calls in instances in settings related to browser broxy calls, excluding internet pages and sync pages that are shared with browser settings, which will be addressed in later CLs. Bug: 1049830 Change-Id: I55842b288c7a92c460bc8ea906b5e780a84c4bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053087 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#742712}
-
Rahul Arakeri authored
This CL enables autoscrolling tests on Mac. Bug: 953847 Change-Id: I90a4fcd918c3558db7caae8c6134eac354bb0306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061197 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742711}
-
Yann Dago authored
The IPolicyStatusClass class is supported in Google Update starting with 1.3.35.331 Bug: 1033573 Change-Id: I5e1b23ceff7cdcc79ab7ba9e950aa6e720e39181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063688Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#742710}
-
David Benjamin authored
Some of our tests still use tlslite, which we didn't patch with proper signature algorithm negotiation way back when we added TLS 1.2. Bug: 658905 Change-Id: I6624a13cd614c90f4583022041f7249a13603ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063334 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#742709}
-
Sami Kyostila authored
When posting tasks with base::PostDelayedTask(), explicitly specify whether the tasks should run on the thread pool on a specific named thread. This is in preparation for making it always mandatory to specify the destination for posted tasks. This patch has no functional changes. This CL was uploaded by git cl split. Bug: 968047 Change-Id: I9595134c52d067fc61f8d3c705fa7f21db18b10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063168 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#742708}
-
Avi Drissman authored
Switch from a symbol that is no longer present in the macOS SDK to a string that is undocumented. Bug: 1053786 Change-Id: Ibed8b3a53a7280182b85e2cfeec7acd0bdabf53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063732 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#742707}
-
Brian Sheedy authored
Fixes Android instrumentation tests that use EmbeddedTestServerRule leaving behind a zombie server process if they crash. This is typically not much of an issue, as the next test to use EmbeddedTestServerRule will pick a free port instead of the one in use, but a number of tests have to set a static port due to being render tests (and a variable port will cause the test to fail due to the port being visible in the URL bar). Bug: 1019983 Change-Id: I9adcb22e75ebf0f83d15db6c825e896e618e8f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056935Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#742706}
-
Dong Hwi Lee authored
The current structure looks (in a very abstract form for readability, e.g. <div class="collapsible"...> -> <collapsible>): <collapsible> (stay) <expanded> (remove) <line> (stay) <collapse-button> (-> collapsible-button) <html-tag> (stay) <collapsible-content> (-> expanded-content) <collapsible> (stay) <line> (stay) <html-tag> (stay) <collapsed> (-> collapsed-content, become <text>...</text>, move under <collapsible>) <line> (remove) <expand-button> (merged to collapsible-button) <html-tag> (remove) <text>... (remove) <html-tag> (remove) The changed structure looks: <collapsible> <line> <collapsible-button> <html-tag> <expanded-content> <collapsible> <collapsed-content>... <line> <html-tag> The saving in terms of number of elements ranges 20%-30% depending on the size of the text in an XML element. For example, a longer text in XML will create more HTML elements, which means the saving ratio is higher in that case. Tested XML files (from random searches): https://www.sitemaps.org/sitemap.xml https://ririkaburbe.tk/sitemap_0.xml http://big5.sputniknews.cn/export/rss2/archive/index.xml Change-Id: Ibfefb175b58bc54c3f31e65456ff832d432d5c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062797 Commit-Queue: Dong-Hwi Lee <leedh@google.com> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#742705}
-
Mugdha Lakhani authored
from chrome:// to components:// and update all references. Bug: 1052375 Change-Id: I3ecfc036d1b7aa527151db2ed2d9bb7389ae2bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062274 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#742704}
-
Matt Mueller authored
The 3 values are kDefault, kBuiltin, kSystem. When the value is kDefault, the NetworkContext will check net::features::kCertVerifierBuiltinFeature for which verifier to use. This means that services_unittests and other build targets which use the network service but don't have explicit handling for the use_builtin_cert_verifier setting will now use the expected default implementation of the verifier instead of always using the system verifier. Bug: 1049869 Change-Id: I74d20c2bb153e34074dc35269927b582eb5c61a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058004Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#742703}
-
Balazs Engedy authored
This CL removes all studies in fieldtrial_testing_config.json where neither the study name nor any of enabled or disabled feature names appear as a string literal elsewhere in the codebase. Bug: 1045530, 1053702 Change-Id: If46efd7269250a7f3d18ca2d234a72d8e08bde12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063133 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
