- 05 Mar, 2020 40 commits
-
-
Sylvain Defresne authored
Assigning a relative value to ios_sdk_platform_path does not work as the variable is used by more than one target/config as some of them are from a different level in the directory hierarchy (thus they require a different rebased value). Instead change build/config/mac/sdk_info.py to output a path that is relative to root_source_dir (i.e. a path starting with //) and fixes the different usage of the ios_sdk_platform_path variable to do the rebase_path as required. Bug: 1058221 Change-Id: I41545765dbf66efb96b8d00246bfe1856dba9bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087219 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747181}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.31-1583148634-benchmark-82.0.4075.0-r1 to 82-4044.31-1583148634-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I32034757c7d1bd912a42225296b767d8104e5ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747180}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcb8686f7685..968c87018591 Created with: gclient setdep -r src-internal@968c87018591 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044616 Tbr: jbudorick@google.com Change-Id: Id042625de2b14ce1722e1f6916e15b63173a21aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089025Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747179}
-
Stepan Khapugin authored
Moves -startUpChromeUIPostCrash:needRestoration: method to SceneController. Bug: 1045658 Change-Id: I3d3890b1480dfe1facfbfe58e01cc4bb8ffd7521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087614 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747178}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a6d3a2dd41d4..044ecc0b2c65 git log a6d3a2dd41d4..044ecc0b2c65 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 afdx@google.com spirv-fuzz: Fuzzer pass to add equation instructions (#3202) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@044ecc0b2c65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I6e7df5c3000ccafad6e90b678d637acd80ea26cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089022Reviewed-by:
-
Yutaka Hirano authored
1: https://crrev.com/c/2074177 2: https://crrev.com/c/2075002 3: [this] This series of CLs implements https://github.com/mikewest/corpp/pull/9. We introduce network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter, implement the reporting logic in content::CrossOriginEmbedderPolicyReporter and the CORP check, and plumb the mojo interface. This CL creates CrossOriginEmbedderPolicyReport during the frame navigation and dedicated worker initialization, and give it to the network service so that (possibly potential) CORP blocks are reported. Bug: 1052764 Change-Id: Ia39ff8277eb23d96025f5e6fba4e5a4fa6ffde70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076223 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#747176}
-
Colin Blundell authored
This CL is another step toward the componentization of ExternalNavigationHandler.java for sharing with WebLayer. It removes the dependence that ExternalNavigationHandler.java currently has on //chrome's WebappScopePolicy.java. This dependence is to assist in determining whether the user is navigating within the context of an installed PWA within which the intent should stay. At this point in time, this is //chrome-level functionality. Hence, we abstract this check through ExternalNavigationDelegate. Bug: 1031465 Change-Id: I65869090553f2cf337db39cfbb9aaac6d341f7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087678 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#747175}
-
Yutaka Hirano authored
Yoichi landed many CLs for https://crbug.com/865001 and https://crbug.com/967524 and I think it's good to have him as an OWNER. Bug: None Change-Id: I5e3b8d9b362a18d53cdca383cc1c61a9b3beb993 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086389 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#747174}
-
Stepan Khapugin authored
Moves some process-scoped code from -startUpChromeUIPostCrash:needRestoration: * Break down scheduleTasksRequiringBVCWithBrowserState to not include promo-related code. Promo logic will move to Scene. * Move some calls to startUpAfterFirstWindowCreated Bug: 1045658 Change-Id: Iab374d1fc4befedf1f51713d13e00ba4d108c02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087334 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
1: https://crrev.com/c/2074177 2: [this] 3: https://crrev.com/c/2076223 This series of CLs implements https://github.com/mikewest/corpp/pull/9. We introduce network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter, implement the reporting logic in content::CrossOriginEmbedderPolicyReporter and the CORP check, and plumb the mojo interface. This CL implements the reporting logic in the CORP check. Bug: 1052764 Change-Id: Ia3c4d3aec886c76be6dd32083809e9e447ce2a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075002 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Miriam Zimmerman authored
This will help the telemetry team debug consent flakes in integration tests. BUG=1041062 TEST=modified KernelWarning to use appropriate verbose flag and \ `tast run --extrauseflags chrome_internal $DUT platform.KernelWarning` Change-Id: I050b43b1a8578ce427ca9974c237f133115161de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082918Reviewed-by:Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#747171}
-
Yutaka Hirano authored
1: [this] 2: https://crrev.com/c/2075002 3: https://crrev.com/c/2076223 This series of CLs implements https://github.com/mikewest/corpp/pull/9. We introduce network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter, implement the reporting logic in content::CrossOriginEmbedderPolicyReporter and the CORP check, and plumb the mojo interface. This CL introduces network::mojom::CrossOriginEmbedderPolicyReporter and its implementation content::CrossOriginEmbedderPolicyReporter. Bug: 1052764 Change-Id: I7ccce3e39c760393bf2d1b73786cf2a7ae838fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074177Reviewed-by:
-
Adam Rice authored
http/tests/streams/chromium/get-reader-byob.html is timing out on the Fuchsia bots some times. Mark it as flaky in TestExpectations. BUG=1057020 Change-Id: I53f94f98e738682b6ede5efc649cc8e883b27370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078380 Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#747169}
-
Benjamin Beaudry authored
An issue came up with CreateAdjacentLeafTextPosition(), used to create boundaries start/end positions in ax_position.h and help with text navigation. It was caused by the UIA-only concept of embedded object replaced by the empty object character when all children of a node are ignored. One of the conditions for a node to be considered as an embedded object was to look at its child count: if it had at least one child, it could not be an "empty object". However, a corner case where a button (or any other control) contains an empty div forces us to modify this condition. Consider the following example: **************************************** <button> | <div></div> | </button> | | would result in the following AXTree: | | ++kButton | ++++kGenericContainer ignored | | **************************************** Because the button node contains one child, it is not considered as an empty object replaced by character. However, because this button has no text content and its child is ignored, nothing will be exposed to text range provider. Furthermore, CreateAdjacentLeafTextPosition() will not be able to create a position in the button even though it should. This will result in the button being either skip (thus inaccessible) or causing Narrator to get stuck on this node when in Scan Mode. This CL fixes the issue with a two steps solution: 1. If all children of a node are ignored, we might consider it to be an empty object replaced by character even though it has a child or more. Remember that this logic is only activated by UIA. 2. I introduced AXPosition::IsLeaf, which returns true when a node has no child or is an empty object replaced by character. Now, when we call CreateNextLeafTextPosition (or any other similar method) right before a button that contains an empty div, the position created will be inside the button node and not inside of its leaf ignored node. Final note: it is important from now on to call IsLeaf() instead of AnchorChildCount() in ax_position.h to determine if a node is a leaf. We shouldn't notice a perf difference, since IsEmptyObjectReplacedByCharacter is of constant complexity (+ it has a shortcut that returns false when called by something else than our UIA implementation). Bug: 928948 Change-Id: If95281745d1c8dda3e646dba00923791cc1af7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079619 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747168}
-
Jose Lopes authored
This is a repeating callback because it's called from a for loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/ts_section_pat.cc?rcl=12cb56005b4e382d8ba25cec382deb04bc024369&l=105 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: I3fd346d4f02ea0281a9eb716090ff76cdf6d5a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080359 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747167}
-
Rushan Suleymanov authored
This patch introduces timeout error code which will be used every time when the bridge didn't get response on sent message. Bug: 1056210 Change-Id: I026769097d7eba349e90e5f292123a9ed323e489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082923Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#747166}
-
Eric Seckler authored
This patch fixes two issues that could previously lead to unterminated LatencyInfo flows: 1) When we replace a surface (new surface for same frame sink activates) before frames on multiple old surfaces were activated or aggregated, we didn't correctly propagate the LatencyInfo from all old surfaces. 2) When a CompositorFrame is rejected by CompositorFrameSinkSupport or Surface::QueueFrame(), we should terminate its LatencyInfo, too. Bug: 1056604 Change-Id: I1a4e2067cf1d762298cafb7fced6c7bbc9a7bd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078015Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#747165}
-
Side Yilmaz authored
when called incognito. This CL replaces usage of deprecated |getLastUsedProfile| with |isOffTheRecord| param. Curently, always regular profile is used to get InfoBarController, since |getLastUsedProfile| return always regular profile. However it is not true. Therefore, this CL uses |isOffTheRecord| param from info of download item at DownloadManagerService to get correct InfoBarController for the correct profile object(i.e., regular or off-the-record profile). Bug: 1041781 Change-Id: I2d5ecf786043c8cf8fa7b62e09240a3d0c6f3c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083301Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#747164}
-
Victor Hugo Vianna Silva authored
This is a preparation for the removal of said method. Although these unit tests seem to use an arbitrary SyncableService at first glance, inspecting SyncValueStoreCache shows the object is actually always one specific implementation of the interface (SyncStorageBackend). This CL downcasts the return value of SyncValueStoreCache::GetSyncableService so that the tests don't depend on the SyncableService interface having the method. Bug: 1057577 Change-Id: I8b6e674d28d4b28829b519caf1d930c89552f5c7 Fixed: 1057577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084991Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#747163}
-
Robert Woods authored
Ideally, file handlers would be represented in a consistent way across all systems in Chrome. A new representation was created for BMO; this CL lifts that out and into app_service, making it available everywhere. Bug: 938103 Change-Id: I38bd222c8bc3b6a46f6ee238844fb3ae0cb740ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073180Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Robert Woods <robertwoods@google.com> Cr-Commit-Position: refs/heads/master@{#747162}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/14e5f0b2cb03..3f1aee3cbb9f git log 14e5f0b2cb03..3f1aee3cbb9f --date=short --first-parent --format='%ad %ae %s' 2020-03-05 deadbeef@webrtc.org Change network_priority from a double to an enum. Created with: gclient setdep -r src/third_party/webrtc@3f1aee3cbb9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I82cadfce4900d51388343b165800fd86c3e94d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089020Reviewed-by:
-
Victor Hugo Vianna Silva authored
No behavior is changed, since this parameter was unused. Bug: 978775 Change-Id: Ia16b9170507262401df5277c96e658fd7761a1fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087393Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#747160}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6ed96d1c23b..f0c5950706c6 git log f6ed96d1c23b..f0c5950706c6 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9e9493f29dbf..c55fbc4064aa (16 commits) 2020-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 126720bd2e57..a095711c5d77 (4 commits) 2020-03-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2f96e324..7c474dc8 (439 commits) Created with: gclient setdep -r src/third_party/skia@f0c5950706c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Ia3f1b67fc635583ce6a21608103534d4f3f233ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089011Reviewed-by:
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I6c2d3a4ce305ef0ab5bf0dc36bfff27093c9717f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087584Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Maksim Sisov authored
The buildbot could not run weston as it could not find some libraries. The problem turned out to be that linker wasn't looking in the out/release directory for libraries because that directory isn't in LD_LIBRARY_PATH. TBR=thomasanderson@chromium.org Bug: 1029241 Change-Id: Iaf9d0004bf4834dcf208ce7f588308801af0861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087407Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#747157}
-
Jose Lopes authored
This callback is called from a while loop. It's run in: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=179 which is called from: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=297 Another example. It's run in: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_mpeg1audio.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=196 which is called from: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=179 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007806 Change-Id: Id10660797cf181121e0c34c581edd300fa3e23e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080268Reviewed-by:
-
Colin Blundell authored
The only client of ExternalNavigationParams.getTab() is now ExternalNavigationDelegateImpl, and the only client that sets the Tab of the params is InterceptNavigationDelegateImpl. The latter sets the Tab of the params to its own ivar, which is the same object that it has passed to the ExternalNavigationDelegateImpl instance that it constructs via TabDelegateFactory.createExternalNavigationHandler(). Thus, ExternalNavigationDelegateImpl can simply use its own |mTab| ivar in place of ExternalNavigationParams.getTab(), as they refer to the same object. This CL also makes a minor change to the structure of ExternalNavigationDelegateImplTest.java to adjust for the production change. This change aids in the componentiation of ExternalNavigationHandler for sharing with WebLayer. Bug: 1031465 Change-Id: I0b79258555c63171ab61459187ad6303822a467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087671 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie37277969698e1bd2539e43f93fa4481e8f41b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089019Reviewed-by:
-
Maksim Sisov authored
This change removes hard requirement on a wl_seat and allows to run Ozone/Wayland without that. This is required by 1) tests that will be run with headless weston 2) systems that run without any perihperial peripheral devices. TBR=spang@chromium.org Bug: 1029241 Change-Id: I9970052b3d6d593591eb93738d0b83218abd1353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088852Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I4382d96bec21c7267c749b1bf9d6fb07b3218f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088954Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60abb5cb5d28..dcb8686f7685 Created with: gclient setdep -r src-internal@dcb8686f7685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia02c83006b3dc70f6012d7f1f522c4d2a740a6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089015Reviewed-by:
-
Anqing Zhao authored
Before supporting a new json format for uploads.log file, it's worthy to extract the cleanup codes for CSV format to an independent method. It can improve the readability. Bug: 1040078 Change-Id: I661bf875f799a6d56875b890c22f1fb1730c8d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057763 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#747150}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 432677d1. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib30a3724aefd9d2ab85b58ed8b306b8fb99cf6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088692Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747149}
-
Eugene But authored
User Actions are added to Breadscrumbs (log attached to steps to reproduce). Logging the actions earler will include them into Breadcrumbs if presentation code crashes (like what happens in crbug.com/1050786). Bug: 1046231 Change-Id: I6cde3c11320d41135bbeffc9d4943d5b9645a293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087874 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747148}
-
Dana Fried authored
This is a continuation of the pattern of AnimatingLayoutManager::GetDefaultFlexRule(). Bug: 1048061 Change-Id: I0aaff55bea6c674b07b42abd4584092058b01df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040731 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#747147}
-
Nicholas Verne authored
These tests are an promised add on to https://chromium-review.googlesource.com/c/chromium/src/+/2084213 Bug: 1057899 Change-Id: I92f6f7a308df197a02e0b935c6d0627509b60761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087879 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#747146}
-
Alice Wang authored
This CL cleans the AccountManagerFacade.getGoogleAccounts usage in RequestGenerator. We should use this method when the error thrown is meaningful. Bug: 1057040 Change-Id: Ib6dbd625d20c6da4a231a25055333100e93bc844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080231Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747145}
-
Rainhard Findling authored
* Aligns the safety check UI with the latest strings in the mocks. * Adds links to the dynamic UI strings of safety check. Bug: 1015841 Change-Id: I32c94c9b454c089aac5bfb1751e314e9911bb228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085371Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747144}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Ic735aaff5e8692b406a2d41a9063c8422cc91143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088338Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#747143}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I484604e2a494dc32712b0b16ea1c011f58a403ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088359Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747142}
-
