- 10 Jan, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72ee5754..e195519d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c29cdd5bb0f59a1f365f9983832fffda65ec8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993763Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730134}
-
Gauthier Ambard authored
This CL adds the UIAccessibilityTraitNotEnabled to the search engine cells when they are not interactable. Fixed: 1040497 Change-Id: Iec65f625d7bf3d7f738d82ab86b204c3c58a6099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994284 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#730133}
-
Vasilii Sukhanov authored
TBR=erikchen@chromium.org Bug: 989810 Change-Id: I45c6ba5ddc575e8c5202ca32db5165169de1421b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994289Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#730132}
-
Mikel Astiz authored
It reuses a screenshot previously uploaded for IDS_SYNC_ERROR_PASSWORDS_USER_MENU_TITLE. Bug: 1036454 Change-Id: I4388b36516d040b4314197f9b4f642d9577c3523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995160 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#730131}
-
Anders Hartvoll Ruud authored
BUG=545324 Change-Id: Ib7c79ad352a8d68a7815ca992f25280e5c980561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986797 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#730130}
-
Alex Danilo authored
Quickview loads image previews by calling decode() on the <img> element after its 'src' attribute is set. When the image is finished decoding it should replace the previous decoded image. Changes decode() failures to send a message to the container that decode failed and in turn, set the contentURL to '' which in turn unloads the webview and displays the 'no preview available' icon. Bug: 645021 Tests: browser_tests --gtest_filter="*QuickViewBrokenImage" Change-Id: Ie1d19f1a4f1014486eaaec9581007f25d4c7f165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992954 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#730129}
-
Clemens Backes authored
We plan to run a finch trial on mobile chrome to test different compilation strategies. For this, we need to separate enabling Liftoff from enabling tiering. The finch config could then enable Liftoff but disable tiering - a configuration which is not possible currently. Note that this CL does not change the default configuration. On Desktop, we enable both Liftoff and tiering. On mobile platforms, Liftoff is disabled, so the tiering flag has no effect. R=ahaas@chromium.org, jochen@chromium.org Bug: 1040030, 1040061 Change-Id: I7cd0a8907d84388d15cb49663d18fe4c5c81dd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988360 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#730128}
-
Monica Basta authored
This CL implements communicating the sWAA to |chrome://settings/syncSetup| as part of the friendly settings project. The sWAA bit will be fetched and shown in the sync section. Its value depends on the following factors: 1- Data is encrypted with custom passphrase or not. If yes, Google has no access to the data and can not use history to provide personalized experience. In that case, sWAA is 'Off'. 2- History sync is On/Off. This pref is set per device which means history from this device can not be used for personalization. We show 'Off' as well. 2- History recording is enabled/disabled in |Web and Activity| in the Activity control page. If the user does not have encryption and history sync is On, then sWAA will be On if history recording is enabled and Off otherwise. The sWAA can be in one of the following states: 1- Not fetched: On startup, sync is off, feature |kSyncSetupFriendlySettings| is disabled. In that case, no changes is reflected in the UI. 2- Fetching: we show a spinner. The request is pretty fast and the spinner is almost not visible. 3- Failed: If we fail for any reason to fetch the sWAA bit. Also, in that case no changes to the UI. 4- On: We show sWAA state 'On' + hint to reflect how will this affect the user experience. 5- Off: We 'Off' + hint to indicate the reason why Google can not use history to provide personalized experience whether it's because of encryption or history sync off or history recording toggled off. To guarantee we show the most up to date value, we refresh sWAA on the following events: On navigation to page, Sync turned on, Encryption, History sync toggled, sync pref changes in case we previously failed to fetch (fetch failures sometimes are due to sync service not active yet) and page is visible. Bug: 1035421 Change-Id: I0577b0ff76bfd7d66415416fdfba5f91f4e34316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973915 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#730127}
-
Vasilii Sukhanov authored
TBR=eirage@chromium.org Bug: 1040874 Change-Id: Iec6b2cc5a72e1b3256d66b8acf09f515e8a0b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995164Reviewed-by:
-
Richard Knoll authored
The P2PSocketManager resolves host names in GetHostAddress and responds with the supplied callback. That callback is dropped in the destructor which can happen if there is a mojo connection error. We need to close the pipe to the mojom::P2PSocketManager before doing that as mojo will check if the connection is still active when dropping a callback. Bug: None Change-Id: I2a1e411f5aba21a375e33bd242b67f64c9362a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991560Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730125}
-
Alice Wang authored
This CL tests and refactors the SignOutDialogFragment. Bug: 967374 Change-Id: Ibe0af76022877305b38513d5855e238465635469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982557 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#730124}
-
Vasilii Sukhanov authored
This reverts commit d140b7a4. Reason for revert: Broke crashpad_tests reliably https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/12597 Original change's description: > Enable init_stack_vars for non-official Debug Windows builds > > Debug build is fixed with: crrev.com/c/1973353 > > Bug: 977230, 1030261 > Change-Id: Idcb24d092247f6bc7438c74b6405b4b93539507d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970852 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728840} TBR=hans@chromium.org,vitalybuka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 977230, 1030261 Change-Id: Iad7d92e12299365b4a45a5237c3bc5e371e33dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993964Reviewed-by:
-
Richard Knoll authored
The latest beta of 10.15.3 fixed the issue where an XPC service could not show notifications. This removes the workaround we put in place in https://crrev.com/c/1883648 for macOS 10.15.3+ but keeps it for earlier versions of 10.15. Bug: 1007418 Change-Id: I928dac7366c9e7faee793dd72d282b031e535092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991637 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#730122}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dbcda838560..a104a789f873 git log 9dbcda838560..a104a789f873 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 dberris@chromium.org Fix dispatch routing Created with: gclient setdep -r src/third_party/catapult@a104a789f873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1035930 Tbr: crouleau@google.com Change-Id: I895bd006cf70d17e86fc254e5382c50f708cbe76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730121}
-
Eric Seckler authored
Replaces SyncChannel::Send, RenderProcessHostImpl::Send, and GpuChannelHost::Send trace events with typed trace events. Also adds a utility to convert the IPC class ID to a corresponding protobuf enum. Corresponding proto buffer definitions for these events were added in aosp/1180211. Typed trace events will allow inclusion of the event arguments in slow reports data in the future. The trace format is protocol-buffer based under the hood already (see docs.perfetto.dev for details), this patch adds strong typing for the arguments of the respective events only. TBR: sunnyps@chromium.org Bug: 644264 Change-Id: I91c71230e62161b08faec889bf9eb70639ae0b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950986 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#730120}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c83d5e24..72ee5754 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa8b427cf8b0d55d57713ff008eca12ecf809f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993762Reviewed-by:
-
Stepan Khapugin authored
Since UIRefresh had long been the only option, remove references to it in constant names. Bug: none Test: none Change-Id: Ifb3cdb5fec82ad4ea015014c098685010b04e81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991455 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9b289b2c2973..4b6df1777cba git log 9b289b2c2973..4b6df1777cba --date=short --first-parent --format='%ad %ae %s' 2020-01-10 thomasanderson@chromium.org Update Linux documentation links Created with: gclient setdep -r src/third_party/webrtc@4b6df1777cba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6d041aea175da5de05ec33c24756cce67befcaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995141Reviewed-by:
-
Anders Hartvoll Ruud authored
BUG=545324 Change-Id: Ic90b7e417accdbf64b110f70db41369e2edec0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986831Reviewed-by:
-
Steve Anton authored
Linux limits the thread name to 15 characters which was cutting off the signaling/worker distinction. Bug: None Change-Id: Ibbbfdf1cedd0add91a8c3aa5c5b5cac6a06d4168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994050 Auto-Submit: Steve Anton <steveanton@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#730115}
-
Raphael Kubo da Costa authored
web-platform-tests has recently gained the ability to set the permission associated to a permission type via test_driver.set_permission(), in a similar fashion to Blink's testRunner.setPermission(). This is CL #1 of a few, and the ultimate goal is to add an implementation of set_permission() to testdriver-vendor.js, so that we can replace uses of testRunner.setPermission(), and consequently move more Blink-specific tests to WPT. This CL adds a new .mojom file to third_party/blink/public/mojom/permissions that allows setting the permission associated with a given permission type, in a similar fashion to testRunner.setPermission(). This API is only intended for use in tests, so the new PermissionAutomation interface is added to a separate file that is part of the blink.test.mojom module, and it is only implemented by content_shell. It then plugs it into the internals object. While in the short term it adds another way to achieve the same thing in layout tests, this was done for a couple of reasons: * test_driver.set_permission() takes a PermissionDescriptor (from the Permissions API) rather than a string that does not necessarily match the permission name as specified in the Permissions API. It makes sense to use standardized APIs, so rather than adding code to convert a PermissionDescriptor into a string accepted by testRunner's setPermission(), internals.setPermission() also takes a PermissionDescriptor. * Since testRunner is implemented entirely in //content/shell, we cannot have its code call Blink to convert a JS value representing the descriptor into a blink::mojom::PermissionDescriptorPtr. By Onion Soup'ing the code to set permissions, we can do all the PermissionDescriptor parsing in Blink and just call the PermissionAutomation implementation in content shell's browser side. For this, we change the internals object in Blink and bypass testRunner altogether. * The new API also gives us more flexibility: it returns a promise so that we can be sure the permission changes really have an effect before executing the rest of the code in a test. A few layout tests have been converted to the new API to show it works. Once existing uses of testRunner.setPermission() are converted, we can remove it altogether, and have internals.setPermission() be part of the implementation of testdriver.js' set_permission() call. Bug: 1030663 Change-Id: I3f40a9facd521ac41c4506b4043ecd5c831586fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958117Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#730114}
-
Jérôme Lebel authored
Removing SigninAccountSelectorViewController class. It was used to select an account before Unity UI. This class should have been removed with crrev.com/c/1778868. And renaming -[ChromeSigninViewController signinCompletedWithUnity] into -[ChromeSigninViewController signinCompleted]. Bug: 951313 Change-Id: I7012595fdd6de754ed60ac4bb17d0dd9951affbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991454 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#730113}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1577705382-benchmark-81.0.4013.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2f7962cd02def14c638147afcb8c3e0610c89536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995144Reviewed-by:
-
Takashi Toyoshima authored
cors::CheckAccessInternal() ensures if the HTTP response status is set to a non-zero value. This code was originally introduced in Blink side, but it's out-of-spec implementation. CORS preflight response expects an ok status for CORS checks and our implementation implicitly rejects the status 0. Actual response does not have such CORS specific status code check, and fetch() or XHR can receive an error status as long as the response has a right access control headers. But since 0 is not used in HTTP, we don't need such check in CORS code. So, let's remove this stale check and relevant test, WebAssociatedURLLoaderTest. CrossOriginWithAccessControlFailureBadStatusCode. This was added by https://codereview.chromium.org/110273006/, but the original change's intention does not help developers today. Also note that usual server applications such as Apache converts this kind of invalid status from CGI to 500 to assume such situation as an internal server error. This patch also integrate the ok status check into the cors::PreflightAccessCheck so to minimize exposed functions. Bug: 1039174 Change-Id: Ib8f8d84e200a01884daab9d726ac52b38e36a591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983696 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Ionel Popescu authored
*** SHERIFFS: if this CL triggers a flaky layout test, PLEASE do not *** revert this CL. Instead, please disable the offending test(s) and *** add them to the crbug.com/1035582 section of TestExpectations. I *** will then take care of them as I fix up the remainder of these *** tests. Feel free to cc me if you create a bug. Thanks. This CL updates the focus ring to be made of two borders which have a 2:1 ratio. The new width of the focus ring is 3px: 2px nearly black (#101010), followed by 1px white. If the element has a border large enough to have an inset outline (width >= 1px) then we are going to inset the focus ring by 1px as we want it to be partially drawn over the border to avoid clipping or strange alignment issues caused by increasing the width to 3px. For elements that have not been styled and that have an appearance, the border radius of the focus ring is updated to be the same as the one used for drawing the element. For all other cases the current behavior is maintained: border radius = outline width. Tests are added to validate the new focus ring for multiple scenarios (see controls-refresh/focus-rect) Bug: 1026553 Change-Id: Ibe05cf6b7336198bd9513174493f51da5108339a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975072 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#730110}
-
Takuto Ikuta authored
chrome_public_test_apk passes now. https://luci-milo-dev.appspot.com/p/chromium/builders/ci/Android%20N5X%20Swarm/10131 This was introduced in crrev.com/3400947e Bug: 955013, 731759 Change-Id: I4b73a7efcf5052d83df66021580a233ece3e66fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993002 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#730109}
-
Renato Silva authored
Clicking/Tapping on the 'Learn More' link on the EULA screen will now change the focus to the link itself. Fixed: 1025176 Change-Id: I12ce9c5c4d7d07d9634a2bda66f44441b439c7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991480 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#730108}
-
sandromaggi authored
This CL makes the box around the poodle bigger, such that the animation inside does not clip. This requires an adaption of AnimatedPoodle.java, see https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2396454/ Before: https://screenshot.googleplex.com/RKTuHnfqAUT After: https://screenshot.googleplex.com/Nh1CExNGP14 Bug: b/146418409 Change-Id: Ia15cff2f7d680c0a1fcc92d02fe6bb9e1a691c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991427Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#730107}
-
Mikel Astiz authored
One TODO has already been addressed in https://chromium-review.googlesource.com/c/chromium/src/+/1969582 and the other TODO should be linked to a more appropriate bug. Bug: None Change-Id: Ib2b1da6f68c2dc43a9e892100864b5888cb6996b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992432 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#730106}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/12ce8f687d23..dcc57015f892 git log 12ce8f687d23..dcc57015f892 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 77c89ff847b6..110236f3ce70 (5 commits) Created with: gclient setdep -r src/third_party/angle@dcc57015f892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I734c7f03cc823c9a374acb6d9cb8a598bbde7514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994256Reviewed-by:
-
Simon Zünd authored
For the V8 CL https://crrev.com/c/1350790 two web tests were temporarily disabled. This CL re-enables them and rebaselines one of them. The rebasline is necessary as the CL https://crrev.com/c/1971832 that changed the ordering of properties also modified the expectations. R=petermarshall@chromium.org Bug: chromium:924308 Change-Id: Idf57e2525480828da44b0e6dfb43a07b39af65ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993803Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#730104}
-
Swapnil authored
This is to get a better idea for failure of Force installed extensions through UMA statistics by reporting error codes. Earlier we used to report the network error codes to Extensions.CrxFetchError histogram, but that accounts for all the extensions. Now in addition to Extensions.CrxFetchError histograms, we will have new histograms which will report only in case of Force Installed Extensions. In addition we also report Http error codes, and the number of fetch retries made in case of CRX_FETCH_FAILURE error. Following histograms are added: Extensions.ForceInstalledFetchTries -> Reports the number of fetch retries made in case of CRX_FETCH_FAILURE. Extensions.ForceInstalledHttpErrorCode -> Reports the Http Error Code in case of CRX_FETCH_FAILURE. Extensions.ForceInstalledNetworkErrorCode -> Reports the Network error codes in case of CRX_FETCH_FAILURE. Error codes are received in the ExtensionDownloader, and then they are passed to ExtensionUpdater through the ExtensionDownloaderDelegate. ExtensionUpdater reports the error codes to the InstallationReporter. Bug: 1030224 Change-Id: Id9762df857483edaa008a2f2c718a425ead3f25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955726Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#730103}
-
Robbie Gibson authored
Before, these methods were required, but many classes that conformed to the protocol had them as no-ops. It is simpler to mark them optional and remove the no-ops. Change-Id: I1b71f15f8574742fc92e5bf599e37530f9ac5229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991629Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#730102}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idb55f2410f440addd41543cfb2483f7b7dec7347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994257Reviewed-by:
-
Mikel Astiz authored
This is a reland of d35a5b72, which includes a fix to prevent the issue of the BookmarkModel being modified while iterated, which can invalidate iterators due to how GUID reassignment is implemented. Original change's description: > Bookmark sync: use GUID as temporary server ID during commit > > This patch effectively relands the logic reverted in > https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which > caused crashes in the past (CHECK failures). > > In this new form, the underlying issue is addressed: for users that > don't use GUID-based merging of bookmarks, local GUIDs are reassigned > randomly to avoid GUID collisions in the local bookmark model. > > Bug: 978430,1004205 > Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729405} Bug: 978430, 1004205 Change-Id: Ie86f42a1d8985e325fca5741d43aefc6ef0955c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993295 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730100}
-
Yuta Kitamura authored
Bug: 1040450 Change-Id: I80fa1ff683706760207e37c00e22b66375cce23e No-Try: true Tbr: vasilii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995104Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#730099}
-
Matt Falkenhagen authored
This histogram expired: * Worker.TopLevelScript.OriginType.RequestUrl.DedicatedWorker Bug: 867302, 960042 Change-Id: If44ab380b6da4ad61b5343182294e4c400406b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686861 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#730098}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70b009b0f1e..fb2e819819ef git log e70b009b0f1e..fb2e819819ef --date=short --first-parent --format='%ad %ae %s' 2020-01-08 dneto@google.com Fix GN build for OpenCL.DebugInfo.100 update (#3134) 2020-01-08 bclayton@google.com Fix bad parameter names in error message (#3129) 2020-01-07 alanbaker@google.com Revert PR #3093 (#3131) 2020-01-07 alanbaker@google.com Disallow forward references in arrays (#3093) 2020-01-07 afdx@google.com spirv-fuzz: Add fuzzer pass to perform module donation (#3117) 2020-01-06 dneto@google.com GetOperandConstants operand can be const (#3126) 2019-12-27 dneto@google.com Avoid pessimizing std::move (#3124) 2019-12-27 kburjack@googlemail.com Fix typo in validation message (#3122) 2019-12-27 greg@lunarg.com Change default version for CreatInstBindlessCheckPass to 2 (#3119) 2019-12-21 greg@lunarg.com Fix convert-relax-to-half invalid code (#3099) (#3106) 2019-12-19 dneto@google.com Support OpenCL.DebugInfo.100 extended instruction set (#3080) 2019-12-19 afdx@google.com spirv-fuzz: Always add new globals to entry point interfaces (#3113) 2019-12-19 afdx@google.com spirv-fuzz: Transformation to add a new function to a module (#3114) 2019-12-19 afdx@google.com spirv-fuzz: Avoid passing access chains as parameters (#3112) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fb2e819819ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I832222314f0eaf0dd778311e48bc7921dee3baee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994255Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d41d8be6..c83d5e24 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9b2cef40998e4d159581b2b91ca27bcecbb483c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994901Reviewed-by:
-
Gauthier Ambard authored
This CL cleans a bit more the collection view. Bug: 894800 Change-Id: I3211f9afa8af578323bec1a2a13ca8842d91c42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991449 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#730095}
-
