- 10 Sep, 2019 40 commits
-
-
Rune Lillesveen authored
Multiple issues with previous patch: - color_scheme check was not correct - we did not resolve the chosen color value from the pair correctly Bug: 939811 Change-Id: I519ed2c70f5f28ceaf102f9c7c466d155779db05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789538 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#695084}
-
Tanisha Mandre authored
- 'Add' button: Test enable/disable, test alert on adding wrong number. - 'Cancel button: Test dismissing 'Add Credit Card' view on tap. Bug:1000669 Change-Id: I7303be8416a43493d07d51b7bf966dbcc5f61ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787645 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#695083}
-
Gauthier Ambard authored
On iOS 12, when the screen time Content Restriction is enabled with SlimNav, this DCHECK is hit. This CL relaxes it in that case. As iOS 13 should be out soon, the usage of iOS 12 among our users should become smaller. Bug: 1000366 Change-Id: I39e02361ce0771a140d17060ed35f6be20f30a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791154 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 1000055 Change-Id: I4e7fdbe09f31460f27ad88b4bb2f075d42d21a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793289 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695081}
-
Tanisha Mandre authored
- Enables CreditCardScanner feature flag in setup. - Tests text fields appear - name, card number, expiry month, expiry year. - Tests 'Use Camera' button appears only in iOS 13. Bug:1000669 Change-Id: Idf4d39061b715bab322e88b65ccc2d31e715bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787378Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#695080}
-
Friedrich Horschig authored
The keyboard accessory was still using the old announcement. It would shout "Passwords available" which isn't wrong since passwords fallbacks are available but it is very unprecise, incomplete and misleading if the accessory is filled with Address autofill suggestion. Bug: 969202 Change-Id: I5792ff1479b361344d976b3036bec7b46cdf5638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793082Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695079}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider, as well as simplify code in RenderFrameHostImpl by using the new service_manager::BinderMap class directly, instead of using the old service_manager::BinderRegistry object. Last, this CL also adds missing includes in browser_interface_binders.cc Bug: 955171, 978694, 936482 Change-Id: I72354777751fe407680d7935db6e6bd41d194095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768338Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#695078}
-
Eliot Courtney authored
This makes sure that the HIDDEN occlusion update is delivered when hiding the window, not when showing it later. Subsurface additions are processed at any time (not only commit), which means hidden windows can get added to the hierarchy. Their occlusion will be computed as hidden until the next CommitSurfaceHierarchy where they are made visible. This change moves that HIDDEN occlusion update to the time of hiding, rather than the time of showing. sent upon entering PIP, not leaving. Bug: 140563748 Test: Alt-tab to trigger PIP on Youtube. Occlusion fraction of 1.0 is Change-Id: I9a4a8f74bdaa0a55a65a6152b9df1232bd0e6e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792041 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#695077}
-
Robbie Gibson authored
Bug: 974255 Change-Id: Ib0ba38dfee28e87f744818b350af8dd77d37a4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792870Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#695076}
-
Mohamed Amir Yosef authored
Change-Id: Ibae7013f4690d43d5fe576f82096ab1e6b1ee5fc Bug: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774285 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#695075}
-
Anastasiia Nikolaienko authored
For Active Directory login there is no primary account, since it has to be Gaia acccount. - We will not abort reconciliation if primary account has an error. - GetFirstGaiaAccountForReconcile will keep the order of Gaia accounts even if there is no primary account. Bug: 993317 Change-Id: I2a20933a3a9627b83cce2d4e027d91eb7d52795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758072Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#695074}
-
Mario Sanchez Prada authored
Convert the remaining bits in //content that still use the old mojo types for content.mojom.Echo to the new mojo types. Bug: 955171 Change-Id: Ia57bf99582ebf6d280de6eca7971ca30c805f550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792871Reviewed-by:
-
Pâris MEULEMAN authored
In preparation of the creation of PrimaryAccountMutator.java, move the java signin metrics enums to //components/signin, aligning them with their C++ counterpart. Indeed, these will be used by PrimaryAccountMutator.java within the component. Bug: 934688 Change-Id: I4574d9caba9464328ffa0c6859dbbeefc2e18901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782901 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695072}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7b6bab50170..b09e9fc89fa7 Created with: gclient setdep -r src-internal@b09e9fc89fa7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I5ab2c9a9c26f1acc1c52fb35ae40cf48364124f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793888Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695071}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/008a1db55909..9e5c47936b17 git log 008a1db55909..9e5c47936b17 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7ff7df26f28..58c5b07b47cf (7 commits) 2019-09-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 44e6523d7ff3..cebb9635a5d5 (1 commits) Created with: gclient setdep -r src/third_party/skia@9e5c47936b17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None,chromium:None Change-Id: I0c4e40a1c4d41652816527fdb92b82af0ed9b91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695070}
-
Dominik Röttsches authored
Reland after reason for printing test timeouts has been identified in issue 996185. This will prefer performing DWrite API based font fallback on all Windowses, particularly on Windows 8.0 and below, where API based fallback was previously not available and hard-coded lookup tables were used. A content feature is used to flip the switch on this as a last-resort deactivation method, should this lead to unexpected fallback problems. Sheriffs, if there are individual layout tests failing with differences in arrow icons or different fonts used for Chinese, Japanese or Korean text, please disable the test and assign it to me - I will add the new baselines. Bug: 976737 Change-Id: I8546d1cb095af4691f6848209ba521b96d0b3cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778604 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695069}
-
Sergio Villar Senin authored
It's unused so there is no point in passing it. Bug: 994811 Change-Id: Ib7923897beaaf7b302c3d49b23d5da9fe11e32e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792892Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#695068}
-
Jérôme Lebel authored
Updating the header image in the user consent view to support dark mode. https://drive.google.com/open?id=1lZj0o-kIoTZsa5bMnRirKr-YfSUXEo_D Bug: 1002075 Change-Id: I09acf58a8c236a24f5c10c488896f85206083f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790111Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695067}
-
Maksim Sisov authored
Now, the DWTHPlatform just minimally responsible for setting the window into fullscreen/maximized state or even restoring its state. Most of the functionality has been moved from DWTHX11 to X11Window instead. What is more, AdjustSize has been moved to X11Window and is Linux/X11 specific now. Show/Hide methods have also been reworked and DWTHPlatform determines inactivity now and is responsible for for window state changes. Also, the WindowManagerTogglesFullscreen test has been changed in such a way that it expects that Chromium reacts on fullscreen changes made from a window manager side. This is what we have already been doing in Wayland, btw. Last, SetBoundsInPixels method has been removed from the DWTHX11. Instead, the WTHPlatform::SetBoundsInPixels is used. And, as said previously, AdjustSize for that method is implemented in the X11Window now. Bug: 990756 Change-Id: Ia4a7d4859a4b42bd7de99eb7c4309ac55e34e9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769450 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695066}
-
Maksim Sisov authored
This CL moved the Get/SetZOrderLevel to DWTHPlatform. This method is useful for both Windows(if it eventually starts to use this path) and Linux. Also, SetAlwaysOnTop and IsAlwaysOnTop have been added to the PlatformWindow interface. However, default implementation is also added to avoid messing much with other platforms, which do not support that on the PlatformWindow level like Ozone/Drm. Instead, ChromeOS sets a property on an aura::Window. Both Windows and X11 support setting the always on top value. In case of Wayland, we'd need to add gtk_shell support and use it whenever Chromium is run on gtk. Thus, I've added NOTIMPLEMENTED to those PlatformWindows, which could potentially support that. Bug: 990756 Change-Id: Id69cca5ac59556384f1a7e01d59ab021370f19a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774454Reviewed-by:
-
Daniele Castagna authored
viz::BufferQueue currently implements partial swap reading back from the previously swapped buffer contents that are outside the current swapbuffer damage. This introduced a dependency on a GPU API, that we want to get rid of (crbug.com/958670). This technique also assumes it is safe to read back from a buffer that is used from another driver (crbug.com/457511). This CL removes the readback and solves the same problem exposing a rectangle that the compositor needs to redraw to make sure contents damaged during all the swapbuffers before the current one are recomposited. Bug: 958670, 457511 Test: BufferQueueTest.PartialSwapCurrentBufferDamage Change-Id: Icda39c42053c2d1134f739485357009271b80634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761708 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#695064}
-
Ricky Liang authored
Also changes GfxBufferFormatToVideoPixelFormat to return nullopt when the input GFX format is invalid instead of crashing through LOG(FATAL). Bug: 982201, 997581 Change-Id: Id98fe66dbc82dc9d520623296f92107bd1dc8707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792362 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695063}
-
Tao Bai authored
This reverts commit 9c44fedd. Reason for revert: broke https://ci.chromium.org/p/chromium/builders/ci/android-jumbo-rel/13515 Original change's description: > Cleanup Android video targets > > Fixes WebView component build issues. > > Previous CLs introduced a number of new targets including > texture_owner_android and shared_image_video. These were causing build > problems due to duplicate file compilation which led to DCHECKs. > > Moved most of these files into gpu/command_buffer/service:gles2, as > they all depended on this target (so no new transitive deps), and it's > probably a good place for them for now and simplifies dependency > management. > > Bug: 996285 > Change-Id: Ic5a9cced7e67500cfd5fff8809d4ee5e17bbab8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787165 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: vikas soni <vikassoni@chromium.org> > Auto-Submit: Eric Karl <ericrk@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#695006} TBR=kinuko@chromium.org,nasko@chromium.org,liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org Change-Id: Ib51ec09046ecfa51543836755b6b830d76fbce94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793931Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#695062}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreateFaceDetection() in FaceDetectionProvider interface. Bug: 955171 Change-Id: I13702984c7b183eb0f58a994fbd8d00a1ba8db40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792032 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695061}
-
Chih-Yu Huang authored
Currently we always set a "just-enough" frame number. In usual usage there is no stale frames. This CL remove the frame purging logic to simplify the code and reduce the periodically cleanup time. BUG=none TEST=media_unittests --gtest_filter=PlatformVideoFramePoolTest TEST=Run video_decode_accelerator_tests on Kevin Change-Id: I1542c97ed2a492776bc6ec7a2e1d48fdc12467a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786706 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#695060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b388a9a81e11..c7b6bab50170 Created with: gclient setdep -r src-internal@c7b6bab50170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I829340c3cc43e3797052f67a107a57ddecfdcf33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794031Reviewed-by:
-
Peter Kasting authored
Bug: 23697 Change-Id: Id6eeb2b255a653668d57df0aa44c454784786ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792004 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695058}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I0422306175fb40eefa22b58028266414d5485bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792953 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change introduces several overloads for base::Value::Append, supporting boolean, integer, double and string arguments. This change is in preparation for no longer returning a mutable std::vector reference from GetList(), making the previous advice to use emplace_back no longer relevant. Bug: 646113 Change-Id: I10607d14de336ef026a73689e2cae144cc5fec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793083Reviewed-by:
-
Takashi Toyoshima authored
This patch updates the webRequest API documents on a plan for behavior changes caused by OOR-CORS. There could other changes, but will be handled in a separate CL. Bug: 1000554 Change-Id: I631dc3bbf93e041810f2f2016067376ed7b1e352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784258Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695055}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8cae1e95a23b..008a1db55909 git log 8cae1e95a23b..008a1db55909 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a0cef9f5..340a17ae (385 commits) Created with: gclient setdep -r src/third_party/skia@008a1db55909 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None Change-Id: I7f356cdb995a06ec2fabded6e25e6b401d185349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793885Reviewed-by:
-
Kent Tamura authored
An existing forward declaration is enough. Bug: 242216 Change-Id: I1e2c60acf3aac2c90666d916dd92ad187d909900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794326Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695053}
-
Miyoung Shin authored
This CL converts BluetoothSystem{Ptr, Request} in ash and services to the new Mojo type, and uses pending_receiver<BluetoothSystem> in bluetooth_system.mojom. Bug: 955171 Change-Id: I764daf49604184341812fbb3b3249590b29b7d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787663Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#695052}
-
Charles Zhao authored
(1) If ScoreTabs is called with type_ == KPairwiseScorer, then more sophisticated ScoreTabsWithPairwiseScorer is used for scoring. (2) The ScoreTabsWithPairwiseScorer puts all tabs without TabFeatures first, and then sort the result with MRU. After that, best candidate for each position j is picked one by one (3) In unit tests, we directly call ScoreTabsWithPairwiseScorer with type_ = kFrecencyScorer, so that the tests can be independent with the ML model. (This won't happen from public interface in real applications.) Bug: 999908 Change-Id: I85302cda11fc0fc754f5402fdacd1e3796a41b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788774Reviewed-by:Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Auto-Submit: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695051}
-
Julie Jeongeun Kim authored
It converts RenderWidgetHostNSViewAssociatedRequest and RenderWidgetHostNSViewAssociatedPtr to new Mojo types. These are replaced with mojo::PendingAssociatedReceiver, mojo::AssociatedReceiver and mojo::AssociatedRemote. Bug: 955171 Change-Id: I1658a50da87f9e494a57bbb26e548373fa562268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792463 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
James Hawkins authored
This is modeled after the same functionality in the internet detail page implementation. R=stevenjb@chromium.org Bug: 999474 Test: none Change-Id: If5dcac633d5881aa04878b0e57223a437c9af4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793808 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695049}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46c88567d52f..58c5b07b47cf git log 46c88567d52f..58c5b07b47cf --date=short --no-merges --format='%ad %ae %s' 2019-09-10 timvp@google.com Replace Issue 3221 with 2672 in deqp_gles3_test_expectations.txt Created with: gclient setdep -r src/third_party/angle@58c5b07b47cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Ie1bbf0ad193f92949ba767647e59f6383dfd69f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793752Reviewed-by:
-
Eric Willigers authored
Values in the following grammar are tested: [ [ <'font-style'> || <font-variant-css2> || <'font-weight'> || <font-stretch-css3> ]? <'font-size'> [ / <'line-height'> ]? <'font-family'> ] | caption | icon | menu | message-box | small-caption | status-bar https://drafts.csswg.org/css-fonts-4/#font-prop Change-Id: I5180df5bff0e477e08a40197f8886fc8d8cc66c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789217 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#695047}
-
siyua authored
This CL adds the blue round circle highlight animation around the avatar button. It reuses the ink drop hover animation but with a different color. Whenever the animation is visible, hide the avatar sync paused/error state, even if there is no autofill icon visible in the status chip. Controlled by experiment flag kAutofillCreditCardUploadFeedback: No event will be sent to avatar icon if flag is disabled. The animation will be shown when any credit card is saved. Animation for password save will be added later. Bug: 964127 Change-Id: Icc386241e244a6bf9f3db271928ca19029348f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784138 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#695046}
-
Scott Violet authored
This way we get build bot coverage. BUG=none TEST=none Change-Id: Ibce3b2be48420e70a839545a950d105d956477fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790743Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695045}
-
