- 24 Feb, 2020 40 commits
-
-
Adrienne Walker authored
This is just preparation for making moving this code easier. Bug: 1015214 Change-Id: I379b6d1c8be4f61f9e13329c6ddae590fd8c80a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068929 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#744107}
-
Joel Hockey authored
For Autogenerated, and extension-based themes, use frame color for COLOR_STATUS_BUBBLE rather than toolbar. When PWAs set a theme-color, status bubble bg will match frame. crbug.com/1053823#c16 Bug: 1053823 Change-Id: I3a159a5c25a038ab78594c98b7208b3066a82181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067763 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744106}
-
Saman Sami authored
We are seeing invalid frame tokens in the wild. Add some crash keys before taking a dump to help investigate this issue. Bug: 1045372 Change-Id: I3e8546ff214c2ee2f6d2bda3cf4b64d277cce920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042290 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#744105}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.5-1581936665-benchmark-82.0.4065.0-r1 to 82-4044.25-1582540590-benchmark-82.0.4065.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I608cd8043babc2c20590505a074645239339d3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744104}
-
Toby Huang authored
Attempting to show HaTS for supervised users will cause ChromeOS to crash because incognito mode is disabled. Disable HaTS until it is ready for supervised users. Bug: 1055022 Change-Id: I1b7286410a6c2b9c08145862d45944c320ee44c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070111 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744103}
-
Collin Baker authored
Currently, events that would be dispatched to a disabled view are discarded instead. This seems to be a holdover from old event handling code and not necessary anymore. To allow pre-target handlers to still see these events, this CL changes these methods to dispatch the events to the closest enabled ancestor view. Bug: 1043374, 1011082 Change-Id: I82bca238e98b9b820c0c7619a5880fbf3497d886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029087 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744102}
-
Manu Cornet authored
It is unused and retrieving the login status from the session controller is easy enough anyway. Bug: 1042918, 1047012 Change-Id: I06afc5a4f724a45814e76b3bd7af79eab42489a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070815Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#744101}
-
inglorion authored
This uses the new debug info size reduction feature introduced in https://github.com/llvm/llvm-project/commit/651128f5). This was previously enabled for other platforms (crrev.com/c/2040441). For ChromeOS, we needed to upgrade the compiler to get the new feature. Now that that is done, we can enable the feature for ChromeOS, too. Bug: 1050118 Change-Id: Ide359fcb8d1e748bb321927055802bf6ebd7fad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067741 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744100}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1cb4a3a99d23..05a90eab354e git log 1cb4a3a99d23..05a90eab354e --date=short --first-parent --format='%ad %ae %s' 2020-02-24 primiano@google.com Merge "Revert "UI: Add CSP policy"" Created with: gclient setdep -r src/third_party/perfetto@05a90eab354e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6118d0ec4c0ed8105b1c3a6eed3862380fec5327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068283Reviewed-by:
-
Ahmed Fakhry authored
- On sign in of the primary user, desks count and their names will be restored to their most recent state for this user. - Desks addition/removal/renaming triggers updates to the desks restore prefs. - The data structure selected for storing and restoring desks was chosen to be very simple: * A list of desk names. * The size of the list indicates the number of desks that needs to be created on restore. * An empty desk name is treated as a placeholder for a desk that wasn't renamed by the user and should be default-named. * Non empty desks names are the user-modified desks names. - In a multi user session, changes to the desks made by secondary users will be persisted in the prefs of the primary user only. It will never affect the prefs for those secondary users. BUG=1040980 TEST=Manually, added new tests. Change-Id: I85000f9bba32419ef907f26a03c34f25ff67686f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067358 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#744098}
-
James Cook authored
The code in //chromeos/components/drivefs runs in the browser process on the UI thread. There aren't any plans to move it out of process. It can directly use the C++ IdentityManager instead of using the mojo Identity Service. This will eliminate the last client of the Identity Service, making it easier to refactor or delete it. Convert DriveFsAuth to use PrimaryAccountAccessTokenFetcher, which automatically handles waiting for / getting information about the primary account. Migrate the tests to use IdentityTestEnvironment, specifically the helpers for access token requests. This requires rewriting tests that used GMock on the Identity Service mojo API, but ends up being less code overall. Test: rewrite the chromeos_components_unittests Test: Google Drive still works in File Manager to read / write / copy files. Bug: 1054673 Change-Id: If83be823ee2ab1936289e21b2c50451004557c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063419 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:Austin Tankiang <austinct@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#744097}
-
Ana Salazar authored
Bug: 1049273 Change-Id: I8e01516825cf26118e454ed640884fcc6f365ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071035 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#744096}
-
Samuel Huang authored
This reverts commit 64e434bf. Reason for revert: Causes ASAN failure, because range-based for-loop is used when it's not supposed to (per comment in code). Original change's description: > AppCache: Fix clang-tidy warnings. > > This CL fixes all currently-enabled clang-tidy warnings in > //content/browser/appcache. The main benefit here is to prevent > distractions while pursuing further refactoring in AppCache. > > This CL introduces no functional changes. > > Change-Id: I81176a48ac8a3362d75cdde6672e462590cb397f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069849 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744051} TBR=jsbell@chromium.org,pwnall@chromium.org Change-Id: I2f78baace7d7c4adb6f5e9f2ed74866e9a5f0c5c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070838Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744095}
-
Adrienne Walker authored
This will help move indexeddb to components/services/storage. Bug: 1015214 Change-Id: Id391961bcb8c3b19e44b650dc33c8e729b845183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068872 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Peng Huang authored
RasterDecoder doesn't use GL for Vulkan, Dawn, etc. So GpuChannelManager::DoWakeUpGpu needs to make sure to use a decoder_context() which uses GL to call MakeCurrent. Bug: None Change-Id: I22249d060d8b79728a649ccc041ff426b6d76b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070374 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#744093}
-
Orin Jaworski authored
Bug: 893183 Change-Id: I864b07ae2c53bf1ee93f8d1d0a8e85597a93afc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070595Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#744092}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6d87d0f..def23d3c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0ffb33c191dbf2793aeca9beef9dd85b4a3e01ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068581Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744091}
-
Dan Harrington authored
This includes the following changes: https://chromium.googlesource.com/feed/+/aa5e906377aaec1263ec77fe66c0e069217af54d https://chromium.googlesource.com/feed/+/94aa97321638b5d42031fa92f6f6ef83c1c91b49 https://chromium.googlesource.com/feed/+/52bcecef85fd6c49c850199c00ba88ec274b1585 Change-Id: I11ed1aa4fea5c884313d8e5edfb0c0ebea97d26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070687Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#744090}
-
Guido Urdaneta authored
This intends to address a series of flakes caused by problems with Pulse Audio on some bots. Bug: 1047655 Change-Id: Iade028ea431cdaa8df3255a246c5f23c0365ff9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066911 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744089}
-
Sophie Chang authored
This is a reland of eed7024d TBR=tbansal@chromium.org for chrome/browser/predictors/... Original change's description: > Add support for loading predictor to use hints from optimization guide > > Will add metrics in a subsequent CL. This shouldn't affect any current > metrics since the support is all behind a feature flag. > > Bug: 1050101 > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743767} Bug: 1050101 Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#744088}
-
Anastasia Helfinstein authored
Simplify BackButtonNode.findAutomationNode() to be more in line with the rest of the Switch Access code. Bug: None Change-Id: Ibccfc0bfd65c45120226b3ce3e976c832d5ade6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065312 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#744087}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1773f37de61e..f95054fa7d04 git log 1773f37de61e..f95054fa7d04 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 yiwzhang@google.com Roll bb tool to @36780e0 Created with: gclient setdep -r src/third_party/depot_tools@f95054fa7d04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1054982 Tbr: agable@chromium.org Change-Id: I941c083df93e33b2d36c9a872cade81088f17006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070775Reviewed-by:
-
Brian Sheedy authored
There is an issue when building //third_party/breakpad:dump_syms in cross-compiled builds. Since dump_syms is unused in Telemetry on Windows anyways, remove the dependency entirely on that platform. TBR=crouleau@chromium.org Bug: 1055301 Change-Id: Ic78db0dff8fe6ffe008cd4610393b654775593d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070200Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#744085}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/659cc1c90705..bfe5a68c1e31 git log 659cc1c90705..bfe5a68c1e31 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 westont@google.com Move Pixel2XL Android_DDL1_Vulkan and Android_DDL3_Vulkan jobs to NVIDIA_Shield. 2020-02-24 nihohit@gmail.com Remove docs for macros that don't exist in the code. 2020-02-24 csmartdalton@google.com Remove SWAP_PER_DRAW from GrGLGpu Created with: gclient setdep -r src/third_party/skia@bfe5a68c1e31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I5db7abd448bbd8eae3df5434fd7f852b175f61c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068626Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie2e412295126077b9762f69b9acd993f870a8e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068832 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#744083}
-
wutao authored
Bug: b/145218971 Test: manual Change-Id: Idbafcf175286ebbd933cd1228931fe511e74bc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070114Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#744082}
-
Toni Barzic authored
BUG=1021773 Change-Id: I10b0f70f41f5c067049757ec093424c5a8641d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070689 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Daniel Clark authored
Fix an issue where focusing the 'This month' button in a month input popup and pressing 'Enter' would close the popup but not switch to the current month. The problem was that the MonthPicker.onKeyDown_ handler was receiving the event first and submitting the popup with the current value (which was the correct behavior for an 'Enter' keypress anywhere else in the popup). With this fix, the onKeyDown_ handler skips the event if the target was the 'This month' button so that MonthPicker.onTodayButtonClick_ can handle it correctly. An alternative solution that I explored was to move the element for the 'This month' button under the YearListView so that the button's event handler would be triggered before the keydown handler on the MonthPicker, but this caused problems with the popup layout while leaving other issues with the event ordering, so I chose to go with the simpler solution found in this CL. Bug: 1054469 Change-Id: I4f32b6ca8b71b7e700e63c8e2d45429df74dce27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067718Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744080}
-
Filip Gorski authored
Bug: 1055466, 1054072 Change-Id: I36d21fc5d28c4144b788e204f33b4f66fdae0b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066585 Commit-Queue: Filip Gorski <fgorski@chromium.org> Auto-Submit: Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744079}
-
Patrick Monette authored
Change-Id: Ie279dd645e59380dd7d771e36888d1381d153b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067195 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#744078}
-
Rachel Carpenter authored
Previously we served the sandboxed iframe at chrome://help-app-guest. Now the untrusted scheme is ready, using chrome-untrusted://help-app. Bug: b/149713277 Change-Id: If474995c39dbcce85d868535fa33effd9592d5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066373Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#744077}
-
Samuel Attard authored
On some windows machines we were seeing errors "ImportError: No module named name_style_converter" This error appears to be caused by the strange interactions in module imports in generate_bindings.py, potentially some kind of circular dependency. However, just changing the order of these imports fixes the issue. Change-Id: Icf0a6f36db726ffa25dbbc46fe41b8d8d09f2f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070668Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#744076}
-
Demetrios Papadopoulos authored
Specifically, when the PrivacySettingsRedesign flag is on: - Split content settings types to two categories "permissions" and "content settings" - Within each category show 5 items by default, and place all remaining items within an expandable section. Achieved by introducing a new settings-site-settings-list custom element, and moving some logic previously in site-settings-page to the new element. The old codepath where PrivacySettingsRedesign is off, is also leveraging the newly introduced settings-site-settings-list element. Bug: 1032584 Change-Id: Id7c7b3d01aa319371374ae1379ea617703934abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065338 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01dabee6. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" ea6dba31 "Align <pattern> and <*Gradient> attribute collection" 7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I5ee8bcc66072dc9fff1f1e1085f7009f234575c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070391Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744074}
-
nancy authored
ChromeLauncherController::LaunchApp could be called from AppServiceAppItem::Activate, which is not from Shelf as the launch source, so convert and get the correct launch source from the LaunchApp function's parameter. BUG=1043205 Change-Id: I9ca32bc50340b861938afffadfd5c8a823d83f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066503Reviewed-by:
-
Henrique Nakashima authored
These flags are default enabled and can be removed to simplify a ton of code. Bug: 1012975, 1018268 Change-Id: I606ea81d3cef3f9bead86276467c1aeb27fce350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068864 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#744072}
-
Michael Sun authored
CRAS registered a media player with the Chrome OS Bluetooth stack (BlueZ) following the Bluetooth AVRCP (Audio/Video Remote Control Profile). The media player is capable of providing media status, track information, metadata, and etc to the remote Bluetooth device. This patch (as a part of more changes) adds new functions to support Playback Status, Player Identity, and Player Position information flow to the lower level through DBUS. BUG=b:147365563 Cq-Depend: chromium:2067192 Change-Id: Ib6255a455d97200ba1c7ee2fadb6905f5a6b46d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069273 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744071}
-
Tom Anderson authored
The new constants are necessary because GTK differentiates between dropdowns (which it calls comboboxes) and menus. On the Ambiance theme (the default on Ubuntu), dropdowns are light but menus are dark, so this change is necessary for consistency with GTK apps. BUG=914974 R=pkasting Change-Id: I4805526eee93322c4e7d57b879e0528b0998c933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069021 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Chong Gu authored
Create exceptions so that the CI Fuchsia bot does not run the test suites yet. Bug: 1054545 Change-Id: I27e777ac691d290c2ce3f9ce9a4c6b4573e1f5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067451Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#744069}
-
Bruce Dawson authored
Numbers like 0xC0000005 and 0x80000003 are easily recognizable in hex (access violation and breakpoint respectively) but confusing and unrecognizable in decimal. So, print these in hex. This change is based on crrev.com/c/1962589 Bug: 803617, 1007013 Change-Id: I53db7e6cadaaa41315180021bcaff84f540de990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067652Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
