- 11 Jul, 2019 40 commits
-
-
Egor Pasko authored
rsesek@ wrote: Anything forked from the system zygote will have many libraries with the same address space layout, with plenty of gadgets for exploitation. There’s no benefit to doing extra work to support different layout just for Chrome’s relocations. Hence switch the crazylinker to share RELROs across renderer/utility and browser processes. This should save ~2 MiB RAM (private dirty) on non-lowend devices. The low-end devices are sharing RELROs since long ago, so this change just removes code for not-sharing RELROs. Bug: 981599 Change-Id: I96225be9c3dad3df0c0e3d90f66fec3db364750d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694101 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676394}
-
Tanmoy Mollik authored
These classes are no longer used post-unity. Some static functions that were moved to SigninActivity from AccountSigninActivity to remove the class. Bug: 978908 Change-Id: I2b66e336f5b4396484e0485685ff9a8c6c2829a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688844Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#676393}
-
Egor Pasko authored
This reverts commit 774b2fbf and describes new evidence in comments. Bug: 980304 Change-Id: I20f3e7abdcade1cafa2b5d85bad4aa215e6ff1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695557 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676392}
-
Sylvain Defresne authored
This interface abstract the synchronisation of device accounts with the IdentityManager. The goal is to promote the "legacy" methods LegacyReloadAccountsFromSystem() and LegacyAddAccountFromSystem() to supported method but with a nice abstraction that explain why they are needed (i.e. access to accounts stored on some device abstraction). Add implementation (restricted to iOS for the moment, but could be enabled on Android if needed) that just invoke the same code as the old methods. Convert iOS code to use the new interface and remove the old ones (except LegacyAddAccountFromSystem which is now marked as Android only). See design at: https://docs.google.com/document/d/1_NknywZB7UCQdCiCxEPQU85lXouid_aMxdzujEJSiEM/preview Bug: 930094, 957887 Change-Id: I09fb20ea72c4cf584079e975276367c33392f416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690965 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676391}
-
Gabriel Charette authored
[ScopedTaskEnvironment] Introduce the TimeSource trait to replace MOCK_TIME MainThreadTypes and NowSource The impl now only relies on the new trait (after a conversion from the TimeSourceForTraits() helper). Only basic test were added as the current tests cover the old modes and TimeSourceForTraits(). Tests will be cleaned up after the migration (which will reduce the number of parametrized test instantiation :)). Users of the old traits will be mass-migrated in a follow-up scripted change. R=alexclarke@chromium.org, fdoray@chromium.org Bug: 946657 Change-Id: Ice18fe1e170a519fc40873783ad4ef18665e268d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689400 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#676390}
-
Gabriel Charette authored
First use case for https://chromium-review.googlesource.com/c/chromium/src/+/1686776 Bug: 946657 Change-Id: Ic7d6e57c4d2bbf020340690017bbce5af155cfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687272 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#676389}
-
Antonio Gomes authored
This is another preliminary step to Onion souping webmediaplayer_ms{_compositor}.cc|h It is part of step 4.4 described in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic3d0b6394d4a5518831db1c0c2c6fa029c24d5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693064 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676388}
-
Omer Katz authored
Bug: 983048 Change-Id: I488443295d7bbc6447f103933cd5b6c5ade75042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698142Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676387}
-
Anton Bikineev authored
Bug: 967258 Change-Id: I3f7f7b7b8c75d330364f74849e22205e60c3d323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697605 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676386}
-
Ramin Halavati authored
A function is added to iOS browser state metrics to return browser profile type given web state. Bug: 966747 Change-Id: I3f00212bb875ba010ea98e3b9db71dd2fb082b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690577Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#676385}
-
Andreea Costinas authored
This cl restricts CertificateManagementAllowed policy to client certificates only and renames it to ClientCertificateManagementAllowed. This is the first step towards creating a separate policy that manages user permissions over CA certificates in the Chrome certificate manager UI. Bug:958455 Test:- manually tested that importing and deleting CA certificates works regardless of policy settings - manually tested that importing and deleting client certificates works according to policy Change-Id: Id0aaf44f3bc4e3a22e99904234be3fd5343dce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690862 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676384}
-
Donna Wu authored
This CL replaced the custom type UsbInterfaceDescriptor with Mojo type UsbInterfaceInfo and adjusted related code. Bug: 716557, 699790 Change-Id: Ib92a3662b8f1708f272229ae04d1d2a721676f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692867Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#676383}
-
Steve Kobes authored
Bug: 963474 Change-Id: I62ab34952954bcf336c2ac63360cb4636cb6555b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666925Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#676382}
-
Colin Blundell authored
In preparation for building PrimaryAccountMutator::SetPrimaryAccount() on ChromeOS, this CL just does some reordering of the PrimaryAccountMutator methods so that the followup CL can be as clear as possible. Bug: 967605 Change-Id: Id1860df04c384cc4f895c5eaeeb4f8c270709f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695267Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676381}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/062d4a74..e545aee4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7fa2f9765c0c7716f2a015fbff156ff12f94fe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698022Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676380}
-
Corentin Wallez authored
This reverts commit 5d9df7f2. Reason for revert: Makes conformance/canvas/buffer-offscreen-test.html fail consistently on Win 7 FYI Debug AMD Original change's description: > Add Viz timestamps to FrameTimingDetails > > This CL starts adding more timestamps to the new FrameTimingDetails that > is sent back to Viz clients after a frame is presented. Eventually these > timings will be used to determine abnormally long stages of the > rendering pipeline in the case of missed frames. This CL simply adds > the timestamp of when the display compositor receives a submitted > compositor frame and when it begins the DrawAndSwap. > > Bug: 963780 > Change-Id: I3ca4715689401d0544c7efb17a9a096e2534131d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655738 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676207} TBR=sadrul@chromium.org,kenrb@chromium.org,nazabris@microsoft.com Change-Id: I870b9c3a61d0add8ce2ca92e034fd7660310977e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697646Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#676379}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically the last step folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves GetURLLoaderFactory() and CreateAccessTokenFetcher() to DeviceO2TS and eliminating DeviceO2TS inheriting from DeviceOAuth2TokenServiceDelegate::ValidationStatusDelegate since DeviceO2TS can handle ReportServiceError() by itself. With this CL, device_oauth2_token_service_delegate.cc/h are removed from the source tree. Bug: 967598 Change-Id: I5e391cee94a67185c6e83aab8fccb54cf4b215a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697002 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676378}
-
Omer Katz authored
Bug: 981043 Change-Id: I0f72c95ec17110146c7ed7811d8ca4573e8db4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697604Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676377}
-
Juan Antonio Navarro Perez authored
With crbug.com/981283 resolved, we can now fetch APK size data from the newer timeseries2 API. Also take the chance to do a bit of cleanup when building timeseries keys from dicts. TBR=benmason@chromium.org Bug: 900218 Change-Id: I060921a01e380693e0633905aa2a3c7c43f73ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692408Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676376}
-
Chih-Yu Huang authored
The VP9 show_existing_frame feature allows a decoded frame be outputted multiple times. This CL supports this feature at V4L2SVD implementation. Before sending VideoFrame to the client, we set the correct timestamp corresponding to the bitstream ID. This makes it possible for the same video frame memory to be output several times with different timestamps. BUG=941330 TEST=Play video with show_existing_frame at File app. Change-Id: I2f78f59ff40e49c0c724cf43a54bcb233097cbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631230 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676375}
-
Juan Antonio Navarro Perez authored
These are no longer scheduled to run anywhere. TBR=etienneb@chromium.org Bug: 761014 Change-Id: I46c99e2fc50fc2340401a2db3ff1a93da72edcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687240Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676374}
-
Roman Aleksandrov authored
Add information to Transparency view about Crostini reporting. Bug: 979286 Change-Id: I68ee9835ec92ae435f1f1c7670f3137828864ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685383Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#676373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80fe6f05f6bd..3bf592f177c2 Created with: gclient setdep -r src-internal@3bf592f177c2 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I79a08abde7e2e241491947a431495fdad1ac2d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697925Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676372}
-
Benoît Lizé authored
Bug: 974988, 951773 Change-Id: Ifcd70b11943e5c8014b37072fef40598cf2f6a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695345Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#676371}
-
Henrique Ferreiro authored
This is an intermediate step in the process of moving all of ProfileOAuth2TokenServiceBuilder code into IdentityManagerBuilder. To do this, the building of PO2TS cannot use Profile not any code from //chrome/browser. In this CL, ProfileOAuth2TokenServiceBuilder is modified to access cookie settings, the web data service and the reauth callback from parameters provided by IdentityManagerFactory. Bug: 974198 Change-Id: I9fe95b2f63859e5bcdd8128b362846ed5b212a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690843Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#676370}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0c4feb643b89..5081512502df git log 0c4feb643b89..5081512502df --date=short --no-merges --format='%ad %ae %s' 2019-07-10 52076061+digit-google@users.noreply.github.com BUILD.gn: Add targets to build all command-line tools (#2727) 2019-07-10 stevenperron@google.com Change the order branches are simplified in dead branch elim (#2728) 2019-07-10 troughton@users.noreply.github.com Add —preserve-bindings and —preserve-spec-constants (#2693) 2019-07-10 stevenperron@google.com Handle decorations better in some optimizations (#2716) 2019-07-10 zoddicus@users.noreply.github.com Update memory scope rules for WebGPU (#2725) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5081512502df The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: I7df93657793464e0a4a078df5eb6e28d6a2e336b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676369}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves the code for the token validation including StartValidation() and RequestValidation(). DeviceO2TS inherits from gaia::GaiaOAuthClient::Delegate and implements methods. When StartValidation() is called, it creates |gaia_oauth_client_| with |this| and gets errors or responses. Bug: 967598 Change-Id: I268e1a7f2909f77170279e178c95c354a45ca1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697126 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676368}
-
Miyoung Shin authored
This CL adds an audit check for the banned std containers to ensure the new usage of std::unordered_set and std::unordered_map doesn't come in, and updates the warning message to clarify to allow the use case at the boundary layer between Blink and Chromium. Bug: 952716 Change-Id: Idca01e5d96a515a9dcff7e8f347248944a540a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691909 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676367}
-
Clemens Arbesser authored
This CL adds a new enum histograms for tha autofill assistant payment request. The histogram measures whether the payment request was successful as a function of whether the PR was initially complete autofilled or not. This is a first step towards investigating why many users stop the flow in the payment request. The current hypothesis is that an initially incomplete payment request will result in more users cancelling the flow, compared to initially complete payment requests. Bug: b/133124492 Change-Id: Ibdbd11174a2372011a580244e652505dcc78bc4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680179 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676366}
-
Vaclav Brozek authored
As described in the design doc [1], a new class, CSVPassword, is introduced as a wrapper around a single line of a CSV text representing a credential. [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: I681f95d8b6abbf707cc346e2f83a7fd201924310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690588Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676365}
-
Edvard Thörnros authored
The WTF::Vector datatype has not had a way to insert with an iterator, which is the preferred way to iterate through all elements. This new method takes an iterator and saves you the trouble of thinking and making silly iterator-math errors. Bug: 981522 Change-Id: I4850606e4072668406e55b97ee65208aaf35d33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690961 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676364}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b79dda949e88..379aec0e1afe git log b79dda949e88..379aec0e1afe --date=short --no-merges --format='%ad %ae %s' 2019-07-11 perezju@chromium.org [Telemetry] Remove all results.pages_that_* properties Created with: gclient setdep -r src/third_party/catapult@379aec0e1afe The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973837 TBR=zhanliang@google.com Change-Id: I55716cc8183d6b4dc007ab4c0b4f1d5f8a8f1fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676363}
-
Tanmoy Mollik authored
Bug: 872809 Change-Id: I02335d7101535724035c100681080a4992c81d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689793 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676362}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib131f7dcc043af790bd91ec586f52c4849591165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695748Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#676361}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16850598db2b..ca160215c9d1 git log 16850598db2b..ca160215c9d1 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 ilnik@webrtc.org Update rtc_tools/rtp_generator to compile Created with: gclient setdep -r src/third_party/webrtc@ca160215c9d1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8cb5a1d451c5238822efbf304002f37fe22041ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676360}
-
Eldar Rello authored
Spec: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-onicecandidateerror Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fs-Y4awdYj0 Bug: webrtc:3098 Change-Id: I9c4a3ec75050e85f2a13b896f580bc16206ca2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607800 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Qingsi Wang <qingsi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676359}
-
Rayan Kanso authored
Update the OfflineContentProviderAggregator with content entries and visuals. TBR=avi@chromium.org Bug: 973844 Change-Id: I059fcf53a2e4a5a9b388dbbfed929f6270bc85de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688788 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676358}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves the refresh token encryption and decryption from DeviceO2TSDelegate to DeviceO2TS. The sequence is that if the system salt is available, it gets the encrypted refresh token from pref and decrypted it using the system salt. Previously DeviceO2TSDelegate had it. It's moved to DeviceO2TS with this CL. Bug: 967598 Change-Id: I668704ce0ac655c64ddfe493c4ee5f0cc6fa1559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695281 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676357}
-
Gyuyoung Kim authored
Some files have been including account_reconcilor.h even though they don't use any AccountReconcilor stuff. This CL removes the unnecessary includes in the files. Bug: 970268 Change-Id: I9e4d62396273c4a52f38d577d5c2405e99ac1add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697201 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676356}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/198be0a8bff1..67a281286c52 git log 198be0a8bff1..67a281286c52 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 khokhlov@google.com Merge "Remove strings table" Created with: gclient setdep -r src/third_party/perfetto@67a281286c52 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib6ca836144e0e71d3673f0c4172386ba5f0ab3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676355}
-