- 23 Jul, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7480fc89c7ee..6d863b5a5ead Created with: gclient setdep -r src-internal@6d863b5a5ead The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Iaf618e9956e40f6b8271245f60c4593d060a3c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715396Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680185}
-
Joey Arhar authored
Bug: 849483, 868407 Change-Id: I6ab375a857d248b68122222367ce908cb349b42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659528 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#680184}
-
Brian Sheedy authored
The fix from https://crrev.com/c/1713749 appears to fix the issue of not getting minidumps to symbolize on all platforms, so re-enable the minidump tests on all supported platforms. Bug: 634156 Change-Id: Iabc150bb525c294d875105ef4dd48b57c14249f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715395Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15baa953a54e..829144cc76fe git log 15baa953a54e..829144cc76fe --date=short --no-merges --format='%ad %ae %s' 2019-07-23 brianosman@google.com Better bot coverage for (Vk, Mtl) x MSAA Created with: gclient setdep -r src/third_party/skia@829144cc76fe The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: Ie187030baf35036f6734d7ee33183005db6f61e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680182}
-
Daniel Rubery authored
This histogram has expired. It's also been historically stable and not useful, so we can obsolete it. Bug: 975709 Change-Id: I787b6851fc99d8826249c82ca62fa28e8d2837bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715236Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#680181}
-
Alex Cooper authored
Updates webxr_test_asserts with chromium's more verbose asserts for easier debugging of tests, and removes the asserts from xr-test-utils so that all asserts can be referenced from webxr_test_asserts. Bug: 985156 Change-Id: Ie8d2ca70dd18a7e1759fe2b4d83b02076fcf91c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715916 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680180}
-
James Forshaw authored
This CL changes the dynamic resolving of the attribute functions to static linking as the APIs are available on all supported platforms. At the same time the opportunity to cleanup the code to more modern standards has been taken. Bug: 986625 Change-Id: Iafeed84a46fda8c0a21ad32e19af29c7a2c9a52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714216 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#680179}
-
Yi Gu authored
This patch removes one unused override function and makes some variables private. Bug: None Change-Id: Iffe10827abd4ef5fcbccc70393fa6d4167f223df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711975Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680178}
-
Kyle Horimoto authored
The string in question is "Enter", which appears on the confirmation button. In this context, "Enter" is used as a verb. However, the description for this string was unclear and was confused with "Enter", the name of the key on a keyboard. A translator was confused by the ambiguous description and chose to use "Enter" exactly as it appeared. This CL updates the description for clarity. Bug: 983097 Change-Id: I13fe1a2e97f0b71bf4c6195c40c4728bc2237916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714185 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680177}
-
Sergey Ulanov authored
Previously base::SysInfo was using uname(), but uname() depends on fuchsia.device.NameProvider API which may not be accessible in all processes. This change updates SysInfo to use zx_system_get_version() to get OS version. Bug: 986952 Change-Id: Ie3324180040933a509124147efd743de1f112416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715631 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#680176}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-30.html BUG=412078 NOTRY=true TBR=jschuh@chromium.org Change-Id: I428f516dde42a88ebc900c71eb7899b76da36950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715539 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680175}
-
Maksym Onufriienko authored
Fixed ios13-beta build by adding shards:1 because test_runner does not support multi-sharding command https://chromium-swarm.appspot.com/task?id=46388c76bc6f6410 Change-Id: I426b3ecc8790508656b31ac9f6fbf7d54245ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715565Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#680174}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec869c11c79d..1a62d1623e3b git log ec869c11c79d..1a62d1623e3b --date=short --no-merges --format='%ad %ae %s' 2019-07-23 vapier@chromium.org use six to control metaclass settings Created with: gclient setdep -r src/third_party/chromite@1a62d1623e3b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id539584827a3b7490ba109b3ba4536e95e354e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715438Reviewed-by:
-
Istiaque Ahmed authored
Bug: 985936 Change-Id: I1c907018d39be097129e863ec464e35acf8bdb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715525 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680172}
-
Glenn Hartmann authored
My original CL https://chromium-review.googlesource.com/c/chromium/src/+/1708416 left out some <statistics> tags inside the <history> tags. I think I got them all. Bug: 982362 Change-Id: Ia5c178c5ab2ab07f4ef6ab4012bf72c90616ecf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714369Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Josh Nohle authored
Adds fake implementations of CryptAuthFeatureStatusGetter and CryptAuthFeatureStatusGetterImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I4f467effb33f426697225f7e9d53e574933b8fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711210 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680170}
-
Christopher Grant authored
With native feature modules, generation of the main library (and feature libraries) is a two-step process: 1. Link a single, combined library (with partitions inside it) 2. Use llvm-objcopy to split out the main lib and feature libs This implies that: - libchrome.so's ninja inputs are not .o and .a files - The .map file now relates to the combined library, not the partitions, although it can naturally be used to analyze the partitions. Bug: 982334 Change-Id: I345f618f30639e7637ee905776a50c9cf5686773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708204 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#680169}
-
Ken Rockot authored
This refactors the Video Capture service and its clients to use the simpler service model described in https://docs.google.com/document/d/1M0-K0gi1xXO0f_-YKSH2LFVh4RJY-xe9T9VaGFOSXb0/edit. The DeviceFactoryProvider interface is renamed to VideoCaptureService and previous binders for other top-level interfaces (TestingControls and cros.mojom.CrosImageCapture) have been added to the interface. Service lifetime is no longer managed by manual ref-count but is instead automated using new Mojo interface idling bevhaior. The behavior should effectively mirror the service's behavior before this change. Namely: - The service stays alive as long as any receivers are bound other than the main interface pipe (previously DeviceFactoryProvider, now VideoCaptureService). Once this condition is no longer met, the service is considered idle. - On non-Android platforms, when out-of-process Video Capture is enabled, the service process is killed after 5 seconds of continuous idling. - On Android, the service process does not tear itself down ever. - If out-of-process Video Capture is not enabled, all clients will use the same shared in-browser instance of the service, which lives forever. This also ends up deleting a bunch of tests for the service which effectively tested behavior that's no longer applicable, like lifetime behavior built around VideoCaptureService (nee DeviceFactoryProvider) connection. Bug: 977637 Change-Id: I96ccf3558be7d173041de0de70251d841dd519f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710051Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#680168}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I1788eaeae2e55de046546c1c8dcc43236d5793a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715397Reviewed-by:
-
Mike Dougherty authored
Bug: 976348 Change-Id: I406ad72964ff3fdcbd6c055031e5db8bf742d9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715155 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
chrome://printrbpotter authored
Bug: 986711 Change-Id: Ic0556f349fe7f129a2761daf26198273fdf1d620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715711Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#680165}
-
Pavol Marko authored
This can be used in testing so it's easy to test with CertVerifierBuiltin without setting up a local finch instances. Also promote logging of chosen cert verifier to VLOG(0) so it's visibe in test logs and potentially also if a user reports cert verification errors, --force-cert-verifier-builtin (watch log output for chosen cert verifier) Bug: 978069 Test: browser_tests --gtest_filter=*SSLUITest* \ Change-Id: I74981fa0a2aecb94b7eab129ab5da155f18847a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715348Reviewed-by:Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#680164}
-
Robert Ogden authored
The OfflinePageModel likes to call OfflinePageDeleted when entries are refreshed or otherwise cleaned up. When this happens it comes with an OfflinePageAdded event (before the deletion) with a different offline page id but the same url. Thus, the offline helper entry is removed whenever that happens because we are not keying on offline page id. This CL makes it so we may trigger a preview attempt on a truly deleted page, but only for a single session. This comes at the benefit of triggering on all true positives. Bug: 969163 Change-Id: I4cf9d303ae997f1acba46652a48112bf6d3afabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715529Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#680163}
-
Bryan McQuade authored
Now that the LCP implementation has stabilized (all significant known implementation issues have been resolved), we are updating the UMA and UKM histogram names: * remove 'Experimental' from names * change 'LargestContentPaint' to 'LargestContentfulPaint', to be more consistent with FCP * make the all-frame version the default, and add a new MainFrame-only histogram (also consistent will all-frame version being the default for FCP) Change-Id: I4388e3db210df2b696bf724e27e3d19230c45eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712948Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#680162}
-
dalyk authored
We can now set the secure dns mode to AUTOMATIC and turn the insecure part of the resolver off, which will result in the async resolver issuing DoH requests and falling back to the system resolver without attempting to send plaintext DNS requests itself. In a follow up cl, the secure dns mode part of the configuration will be read from prefs. For now, we continue to set the mode to AUTOMATIC if there are DoH servers specified and to OFF otherwise. Bug: 985589 Change-Id: Ia40cbae1fdd57e19e925e125dcf1e82289220242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709928 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#680161}
-
Nicolás Peña Moreno authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DXSoS7dMmok Bug: 879270, 942033, 883483, 972830 Change-Id: Ie6255ed53ec00a083af37e71ebae34e48f72c3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713275 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#680160}
-
Mugdha Lakhani authored
We set delay_until super high, but this added change will ensure we never fire a sync event for a suspended registration. Note that we'll never mark a one-shot Background Sync registration suspended, so there is intentionally no branching here. Bug: 982378 Change-Id: I462468b6516098623733379a8ae0a1d062158311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704257Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#680159}
-
Yuly Novikov authored
Reflecting Android Q OS upgrade. TBR=kbr Bug: angleproject:3340 Change-Id: I7a246fdd4a68a06ae226200c96adb23397ccd381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715905Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#680158}
-
Ted Choc authored
When the tabs are being initialized on startup, we should suppress broadcasting the tab count when it is rapidly changing to avoid the number flickering in the toolbar. This was the previous logic, but regressed when we introduced the TabCountProvider. BUG= Change-Id: I6b3ed6724ca1a5e78df2e2dddee2e693d65de4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715571 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#680157}
-
Min Chen authored
Add RippleAttributes and corresponding get function in AshColorProvider for ripple. Bug: 972162 Change-Id: I49ffb4cb2a01600f210a57f2e7adb3bf21088513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686790 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#680156}
-
Luke Sorenson authored
Bug: 986947 Test: Not necessary. Change-Id: Id796ced76715e891c42a2ff401cbc7b886a91d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715668Reviewed-by:
Luke Sorenson <lasoren@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#680155}
-
dpapad authored
- Adding BUILD.gn configuration for JS type checking - Fix a lot of type errors - Comment out GN targets that still exhibit errors Repro - Add "closure_compile = true" to args.gn - ninja -C out/<folder>/ components/sync/driver/resources:closure_compile Bug: 986001 Change-Id: Ieed34584815b11923c50098d00c072b3da3bb934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711211Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#680154}
-
Gil Dekel authored
This CL introduces VaapiWebPDecoder for decoding lossy WebP images from the web using the VA-API. It does so by utilizing VA-API VP8 profile, since the lossy WebP format is used as keyframes in VP8 video formats. The VaapiWebPDecoder is currently not being used. Follow up work will turn VaapiJpegDecoderWorker into VaapiImageDecoderWorker, which will use VaapiImageDecoder(s) polymorphically. One of the decoders will be the VaapiWebPDecoder added in this CL. For full design details see: tinyurl.com/vaapi-webp-decode-acceleration This CL also updates all callsites of gpu::ImageDecodeAcceleratorType. Bug: 877694 Test: jpeg_decode_accelerator_unittest Change-Id: I623f1ab77f4e35e7381b8e5dfb35a33b5cae2dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672404 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Bryan Ferguson authored
This change makes window capture via the getDisplayMedia API on Windows perform & behave consistently with window capture via the chrome.desktopCapture API from an extension. (Also, with the previous experimental window capture support via the getUserMedia API with non- standard constraints.) This change allows window capture via getDisplayMedia to use the capture-screen-and-crop approach when the window is occluded only by the 'sharing' notification bar and some other conditions are met. It broadens the scope of existing logic to plumb the notification window ID to the capturer, so that it may be special-cased there (ignored when checking for occluding windows). This plumbing is now enabled for a stream type of DISPLAY_VIDEO_CAPTURE (screen/window capture via getDisplayMedia) in addition to a stream type of GUM_DESKTOP_VIDEO_CAPTURE (screen/window capture via older APIs). Benefits of this change: + Allows use of the significantly faster capture-screen-and-crop path in more cases, which can be up to ~36ms/frame (~160x) faster than the capture-window-contents path in my testing (more details are in the bug). This difference increased with the recent fix for https://crbug.com/webrtc/10734 . + Allows capture of menus & tooltips in more cases (plus dialogs if https://crbug.com/webrtc/10767 is fixed), partially mitigating https://crbug.com/980864 . Downsides of this change: - Includes the 'sharing' notification bar in the captured frames in more cases, when it overlaps the window. This is similar to the behavior of capturing the main screen, and identical to the behavior of capturing a window via the chrome.desktopCapture API from an extension. - May decrease test coverage / issue discovery around the capture- window-contents path, by reducing the likelihood it's used via Chromium. Bug: 973245 Change-Id: I224b20137ba701150ed01c6a1fb5dba134478c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711183Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#680152}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/282f4dfee653..5f7b2c2ad2f2 git log 282f4dfee653..5f7b2c2ad2f2 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 oysteine@google.com Updated py_vulcanize/py_utils to be python3-compatible Created with: gclient setdep -r src/third_party/catapult@5f7b2c2ad2f2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: I1c9848a50b19a0c81dfc435a30a94ff539af1162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715798Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59b2d77a1e39..7480fc89c7ee Created with: gclient setdep -r src-internal@7480fc89c7ee The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None,chromium:None Change-Id: I04de6fd732e7503bf6fc445cb3abe16e8f6eb5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715792Reviewed-by:
-
Jack Steinberg authored
Bug: 972945 Change-Id: I66a9384caae890e5e2ab99d617af315d080c80b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714190 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680149}
-
Renjie Tang authored
Version 99 is adopting HTTP/3 priority, which is different from H2 priority. After this CL, no priority related stuff will be sent on headers stream any more. Change-Id: I00aab1b9daf5bc288b0afde3211d169bcd92f6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710850Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#680148}
-
Kush Sinha authored
Gaia, by default, applies the Chrome OS Login Screen's third party SAML IdP's SSO redirection policies to Chrome OS Account Manager's in-session sign-in flows. The policy has the effect of blocking sign-ins on the login screen for some managed users. Note that however, the policy does not apply to Chrome content area sign-ins in Chrome OS. After Chrome OS Account Manager's unified sign-in flow is rolled out, there is no way to sign-in from Chrome content area. This has the effect of making certain managed accounts totally unusable on Chrome OS: they cannot login out-of-session from the login screen and they cannot login from within the session, from Chrome OS Account Manager. Fix this by sending a signal to Gaia that IdP redirection policies should be ignored, and let Chrome OS Account Manager's sign-in flow be treated like Chrome content area as far as this policy is concerned. Please check the attached bugs for more context. Bug: 984525, b/137886522 Change-Id: If0758a056e9e49da8a54502bd3b9742db640d666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715804Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#680147}
-
Christopher Grant authored
Some build rules have a rulename and implicit inputs, but no explicit inputs. For example: build libfoo.so: __chrome_android_some_rule | lib_maker.py Also: - Add unit tests for the core parser functionality. - Add a run_tests helper script for quick verification. Bug: 982334 Change-Id: I7481018ae4ae4ce1bc71a19e73dc241b124bfb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715606 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#680146}
-
