- 05 Jun, 2019 40 commits
-
-
Cammie Smith Barnes authored
We add a method to extract the resource URL from the cache key, so that HttpCacheDataRemover can perform its URL matching to determine which cache entries to remove. This is in accordance with the spec at https://w3c.github.io/webappsec-clear-site-data/ In future, it may be desirable to change the spec so that when there is a clear-site-data request for a given site, all resources keyed with that site as the resource URL, the domain, or the initiator, inclusively, would be removed from the cache. Test 1: net_unittests --gtest_filter=*HttpSplitCacheKeyTest* Test 2: services_unittests --gtest_filter=*HttpCacheDataRemoverSplitCacheTest* Bug: 951812 Change-Id: Id1afd9fff5f766e46d596ce8be340d09e6296bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590406Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#666466}
-
John Abd-El-Malek authored
The tests that used to be on this bot are now on the CQ as network service is on by default. Bug: 598073 Change-Id: If1a941917910a8543aab4c2b2a0d893d516aecc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645993 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#666465}
-
Xiyuan Xia authored
- Replace mojo interface MediaController/Client in cpp; - Current MediaController/Client -> Media{Controller/Client}Impl; Bug: 958207 Change-Id: Ia3b9253a45d431e9d0532adc434e38fb0a97adf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646532 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666464}
-
Jacob DeWitt authored
- Remove TODOs that reference closed crbugs. - Create crbugs and update comments for TODOs that didn't already link to a crbug. Change-Id: Id25cca7ca4ffa6ee8f9a5ac7f7af4ee817e17ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639204Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#666463}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/928b2997b301..e0d90c84e42f git log 928b2997b301..e0d90c84e42f --date=short --no-merges --format='%ad %ae %s' 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-05 csmartdalton@google.com ccpr: Preserve fill rules for cached paths Created with: gclient setdep -r src/third_party/skia@e0d90c84e42f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ia5abd88548b6d0b3d8af4f521e622148af60820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666462}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e77dbf600358..01927c1c5000 git log e77dbf600358..01927c1c5000 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 manojgupta@google.com cros_sdk: Allow using a Frozen SDK for bootstrapping. 2019-06-05 manojgupta@google.com cros_sdk: Format with yapf. 2019-06-05 saklein@chromium.org Build API: Recursive Path Handling 2019-06-05 dburger@chromium.org Fix config updater. Created with: gclient setdep -r src/third_party/chromite@01927c1c5000 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Idb0a76aea82296816ae761361861da50a612f8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645986Reviewed-by:
-
Dana Fried authored
Button listener was not scoped and is not owned by the button in question, so was never deleted. Since button listeners are optional and this one was never used, the choice was made to remove it entirely. Bug: 961075 Change-Id: If9600ba17cb2e30a4a10c9bdf4d0449f056b583f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646753 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#666460}
-
Charlie Reis authored
This also fixes some owner lines with typos which caused issues in processing the file. Bug: None Change-Id: I17a6ec571846da6a7018bd2cfef5d40e61a4c530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645981Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#666459}
-
Mei Liang authored
Change-Id: If3d333382233c155e4882e04fb3e9acbc14ea109 Bug: 970982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644525 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666458}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: If4403c877bc53c97b35a0b36f7cb0de142cdfb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646373 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#666457}
-
Yuchen Liu authored
Temporary grants permisson of PROTECTED_MEDIA_IDENTIFIER, to unblock EME dev. Bug: 922833 Bug: 966191 Test: Build and pages with EME Change-Id: I853719d74ee04a1bbc0e7d4768d17aa208147ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646632 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#666456}
-
Nick Burris authored
Per discussion, it makes sense for TextFragmentAnchor matching to be case sensitive to reduce ambiguity. Case insensitivity is likely not useful since the targetText would be generated by a copy of the text (either by a machine or a human copy-paste). Change-Id: I7b52d2adc4f9474fbf77bbfb45814f5ab91036c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644835Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#666455}
-
Harry Cutts authored
See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the feature. The flag should never expire as these are debugging and development tools, so we'd never want to enable them for everybody, but nor would we want to disable them. Bug: 952054 Test: build, then check chrome://flags/#gesture-properties-dbus-service. Change-Id: Ic876d3f9f2fffff084b7c280b4561e013cd31a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589446 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#666454}
-
Joe Mason authored
Make sure the navigation observer is watching the WebContents returned by AddSelectedTabWithURL. GetActiveWebContents can return null when there is no page open. Change-Id: I9de58135e3559df0bfedc673241e44f345cf3cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636598Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b632bc58ed37..9cd21f1bf945 git log b632bc58ed37..9cd21f1bf945 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 enga@chromium.org Implement CreateBufferMapped for non-mappable buffers 2019-06-05 enga@chromium.org Add Create/ReleaseStagingBuffer to DynamicUploader Created with: gclient setdep -r src/third_party/dawn@9cd21f1bf945 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I8078513f9b6e70dd17d21bd64c44766169f097c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645242Reviewed-by:
-
Matthew Mourgos authored
- Fixes the padding and spacing within the folder view. - Fixes the AppListItemView title width to be the same both outside and inside of a folder. Bug: 911745 Change-Id: I1d2d168631312ca9a17da2b4adf317079af9319d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639720Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#666451}
-
Yue Zhang authored
This CL enables dropping a tab on another tab to form a group. It is behind the TabGroupsAndroidUiImprovements flag. Bug: 963692 Change-Id: I1cb49a20459972af3c02bdc7c9ebb9480209de29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615606Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#666450}
-
Etienne Bergeron authored
This CL is basically removign dead code. There is an old bug still going on to remove the NATIVE typesetter on MAC. CC=benck@google.com R=tapted@chromium.org Bug: 889152, 454835 Change-Id: If1e2814a22aced9030b914b6c1ab60b2f4bf39eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645143 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#666449}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 960984 Change-Id: I37833956b7c9fd6b82a04a264dcaac096aebdd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638779Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666448}
-
Jack Lynch authored
Currently, the settings modal does not set aria-hidden on the main devtools content when it is opened. As a result, screen reader users who use the "Form fields" list in NVDA or similar functionality in other tools will be presented with a list of form controls that are visually hidden. This change adds a field to UI.Dialog that determines whether the dialog should mark all of its siblings with aria-hidden when it is shown. Before: https://i.imgur.com/7kV9dgE.jpg After: https://i.imgur.com/AyNJQCQ.jpg Change-Id: I131144a6e551cb2387f7db2fd5a67c5526051f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620777 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#666447}
-
Erik Luo authored
"grid" shorthand and "grid-template-areas" CSS properties may accept an ascii-like structure as a value, representing the grid. This CL wraps the value onto a newline once a new row begins. Screenshot: https://imgur.com/a/c7y3ILm Bug: 943858 Change-Id: I0268a9df2a2582aea60efcbd88f661780d4b0e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531685 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Jason Majors authored
This service will expose a parser for BLE advertising packets so we can safely parse them. The bluez device needs this parser so it can expose the navigator.bluetooth.requestLEScan(options) API. Bug: 962699 Change-Id: Ic205b2c427a703379b5fc619daff998585654aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610873 Commit-Queue: Jason Majors <jmajors@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666445}
-
Tommy Steimel authored
This CL adds a new ScopedSetIdleState class for testing that sets an overriding idle state in ui/base/idle so that classes depending on ui/base/idle can be more easily tested. Bug: 951560 Change-Id: I4234af0783c7fc053620803b74f0ef6b0fc0ce4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643414Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#666444}
-
Dave Tapuska authored
Due to lifecycle issues with the presentation API it is easier to ensure that the objects it creates are garbage collected and we can copy the lists before iterating on them. BUG=960785 Change-Id: I06fe61d0465fa36e16a3defa7b06a32b220b05c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645813 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666443}
-
Vladislav Kuzkokov authored
|base::OnceCallback::Run| can only be called on rvalue reference. Bug: None Change-Id: I209de9b09c4b37ed97f592f6a077b9c4d8152821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646013 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Becky Zhou authored
Bug: 940650 Change-Id: Ief5041b3aba808b861901fde6d0696fbc12f53e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637843 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#666441}
-
Hwanseung Lee authored
Currently, device::Gamepad's mapping is character array. it can be more simplify using an enum instead of a character array. Bug: 955809 Change-Id: I90fa1b40a33e01942ebdfda9535ae0ca000210e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600922Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
Mike Dougherty authored
With SlimNavigationManager enabled, the resent post request dialog is presented while the load is still ongoing. On iPad, this displays a loading spinner on the tab UI which interferes with EarlGrey synchronization. Disable synchronization while the dialog is shown if SlimNavigationManager is enabled. Bug: 968296 Change-Id: Ib67693a451dd8170746b4f2329ca4eed82fc254e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645434Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666439}
-
Ilia Samsonov authored
If disabled tests run, test launcher was flagged to run them explicitly. Since we will remove the MANUAL_ flag, we should track the results. Instead of testing test result tracker procedurally, We use test launcher unit tests for functional testing. Bug: 936248 Change-Id: Iafb2d40a9c650964097cd3f1136d6a5012afda3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641805 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666438}
-
Erik Chen authored
The method is a duplicate of GetVmSwapBytes Change-Id: I1bfc11484035c8c3452831bee0553a98e07a8cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637746Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Jose Dapena Paz authored
XSetWindowAttributes initialization of attributes in GLSurfaceGLX is not in the same order of the declaration. GCC fails because of that. Bug: 819294 Change-Id: I8a97da980d5961a35a47ae4d0d8d558b85291f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646253Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#666436}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/075cb05bdeb5..affd410d415a git log 075cb05bdeb5..affd410d415a --date=short --no-merges --format='%ad %ae %s' 2019-06-05 ehmaldonado@chromium.org gclient: Report only the origin to metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@affd410d415a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:896868 TBR=agable@chromium.org Change-Id: I958b0868a745c7a905816bc335456299615c416f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644762Reviewed-by:
-
Matt Reynolds authored
UnpackAPIPermissions unintentionally discards the data associated with complex permissions when creating the UnpackPermissionSetResult object. This occurs because the APIPermissionSets in the result object are populated using an insert method that takes only the permission ID and not the associated data. This CL modifies UnpackAPIPermissions to instead use the insert method that takes a clone of the APIPermission object. BUG=967292 Change-Id: I9882d4307d4ed5c61767b6333566f5fa1edbb6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636444Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#666434}
-
Yi Su authored
This CL moves CRWWebController.removeAllWebFrames into CRWWKNavigationHandler. Bug: 956511 Change-Id: I645d20a59c237f99edb474720dc96f8e8d15d392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645352Reviewed-by:
-
Luna Lu authored
Change-Id: I685a94a3b6b61dba274ea853e0f6b7f75edd9595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636393Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#666432}
-
Robert Liao authored
BUG=937566 Change-Id: I3bc8ad60e375e89ae70ee8abcc4d77fb62fd274a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642240 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666431}
-
dalyk authored
In AUTOMATIC mode for the general case, the correct order of lookups is secure cache, async resolver DoH request, insecure cache, async resolver plaintext request, and finally system request. This change also introduces an assumption in HostResolverManager::Job that there is a 1:1 correspondence between the URLRequestContext and HostCache. Bug: 878582 Change-Id: I3feaec856bc9be303808fc7e7aaac933b773e7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525985 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#666430}
-
Ramin Halavati authored
Browser.WindowCount.Incognito and Browser.WindowCount.Guest histograms are added to record the number of open off the record windows that are used at the same time. Bug: 966747 Change-Id: I521eb570b71fb1967e5d51311a747f09b818ecae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645355 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Previously HitTestResult::LocalPoint() is in pure physical coordinates if the result is produced by LayoutNG, while is in flipped physical coordinates produced by Legacy. We tried to use it as pure physical in LayoutNG and flipped in Legacy in PositionForPoint, but failed when it is passed between Legacy and LayoutNG, especially in the case when it's passed through LayoutObject hierarchy where is unclear about the Legacy and LayoutNG boundary. This CL makes HitTestResult::LocalPoint() always in flipped physical coordinates, and let LayoutObject::PositionForPoint() always accept flipped physical coordinates (including LayoutNG objects), and flip the point when needed. This CL is temporary because future CLs will change HitTestResult::LocalPoint() and LayoutObject::PositionForPoint() always physica, but those CLs are too big to fix the bug in M76. Bug: 966731 Change-Id: I19e0cd392d2a92bd0f5467c6fc816dfa86f94933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643911 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#666428}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a6e239978796..6788784ac192 git log a6e239978796..6788784ac192 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 ahest@yandex-team.ru [devil] Use HasRoot to check if EnableRoot was successful. Created with: gclient setdep -r src/third_party/catapult@6788784ac192 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Change-Id: Iaea1f297ae819733bbd260ca601930dc0e9cdde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644897Reviewed-by:
-
