- 27 Jan, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
The following tests are being disabled on iphone-device: BookmarksTestCase/testMoveDoesSaveOnSave BookmarksTestCase/testEmptyBackgroundAndSelectButton BookmarksTestCase/testBookmarkContextBarInMultipleSelectionModes BookmarksTestCase/testBookmarkContextBarInSingleSelectionModes BookmarksTestCase/testKeyboardCommandsNotRegistered_EditBookmark BookmarksEntriesTestCase/testContextMenuForMixedSelection TBR= sczs@chromium.org Bug: 1045966 Change-Id: Idd767cc19e7443825be6f08680813732426770ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020932 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#735446}
-
Avi Drissman authored
Those are needed when compiling against SDKs older than 10.12 or so, but Chromium has compiled against the 10.14 SDK for a while. Bug: 1044838 Change-Id: Id9a70aa1c702b0c1992963c1fbd0a2e26f8e07ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020805 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735445}
-
Mike Wittman authored
Adds a field to Thread::Options to allow the task queue time domain to be configured, to enable Thread users to test task posting functionality using synthetic time. Bug: 1034758 Change-Id: I9b301f98e856a86045a12bab6e25569d4ef9b330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020480Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#735444}
-
Sylvain Defresne authored
$ git log 34381dd16..e5005ca20 --date=short --no-merges --format='%ad %ae %s' 2020-01-24 featherless Bump the release. 2020-01-24 featherless Notes. 2020-01-16 rsmoore [Chips] Fix `imagePadding` behavior. (#9442) 2020-01-16 rsmoore [Chips] Additional `imagePadding` tests. (#9441) 2020-01-16 rsmoore [Chips] Fix `contentPadding` API. (#9440) 2020-01-16 featherless [AppBar] Annotate MDCAppBarNavigationControllerDelegate's appBarNavigationController:willAddAppBar:asChildOfViewController: as to be deprecated. (#9395) 2020-01-21 featherless Automatic changelog preparation for release. 2020-01-17 featherless Revert "merged release-candidate" 2020-01-17 andrewoverton [TextControls] Restructure Cocoapods and Blaze targets (#9430) 2020-01-16 codyleeweaver [TextFields] Add theming extension for underline controller (#9437) Created with: roll-dep src/ios/third_party/material_components_ios/src Notable fixes: manually updated the list of files to build as part of the framework as some files were added/renamed/removed. Bug: 1045877 Change-Id: I2d4ab61b4ab67161f99baa3907ea3bb499d9867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022947 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Tommy Li authored
In this CL, I did a cleanup: https://chromium-review.googlesource.com/c/chromium/src/+/1937773 But the cleanup had a negative side effect, in that repreated presses of Ctrl+E for entering keyword mode would cause the omnibox popup to close and re-open. This CL is a partial revert of the original CL, but keeps the flag deletion portion. It also makes sure a TODO that was wrong is gone. Bug: 1044917 Change-Id: Idceb8c73d4a5907cfca8966bf41f80c09fc130bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020473 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#735442}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c06f226b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source domenic@chromium.org, ricea@chromium.org: external/wpt/streams futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/IndexedDB external/wpt/encoding jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mcasas@chromium.org: external/wpt/mediacapture-record meade@chromium.org: external/wpt/web-animations mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org: external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I829df5abb577665adafb08dbeb61ffda3f40e78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022325Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735441}
-
Rakesh Soma authored
Bug: 1045536 Change-Id: Idd58ba1153e1e006bc07c54305db39e217e91779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020243 Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#735440}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2c5b856a7f09..b1e9971eb712 git log 2c5b856a7f09..b1e9971eb712 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 brianosman@google.com Switch runtime SkSL to always sample at explicit coords 2020-01-27 sergeyu@google.com Fix GrSmallPathRenderer to respect max texture size. 2020-01-27 kjlubick@google.com [canvaskit] Fix test for drawOnce Created with: gclient setdep -r src/third_party/skia@b1e9971eb712 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ic888343ead714d0dca80f0a603993d6d7293f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735439}
-
Francois Doray authored
TBR=jlebel@chromium.org Bug: 1045478 Change-Id: I531d38944da8c6c5b57d6d7e94b217ab8a303b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022928Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735438}
-
Kevin Ellis authored
Spec: https://drafts.csswg.org/web-animations-1/#remove-replaced-animations Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/H5sz_dg6fKc/1X7K7U4XCgAJ Bug: 981905 Change-Id: I9267e3e4fda14133f2edcc0e8aea1e8a031959a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020245 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735437}
-
Charlie Hu authored
This reverts commit a6198a9e. Sort keys of python dictionary so that deterministic build won't fail. Original change's description: > Revert "Refactoring origin trial dependency generation in feature_policy_helper.cc" > > This reverts commit 0c31aad8. > > Reason for revert: Somewhat speculative; looks like it made > the build nondeterministic (https://crbug.com/1038775) > > Original change's description: > > Refactoring origin trial dependency generation in feature_policy_helper.cc > > > > This CL refactors build script code that generates feature_policy_helper.cc, > > so that the logic could be reused for document policy. > > > > - Simplifies make_runtime_features_utilities.py API. > > - Makes most util functions pure. > > - Adds more unittests > > > > The output of make_feature_policy_helper is verified to be the same as before. > > > > Bug: 993790 > > Change-Id: I0f0e07888f5b9e02727e3f210bbfb4cd871ecc15 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003255 > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 993790 > Change-Id: If7aaa4c6b851f74db6b418b480cf8482b15cf7b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013472 Bug: 993790 Change-Id: I4100bfed3c14da388d625df39f93d428497f1671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016339 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735436}
-
Avi Drissman authored
Chromium uses the 10.14 SDK, so remove any code that handles the case of an old SDK being used. Bug: 1044838 Change-Id: I5db561bfaf5b8e6aac7352dac010d90fb202bdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020883 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
kylechar authored
Bug: 936425 Change-Id: Iff33d59b71980d040825f0d78860dd121e77b120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020922 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#735434}
-
Guido Urdaneta authored
Change-Id: I09c9a01620d2c9667e1a80c68a367952b10b6042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020926 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#735433}
-
Rayan Kanso authored
Bug: 1045506 Change-Id: I3e8b192331c848241848e754ffde0309b620efcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022669 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#735432}
-
Wez authored
This reverts commit 312152d0. Reason for revert: The underlying issue can be resolved in a separate layer, so it's no longer necessary to disable these tests. Original change's description: > Disable tests for notouch builds > > These tests are currently expected to fail in notouch. > In this CL I've disabled and left a comment pointing to > the associated bug. > > Bug: 956756 > Change-Id: I070da0ef5ae5a0fa1b03b3090d40aa3adf7c19f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673918 > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672398} TBR=garykac@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 956756, 1045960 Change-Id: I88537e3f233695ca228efdd7668aac2bbe2b96f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020930Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735431}
-
Martin Šrámek authored
These tests had bugs auto-filed for them, because they were being flaky. All of them are 1) still flaky as of today, 2) are flaky on all platforms (W/M/L), and 3) have a large amount of flakes at least on one platform. Bug: 1042935,1042936,1045686,1045685,1045675,1045634,1045279,1045250,1043277,1043186,1043181,1043119,1043086,1043085,1043044,1043043 Change-Id: Ie03ef7eead395bf77b884604f76b6c9511170514 TBR: yangguo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020958 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#735430}
-
Nicolás Peña Moreno authored
This CL replaces some assert_unreached with assert_precondition and adds some assert_precondition to tests. The ones that use ScoreWatcher should already throw an error and not timeout. async_test should not use async since that will result in errors not being caught, so this CL fixes that too. Change-Id: Iecda47acce998efac0dc78e5214b60b005c16075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020244 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#735429}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ccfb08a648f..20be649ad2fd git log 4ccfb08a648f..20be649ad2fd --date=short --first-parent --format='%ad %ae %s' 2020-01-25 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-25 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-25 achuith@chromium.org device: Remove RunCommand and RemoteCommand 2020-01-25 pprabhu@chromium.org config: Change temporary to query 2020-01-24 bpastene@chromium.org cros_chrome_sdk: Don't disable the 'unknown-warning' clang warning. 2020-01-24 saklein@chromium.org Goma: Move USE_GOMA envvar set to the build_packages config 2020-01-24 gbiv@google.com config: stop publishing kernel 3.14 profiles 2020-01-24 dhaddock@chromium.org release_stages: Restrict FSI AU tests to models that make sense. 2020-01-24 gbiv@google.com scripts: add a script that dumps all objects in a given board 2020-01-24 lamontjones@chromium.org sdk.update: Build all targets if building from source. Created with: gclient setdep -r src/third_party/chromite@20be649ad2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I7519c867922ccbc93bcc45564c5b170039f2a5f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021976Reviewed-by:
-
Marc Treib authored
It's flaky, mostly on Windows but also on other platforms. Bug: 1043899 Change-Id: I218ce343f68be745a349c187fe1da16d75da978f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022650 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#735427}
-
Javier Ernesto Flores Robles authored
OmniboxPopupTestCase.testIncognitoSeparation crashes constantly on devices. TBR=stkhapugin@chromium.org Bug: 1045950 Change-Id: Ie6ccd8308d39e53d1ea66da1269fd5b1e8282f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020781 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Guillaume Jenkins authored
This is the first step towards making the native spell checker class (WindowsSpellChecker) more testable. Right now, it can't be easily tested because its life cycle is tied to a base::NoDestructor pointer, but it holds references to thread pools. So, between tests, the WindowsSpellChecker is kept alive, but its references to the thread pools are invalidated. The next step will be to move the WindowsSpellChecker from a static base::NoDestructor pointer to the BrowserProcessImpl object, which is destroyed and recreated for every test. In addition to the above, the spellcheck_platform_win.cc file was getting very large, so that's another reason to split it up. There are no functional change as part of this; only code being moved around to new files. Bug: 463364, 1035044 Change-Id: I0b621ad2beba6ed57856dd3cff1910aebebbb710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008031Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#735425}
-
Jan Krcal authored
This CL removes expectations in tests that were introduced to investigate an issue that is closed for more than 7 months. Bug: 904390 Change-Id: Id70f9f9042104ab5ba4120d9158e835663f02683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022651 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#735424}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/732248c2f1dc..2c5b856a7f09 git log 732248c2f1dc..2c5b856a7f09 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 bryct@amazon.com Add drawOnce() API to SkSurface. Created with: gclient setdep -r src/third_party/skia@2c5b856a7f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I0f312facfc7b7e125c5279d8959640294560f07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021975Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c2484f8..82608c5b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If50f75fe5d785d1fe16f41215582086af16bfc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022324Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735422}
-
Rushan Suleymanov authored
DummyMetadataChangelist may be useful for data types which do not store any data in the bridge. Bug: 1034930 Change-Id: I2cb2f548f1874bba1edb8fa04afe31b15f0b42d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019206 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9c0a83ea4dae..ff0e4dbd1f0b git log 9c0a83ea4dae..ff0e4dbd1f0b --date=short --first-parent --format='%ad %ae %s' 2020-01-27 minyue@webrtc.org Reland "Send absolute capture time through audio coding module." 2020-01-27 jonasolsson@webrtc.org Cleanup log formatting in modules/audio_processing Created with: gclient setdep -r src/third_party/webrtc@ff0e4dbd1f0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e36f1c9f62483904f0215621bb872c4ab9ad5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021973Reviewed-by:
-
Fredrik Söderquist authored
This is in preparation for fixing the behavior of SMIL events wrt to seeking. This also makes these tests pass in Gecko with a single exception. svg/animations/begin-event.svg, svg/animations/end-event.svg, svg/animations/repeat-event.svg, svg/animations/onbegin.svg, svg/animations/onend.svg and svg/animations/onrepeat.svg Adjust the seeked-to time so that the beginEvent/endEvent/repeatEvent is dispatched. Convert from reftests to testharness.js. svg/animations/repeatn-event-1a.svg, svg/animations/repeatn-event-1b.svg, svg/animations/repeatn-event-1c.svg, svg/animations/repeatn-event-1d.svg and svg/animations/repeatn-event-1e.svg 'repeatEvent's are not dispatched while seeking, so seek to just before the relevant repeat and then wait for the event. Convert from reftests to testharness.js. svg/animations/repeatn-event-2a.svg Switch to "stepping through" all the repeat points rather than to the end directly. Convert from reftest to testharness.js. wpt/svg/animations/repeatn-remove-add-animation.html Need to make sure that 'repeatEvent's are actually dispatched, so this test cannot use smil_async_test() which steps while paused. Bug: 1039886 Change-Id: I500f5005a29ed22a920dd3835f8070b52d4def7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017527Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#735419}
-
John Delaney authored
This change implements a storage layer in sqlite for persisting impressions and conversions from the API to disk. The storage for the API consists of two tables, an impression table and a conversion table. Every row in the conversion table is associated with an impression in the impression table to reuse common data such as conversion and reporting origins. The storage layer does not implement specific functionality like last clicked attribution, bit limits, or reporting delays. Instead it abstracts that functionality to an injectable delegate class. This change also includes some common structs that are used by the API, such as a new mojo struct blink::mojom::Conversion. The functionality of the API is described on https://github.com/csharrison/conversion-measurement-api Reference prototype change: https://chromium-review.googlesource.com/c/chromium/src/+/1967220 Bug: 1014604 Change-Id: Icff2d720fe7c595398835fcfd026f6d321cb9c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965450 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#735418}
-
Robert Flack authored
The other commitStyles tests are not affected by the underlying style. This test verifies that applying a partial composite: add stack correctly applies to the underlying style. Bug: 981905 Change-Id: Ia32a51a50e5c537b29c4848248ab94e7de56f19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021741 Commit-Queue: Robert Flack <flackr@chromium.org> Auto-Submit: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#735417}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I4bc3751593aeab88d33c9c5b051023daedb5cecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020950 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735416}
-
Rushan Suleymanov authored
Do not send messages to server while sync is in pause state. Bug: 1045896 Change-Id: I3d4bcdcc9357836dc66ce30a107dab48b255960f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020775Reviewed-by:
-
Wez authored
- Migrate to range for loops in KeycodeConverter. - Fix naming of DOM |key| and |code| mapping table constants. - Replace NULL with nullptr. Change-Id: I1d4ae6146afa9bb32083e40c474653a1f6d1ec57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022666 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735414}
-
Yi Gu authored
cc::WorkletAnimation has both scroll_timeline_ and animation_timeline_. When a worklet animation updates its ScrollTimeline, it is the scroll_timeline_ that should be updated. However, the other timeline gets updated due to function inheritance. This will be fixed after crbug.com/1023508. Until then we should apply a temporary fix. This patch allows WorkletAnimation to override the base function to update the scroll_timeline_ correctly. Bug: 1045812 Change-Id: I7e83e7930c4d236e88198ef645c81db8f4041555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020573Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735413}
-
Ian Clelland authored
Bug: 993790 Change-Id: I7d90f98cd3a2b1ef63441a39ed51512b8068c927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015782Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#735412}
-
Xi Han authored
The FeatureUtilities#isAllowToRefetchTabThumbnail() checks ChromeFeatureList and requires initializing native. In this CL, we make this function to check a cached value. Thus, this function can be called before native is initialized. Bug: 1041865 Change-Id: I029f18ffe96eeb8f3d997775c51662363e9aac26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011166 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#735411}
-
Peng Huang authored
In low end device mode, the GLContext is created to be compatible to GLSurfaces with RGB565 format. Right now, SkiaOutputSurfaceDependencyImpl::CreateGLSurface() creates GLSurface with default format which is RGBA8888. It isn't compatible to the GLContext. It causes MakeCurrent fail. Bug: 1033170 Change-Id: Id372e0dee73a01b8e7511bbef6740481b890d742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016338Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735410}
-
Boris Sazonov authored
Disables StartSurfaceLayoutPerfTest#testTabToGridFromLiveTabWith10TabsWithoutThumbnail on L and before. Reason: flaky. TBR=wychen@chromium.org Bug: 1045938 Change-Id: I4f508e7005d0cc558308a53851b2541d31e9c766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022647Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735409}
-
chrome://omniboxmanukh authored
The debug page compares response and request inputTexts to prevent async responses for old requests from being shown. This comparison did not consider that responses' inputTexts are trimmed of whitespace. This CL likewise trims the requests' inputTexts when comparing the two. Bug: 1045343 Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9 NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019927 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#735408}
-
Ali Juma authored
This CL builds PingManager and VerdictCacheManager on iOS, and makes the corresponding unit tests run as part of components_unittests on iOS. To make the VerdictCacheManagerTests pass on iOS, this CL also modifies WebsiteSettingsRegistry so that ContentSettingsType::PASSWORD_PROTECTION and ContentSettingsType::SAFE_BROWSING_URL_CHECK_DATA are registered as settings on iOS. Bug: 1028755 Change-Id: Ia364f1c782b6612c7f41f73f87f3f2493ed6ac33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020551 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#735407}
-
