- 08 Jul, 2020 40 commits
-
-
Erik Staab authored
This reverts commit b9897c33. Reason for revert: This breaks a few waterfall builders. Original change's description: > GN: switch from check_targets to no_check_targets. > > The list was semi-automatically generated by parsing the output of > "gn check" against various configurations. > > With some exceptions, parsing was done using: > grep -E -A1 '(The target:|It is not in)' | grep '//' | \ > grep -v '//build/toolchain' | cut -f1 -d: | sort | uniq -c | \ > sed -e 's/ *\([0-9]*\) *\(.*\)/ "\2:*", # \1 errors/' > > Note: if this breaks the "gn gen" step of a build configuration that > isn't tested in the CQ please add more entries to this .gn file instead > of reverting this CL. > > Bug: 896680 > > Change-Id: I4e3d2b316ec014f969303f7c4bb809e436447b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278172 > Commit-Queue: Erik Staab <estaab@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786102} TBR=dpranke@google.com,estaab@chromium.org Change-Id: I994a4149f38fe00779045612291b0984b95f9075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286473Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#786115}
-
Mark Pearson authored
about number of lines in various databases Remove sbirch@ as owner. (Not a Chromium contributor; not an appropriate owner.) Add myself as owner. Add sky@ as secondary owner, as sky@ is familiar with these histograms. Extend for a few months. Bug: 1039298,1041513,1043689,1036899 Change-Id: I33c38247d78b3b55c8d8070d0000239ef5743dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285347Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#786114}
-
Alexander Cooper authored
The tool currently fails to compile, and is breaking the trybots. Normally, we'd revert the commit that caused this to fail, but this tool is scheduled for deletion in the very near future and currently unused; so fix the bots by stopping building it on them. Change-Id: Ic4e8639c3d2f3f083072dd21ffa8b3d5c7df70ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285225 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786113}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f6f11215cd93..28159ee9c8e3 2020-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ f6f11215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Icd6c2200371b7549302af8a0d6ab2ab8417c2308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786112}
-
Jian Li authored
Bug: none Change-Id: I538d5a32853ea8a62b54f25f9c00c69d12fd53ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278344Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786111}
-
Kurt Catti-Schmidt authored
This change builds upon the previous work in NGGridLayoutAlgorithm to actually perform measuring on the grid items. The next step in the grid algorithm is to determine track column widths. Since column-widths can be content-based (min-content and max-content), these measurements will be necessary at that point. Much like my previous change, this is validated using unit tests, as we cannot currently test end-to-end grid layout until we have more stages of the grid algorithm completed. Note that percentage resolution is currently incorrect. It will require another layout pass with additional sizing data. This is noted in the incorrect test result. Bug: 1045599 Change-Id: Ic10a8522a16e70792e2299dfe3d8eda0231ff877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257403Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786110}
-
Matt Menke authored
This reverts commit 341bb752. Reason for revert: This broke the CQ. See: https://ci.chromium.org/p/chromium/builders/try/win-libfuzzer-asan-rel/472138? https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/604561? etc. Main builders also look to be failing. Original change's description: > [Nearby Share] Add ToDictionary, FromDictionary to PrivateCertificate > > ToDictionary and FromDictionary methods convert to/from a Value > dictionary to facilitate storing PrivateCertificates in Prefs. > > Change-Id: I92117836af94cd224eeea34edc7dd55dd3eb7484 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284043 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#786027} TBR=nohle@chromium.org,cclem@google.com Change-Id: I3a840d2bcdc09ff8ac6db1926a1a7339e121ca04 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286470Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#786109}
-
Nate Fischer authored
No change to logic. This swaps "whitelist" for "allowlist" in AwContentCaptureTest and components/content_capture. Fixed: 1101006 Test: run_webview_instrumentation_test_apk -f AwContentCaptureTest.* Change-Id: Id4c4fef7cf82c6b5ac9ba719c2ba46ca9c1b093f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285398 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#786108}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594154384-2956366c17c90e62cea6163ad2cfb0a0603637b5.profdata to chrome-mac-master-1594166201-979527694a92667bf62297ee8ba7cd564f63c679.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae52188e8d4f376cc920d04a0d284dec76b01b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285832Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8f04e3d34cd0479d654c80c9cb7085e96abcb0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284736Reviewed-by:
-
Chris Blume authored
ImageDecoder::SetMemoryAllocator() said it did not work for multi-frame images. But it did not describe why. This CL adds a comment explaining the reasoning behind it. Change-Id: I8f2f0fa5e36f8eed938b5bfe17f5e82995fd2bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236927Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#786105}
-
Nate Chapin authored
Bug: 1102810 Test: fast/animation/keyframe-effect-on-element-from-inactive-document.html Change-Id: Ie6f1d8014fb1a1ca640b81b828aa4299e57d47d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284090 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Alice Boxhall authored
Bug: 1094565, 817199 Change-Id: Ibf5cea41aa43d5e6f932df69a0b589d8e1d57015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277660Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786103}
-
Erik Staab authored
The list was semi-automatically generated by parsing the output of "gn check" against various configurations. With some exceptions, parsing was done using: grep -E -A1 '(The target:|It is not in)' | grep '//' | \ grep -v '//build/toolchain' | cut -f1 -d: | sort | uniq -c | \ sed -e 's/ *\([0-9]*\) *\(.*\)/ "\2:*", # \1 errors/' Note: if this breaks the "gn gen" step of a build configuration that isn't tested in the CQ please add more entries to this .gn file instead of reverting this CL. Bug: 896680 Change-Id: I4e3d2b316ec014f969303f7c4bb809e436447b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278172 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#786102}
-
Alex Turner authored
As each dedicated worker can only have one parent execution context, we simply inherit that parent's UKM source id. Bug: 1085645 Change-Id: I55b0650a6f38d005e9da6c7110a21953b1f83551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270699 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#786101}
-
dpapad authored
Fixed: 1102943 Change-Id: Ic44bf23de891295106fa73092c14f9a17672fd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285383 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#786100}
-
Dominic Mazzoni authored
Most of the magic that connects PDF annotations for hyperlinks to their corresponding struct tree node happens inside of Skia. All that's needed in Chromium is to add the proper node type for a link. Bug: 1100712 Change-Id: Ica08cd04bc9dcb00684af5eb299927353618d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278173Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786099}
-
Kyle Milka authored
When the device layout changes invalidate and re-layout the two recycler views that make up the share sheet. Bug: 1099496 Change-Id: I45b883b49d490f9d2c1c3d6f0a0f10dac968c1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278409 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#786098}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Id0f79710fb70bdf31ad0959e7b8ab92f22ecdacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280201Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786097}
-
Kyle Milka authored
For the initial launch we do not want to show the custom share sheet for CCTs. Bug: 1090470 Change-Id: I60ed2bae711adbe93db2e21866db0f7cb1b48c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284363 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#786096}
-
Xiaohan Wang authored
Make the message more clear about the ban of variants like ReleaseAndGetAddressOf(). Bug: 914910 Change-Id: I16fb4cb51a619aea4f414601cf10279ac482992a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271072 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#786095}
-
Chris Harrelson authored
Bug: 1100711 Change-Id: Ibbc44d0937ef1dd899677e72e1ebff5db40d9ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280590 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786094}
-
Robert Sesek authored
These were missed by the awk script I ran initially. GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I0cf1677e1054f2ffcb54660820fba61d1c3590a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278363Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786093}
-
Jeffrey Cohen authored
This enables the the image_editor to construct a ShareParam. Bug: 1093365 Change-Id: If1e06d0fea433628540db5d52c73c237f61a4526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285357Reviewed-by:
Travis Skare <skare@google.com> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786092}
-
Nate Chapin authored
We appear to crash in HTMLTrackElement::CanLoadUrl if GetExecutionContext() returns nullptr, so early-exit in that case. Bug: 1102668 Change-Id: I43f0008eefe5d12b63d69c42d0fd341fe0e2f2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284390 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Hesen Zhang authored
- Add InternalsUIMessageHandler as observer. - Inject Logger to TileServiceImpl. - Inject LogSink into TileServiceScheduler and ping the observer. - Set scheduler as LogSource. Bug: 1066556 Change-Id: I6fdf79da6dea82327af5be1aa1b79a6cbee9926d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264934 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786090}
-
Jason Lin authored
This CL updates the icons we use for Plugin VM for the shelf, launcher, installer, uninstall notification, settings page, and task manager. The icons for the file manager will be in a separate CL. Bug: b:151096611,1073795 Change-Id: Ib7ea9d496a773cc5fee091adf07bcac27d591ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264191Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#786089}
-
Maggie Chen authored
Set different timeout values for systems with number of process >8, >4, and <=4 on Windows. Bug: 949839 Change-Id: Id7cf8661df77c5496b3575d5603a2617382b62e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282781Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786088}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1ca4c7cd49a..faef2531ecbb 2020-07-07 rsavitski@google.com Merge changes I461fa63a,I3c67b7b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4816d94e3798d63d136251c7c36e88b77003b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285220Reviewed-by:
-
Ghazale Hosseinabadi authored
In this CL, we add a check in IsCommandIdVisible in order to call HasVisibleItems only if submenu_model is not null. Bug: 1101726 Change-Id: I248daaeca3ac67777c00020c81d7f08e2433fae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285388Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#786086}
-
Darwin Huang authored
This reverts commit b988cfa5. Reason for revert: per https://crbug.com/1102947#c4, this was already fixed a day earlier, in https://crbug.com/1100152 Original change's description: > Sheriff: Disable Flaky FilesAppBrowserTests in TabletMode. > > Flaky tests include: (FileDisplay|QuickView)/FilesAppBrowserTest.Test/(fileDisplayDrive|openQuickView|fileDisplayDownloads)_TabletMode. > > Flake occurrences can be viewed at https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyOgsSBUZsYWtlIi9jaHJvbWl1bUBicm93c2VyX3Rlc3RzQEZpbGVzQXBwQnJvd3NlclRlc3QuVGVzdAw > > TBR: lucmult@chromium.org > Bug: 1102947 > Change-Id: Id39ff39a94e955f0a513b7e5ddceef264846beae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285298 > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786050} TBR=lucmult@chromium.org,huangdarwin@chromium.org Change-Id: I5cb75418c2be74a1ad4dda713376ece9e66de164 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286190Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786085}
-
Yuly Novikov authored
TBR=kbr Bug: 1099978 Change-Id: I796e2b069946d75328b7fe63483b07b18bafa882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285355Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#786084}
-
Travis Skare authored
Bug: 1088012 Change-Id: I5f09de4fb703864e13af8b67f6f4f130735f82fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238491 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#786083}
-
Ahmed Fakhry authored
When a window is dragged to overview by gesture dragging from shelf, tablet mode can end before the drag ends, at which point The homescreen window is closed, and we can't use it to get the SplitViewController. This CL reworks ShouldShowHomeScreen() to fix the crash, and do only the next checks if the previous ones failed. BUG=1101143 TEST=Manually by exiting tablet mode while dragging a window from shelf. Change-Id: I6a58e1c7caa6ebccc45d47cbfa27136891cfee9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285609Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#786082}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I1de34595f2a7eede058244293cfd0a7db4b0e216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285295Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786081}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f612d485..e078f1d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I39539b15015b66b9ab620124965e2f6af14a3ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786080}
-
Yury Khmel authored
This handles new style of applying ids to async events. TEST=Locally BUG=b:150030838 BUG=b:160024571 Change-Id: I7ac4ab3241cd04201ae8c7800102bfa43c7df499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285506Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#786079}
-
Jonathan Freed authored
For the histograms that are important for the Feed, we are extending the expiration date and taking over ownership. Bug: 1089067, 1089069, 1089076, 1089079, 1089080, 1089084, 1089089, 1089091, 1089095, 1089104, 1089105, 1089107, 1089704, 1089705 Change-Id: Ia2de4dcda552b2270915961d587ef95f3095e378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284135Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3bb512bc9f62..0f35b042e02e $ git log 3bb512bc9..0f35b042e --date=short --no-merges --format='%ad %ae %s' 2020-07-06 david [build] Really fix multi and C++ builds. 2020-07-06 david [build] Fix multi and C++ builds. 2020-07-06 wl [psaux] Improve `t1_decoder_parse_metrics' (#58646). 2020-07-02 david [build] Improve visibility support of library function names. 2020-07-02 david [build] Split off more stuff from `ftconfig.h'. 2020-07-02 david [build] Move mac support code to `mac-support.h'. 2020-07-02 david [build] Put integer type definitions into `integer-types.h'. 2020-07-02 david [build] Rename `build/unix/ftconfig.in' to `ftconfig.h.in'. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Due to changes in how FreeType is including it's own headers (moving from FT_HEADER_H to <freetype/header.h> it is necessary when overriding headers to use the same folder structure as freetype's include/ directory. As a result the customized configuration headers are moved to include/freetype-custom/freetype/config and the roll-freetype.sh roll script is updated to point to the new locations of these headers. Bug: skia:10472 Change-Id: I889e2ed0d8dc54987e7f9c6372b2d72e8703e9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283962 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#786077}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForPointInInlineBox()| to call |NGInlineCursor::PositionForPoint()| for |closest_child_after| like it does fro |closest_child_before| to make hit test on left edge of RTL inline element to pass the test[1]. This patch also changes |NGFragmentItem::PositionForPointInText()| to avoid calculating position for items of |IsGeneratedText()|, e.g. ::before/::after. This is follow-up of the CL[2] which introduces calling |PositionForPoint()| for |closest_child_before|. [1] editing/selection/caret-at-bidi-boundary.html [2] http://crrev.com/c/2104812 [NGFragmentItem] Fix hit test on position:relative inline element Bug: 707656 Change-Id: I8aca51af66a7d1885b7b7c2627cd7f4131b37c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282721 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786076}
-
