- 07 Mar, 2019 40 commits
-
-
Tetsui Ohkubo authored
This CL removes support for Diamond key. The feature was supported by --has-chromeos-diamond-key Chromium flag. Chrome OS side change: https://crrev.com/c/1474861 TEST=manual BUG=929027 Change-Id: I0f338ca1776af59409068bd963c636fbc6ee3658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478571Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#638453}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ad364d5cbb9..a6918d7b72a9 git log 4ad364d5cbb9..a6918d7b72a9 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 zamorzaev@chromium.org cbuildbot: Add Skylab support for *-android-pfq Created with: gclient setdep -r src/third_party/chromite@a6918d7b72a9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2f5005ce6e4f3e894b4249c875b51c2c378b3eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638452}
-
mrefaat authored
It's only used now by unit tests. I'm keeping it as a private member of tab for now until i move the overscrollController out of Tab. Bug: 902044 Change-Id: Ic326796a71e0c27f62c4e4b3198a01ad7098c085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504836 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638451}
-
Evan Stade authored
The implementation matches the default, i.e. WidgetDelegate::GetWindowAppIcon(). Bug: none Change-Id: I8c0980cbc676dd835105c551df9039cd2fca666e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506695Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638450}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1cc386687cde..579cf621f3dc git log 1cc386687cde..579cf621f3dc --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cwallez@chromium.org Split off common and libdawn / dawn_headers from BUILD.gn 2019-03-06 cwallez@chromium.org BUILD.gn: Split dawn_component/generator in their own files Created with: gclient setdep -r src/third_party/dawn@579cf621f3dc The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If135e279f6fdd9818334f334b45267eb3293b98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506669Reviewed-by:
-
Karandeep Bhatia authored
This CL fixes extraHeaders modification for webviews in non-network-service path. r611357 began requiring the 'extraHeaders' specifier for event listeners which wanted to intercept certain headers. However ExtensionWebRequestEventRouter::OnEventHandled doesn't handle webview listeners while computing the extraInfoSpec. Fix this by sending the webViewInstanceId to the browser process as part of the webRequestInternal.eventHandled function. This allows us to accurately determine the listener which called the function. Also, add a regression test. The network service path will be fixed in a follow-up. BUG=938095 Change-Id: I89a5383c6ba1eac67efc8c3fe25a7714a54e2605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504961 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638448}
-
Yuichiro Hanada authored
There could be multiple ui::InputMethod instances in SPM. This CL makes ArcInputMethodManagerService observe ui::InputMethod changes. Bug: 937769 Test: manual - Android IMEs show up when tapping on a text field. Change-Id: Ie507d6ef612ce4ef60b93e6391353d485f7c5258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504669 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#638447}
-
Michael Martis authored
This CL tracks metrics about: - The core operation of the service (e.g. client communication, cache hit rates, etc.) - The performance (e.g. amount of data transferred to/from, latency) of the image annotation server - The distribution of metadata (e.g. confidence values, empty results) returned by the server Also fixes two bugs found during metrics testing: - We no longer attempt to parse an engine result if we receive a non-OK status. The counterexample to this behavior is an OCR engine failure, which returns an empty OCR result (which is otherwise successfully parsable) along with a non-OK status code. - We were sometimes accidentally populating the cache with failure results (we should only cache successful results). Bug: 916420 Change-Id: I996cebf644865d0135efb73c57785745e5cb7585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498747 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638446}
-
Toni Barzic authored
All usages have been removed in favour of per-screen exit codes. BUG=930267 Change-Id: I0f5b0164f3c74cf3fdf3f0c45743f0df71b30852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506564 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#638445}
-
Paul Irish authored
Changelog: https://github.com/googlechrome/lighthouse/compare/v4.1.0...v4.2.0 Bug: 772558 Change-Id: I12f8cf514afb7fff2503f2b4ca797803f804c4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507206 Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#638444}
-
Ramin Halavati authored
ShowAvatarMenu is updated to open correct menu in Guest mode. Bug: 938600, 896235 Change-Id: I2407c1c6065afd698d2b571c4f86ad0020b1dca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505612 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#638443}
-
Vlad Tsyrklevich authored
Here we are recording allocation metadata for a slot, but not *in* a slot. This is in anticipation of an upcoming change that will make slots/metadata not have a 1:1 mapping so poor wording like this is particulary noticable. Bug: 939142 Change-Id: I55deae7b9290334329e1cc48759859c68ccab11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507312 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#638442}
-
Nigel Tao authored
Previously, such effects were only applied to Extension apps. This commit lets other app publishers apply the same effects. A follow-up commit will do so for ARC++ apps. BUG=826982 Change-Id: I063cabf7a44efb111638e42565a5792b24c38eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505743 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#638441}
-
Chris Harrelson authored
There is an optimization to omit solid-color transparent draw quads, since they don't do anything. However, this optimization is incorrect if the draw quad has a blend mode other than kSrcIn. Also add support for non-kSrcOver blend mode for SolidColorLayerImpl. Bug: 937258,939168 Change-Id: Id779b9bbe06d2ff5c6e9c34a18026b500f5791a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506383Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638440}
-
dstockwell authored
Bug: 902646 Change-Id: Idd2e85b2b5b1e228639120858c9defe9ec207d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506919 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638439}
-
Collin Baker authored
Bug: 920027 Change-Id: I6af75af13d85f44ed55bd175dc169836b2a83716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504149 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#638438}
-
Bruce Dawson authored
The ARM64 Win32 builders still run a bit slow (30 - 160 minutes) due to the large number of build steps (cross compilation) and the use of -j 80 when many other builders use -j 150. This changes to -j 150 by using the appropriate mixin. Builder is here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-arm64-rel Bug: 938085 Change-Id: I6c7b7cb8d6fb81c5ed3969cd5d31368f09b009ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506949 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#638437}
-
Rob Schonberger authored
When a user interacts with a fast app reinstall result, how many times did we show it before they clicked. Change-Id: I29cf36c2511a8ab3025d24ebb3c5432f699ed599 Bug: 911427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503180 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638436}
-
Abhijeet Kandalkar authored
The primary motivation is that the function names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL renamed functions to follow proper case style. Bug: 936684 Change-Id: I06903ede66a09c133978f4ff940c7b505d1123f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503276Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#638435}
-
Matt Reynolds authored
This CL adds initial IDL for the navigator.hid object which is enabled under the experimental web platform features flag. (chrome://flags/#enable-experimental-web-platform-features) A FeaturePolicyFeature is also added to control access to HID within the renderer. BUG=890096 Change-Id: If75aefdd7dcaaad06ae56cff8d898d0bea0f83a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441992 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638434}
-
Yuke Liao authored
The coverage build is about 10x slower than regular build when running browser_tests, and this CL increases the timeouts accordingly. Bug: 937521 Change-Id: I5939648142f29fbd9fe36625d661cc70ff6019e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504153 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638433}
-
Tommy Nyquist authored
This CL removes the special cases for Jelly Bean in the ApiCompatibilityUtils in //base. After that it turned out that all the APIs could be inlined. One API had to be special cased, since it was more than a single line, namely the isDeviceProvisioned(Context) method. It had null-checks for the Context and ContentResolver, and they were kept to ensure this CL has no functional changes. Some API callers were using the result of !inlineMethod(...), and the method itself was checking == against something, and for those the == was flipped to != and the negation of the call was removed after inlining. The method getUriForImageCaptureFile(File) had some documentation, and that was moved to the only method it ended up calling, since that was lacking documentation. Bug: 893231,923477 Change-Id: I43420a38f6fe191b2c489f2f1bec99160bbcc718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496522Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#638432}
-
Hiroshi Ichikawa authored
The issue was that this condition is true even when the task is cancelled (state kCancelled): https://cs.chromium.org/chromium/src/ios/web_view/internal/cwv_download_task.mm?l=135&rcl=584d37cf04ac09d05ecacdf946edf11bdeeb0198 So it unintentionally tries to call DisownFile(), which fails. Also introduce CWVDownloadErrorFailed and CWVDownloadErrorAborted because clients probably want to distinguish failure and cancel. Change-Id: I1637aabf8843685ccee01cf272a5f5acee85e005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504486 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#638431}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c957d575c58..e62d14c1d9ba git log 3c957d575c58..e62d14c1d9ba --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bf943f67daa4..2995dc2a67c7 (2 commits) 2019-03-07 bungeman@google.com Correct argument order for blobs in viewer. 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 76e9bc066b28..bf943f67daa4 (2 commits) 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e397949ec2db..14126505b237 (4 commits) 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e62d14c1d9ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I218aad36e61d4d7b9bbf157a3ff850e37e64c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507253Reviewed-by:
-
Ramin Halavati authored
Incognito window counter's insets are updated to unify with other profile-chooser dialogs. Bug: 931320, 934689 Change-Id: I433f0678a245768be226e26274c9fd663c822b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505172Reviewed-by:
-
Toni Barzic authored
Stops using remaining ScreenExitCode enum values (for reporing oobe screen results. Instead, defines screen result enums per screen when needed (i.e. if the screen may report multiple values). Updates how screens relay the exit code to WizardController - instead of using BaseScreenDelegate::OnExit (indirectly though BaseScreen::Finish), the screens now take a callback that is run when the screen exits. Affected screens: * AppDownloadingScreen * ArcTermsOfServiceScreen * AssistantOptInScreen * DemoPreferencesScreen * DemoSetupScreen * DiscoverScreen * EnableDebuggingScreen * FingerprintSetupScreen * HIDDetectionScreen * KioskAutolaunchScreen * KioskEnableScreen * MarketingOptInScreen * MultideviceSetupScreen * RecommendAppsScreen * ResetScreen * SupervisionTransitionScreen * SyncConsentScreen * TermsOfServiceScreen * WelcomeScreen * WrongHWIDScreen BUG=930267 Change-Id: Ie53a748b24a9bf8d03bc0e8e467d94d1f38e5898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506492 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Yuri Wiitala authored
Fixes a "choppy audio" issue on platforms with certain audio timing parameters/scenarios. Investigation on crbug.com/934770 led to the realization that three related problems needed to be addressed: 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH directions, not just one direction; and on both the input and output flows. This accounts for the case where a device-switch in audio::OutputController results in a sudden drastic shift in the delay timestamps. 2. Add automatically-increasing capture delay logic to audio::LoopbackStream to ensure the reads from all nodes' delay buffer will never result in underrun. 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) addressing a subtle source of error in task scheduling delay math due to integer truncation; b) exposing timestamps to worker callbacks that allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| that behaves just like a real AudioOutputStream. This "lessens the blow" of a device-switch to SnooperNode. Bug: 934770 Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638427}
-
Takuto Ikuta authored
I will deprecate deps in proto_library for improved build throughput. And we can use proto_deps here instead. Bug: 938011 Change-Id: I406ef84c220536058e3f9e18ccd9ce3e4cb2e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504602 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638426}
-
Jinsuk Kim authored
This CL consolidates various ways to create Tab instances into a single one using TabBuilder. Saves us from passing unannotated params |null| to the constructor, so makes the intention clearer. Bug: 925242 Change-Id: I7440eb501a5ef7a6f456ee60e1c1000932af85b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485611 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This VisiblePosition-typed variable should have been cleared in crrev.com/1501035 but was left over. This CL clears it. Bug: 657237 Change-Id: Idec9cb0e6a4709bece76e6ed36da325d7ab7fba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507134Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638424}
-
Mei Liang authored
This CL adds accessibility strings for tab group feature IPHs and updates tab groups related strings description according to the spec. Bug: 938522 Change-Id: I7efec5e3eeedb76135975ceb30dc3077d70a9439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504162 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638423}
-
wutao authored
This patch adds unit tests for emebedded Assistant UI to test the basic UI visibility and app list states. Bug: 924624 Test: AppListView*Test:*EmbeddedAssistantUI* Change-Id: I588ffb174d5f4e6ec2a1e0c80d139648740a01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501514 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#638422}
-
Dan Beam authored
As far as I can tell, this CSS doesn't work. Removing it instead of attempting to update it for dark mode. R=dpapad@chromium.org BUG=926658 Change-Id: I34213a54828c2becc3b59cfcdd60f8de72bdad2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506389Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638421}
-
Eugene But authored
The test was calling gtm_dictionaryWithHttpArgumentsString method to verify that method exists. Chrome does not call this method, so there is no need to test method existence. Bug: 933827 Change-Id: I86200d3d8bbb9096f12277b7e951422b07672d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500628 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Kayce Basques authored
Bug: 939147 Change-Id: Ic3a208e37a863b695da91af04d0485efe738d118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506305Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I57c94f248bf2db118e94903f6861c81289b07f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507013Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638418}
-
Stefan Zager authored
The root cause for the failure is most likely a change in when the flags controlling frame throttling are updated. That changed when the IntersectionObserver steps were moved to run in a post-lifecycle step. It's possible that a frame was marked as throttled at the time that UpdateAllLifecyclePhases ran, so it was skipped for update; but the throttled flag was flipped to unthrottled before the code path where the crash occurs, so that the call to ShouldThrottleRendering() does not reflect the state of throttling when the lifecycle ran. BUG=938651 R=schenney@chromium.org Change-Id: Ifb7e50d40f096e333e45e5e8610ef7ab7671bee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506757 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#638417}
-
Wei-Yin Chen (陳威尹) authored
Enable triggering of IPH_TabGroupsQuicklyComparePages when tab groups feature is enabled. Bug: 930970 Change-Id: I9182bb3ebe40c00d9dd03f7eb234bde4f1d800c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497638 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
dpapad authored
This file is only referenced by a test HTML file, which in turn is not referenced anywhere. Deleting both. Bug: None Change-Id: I2f872560da6aec7c7b98bdeb57501a9f2cd2a021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507236 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Justin Cohen authored
This reverts commit b89cc617. Bug: 936211, 926235 Change-Id: Ia62f48168f41302582a607b2695cb1b379529945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506880 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
