GitLab

If a user already has a custom background the refresh timestamp
and collection id in the pref would be initialized causing a crash when
we attempt to access them.

Bug: 850317, 990265
Change-Id: Ic34e3a34516be41b96e279d3c135a4a1912a251a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731922
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683754}

It appears that https://chromium-review.googlesource.com/c/chromium/src/+/1731947
caused some tests to just fail instead of crashing, which lead to
failures on WebKit Linux Leak. The tests still seem to crash on the trybots though.

Sample failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2713

TBR=mstensho@chromium.org

Change-Id: If27c2ac16c86df5d2ecd3682161ab1b9872bf934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732796
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683753}

Changes to mb.py:
371e55885 Fix many misspellings
28bae5501 [vpython] Support vpython3 mode in vpython-native, include symlinks
4a77b0e65 [vpython] Support vpython3 mode

Changes to run-swarmed.py:
371e55885 Fix many misspellings
28bae5501 [vpython] Support vpython3 mode in vpython-native, include symlinks
4a77b0e65 [vpython] Support vpython3 mode
3adcb7a14 [vpythonsmoketest] Add a simple smoke test

Bug: 898348
Change-Id: Iff26b08ddfeeb7827d28b75f3e36c09b1a493295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730868Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#683752}

This is a mechanical change and will be TBR'ed after base/OWNERS review
per policy.

TBR=kylechar@chromium.org

Bug: 905412
Change-Id: I8003ea7c4137efdfa5390193d165f80f33f855b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732708
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683751}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=kbr@chromium.org

Bug: 968047
Change-Id: I063d952e16d56b738ee19e8e773d74c1269c0bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729087
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683750}

It would trigger a preferences write on load error, to overwrite the
bad preferences. However, if we don't overwrite bad prefs, we'll load
them the same way we did before, so it doesn't seem like there's an
actual problem here. It's not a huge amount of code to track when
there's an error in loaded preferences, but it doesn't seem to get us
anything, either.

In some cases, some fields having errors cancels short-circuits reading
other fields. That logic still happens, so the results of loading bad
data should always be the same as before, we just no longer write
repaired data until there have been meaningful changes to it.

Bug: 984996
Change-Id: Ic035646d37f33cecdd267d2815c70ce804461e07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726956
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683749}

Bug: 990208
TBR=boliu@chromium.org

Change-Id: If2222cf76edf31860fcc1f4271c2c85a082d1088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734006
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Auto-Submit: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683748}

It was only needed for ChannelPosix because Mach ports could not be
transferred with the message data. Now that ChannelMac exists, just
TakeHandles() is needed.

Bug: 973882
Change-Id: I83e754ea9877f4d355654ee069b5a6be0a14c1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733926Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683747}

PassKit text is not rendered because of iOS 13 system bug. EG1 test
can't test the text (only presentation) so it passes. EG2 is a better
test and fails because of a real bug.

Bug: 989816
Change-Id: I946b862daa244ab3b2ba4c795e6f7e433b254a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733453
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683746}

OnConnectionError should have been resetting both the data producer
as well as the client.

Bug: 958796
Change-Id: Ibc60dc05f7763e4ac61b43e445b5f2b40adc9246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733018Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#683745}

https://skia.googlesource.com/skia.git/+log/17b9d1d1deaf..f8e5aadbd424

git log 17b9d1d1deaf..f8e5aadbd424 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 csmartdalton@google.com Remove 'dst' argument from GrOpList::copySurface
2019-08-02 michaelludwig@google.com Move SkImageFilter functionality into private SkImageFilter_Base
2019-08-02 mtklein@google.com no need to increment uniform pointers by zero
2019-08-02 robertphillips@google.com Revert "Increase specificity of GrColorType computed for YUV planes"
2019-08-02 mtklein@google.com select, {eq,lt,gt}_i32 on x86

Created with:
  gclient setdep -r src/third_party/skia@f8e5aadbd424

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: None
Change-Id: Ia8eb3ff0c2edd4eb12f5cb60da0a79ec02a4d849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733848Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683744}

After some of my refactors, if properties were learned before prefs
had been loaded, they would only be saved in response to other property
changes or on shutdown, which could hteoretically lead to never saving
them on Android, where we never shutdown cleanly.

Bug: 984996
Change-Id: Ica0ebaced0edcb8c2f83429a02000579317c2537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726761
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683743}

The heap profiling service only runs in-process and its lifetime is
effectively managed by the heap_profiling::Supervisor singleton.
This removes the Service Manager from between the Supervisor and the
service implementation.

ProfilingClient receivers are bound in child processes through
|ChildProcess.mojom.BindReceiver()| instead of through a Connector
to the child process's Service impl. The necessary logic already exists
in child processes via ContentClient::BindChildProcessInterface(), so
no changes are needed in child process code here.

Some Service Manager dependencies remain only to acquire Resource
Coordinator interfaces before injecting them into the heap profiling
service implementation. These will be removed when Resource Coordinator
is moved off of Service Manager.

Bug: 977637
Change-Id: Ifb2c2cf404ac7e3db6a0e7b60fc99ed87dee097a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732696Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#683742}

Change-Id: I172fb7f98693cd2b8e46b7510b9160b4e49cdae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733854
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683741}

https://swiftshader.googlesource.com/SwiftShader.git/+log/029a36c7cbfc..060fcf777159

git log 029a36c7cbfc..060fcf777159 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 swiftshader.regress@gmail.com Regres: Update test lists @ f63c4e51

Created with:
  gclient setdep -r src/third_party/swiftshader@060fcf777159

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: I1f7317a609dca70d1e5101de6958ae15e81aed8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733411Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683740}

Sessions should be saved when there are no webStates at all, right now
Chrome doesn't save the session if there is no active webState which
include cases where there are no webStates at all.

Bug: 989482
Change-Id: I96538dbf21be6d20730dd8800988379f0882c8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730166
Auto-Submit: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683739}

Instead of the download icon, use a new icon with the outline of a
folder.

http://screen/e8nJioNs5bP

Bug: 990063
Change-Id: I01d31aaed41ab433460fe389dadf2b5b58ea615d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731104
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683738}

In the current version of AppMenu, the InMenuButtonBackground does not
depend on the state of other views, so there is no need to invalidate
all the other views (forcing a paint-all).
When the comment justifying the SchedulePaintInRect() override was
written, the MenuButtonBackground varied its painting depending on
the state of other views, left_button_ and right_button_.
Whenever the state of one of the other buttons changed, any other
views using a MenuButtonBackground needed to paint too, which is why
SchedulePaintInRect() very heavyhandedly forced a paint-all.

Change-Id: Id3030139ca0cb31e34d610078cfdd13e94494ce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733460Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Annie Su <anniesu@google.com>
Cr-Commit-Position: refs/heads/master@{#683737}

MessageLoopForIO will go away soon use ScopedTaskEnvironment instead.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=kylechar@chromium.org

Change-Id: Ib3a70b497ba1117d20f30399903e40ce204f996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733534
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683736}

Bug: 988891
Change-Id: Ifcafee429c75da79a9f980b022a9524795922f48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726954Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683735}

The CrOS lock screen media controls can now be swiped up on to dismiss. If the
controls are dragged past a certain height or are swiped with a large enough
velocity, the controls will be animated off the screen and playback will stop.
The opacity of the controls changes as they are dragged up and down. If the
controls are not swiped high or fast enough, they will be animated back down
to their initial position.

See bug for video examples.

Bug: 965575
Change-Id: I2bc264ec45c82772a17a926dfbe3e04ad59d01a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730132Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mia Bergeron <miaber@google.com>
Cr-Commit-Position: refs/heads/master@{#683734}

This CL fixes an inconsistent test spec.

Change-Id: Icd7e2b077915c4e27f348afd68d2ed71ab539d33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733578
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683733}

This is a collaboration of fdoray@ (Catan) and dfried@ (Top Chrome) to
improve how preview images are captured for tab hover cards and for
the new touch-enhanced tablet tab-switcher being developed by the
WebUI team in collaboration with the Views and Top Chrome teams.

Tab preview thumbnails are an integral part of our UX plan for tab-
switching improvements in the next few quarters. Previous
infrastructure was aimed at saving images for the NTP, which was a very
different set of capture situations than what we want for tab previews
(specifically, background-loaded tabs were never captured). This logic
allows the capture of tabs loaded in the background or restored from a
previous session by using a different capture mechanism.

This functionality is entirely behind a flag and is known to be slightly
buggy. We plan to use volunteers to teamfood the functionality and send
feedback/issues so it can be made ready for production.

Change-Id: Ie356b95dc42b75729860c772e9a01a19028d0fee
Bug: 981103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689397
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683732}

TBR=corising@chromium.org

BUG: 990210
Change-Id: I15dc467182133ae8793a5174b1f84dfcfeb8429e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732332Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683731}

Also removed the hover highlight of the new desk button.

Bug: 970328, 990044
Test: Manually
Change-Id: Iea844d9614d391f3bd5c53d2c50ff114cfeccd36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732892Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683730}

WebGPUSwapBufferProvider::PrepareTransferableResource must use
GL_TEXTURE2D_RECTANGLE_RGB only on Mac.

Bug: 989818
Change-Id: I1bc11d3f0a8fab7d5de208e744a8c1aa24c47828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730255Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#683729}

-Styled the in-page select, options, and optgroups via css.
-Modified the scrollbar to have rounded corners
(had to plumb the zoom factor through the Scrollbar so that the native
theme aura code can get the rounding correct at paint time)

Bug: 987292
Change-Id: Id11d1a47fe3d5b2be01aa578aa066f80577a9bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715553
Commit-Queue: Allison Pastewka <alpastew@microsoft.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683728}

Make it possible to write pdf_unittests test cases that call
PDFiumPage::CalculateLinks() without requiring PPAPI initialization.

Change-Id: I8433baf810128039efa4705a8862b95f97efd9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725427Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683727}

Fixes a bug in which in_subtree_layout was not properly updated due to the
possibility of ClearLayoutSubtreeRootsAndMarkContainingBlocks being true
when doing a re-layout in post-layout tasks.

Bug: 990225,462719,970224

Change-Id: I8d5b0a543646c5833850a2ec921affc4d71f4dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733462Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683726}

No change to behavior.

This removes the kCheckByURLLoaderThrottle feature. This feature was
only relevant when Network Service was disabled. Since NS is enabled for
all platforms (and the legacy net path is no longer supported), we can
remove the feature entirely.

Bug: 989709
Test: double-check WebView safe browsing still works with the demo app
Change-Id: Ia62c503b66b30c97571e8fbc2ce351962f8b7b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732391
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683725}

NOTIFICATION_TAB_LANGUAGE_DETERMINED and NOTIFICATION_PAGE_TRANSLATED
waiters are removed in favor of a helper class that observes the tab's
ContentTranslateDriver.

Also, ChromeTranslateClient::translate_driver() is changed to return
a pointer instead of a non-const ref.

Bug: 268984
Change-Id: I450ace7f647cf9418a28ac36aef70bf1f97a3f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724420Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683724}

Adds toplevel.flow trace events for message pipe closure to link the
closure of one endpoint to the detection of that closure by its peer
endpoint. This allows pipe closures to be followed like other IPC
message events, since pipe closure is often an important type of IPC
in itself.

Bug: None
Change-Id: I78c928972eddebef26c1ea9765dd697c17807f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733786
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683723}

removing HTTP authentication data.

This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy load
flags and replace them with the allow_credentials setting. See
https://crbug.com/799935,
https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4,
and
go/allow-credentials-tracker
for the motivation and progress of this change.

This CL handles a third of cases where LOAD_DO_NOT_SEND_COOKIES and
LOAD_DO_NOT_SAVE_COOKIES were set, but LOAD_DO_NOT_SEND_AUTH_DATA was not.
This CL will set allow_credentials = false instead, which will make two changes
to the requests:

- The request will no longer participate in HTTP auth if the server requests
  it. HTTP auth credentials identify the user, so private requests should
  not send them. Note this only affects server auth, not proxy auth. Unless
  the server your feature speaks to requests HTTP auth, this is a no-op.
- The request will be pooled with sockets used for uncredentialed requests,
  rather than credentialed requests. This is not expected to meaningfully
  change behavior.

If your code requires HTTP authentication, let me know. You may need to allow
credentials for your request.

Bug: 799935
Change-Id: I48c22f202d5221b33dadf0d66c8f2e3435238a71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580582Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Jesse Selover <jselover@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683722}

Using this + the DoNotInline fix (crrev.com/c/1730845), we go from 47 to 37
RetryVerifcationAtRuntime classes.

Bug: 965189
Change-Id: Ibbe9da08c0f0756fc9fc5c915c246e0352c32819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731771
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683721}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9873ee0de15a..116752315474


Created with:
  gclient setdep -r src-internal@116752315474

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: Ic2ca0c522c0e5803e6b16be17580cbccd0521b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733787Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683720}

No significant code changes other than imports.
Moving existing code out of https://chromium.googlesource.com/enterprise/cel/+/refs/heads/master/test/chrome_ent_test/ent_tests/

Also updated the infra package with a version that has those files
deleted (https://crrev.com/c/1726909).

We're moving these files here because they're not used in other repos
and need to be edited frequently for tests here (and updating the
package is a tedious process).

This move will improve our engineering productivity for those changes.

It will also make some refactorings a lot easier:
  https://crbug.com/986439
  https://crbug.com/986444
Will be sending those out shortly.

Validation:
  https://ci.chromium.org/p/chromium/builders/try/win-celab-try-rel/46

Change-Id: I7343ccb7f50d1f203d4dd38013bb1de723599f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727229
Commit-Queue: Mathieu Binette <mbinette@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Auto-Submit: Mathieu Binette <mbinette@google.com>
Cr-Commit-Position: refs/heads/master@{#683719}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4af1fe027b83..be9e4bf1b538

git log 4af1fe027b83..be9e4bf1b538 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 mmortensen@google.com Fix call to ArchiveFilesFromImageDir.

Created with:
  gclient setdep -r src/third_party/chromite@be9e4bf1b538

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Id894857ca5897d54861b8f3e58e02a804616d07f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733708Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683718}

CodecBufferWaitCoordinator is null in overlay mode. Add missing null
checks while accessing TextureOwner from it.

Bug: 990321,990273
Change-Id: I02b638fb505b8e3d0dc33def5a43e651f96a5894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733746
Auto-Submit: vikas soni <vikassoni@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683717}

RenderWidget objects are re-used for same-domain navigations, meaning
the input handler lives on. The lifecycle state of the input handle
must be reset on navigation to correctly report input timing.

We also increment the histogram name to reflect the change in data
measurement. And rename some of the methods to better match other parts
of the code.

Bug: 958424
Change-Id: Ic43e3a1256000ca3d99e119b3cb8ceee66dc8499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729794
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683716}

https://dawn.googlesource.com/dawn.git/+log/54b4df706968..ef4f3bd17474

git log 54b4df706968..ef4f3bd17474 --date=short --no-merges --format='%ad %ae %s'
2019-08-02 idanr@google.com Add external memory and semaphore extensions

Created with:
  gclient setdep -r src/third_party/dawn@ef4f3bd17474

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: chromium:976495
Change-Id: I7b2286d630068880f1cb3cf9f4285b1064f307a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733728Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683715}