- 21 Sep, 2018 40 commits
-
-
Reilly Grant authored
This method was only used by the BrowsingDataCookieHelper unit tests, which this change converts to using the network::mojom::CookieManager interface. Bug: 721395 Change-Id: Ia4f5a54221d0ce902a42e8f910230ad0d732b7ee Reviewed-on: https://chromium-review.googlesource.com/1236289Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593231}
-
Wez authored
- Migrate //mash and //ui/views examples off QuitCurrent*Deprecated(). - Migrate //net mock off it as well. These are the final remaining call-sites that codesearch identifies as not-test-specific (even though the mock is a mock ;). Bug: 859095 Change-Id: I417f9c93aa6ef6eaae4cf22948e07750d176d83d Reviewed-on: https://chromium-review.googlesource.com/1226455 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593230}
-
Guohui Deng authored
MixerServiceConnection is a component that connects to MixerService via Socket. Bug: internal b/29571387 Test: build and run on an audio device and verify the assistant works fine. Change-Id: Iae323943909167fe247666ffd2c319efcf34c3ac Reviewed-on: https://chromium-review.googlesource.com/1231813Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593229}
-
Christopher Cameron authored
There exist the following to endpoints that need to be hooked up - NativeWidgetMac::InitWidget can use a views::BridgeFactoryHost - AppShimHost has a views::BridgeFactoryHost that can create Cocoa UI in the app shim process Hook these two up by - Adding a virtual method NativeWidgetMac::GetBridgeFactoryHost - Overriding this in the BrowserFrameMac sub-class - Calling into apps::ExtensionAppShimHandler to find the apps::AppShimHandler::Host for the browser window - Adding an apps::AppShimHandler::Host::GetBridgeFactoryHost method - Overriding this in AppShimHost to return its views::BridgeFactoryHost This involves adding the helper function apps::ExtensionAppShimHandler::FindHostForBrowser. Most similar functions are implemented as a static function that call GetInstance to effectively make the function non-static. Because this is confusing, change such instances to be non-static functions, and make public the GetInstance method as apps::ExtensionAppShimHandler::Get. Also do a little bit of cleanup in BridgedNativeWidgetHostImpl so that we don't crash immediately - Make GetBoundsOffsetForParent not dereference null and add a comment that its logic needs updating - Remove |has_received_window_geometry_| because the approach that it assumed will not work R=tapted TBR=avi (for chrome/ OWNERship) Bug: 859152 Change-Id: I9873e0c70b07468fefa90a574606cca1ed54a951 Reviewed-on: https://chromium-review.googlesource.com/1235221 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#593228}
-
Kenichi Ishibashi authored
We should call AppCacheStorage::CancelDelegateCallbacks() in DeliverNetworkResponse(). because otherwise we could call SendResponseInfo() without having a valid URLLoaderClient. No test since AppCacheURLLoaderJob has special casing for testing and it's difficult to work around it. Bug: 882538 Change-Id: I0c4661a08532d0891fc1696464b675eeb4ce6cde Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1237893 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#593227}
-
Steven Bennetts authored
This reverts commit 63cb63c9. Reason for revert: Crashing in debug builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7920 Original change's description: > More OfflineItemModel implementation > > This CL makes OfflineItemModel inherit from DownloadUIModel > > Bug: 881499 > Change-Id: Ic7591f5ce7f5f5243cfeb8ff89ad1e77aa1b78db > Reviewed-on: https://chromium-review.googlesource.com/1237134 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593030} TBR=qinmin@chromium.org,shaktisahu@chromium.org Change-Id: I6fb1e7e1ed50df3147efdfa2e57e38577cffacf8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/1238859Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593226}
-
Robert Ogden authored
I discovered a small bug playing around with the new Previews Omnibox badge that sometimes it fails to show up for certain previews that are not fully "decided" on until page load finish. This change updates the security icon, and therefore the verbose status view if the page is a preview at its finish. Bug: 871839 Change-Id: I9e5b01def3bb9548422956eed869b0820854b803 Reviewed-on: https://chromium-review.googlesource.com/1236854Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#593225}
-
Hal Canary authored
Change-Id: Ic80a13781c3a2145329f36f5c843ca6b16061587 Reviewed-on: https://chromium-review.googlesource.com/1237053Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com> Cr-Commit-Position: refs/heads/master@{#593224}
-
Fritz Koenig authored
There is a lot of flipping going on when using the GL_MESA_framebuffer_flip_y extension. toDataURL and LowLatency have competing requirments when calling CopyToPlatformTexture. https://codepen.io/miguelao/full/WKZaqd https://www.khronos.org/registry/webgl/sdk/tests/conformance/canvas/to-data-url-test.html BUG=883362 Change-Id: Iafe11c23591a79f696b652a57f2d083258d3aa9c Reviewed-on: https://chromium-review.googlesource.com/1237248Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#593223}
-
Rintaro Kuroiwa authored
- CdmProxy::SetKey takes a key type. This should be used to manage possibly different key blobs for different key types. - Calling CdmProxyContext::GetD3D11DecryptContext requires passing in a key type as well, to specify which key type it's requesting for. - Moved CdmProxyContext from media/base to media/cdm because 1) it doesn't need to be in media/base and 2) it depends on cdm_proxy.h now, to access CdmProxy::KeyType. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4064e9426bc8efac3fe667806a9f3713881b31ac Reviewed-on: https://chromium-review.googlesource.com/1234332 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593222}
-
Ella Ge authored
solid color quads used scale = 1 for non-mask layer, so when use-zoom-for-dsf is enabled, it generates a lot more solid color quads, which causes a bunch of rendering performance regression. This CL makes the scale = 1 / dsf when use-zoom-for-dsf is enable, so we generate same amount solid color quads as before. This should not break solid color quad as it doesn't count dsf before. Bug: 871347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7f30ebf51fbd9bfe8800aa34f228b98985358c39 Reviewed-on: https://chromium-review.googlesource.com/1234362Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Xianda Sun <sunxd@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#593221}
-
Josh Nohle authored
Because DeviceReenroller now uses the DeviceSyncClient in the destructor to remove itself as a DeviceSyncClient::Observer, DeviceReenroller needs to be destroyed before the DeviceSyncClient in the unit tests. Bug: 887953, 887557, 887758 Change-Id: I23e8f150ef08e6ad3d388f4ed86d47123077f71a Tested: Unit tests with ASAN on Reviewed-on: https://chromium-review.googlesource.com/1238818 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#593220}
-
James Wallace-Lee authored
Bug: 878390 Change-Id: I94ff2c90bca4434f311b042d3265df881ad8f69e Reviewed-on: https://chromium-review.googlesource.com/1222695 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#593219}
-
bsheedy authored
Changes the behavior of instrumentation tests to automatically restore any shared preference files modified by --shared-prefs-file. Also adds a simple script for manually applying a shared preference JSON file for cases where settings that are normally only used during automated testing are needed for manual use. Change-Id: I94006c1a8e48d910ed2f7e0742f001d8d62b7b15 Reviewed-on: https://chromium-review.googlesource.com/1220557Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593218}
-
Daniel Bratell authored
gn.el used to be in the chromium source tree until gn moved elsewhere. Now it lives somewhere else, https://gn.googlesource.com/gn/+/master/tools/gn/misc/emacs/gn-mode.el which makes it less useful. This is a copy of that file as of today. The file is not updated often, and when it is, it's just to add more keywords so nothing critical. Bug: 887937 Change-Id: I39335815a2cc8ecfe2b0e1728443f6abe84a85fa Reviewed-on: https://chromium-review.googlesource.com/1238462Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#593217}
-
Daniel Bratell authored
Jumbo is a unity build system for Chromium where many files are compiled together. Since so much code is in headers and templates this is much more efficient, and depending on your hardware, can significantly speed up builds. The headless module needs 26 CPU minutes to compile without jumbo. With jumbo for everything, it needs 3.1 CPU minutes. Half of that is already on master through the jumbo support in mojo. This patch adds jumbo support for the rest, changing the compilation effort from 15 CPU minutes to 3. In real world time, this saves about 1.5 minutes on a full build on an 8 thread machine. Bug: 883727 Change-Id: I3ede4805064344574c314d03904208110fdcb462 Reviewed-on: https://chromium-review.googlesource.com/1225702Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#593216}
-
Daniel Bratell authored
In some jumbo build configurations, two ClampBufferSize functions in services/network ended up in the same translation unit which caused compilation errors. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6b7ea9c226b114a10d59fa9891e67f83537c5ec6 Reviewed-on: https://chromium-review.googlesource.com/1238219Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#593215}
-
Sahel Sharify authored
The fling unittests are using mock clock to make sure that the tests are stable. Bug: 868381 Change-Id: I4bafbb71edd668ea553507c00a8784c994f49597 Reviewed-on: https://chromium-review.googlesource.com/1157291Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593214}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/22defe0965adddaa09eebc13df7fa6c64e2abba3..54d332dd9b0263821376161cdffb60ffb3c7847f Bug: 887943 Change-Id: I1a6eed501cc396f4dff8a057b2cf958d808c7869 Reviewed-on: https://chromium-review.googlesource.com/1238467Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#593213}
-
Frank Liberato authored
This reverts commit 555dcba9. Reason for revert: probably the cause of compile failures (e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/3246 ) Original change's description: > [iOS][MF] Secure filling > > Observe the last focused field to validate it is secure before filling a password > > Bug: 878388 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26 > Reviewed-on: https://chromium-review.googlesource.com/1221217 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593194} TBR=mahmadi@chromium.org,gambard@chromium.org,javierrobles@chromium.org Change-Id: Ie272d2622baeda172a802feaf552b1771e436bc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1238822Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593212}
-
manuk authored
Change-Id: I284f33451000a9927a0c2a16df523cd7fa7dd4b3 Reviewed-on: https://chromium-review.googlesource.com/1226101Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593211}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/553230386b67..69356444050a git log 553230386b67..69356444050a --date=short --no-merges --format='%ad %ae %s' 2018-09-21 hjd@google.com trace_processor_shell: Fix linenoise missing argument Created with: gclient setdep -r src/third_party/perfetto@69356444050a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I05328a8efca26bb046dd7d5a523f55d4b42b68a4 Reviewed-on: https://chromium-review.googlesource.com/1238695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593210}
-
Jungshik Shin authored
This roll includes only one change to fix BCP 47 language tag validation for v8. https://chromium.googlesource.com/chromium/deps/icu/+/c52a2a25 TBR=gsathya@chromium.org Bug: v8:8135 Test: v8 - test262/intl402/Locale/constructor-unicode-ext-valid Change-Id: Ida7ed667898c25d4cec6ff20c86d87e07b962c5a Reviewed-on: https://chromium-review.googlesource.com/1238469Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593209}
-
Ian Kilpatrick authored
This allows developers to specify the size which percentages in the block (wrt child writing mode) direction should be resolved against. Currently inline percentages still resolve against the available inline-size. This adds a "OverrideContainingBlockPercentageResolutionLogicalHeight" field on layout box, which both the logic for LayoutBox::ComputePercenatgeLogicalHeight and LayoutBox::ComputeReplacedLogicalHeight use. They follow similar logic to LayoutGrid, in that in quirks mode, percentages are treated as indefinite (doesn't "walk-up" the tree). Change-Id: I256381687d2eed7693a908074f7f5032d5963e2b Reviewed-on: https://chromium-review.googlesource.com/1232206 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#593208}
-
Yunlian Jiang authored
When linking with lld, the lgcc_s is removed from linkage and this makes Nacl failed to load. This cl adds -lgcc_s before --as-needed so that libgcc_s is kept. BUG=chromium:884017 TEST=nacl_helper works when linking with lld. Change-Id: I3a8503787c4b05b7f777c82bc279ae1005d604d1 Reviewed-on: https://chromium-review.googlesource.com/1226452 Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#593207}
-
Keishi Hattori authored
This makes RuleData GarbageCollected so we can remove HeapTerminatedArray usage. Bug: 581698 Change-Id: I2d2f11e21b04e3c7eae6428cb8c030d4bf4f91b1 Reviewed-on: https://chromium-review.googlesource.com/1221606 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#593206}
-
rbpotter authored
Fixing: (1) Action links fell out of the tab order because destinations_dialog and destinations_list were not correctly importing action_link.html (2) Absolute positioning of icon to set it on top of the cr-input in print_preview_search_box led to icon getting misplaced when browser window size changed. Fix by adding a prefix in cr-input. (3) Destination icon was shrinking for large font sizes due to using flex layout. Make icon fixed size (20px, per spec). (4) Ensure there is enough margin on the "Manage" link to show the focus outline. Bug: 884600, 885090, 886593, 887227, 887229 Change-Id: Ic7d910ad1460e8d457186b9c189797f12db4de5f Reviewed-on: https://chromium-review.googlesource.com/1237137 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593205}
-
rbpotter authored
Bug: 886553 Change-Id: I96f6e8381386b2b73ba4cfe60714e84534c24f12 Reviewed-on: https://chromium-review.googlesource.com/1237138Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593204}
-
Eugene But authored
Underlying issue was fixed here: https://chromium-review.googlesource.com/1226195 Bug: 776330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3b1bbffd84e5bdc315c0ca32c1f8ff89747d5abc Reviewed-on: https://chromium-review.googlesource.com/1238379Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593203}
-
W. James MacLean authored
In CL https://chromium-review.googlesource.com/c/chromium/src/+/1169528 we modified CreateGesture to always attach a unique_touch_event_id, if available, to GestureEvents it creates. This facilitates event targetting by not attempting to re-hittest these events in RenderWidgetHostInputEventRouter. Normally an id of 0 indicates an Android ContentView event which must be handled separately. However, adding ids to all GestureEvents has lead to the associated bug, since GestureEventDataPackets for TOUCH_TIMEOUT can now share a unique_touch_event_id with another event in the same Sequence. In this case, we shouldn't mistakenly ack events with source TOUCH_TIMEOUT from the tail of the queue. Bug: 879961 Change-Id: I65dd669cda6c276d6d73bb56b0d761694cb03c82 Reviewed-on: https://chromium-review.googlesource.com/1232592Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#593202}
-
Josh Karlin authored
Removing ParentExistsForSubFrame metric as it was only briefly necessary to verify that the code worked as intended. Bug: 884233 Change-Id: I6934f92d295e03bf2715fc3460333dca63f6f53f Reviewed-on: https://chromium-review.googlesource.com/1234224 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#593201}
-
Olivier Robin authored
With frame messaging, the JS messages are filter sooner than with window ID filtering. The result is that the race condition on form submission is now issue. Pass the form data on submit event to avoid having to do a new JS call. Bug: 418827, 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I64b0f6232e5ed46aa3f91cf7134cbe2c55c9c440 Reviewed-on: https://chromium-review.googlesource.com/1236277 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593200}
-
A Olsen authored
DeviceSettingsProvider in chrome/browser/chromeos/settings has an undesirable dependency on g_browser_process, which it uses to access the LocalState singleton. This CL removes the dependency on g_browser_process by passing in LocalState explicitly. Note that the tests and test helpers still depend on BrowserProcess or TestingBrowserProcess, which they use to initialize and access the LocalState. For tests in the settings package, I need to find a way to remove this dependency in a follow up CL, so that the settings package along with tests & test helpers can be moved out of chrome/browser. See go/cros-untangle2 Bug: 446937 Change-Id: If9b14940f05ceef1fa8f33e612df22d3d9173d8f Reviewed-on: https://chromium-review.googlesource.com/1233711Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593199}
-
Aga Wronska authored
Bug: 870049 Change-Id: Ib5927fd6a095ae5c60bea0eddbef70cb2060f4ba Reviewed-on: https://chromium-review.googlesource.com/1192583 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#593198}
-
Javier Ernesto Flores Robles authored
Only add "show all" when Manual Fallback is disabled. Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I82a7a9818965716e19c57b78e13f196f52b34088 Reviewed-on: https://chromium-review.googlesource.com/1235673Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#593197}
-
Olivier Robin authored
- Known bugs: navigation buttons do not work in iframes. - Payment Request is only enabled in main frame. - This CL does not enable autofill in iFrame by default. Bug: 881364, 792642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia18b8a0543d0c754a22d3ee9287171f6807f5f5c Reviewed-on: https://chromium-review.googlesource.com/1233575Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593196}
-
Kush Sinha authored
- Actual value of |maximum_backoff_ms| for |kBackoffPolicy| in |GaiaCookieManagerService| is 4 hours but the documentation/comment claims that it is 15 minutes. Fix the comment. - Fix lint error for an if-else statement. Change-Id: If957966b754e8a33ab0531eef7d64ee871bdf5a0 Reviewed-on: https://chromium-review.googlesource.com/1238440Reviewed-by:David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#593195}
-
Javier Ernesto Flores Robles authored
Observe the last focused field to validate it is secure before filling a password Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ide4407ea51b315c68c50fa010f256cde93f5eb26 Reviewed-on: https://chromium-review.googlesource.com/1221217 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#593194}
-
Dave Tapuska authored
The background can be painted underneath occasionally. When we have a fullscreen element indicate the backdrop's color. BUG=886544, 785001 Change-Id: I17d2533779abc68b14bc8af732f182dd32e963f0 Reviewed-on: https://chromium-review.googlesource.com/1234232 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#593193}
-
John Budorick authored
Bug: 794372 Change-Id: Ic68afc2f66f340cf807406c3446567f886cd005e Reviewed-on: https://chromium-review.googlesource.com/1237409Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593192}
-