- 14 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010140700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/m0wda58U4knKyUUpL79c-o7EHUHN2PBklk5kEjWgQgwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162263578,b/162264034,b/170670538 Tbr: help-app@grotations.appspotmail.com Change-Id: If6d25e89eb610714d5daf9f3d91b0a9469a461e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471139Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817086}
-
Sylvain Defresne authored
The two imports are unnecessary as none of the variables that are defined in the imported files is used. Remove the imports since they are not useful. Bug: none Change-Id: Id6d87ed3c43a4804a87161e48241d2f945c3ba92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471417 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817085}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c9f31beb6db..a7b30cd95fed 2020-10-14 navil@google.com chromeos_config: Promote eve-full to active. 2020-10-13 engeg@google.com release_stages: Increase signing timeout to 4 hours If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iaa32608482c3dcdf49943554b20770e81d3d9923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817084}
-
Sylvain Defresne authored
Chromium no longer uses sources assignment filter, so the comment above the ios_sdk_developer_dir variable no longer applies and it can be removed. Bug: 1018739 Change-Id: I6e77678be8a176fe912c51a61536459179f21f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471456 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817083}
-
Alex Turner authored
This will help determine whether the API leaks any cross-site entropy about users and, if so, how much. Bug: 973801 Change-Id: I244130bfd50b0b745a7c215d3a01490b1443cd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436620Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817082}
-
dpapad authored
In most cases it is replaced with native click(), and in one case replaced with MockInteractions.down(). Fixed: 812035 Change-Id: I977d3f920a37dc494c78d22ab901c9a4f61b12c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468178 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817081}
-
Henrique Nakashima authored
Split TabWindowManagerImpl out of interface, then move the interface, the impl and the factory to the tabmodel module. Narrow down the interface to be a bit smaller and more generic. Bug: 1112922 Change-Id: I1c76e4ad86fae7435e31211ae857a8d772366b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461950Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#817080}
-
Sunny Sachanandani authored
Swap chain and DXGI handle shared image backings are not marked as cleared which causes SkiaOutputDeviceGL to fail importing using shared image representations and fallback to importing from MailboxManager even though the mailboxes are associated with the shared image backings. Bug: 1136194 Change-Id: I5951574875420cafe2dc48b9bed6164a7b360d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469897Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#817079}
-
Edward Lesmes authored
Remove "TEAM: ios-directory-owners@chromium.org" and "OS: iOS" tags from OWNERS files, as they are inherited from ios/OWNERS. This will make the CLs to migrate to DIR_METADATA files much easier to review. Bug: 1113033 Change-Id: I6db954f83f59d610c4277895527e64e273d88253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469358 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Ben Kelly authored
There was a minor memory regression when we landed the cache.addAll() abort logic. To minimize this avoid creating the AbortController when there is only one request. Bug: 1130781,1133989 Change-Id: I19a324c0ce14dd100b5dc350a17a60f7172709a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461410Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#817077}
-
Caleb Raitto authored
Bug: 973801 Change-Id: I5c7e256f39008f350de7df990cdd6daac632aec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468497Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#817076}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.18-r1 to 87-4277.0-1602498224-benchmark-87.0.4280.19-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic39576d754215f79be93f81a95226b317dc60c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471657Reviewed-by:
-
Minggang Wang authored
Currently, WorkerMainScriptLoader holds a network::mojom::ResourceLoadInfoNotifier remote to notify the loading stats of the main script for dedicated workers (PlzDedicatedWorker) and shared workers. This patch leverages ResourceLoadInfoNotifierWrapper created by FetchContext to send the loading notifications for the main script and removes the original implementation. Besides, we invoke ResourceLoadInfoNotifierWrapper::NotifyResourceLoadInitiated firstly to initiate the ResourceLoadInfo struct before starting to receive the response. Bug: 860403 Change-Id: Iecbed09464814c08c34161d530522b88da9ea19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421209Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#817074}
-
chrome://appsCarlos Frias authored
This CL adds a new context menu option to enable/disable Run on OS Login for a web app listed in chrome://apps list. The context menu option will be shown only when the web app is locally installed and the feature flag for Run on OS Login is enabled. Handler for UX activation is to call OsIntegrationManager class and install or uninstall the Run on OS Login hook as indicated by the user. Testing was performed by manual testing in chrome://apps by right click on app icon, and verifying the new UI option is only shown for installed web apps, and also verifying the activation handler calls the OsIntegrationManger's APIs. The manual testing guidance document describing these tests can be found here: https://docs.google.com/document/d/1XlvL17xAGivmQNiHaUCYBcGtnkPpZ0GijjjWpCma5H4/edit Bug: 1110407 Change-Id: Ifef1cb57068b0836248f3a780ccff6e051abaf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401902 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#817073}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/5a4f76123806..7df418b6dc0a $ git log 5a4f76123..7df418b6d --date=short --no-merges --format='%ad %ae %s' 2020-10-13 vasilvv Replace QuicheOptional with absl::optional. 2020-10-13 bnc Change large header size in EndToEndTest.WayTooLongRequestHeaders. 2020-10-13 vasilvv Remove quiche::QuicheStringPiece and quiche::QuicheStringPieceHash. 2020-10-13 fayang Replace quiche::QuicheStringPiece with absl::string_view in tls_handshaker.cc 2020-10-13 quiche-dev Internal QUICHE change 2020-10-13 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-12 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-12 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-12 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-12 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-12 fayang Consider address has been validated by successfully processing a HANDSHAKE or 1-RTT packet. 2020-10-12 quiche-dev Do not process a write-closed QuicEventManagerStream. 2020-10-12 dschinazi Update Android Conformance Test QUIC test 2020-10-12 quiche-dev Deprecate --gfe2_reloadable_flag_quic_check_fallback_null. 2020-10-12 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-11 wub For QUIC BBRv2 STARTUP, factor out two pre-conditions to check bandwidth growth and losses: !full_bandwidth_reached_ && congestion_event.end_of_round_trip. 2020-10-10 ianswett Add the check for enough loss events into the Bbr2NetworkModel::IsInflightTooHigh() method to simplify the code. Created with: roll-dep src/net/third_party/quiche/src Change-Id: I5375232c82737398e4a739f2ad80fa9ae0172063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469516Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#817072}
-
Fabio Tirelo authored
TBR=bradnelson@chromium.org Bug: 1138451 Change-Id: I41e0a4db460870b5865964cda9dd08f51ef6a905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471077Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817071}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7a2248784fe656a933e97fb6b88d79bba6d499ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470341Reviewed-by:
-
Rakib M. Hasan authored
This will allow CL's uploaded by the chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com to bypass the AUTHORS file check so that it can submit CLs. The service ID is uploading CL's from the following infra.cron job, https://ci.chromium.org/p/infra/builders/cron/create-weblayer-skew-tests. The recipe checks Chromiumdash for new Anroid releases in beta and creates skew tests for Weblayer for each release. The recipe makes changes to src/testing/buildbot/variants.pyl in order to create skew tests. Entries like WEBLAYER_CLIENT_SKEW_TESTS_NTH_MINUS_TWO_MILESTONE in variants.pyl are used to generate skew test suites in the buildbot json files. Bug: 1137911,1041619,1099017 Change-Id: I6b1928d123197defba2a8eb4beb3cff4e866019f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469400 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#817069}
-
Mark Cogan authored
So that there is a mechanism to view the complete image title for images that have them (for example, on xkcd.com), this CL changes how context menu title truncation is performed: - The web layer no longer truncates context menu titles; it applies a simple heuristic to determine what the title should be (a url, an image title, etc), and then passes on this decision (the "menu title origin") in the context menu params. - The embedder's context menu delegate handler (in this case, the BVC) is now responsible for doing any menu title truncation. BVC now truncates menu titles that aren't image titles. - Instead of round-tripping a (by definition) long NSString through a transition to a string16 so that gfx::TextElider can do the trun- cation, instead just use NSString methods to truncate, appending a single ellipsis character if truncation takes place. Note that now truncation is done at the end of the title (which is more typical for truncating URLS), not in the middle as before. - Unit tests now test that the correct menu title origin is assigned, and an integration test tests that menu title truncation is done (or not done) correctly. Other cleanup was done as part of this fix: - Adds //ios/web/public/ui as a public dep for the //ios/web/public gn target; this fixes the issue where XCode wasn't seeing the files in that directory because they weren't in the gn dependency graph. - Fix deps issues this addition makes visible. - Moves the partial-text-match EG2 matcher out of the sad tab egtest and adds it to the general Chrome matcher inventory, with some clearer naming. Bug: 1136473 Change-Id: I661fecaa20bb9f98299ef692342bb93d30b77ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464267 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#817068}
-
Marc Treib authored
Tightening up DCHECKs, removing dead code paths, updating comments. Bug: 647505 Change-Id: I76dab7a9da0cf02252e545f2c839e4079d2270d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470084 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817067}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cac0442277f7..73b70229af3a 2020-10-14 cwallez@chromium.org dawn.json: Expose the driver version in the adapter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I233f14d1cded1a1f165444efacf775f06089c7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471137Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817066}
-
Muhammad Hasan Khan authored
In this change we're adding a test that simulates the same condition that was addressed in https://crrev.com/c/2381050 i.e. we ensure that ArcInstanceStopped is not called on new instances of arc_container_client_adapter if they're created during handling of ArcInstanceStopped event. BUG=b:164816080 TEST=components_unittests --gtest_filter='ArcContainerClientAdapterTest*' TEST=revert the fix and ensure that the test fails Change-Id: Ibe4911664be8b81a16c6c25a282121f4d83323bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459528 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#817065}
-
dpapad authored
Removed BigInt and BigInt64Array, URLSearchParams#keys from externs/pending.js since these have been added to the default compiler externs. Couple of notes: 1) It is the first time a roll is fetching the closure compiler binary and externs from NPM. 2) Any updates to chrome_extensions.js have been intentionally reverted from this CL, since they cause type-checking errors. Instead, a parallel effort is underway to stop using chrome_extensions.js in Chromium. Bug: 1137293,1137350 Change-Id: I6a120b7a8e75aefa8a5dd3ce3c8d03fa33b3f745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464091 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#817064}
-
Colin Blundell authored
This infobar will be reused by WebLayer. The componentization is straightforward as all //chrome dependencies have been removed in prior CLs. Bug: 1116095 Change-Id: I9315ac43591e516dbef59b61aeaadf18505f14b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470657Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#817063}
-
dpapad authored
By using the new |resource_path| attribute an unnecessary intermediate ui/webui/resources/js/jstemplate_compiled.js file which was using <include> and |flattenhtml| is eliminated. Bug: 1132403 Change-Id: I74c1c33b567df3023ccba2b0fed87da097ff37ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470332 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I124bec778c1fc7376b463b78bb323538cd6a5395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469837 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817061}
-
Achuith Bhandarkar authored
BUG=chromium:968349 TEST=local Change-Id: I51a41bee08492482ee2ef0a8e98b6e6c7b61e943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470323 Auto-Submit: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#817060}
-
ckitagawa authored
Check for first paint before proceeding. Bug: 1136907, 1136956 Change-Id: Ibcd835a07ed9ba120873b07081824f03674fc41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469262 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#817059}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ie22085a74d30b42b135365f72f1e6fe6dd02a926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469228 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#817058}
-
Aaron Leventhal authored
TBR=dmazzoni@chromium.org AX-RelNotes: n/a Bug: 1137892 Change-Id: Iaa1108d255b568eb2866b8a82c70efe06ff61837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469097 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#817057}
-
Josh Nohle authored
The Bluetooth socket implements its own input/output streams. During Read()/Write(), we wait until a base::WaitableEvent is notified that the read/write finished. Previously, if Close() is called while the read/write is waiting, the base::WaitableEvent will never be notified. In this CL, we notify the base::WaitableEvent after closing the stream. In practice, this CL fixes the blocking Read() on the receiving Chromebook after the first successful file share. The Read() was waiting for more bytes to appear in the receive stream, which would trigger ReceiveMore(), but those bytes never came because the transfer already completed. This blocking Read() prevented receiving again after the first successful file share. See the following debugging logs from the receiving Chromebook at the end of a successful transfer; the fix is explicitly noted in the logs: https://paste.googleplex.com/4940385051738112. Fixed: 1137673 Change-Id: I0e15aeb5ece9609faea7549b8617a404cb2c145c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467336 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#817056}
-
Xianzhu Wang authored
Previously painter memory usage was reported through ContentLayerClient::GetApproximateUnsharedMemory() which doesn't work in CompositeAfterPaint and unified PaintController because most of the memory usage is not per layer. Bug: 922642 Change-Id: Ie353f44700a5f0fd2bafea156854cbaaee73a87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459866Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817055}
-
Anastasiia N authored
Migrate signin_error_notifier to the new method so it doesn't use HasDummyGaiaTokenSync. Bug: 1135980 Change-Id: I76bdd810bcfdb5952868469b23898b1b10644e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454081 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#817054}
-
Joe DeBlasio authored
This CL breaks out three of the most common kUnspecified safety tip interactions into their own interactions. Fixed: 1137854 Change-Id: I7735b66a855230af43075717e9581587e0d13a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468937 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817053}
-
Dirk Pranke authored
This reverts commit 94d8f7cb (r814499) while updating to the latest revision of catapult (f654dd2f). The Python3 changes that I had landed in the earlier catapult roll are causing crashes in v8, so this reverts them. Unfortunately these changes require manual rolls since the list of python dependencies changes with the roll :(. Tbr: johnchen@chromium.org Tbr: ntfschr@chromium.org No-Presubmit: true Bug: 941669 Bug: v8:11015 Bug: v8:11014 Change-Id: I01b450e6384d1841ba24a90e5f0fc96222049ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469282 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#817052}
-
David Roger authored
The UI now shows the avatar. It also listens to changes in the avatar and profile colors. The input is now fully wired and propagates the profile name to the profile info cache. Screenshot: https://screenshot.googleplex.com/4MKQd5N6pNjLH45.png Bug: 1130945 Change-Id: Ie4526520df36a96fb4ca3d4baaf0a2df158a4bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461321 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#817051}
-
Yuke Liao authored
There is a plan to nearly double the compile load on linux-lacros-rel, and in order to mitigate the impact on CQ cycle time, bump the goma jobs from 80 to 150. Bug: 1129223 Change-Id: I2699dd626b14db2239cc4a72f15955cfa75ff10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458367 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#817050}
-
David Tseng authored
Radio buttons, switches, and check boxes should always be visited during all types of navigation. The one corner case here is if there are clickable descendants for the node; this can occur only if an author creates a complex subtree for the node. R=dmazzoni@chromium.org Test: browser_tests --gtest_filter=ChromeVox*.AriaRadios Change-Id: I6306404f8a303164f4af4a9e3f4b5bde3a261502 Fixed: 1136253 AX-Relnotes: makes ChromeVox output aria radio buttons that don't receive focus. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468076 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e8c80d06a62a..49681b598556 2020-10-14 petermarshall@chromium.org cleanup: Pass settings/experiments to generateJSFrameEvents If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I102a6a2bc3af5d0c85d814ed6dcf8b45e0706a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471183Reviewed-by:
-
Sylvain Defresne authored
All of Chromium and third-party dependencies have been converted away from sources assignment filter, so update the documentation to say that the conversion is complete. Bug: 1018739 Change-Id: Ia47e6e6054744e5aeaccef638e5b081af1abdfe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471418 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
