GitLab

Bug: 830892
Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045
Reviewed-on: https://chromium-review.googlesource.com/1158719Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580163}

Trying to set a decryption passphrase while it's not required triggers a
DCHECK in ProfileSyncService. For that reason, onPassphraseEntered
already checks that the engine is (still) initialized. This CL adds an
explicit check that a passphrase is required, since it's possible that
the engine has actually shut down *and restarted* in the meantime.

This problem was exposed by https://crrev.com/c/1148392, but I believe
it's always been there, just extremely unlikely to occur. It's basically
https://crbug.com/507557 which was never fully fixed.

Bug: 856179
Change-Id: I6f7cfc9643c0c93fadbd6ecbc0e39364791e3451
Reviewed-on: https://chromium-review.googlesource.com/1158366Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580162}

No need to have separate NG lines for tests that behave exactly as in
legacy.

TBR=eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I89c6a65287aba250c8287e26c7983040e145b960
Reviewed-on: https://chromium-review.googlesource.com/1158415Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580161}

This CL extracts some utility methods for converting a bookmark node
to a bookmark specifics and vice verse  into a new file
bookmark_specifics_conversions

This is in preparation for a later CL that will requies access to the
same functionality.

Bug: 516866
Change-Id: Iaa9f11320d9db8b8c0479aaf0137cfdbf5e2cef0
Reviewed-on: https://chromium-review.googlesource.com/1160227
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580160}

Bug: 870151
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8e1fc458e9316be19e35b5e0f3edaefb5d3244f3
Reviewed-on: https://chromium-review.googlesource.com/1132564Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580159}

IdentityManager is the recommended API to access the
Google account used by the user and SigninManager is
deprecated.

Convert ClearBrowsingDataHandler to the new API.

Bug: 798411
Change-Id: I3dc831307cac65dd42369d7482b9a0b794f02048
Reviewed-on: https://chromium-review.googlesource.com/1126384
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580158}

We already did reset the exclusion space when entering a new formatting
context, but when leaving it, we'd return the final exclusion space for
that inner formatting context to the parent algorithm. Although it was
ignored by the parent algorithm, let's just make sure that we don't
return it at all.

Exclusion spaces are also ignored by legacy layout, which is fine, since
we never let the two engines cooperate inside one and the same
formatting context.

Add DCHECKs that verify that we don't "leak" exclusion spaces across
formatting context boundaries.

No behavioral changes intended.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: If025a5d4b5b6c96399f5719aed6cd3ab4d76c556
Reviewed-on: https://chromium-review.googlesource.com/1158409Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580157}

This CL also rerun the query for 'android-go-perf' with:

./tools/perf/core/retrieve_story_timing.py -c 'android-go-perf'  --output-file=tools/perf/core/shard_maps/timing_data/android_go_timing.json

Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Icfc132854aa83d35a9e27cbd5dfc42aeae5b3361
Reviewed-on: https://chromium-review.googlesource.com/1158966Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#580156}

The format was changed in M-57, so legacy code can now be dropped
as M-69 has been branched.

Bug: 661633, 691800
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8cd160acfb994091658939662534d578881c981c
Reviewed-on: https://chromium-review.googlesource.com/1158698
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580155}

This CL adds a user policy which will control the transition from Public session
to Managed session.

Bug: 865947
Change-Id: I50fabd8646409382fbe8c5ff49a6349c77b2fa9b
Reviewed-on: https://chromium-review.googlesource.com/1156584
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580154}

This CL ports the GCMAccountTracker unittest to IdentityTestEnvironment;
this is possible now that AccountTracker is no longer using the
internal signin classes, and hence the GCMAccountTracker unittest does
not need to be aware of those internal signin classes to construct an
AccountTracker instance.

This CL completes the conversion of GCM away from the internal signin
classes and rips out the no-longer-needed dependencies.

TBR=msarda@chromium.org

Bug: 809923
Change-Id: I78f999fc66543b8d64b85053fbcf72973ce8ac2e
Reviewed-on: https://chromium-review.googlesource.com/1152968
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580153}

http://crrev.com/40f8e9a571636737 gained the stripped binary size of
chrome by 40kB (147306728 to 147347688), which is mainly due to an extra
parameter set up on BindStateBase for each base::Bind() caller.

This CL removes the extra argument by merging it to single function with
another parameter. So that the binary loses back to the original size.
(147347688 to 147306728).

Bug: 869098
Change-Id: I7b60797c16a00472e9312466fdd2434395d8bbf7
Reviewed-on: https://chromium-review.googlesource.com/1158093
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580152}

We already report the total PrivateMemoryFootprint (PMF) across all
processes but this totals all the memory used only by renderers. This
should be helpful for A/B testing and detecting regressions w.r.t.
renderer memory usage.

The totals are reported to a UMA histogram named
Memory.Total.RendererPrivateMemoryFootprint

Change-Id: I0ba55ffb91966593a2106566ce50ade3d6039caa
Reviewed-on: https://chromium-review.googlesource.com/1158706Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580151}

https://pdfium.googlesource.com/pdfium.git/+log/f733d7da42cd..649929af2140


git log f733d7da42cd..649929af2140 --date=short --no-merges --format='%ad %ae %s'
2018-08-02 thestig@chromium.org Mark some arrays as constant.
2018-08-02 thestig@chromium.org Simplify CFXJSE_FormCalcContext::unfoldArgs().
2018-08-02 thestig@chromium.org Remove some parameters that are non-const references.


Created with:
  gclient setdep -r src/third_party/pdfium@649929af2140

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I19c95d9c766fad375d1088ab88e99cbc5a84368d
Reviewed-on: https://chromium-review.googlesource.com/1159786Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580150}

ServiceWorkerProviderHosts for service workers are precreated before
the renderer process is known. Before this CL, it was owned in a callback
inside EmbeddedWorkerInstance, and then moved to
ServiceWorkerContextCore once the renderer process was known and
Mojo bindings created.

This created ref cycle as seen on the linked bug:
ServiceWorkerObjectHost -> ServiceWorkerVersion ->
EmbeddedWorkerInstance -> ServiceWorkerProviderHost ->
ServiceWorkerObjectHost.

The solution is to make the ServiceWorkerContextCore always
own the host, from inception. This is possible after
https://chromium-review.googlesource.com/c/chromium/src/+/1159542.

Bug: 854993
Change-Id: I6b8e6d27d008fcd2a5e83af17eaf03a09d9cd5a4
Reviewed-on: https://chromium-review.googlesource.com/1159544
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580149}

https://chromium.googlesource.com/chromium/src/+/7721d7fa8cca6e1006137ca5de74c9899aa8ebf3
enabled the warnings by default in Chromium build but Abseil does not like this warning.

Fix confirmed by patching DEPS roll and compiling WebRTC locally.

TBR: mbonadei@chromium.org
Bug: webrtc:9583
Change-Id: If1750a3823d502478cc83cc49e2d8ffbc7ef2e8f
Reviewed-on: https://chromium-review.googlesource.com/1159375
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580148}

The properties used to serialize the WebStateList opener-opened
relationship was changed in M-59, so the support for the legacy
format can be dropped now that M-69 has been branched.

Bug: 704941
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I63180a9be5d47a507ddcb5c1c37f6b3512cbfa94
Reviewed-on: https://chromium-review.googlesource.com/1158696
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580147}

Record how much time it takes to perform full and partial deletions.

Change-Id: I7494e96c8aaf96434389df19c85a3b40c3cdd0a4
Reviewed-on: https://chromium-review.googlesource.com/1154969Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580146}

This reverts commit 64ab6403.

Reason for revert: Suspected of making 
CrostiniInstallerViewBrowserTest.InstallFlow very flaky on 
linux-chromeos-rel

Original change's description:
> CrOS crostini: sshfs mount immediately when container starts
> 
> Perform sshfs mount to termina/penguin immediately when container
> starts.  Mounting code has moved from the chrome.fileManagerPrivate
> extension functions into CrostiniManager.
> 
> This change will make FilesApp more responsive to users who are
> likely to use terminal or some other crostini app before using FilesApp.
> 
> Bug: 846917
> Change-Id: I9fc246e45e54390e7a75f15a5571a24218cf2d5c
> Reviewed-on: https://chromium-review.googlesource.com/1158317
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580094}

TBR=joelhockey@chromium.org,nverne@chromium.org

Change-Id: Ib00e4417faaa482d62f03bed708dd46b1e0f7902
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846917, 870289
Reviewed-on: https://chromium-review.googlesource.com/1160541Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580145}

This CL is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/788410

This CL makes the Chromium HW video factories implement the new
interfaces directly. It also adds SW codecs, simulcast, and SW fallback
codecs manually, instead of relying on WebRTC to do this. This will
give Chromium more flexibility in the future, and will allow us to
simplify the WebRTC code, since it's only Chromium that uses some of
these features.

Bug: webrtc:7925
Change-Id: Ib66ec75827363dc9e0985c35a6de936ca8f3a523
Reviewed-on: https://chromium-review.googlesource.com/1100463Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Anders Carlsson <andersc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580144}

This reverts commit b0f5b21b.

The difference from the original patch is a kAborted state in
MimeSniffingURLLoader. DCHECKs will capture if something wrong. Also, Abort()
stops to read the body and receive messages from the source URLLoader. We can
ensure that the loader is stopped to work immediately in this way.

Original description:

> This CL adds MimeSniffingThrottle which can intercept the response in
> ThrottlingURLLoader. Typically mime sniffing happens in network::URLLoader and
> MimeSniffingThrottle is skipped in this case. If a request goes to a service
> worker or other interceptors, the MimeSniffngThrottle intercepts the response
> when a set of the mime type and the url is eligible to sniff the mime
> type. Sniffable mime types are defined in net::ShouldSniffMimeType(). When a
> mime type for performance sensitive components like "text/html",
> "text/javascript",or "text/css" is provided, it doesn't sniff.

Bug: 858975
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I51648def32e147eb127ec6efbb59ed2353cfba56
Reviewed-on: https://chromium-review.googlesource.com/1160133Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580143}

When building using jumbo, files get merged and
variables with the same name may
end up in the same namespace and conflict.

This happens for the constant kLocalGuidSize in autofill/core/browser.
The variable is moved to a util file in
common.

Bug: 869381
Change-Id: I038ef40acd5617f9d9d1e18c81a2fcce55cab8eb
Reviewed-on: https://chromium-review.googlesource.com/1158544Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580142}

This method, used for debugging (chrome://sync-internals), has no clear
semantics if a datatype hasn't been started. This is specially true with
future work in mind where we plan to introduce different operating modes
(regular vs ephemeral) that are bound to a start-stop configuration
cycle.

We also migrate away from callers having to use BindToCurrentSequence(),
since there seems to be no reason for it (and is really weird after
having recently introduced ModelTypeControllerDelegate).

Bug: 866814
Change-Id: I653e1ee117883feb42e032faac85d5ba14d28748
Reviewed-on: https://chromium-review.googlesource.com/1160229Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580141}

https://android.googlesource.com/platform/external/perfetto.git/+log/c99a49a615e8..64f2b4dce29f


git log c99a49a615e8..64f2b4dce29f --date=short --no-merges --format='%ad %ae %s'
2018-08-02 hjd@google.com Merge "perfetto-ui: Add engine controllers"


Created with:
  gclient setdep -r src/third_party/perfetto@64f2b4dce29f

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I25150bb6b53c328e5afcee2fb27a94ea6307cc33
Reviewed-on: https://chromium-review.googlesource.com/1160321
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580140}

This TODO was already addressed as part of https://crrev.com/c/1030332
- we now only create the NCPA when not in incognito mode.

R=peter@chromium.org

Bug: 835232
Change-Id: I4023252075c177a5741e8a90f86b2144a8ae5f18
Reviewed-on: https://chromium-review.googlesource.com/1160301Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580139}

Many call sites which use this function do not
bother about the clearing the typing but they use
this function which is confusing.
Rather we will use FrameSelection::SetSelection
and pass default options now.
This CL does it from the GranularityStrategyTest.

Bug: 867563
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I4e88d64fb91b5b1fb7848ec74b216a7fdda7f8bf
Reviewed-on: https://chromium-review.googlesource.com/1159940Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#580138}

Use Maybe version of BooleanValue fallback for generated bindings.

Bug: v8:7786
Change-Id: I8cc17d532840caca2354d6a89be5abe952e47c4a
Reviewed-on: https://chromium-review.googlesource.com/1160201Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580137}

It is flaky on Linux Tests (dbg). E.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/51783

Bug: 851655
No-try: True
No-presubmit: True
Change-Id: I1413c50f37054dc073afc0b6aa2fb281c11ca2ac
Reviewed-on: https://chromium-review.googlesource.com/1160502Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580136}

This patch makes it easier to track the events dispatched by ServiceWorkerContextClient,
similarly as https://chromium-review.googlesource.com/1156334 .

Events modified in this patch are as follows (in the order of appearance):
* ActivateEvent
* BackgroundFetchAbortEvent
* BackgroundFetchClickEvent
* BackgroundFetchFailEvent
* BackgroundFetchedEvent
* DispatchCookieChangeEvent
* ExtendableMessageEvent
* InstallEvent
* NotificationClickEvent
* NotificationCloseEvent
* PushEvent
* SyncEvent
* AbortPaymentEvent
* CanMakePaymentEvent
* PaymentRequestEvent
* OnNavigationPreload

Bug: 860394
Change-Id: Ief11e8a755256ccba5c066d94f3481bd52ed2bcb
Reviewed-on: https://chromium-review.googlesource.com/1159939Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Momoko Hattori <momohatt@google.com>
Cr-Commit-Position: refs/heads/master@{#580135}

These tests are Slow not only on Mac10.13, but in general.
Let me update the entry not to be Mac10.13 specific, and
not to be virtual/outofblink-cors(-ns) specific.

Bug: 869800
Change-Id: I76f13714b93b314a14c16dae5e110a841547d92c
Reviewed-on: https://chromium-review.googlesource.com/1160136Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580134}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0283df9b..8319a20f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8b4330fdeafedd9ecf26354838839a635fb9bfb6
Reviewed-on: https://chromium-review.googlesource.com/1159999Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580133}

The account cell and Google services cell are moved into the account
section.
The changes is visible when the user is signed out, the Google services
cell doesn't share anymore the same section than the sign-in promo.

When signed out:
Before:
https://drive.google.com/open?id=15Y-rwBi292Ii8mNm0x6E0mRWl1sQN-Gd
After:
https://drive.google.com/open?id=17WgNeKqKzZPe0PcGhmY2832L44eoRekD
Mock:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5b2bed3b#slide=id.g3ae6bac383_31_11

When signed-in:
Before:
https://drive.google.com/open?id=18qP0MZSMwlJZkXBTUq9cvt6q7tbaslaR
After:
https://drive.google.com/open?id=16yaGI24UmZ3ufb3lrnfbxW91C7SEre7L
Mock:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5b2bed3b#slide=id.g3ae6bac383_31_43

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I163053b2355947df67c2df7d8305a4e07ecb39b8
Reviewed-on: https://chromium-review.googlesource.com/1158506Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580132}

This CL implements ConsentBumpFragment - a SigninFragmentBase subclass
that provides an easy option to enable all features gated by unified
consent. This CL also modifies SigninActivity to use it as a container
for this fragment.

Bug: 869426
Change-Id: Ibbe64a674aad4ac2a05afca83424449f52f9a683
Reviewed-on: https://chromium-review.googlesource.com/1159068Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580131}

This CL allows SimpleURLLoader's to successfully load file:// URLs, ie when
using FileURLLoaderFactory.

Prior to this CL, even on the file specified in the file:// URL is written
successfully, the URLLoaderCompletionStatus instance is passed to the
URLLoaderClient from FileURLLoader::OnFileWritten, had only with the
|error_code| set.

SimpleURLLoader checks other URLLoaderCompletionStatus class members,
(eg |decoded_body_length|) in order to consider the load actually successful.

BUG=773295,844928

Change-Id: I1040775fad2af7f0eb88f81e48bb355d48e5fc31
Reviewed-on: https://chromium-review.googlesource.com/1159042Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#580130}

The tests were waiting for a request to receive headers, but then
assuming that the request had in fact completed receiving the entire
response, including the body.

Bug: 869551
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2771bb0f786dd18e74423941364d51607fb8b7f8
Reviewed-on: https://chromium-review.googlesource.com/1159587Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580129}

These tests were set cookie settings on a CookieManager interface, and
then sending out a network request on a URLLoaderFactory interface.
Since Mojo events aren't ordered, there's no guarantee that the request
will be sent after the new settings are set.

This CL fixes that issue by flushing the CookieManager interface after
updating the cookie settings.

Bug: None
Change-Id: I1d355a81f935f40a8e1270ca49234bc6b5eb4a86
Reviewed-on: https://chromium-review.googlesource.com/1159192Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580128}

The test wasn't waiting for the secondary NetworkContext to be created,
so it could end up that the secondary NetworkContext was created only
after the primary one was destroyed.

Bug: 869551
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iaefbb98553175cf4e3784017adafe227888c588b
Reviewed-on: https://chromium-review.googlesource.com/1159588Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580127}

This patch only includs an implementation of PaymentResponse.retry() in
renderer and mojo side. We should implement UI in browser side in follow
up CLs.

Once this patch is applied, most test cases will be passed except when
the UI is required.

Intent to implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI

Test:
  //components/payments/core/payments_validators_unittest.cc
  //third_party/blink/renderer/modules/payments/payments_validators_test.cc
  https://github.com/web-platform-tests/wpt/pull/11101

Bug: 861704
Change-Id: I8a644a32ed589a2292ad021f5699105482ad9dd1
Reviewed-on: https://chromium-review.googlesource.com/1142045Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#580126}

To organize a little bit more, this CL starts moving relevant code to
the ui folder.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I357b8d453fb6e284d3a3bdf706511e6ec7234dc2
Reviewed-on: https://chromium-review.googlesource.com/1149000Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580125}

Preferences related to SignIn are removed from the persistent storage
list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I03fbc9c62227ca1cbb3b58b9ee2f9ad90df9b586
Reviewed-on: https://chromium-review.googlesource.com/1159367Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580124}