GitLab

Bug: 1094303
Change-Id: I7471695cb8b1248fe0d3005635ed7310a9ac8296
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462247
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816730}

It is no longer required now that we have concluded the experiment.
We are also enabling the feature unconditionally in this change.

The build flag was introduced by the following change:
https://chromium-review.googlesource.com/c/chromium/src/+/1994668
The current change is undoing everything the change above did.

Bug: 1137561
Change-Id: I96aee0778c224fd81be70a011ff27be0f2310314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466355Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816729}

This CLs plumbs the viewport intersection to the FrameNode, which
will allow the tracking of the visibility of each frame.

Bug: 1077217
Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816728}

Previously the Event message for MEET_DEVICE_TELEMETRY was not formed
correctly. This CL forms it correctly and adds some comments to make it
easier to understand.

Bug: chromium:1078512 b:169427520
Change-Id: Ic6af71cebaf15c37f43dea54f9b4eff9d6ba1e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468836
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816727}

Nearby Share requires using the scan response in BLE advertising due to
the size of the data required. Previously using the scan response was
not possible in ChromeOS. These changes added some limited and
temporary support for a new d-bus property to specify the scan response
data: https://crrev.com/c/2458306 https://crrev.com/c/2459250.

This CL changes the adapter mojom interface to allow specifying that the
service data should be added the scan response and not the original
advertisement data when registering an advertisement. Due to the limited
and temporary Platform support (AD type 0x16 only), we kept the api
change as simple as possible. This change will likely be reverted or
modified depending on the shape of the final scan response API in
upstream bluez. Tracking that here: https://crbug.com/1136920


Bug: 1135699
Change-Id: I0513197efb1ab62cb75a2151fc738b89b5e9ec67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465132Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#816726}

Bug: none
Change-Id: I970d78bdcece269f0d62895df79b7455399676a2
Tbr: rdevlin.cronin
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468700Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816725}

Update the ARCore scheduling to reduce latency, running GetFrameData and
ARCore's update with a delay when appropriate.

Use sliding averages to track timing for recent frames, and use that in
the heuristics.

Also add async trace events to mark Animating/Processing/Rendering
frames in the ArCoreGL timeline.

For background, see this presentation with some annotated trace events
explaining the new logic:

https://docs.google.com/presentation/d/e/2PACX-1vQTol3A0Y_LByOuMPSIb0qk-6FNQ7f5SpqO3GWfN-JY37LO7HPXTv1FrfK5e4Qerxx4CNzw9f90auCA/pub

Bug: 1136276
Change-Id: I0550ed3666c47d6f12b2708a1e5ef9a305b07f10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464052
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816724}

When |this.thumbnail_| is defined, the early return prevented the event
listeners from being added so the Wallpaper app wouldn't register
pressing 'Enter'

Fixed: 1032525
Change-Id: I8debd93242ffbab3981988cdd25105483ec4fd66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463709Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816723}

It's been launched and on by default for a while now. Just noticed there
were some references to it laying around, so this cleans them up.

Change-Id: I9cd0a509a28c778e3efb92b9617a6c8948764017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467008
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816722}

Xcode 12.0.1 still ships with the macOS 10.15 SDK, so this
doesn't bump the SDK version yet.

However, some of the binaries in Xcode 12.0.1 need 10.15 to run
(namely, bison gm4 gperf) while the others need 10.14.6, so this
is still a good exercise to make sure that all our bots can handle
10.15+ binaries now (which is a prerequisite to switching to Xcode
12.2 / the 11.0 SDK once it's out of beta).

I temporarily locally removed the libcodedirectory.dylib line
from xcode_binaries.yaml while uploading the 12.0.1 cipd package,
since 12.0.1 doesn't contain that file yet.

Bug: 1108831
Change-Id: I542e859ae3d245f3715efd1f5b8e7cc5d806790f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465807Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816721}

Oilpan destruction order is non-deterministic, and it is unsafe to
access other on-heap objects from a dtor.

This CL removes such accesses, in favor of letting Oilpan clear out
WeakMembers automatically.

If threading issues or other crashes happen, the USING_PRE_FINALIZER
macro should be used for cleanup instead.

Bug: 1137555, 1137557, 1137588
Change-Id: I97fed30743f7000e296b94a29d02e2cfa5c034b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468188
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816720}

Removes Chrome logic from SplitCompatApplication such that it can be
moved to a module (per chrome-hoa). This unblocks features
in <service> definitions, etc from being modularized.

Change-Id: I934793f4d1096c2af4dc966dff73f3bc5c7b191a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463558
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816719}

Provide a field trial testing for client
side detection on Android.

Bug: 1108080
Change-Id: Idc40e3e9651f70eef1a6d651f01d14481cb2f529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463968Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816718}

- Removes the Flash API, but leaves the resource and proxy which is
  used by PPB_Fullscreen.

Bug: chromium:1064652
Change-Id: I6e1e9ce5f30f3f3ee90fb758e8c1b7e4d4158846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464208Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816717}

The test
ForceEnabledOriginTrialsBrowserTest.ForceEnabledOriginTrials_MainPage
was failing on Site Isolation Android FYI bot, because the "/1" variety
of the test expects to run with with site isolation disabled, and
assumes that there will only be one renderer process in that case.  The
FYI bot runs with --site-per-process, which turns a cross-site iframe on
the test page into an OOPIF even in the presence of
--disable-site-isolation-trials, adding another renderer process. Adjust
test expectations accordingly.

Bug: 1137881
Change-Id: I45c0dd18a47c0ce58c3581daa8412ce8bf042a24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468340Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816716}

Bug: 1128599
Change-Id: I750430e805510d7ffe065e5b9c9f789d7241dc3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465489Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816715}

Bug: 1116243
Change-Id: I9b0541a8bd3c8d4bd43744c1e082f86bfea6249a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468698Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#816714}

The test is flaky on Nexus 5 because it seems that something else in the
system affects the affinity of our process, but seems to pass on other
devices.

Cq-Include-Trybots: luci.chromium.try:android-lollipop-arm-rel
Bug: 1113964
Change-Id: Iae40d8513c177cae1929a425a32899ca4f28419c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467900Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816713}

This is identical to the original CL (https://crrev.com/c/2462560).
The fix happened on the predecessor CL (https://crrev.com/c/2466739).

Original change's description:

> This replaces the use of ash::TabletMode and ash::TabletModeObserver in
> BrowserNonClientFrameViewAsh.
>
> This corresponds to phase 2.6 on the design document [1].
>
> Covered by existing tests, eg
>
> BrowserNonClientFrameViewAshTest.BrowserHeaderVisibilityInTabletModeTest
> HomeLauncherBrowserNonClientFrameViewAshTest.TabletModeBrowserCaptionButtonVisibility
>
> [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/
>
> BUG=1113900
> R=jamescook@chromium.org, sky@chromium.org
>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462560
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816316}

TBR=jamescook@chromium.org

Change-Id: Ic9cc488266a42ca4efc40fdfe4edbf7e00c8f93c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468496
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#816712}

Adds the following to DialogModel:
* Support for dialog icons through DialogModel::Builder::SetIcon.
* Support for base::string16 (not message_id) in DialogModelLabel.
* Support for character break in DialogModelLabel.

Then refactors ExtensionUninstallDialogView to use DialogModel, which
required adding the above items to DialogModel.

Bug: 1106422
Change-Id: I59267cf6037f907171f9ff5121c37528b1d1a371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454978
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816711}

The fuzzertest includes "media/gpu/vaapi/vaapi_utils.h".
This also formats the file.

Change-Id: I199e432c94edb61cd43324e64e602985380d6824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463101Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816710}

Also replace ButtonListener with callbacks in this CL.

Bug: 1130078, 772945
Change-Id: Idabf368ddd6e4e48cce78b7b03a88a69028da2d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466568
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816709}

This handles the case where ChromeVox users attempt to "click" holding
space item views via Search + Space.

Bug: 1137039
Change-Id: Ia4772195a4aba92ed405f74a8ac7c179643a82c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468338Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#816708}

When ChromeVox is enabled, the holding space bubble should be activated
on open so as to announce itself and so as to move ChromeVox focus into
the bubble.

Bug: 1137067
Change-Id: I454813ad1116a2ddb1d27e6ff6251849d5d96dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468341Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#816707}

Remove media controls chip view since they're implemented in
ash/system/media/.

Change-Id: I3b91ca767f5cbae1e14937a0c6a7f327b1ff6aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466351Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816706}

Currently the contents of the generated grd file do not depend on the
contents of each individiual |input_files| member, so such files
should not be declared as |inputs|.

Bug: 1132403
Change-Id: I6ccdcee19fae5304454561fa2cbf19eb770e6865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468377Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816705}

URLs with a file scheme ("file://") are not translated, change 2444549
moves this check from Android into shared code. As such, browser tests
that load a local file to test translation should be updated to use the
embedded test server instead.

Bug: 1127094
Change-Id: Ib02a33844da02dff205e8acf9cc233c53cdcaa1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454692
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816704}

https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/0265cd7a10d1..e67f9369d50e

$ git log 0265cd7a1..e67f9369d --date=short --no-merges --format='%ad %ae %s'
2020-10-12 wtc Change avifDecoderSetIO() to return void
2020-10-12 wtc Change 'size' param of avifIOReadFunc to size_t

Created with:
  roll-dep src/third_party/libavif/src
R=dalecurtis@chromium.org

Bug: 1136922
Change-Id: Ice8f31a64fecf3ac19a68ba636632ea1b738c3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466842Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#816703}

Feedback from users are that they want their collapsed groups to remain
collapsed when reopening their windows.

Also cleaning up kCommandSetTabGroupMetadata which was replaced in M81
for backwards compatibility for color.

Bug: 1127622
Change-Id: Idce8be561c2d060f4c2613bf358502becc70db1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458876Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816702}

If a WeakPtr references an already-destroyed object, operator-> and
operator* end up simply dereferencing nullptr. However, dereferencing
nullptr is undefined behavior and can be optimized in surprising ways
by compilers. To prevent this from happening, add a defence of last
resort and CHECK that the WeakPtr is still valid.

Bug: 817982
Change-Id: Ib3a025c18fbd9d5db88770fced2063135086847b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463857
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816701}

Consume skip_wpr_archives_download and skip_render_test_goldens_download
in DEPS.

Bug: chromium:1135819
Change-Id: Iab3bd5e301f5b37913688b9aa893a79dc61522c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466486Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Ryan Heise <heiserya@google.com>
Auto-Submit: Ryan Heise <heiserya@google.com>
Cr-Commit-Position: refs/heads/master@{#816700}

This is a reland of e94960c9

Original change's description:
> Use a single, consistent path to update stage parameters.
>
> Removes stage_parameters from VRDisplayInfo and updates the XR frame
> request loop to exchange an stage_parameters_id to indicate what version
> of the parameters the session has so that only updates need to be sent.
>
> Part of an ongoing process to remove VRDisplayInfo entirely.
>
> Bug: 998146
> Change-Id: I6f41dc2426b529694903d1e46cdadc16841b2b37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460976
> Commit-Queue: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815903}

Bug: 998146
Change-Id: I433914ca4db3adfa939032946a2095e03c13eed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466932Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816699}

If the Safe Browsing settings was reached to
from the Enhanced Protection promo from the
new tab page on Android, then the enhanced
protection radio button section should be
highlighted in Blue50.

Screenshot: http://screen/5MRDafWDYScPBac
Dark Mode: http://screen/AznVfBwK8AD8rN3

Bug: 1135808
Change-Id: Id9cdf2a42cf0c12bf1ee46c80cfdf79a288600ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454490Reviewed-by: Lijin Shen <lazzzis@google.com>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816698}

Just a rename to latest API. No functional change.

Change-Id: I0073320d0467b9d516f4dcdb0de3476940573be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466523
Auto-Submit: Adlai Holler <adlai@google.com>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816697}

Also, define ostream<< for enum types, to remove some more casts.
This is a mechanical change.

Bug: 1135349
Change-Id: I9d11fb2d7d69b99871acd282484df086fdadc498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467695Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816696}

new account creation irrespective of whether both those user mappings exist on the device.
We should instead fallback to new user creation only if we have multiple valid user mappings
on the device.

Bug: 1137547
Change-Id: I9924a3b07235a05472f35998fb5be869c43d83c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465584
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#816695}

The wrapper currently removes only one set of the flags for code
coverage partial instrumentation. But there can be situation where
multiple sets of same flags are in compile command and all of these need
to be removed.

Bug: 1137569
Change-Id: I32c48710fd9c0c66d7c218f329efcd222704607e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466976
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816694}

This CL
1 - Changes Tutorial not to be a subclass of ImageTile.
2 - Handled additional feature type enum types.
3 - Added some unittests
4 - Fixed a CSS bug

Change-Id: Iceca0057f7e0d9b549af5481a12c7f1565e21441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464855Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816693}

Adds a new helper function that converts a (pref, prefValue) pair to
a (setting, settingChangeValue) pair that can be used to log metrics.
Uses this helper function to automatically capture setting changes
for all pref based settings. As a first example, implements metrics
for the kKeyboardFunctionKeys on the Device page.

Bug:  1133553

Change-Id: Ia1f0118e27bb7e0f610bfe1d75ba0ef324260f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459846
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816692}

This add context counts and surfaces them in the description.

BUG=1085129

Change-Id: Ifd07af7d08e512fc213d19f4656835243b6b079c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446095
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816691}