- 17 Nov, 2017 40 commits
-
-
Dmitry Skiba authored
Library loading is the first thing that happens when a renderer starts navigating to a page. NativeLibraryPreloader is called during loading and is responsible for majority of the loading time. However, unlike library loading, preloading doesn't need to know command line of the child process, and thus can happen earlier. This CL preloads libraries when a child process is bound, which speeds up navigation for warmed up renderers. Bug: 783913 Change-Id: I3bffdc613717bfc61e038a2525cd96c5d0f0c0c3 Reviewed-on: https://chromium-review.googlesource.com/757561 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517527}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/12ab00b4d856..c296255c7ee7 $ git log 12ab00b4d..c296255c7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b313642c156c74dfa3ffc639df8a9ea53ec3c1a Reviewed-on: https://chromium-review.googlesource.com/777222Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517526}
-
wutao authored
Currently Launcher state transition animation is using layer animation element of BoundsElement, which will SetBoundsFromAnimation on each OnProgress. This will generate additional overhead with a whole commit every frame. This cl converts it to use ThreadedTransformTransition, which will let compositor optimize and accelerate the animation. Bug:786209 Test:On Cyan and EVE Average Smoothness Improved: Cyan: 1x slow-down-compositing-scale-factor: 88% -> 100% 10x slow-down-compositing-scale-factor: 63% -> 73% 1x slow-down-compositing-scale-factor: 93% -> 99% 5x slow-down-compositing-scale-factor: 46% -> 59% EVE: Change-Id: I960421d89762ff7fcb7c4e230d98137cd3e61170 Reviewed-on: https://chromium-review.googlesource.com/776195 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517525}
-
John Budorick authored
Bug: 782848 Change-Id: I9def38ec856a99a20cedf5f3595ee38b0cef2c8e Reviewed-on: https://chromium-review.googlesource.com/777022Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517524}
-
Donn Denman authored
Removes the deprecated onReparentingFinished in favor of the new method onActivityAttachmentChanged. Updates callers of the old method. Bug: Change-Id: I67920b1caea804281972fbac32f91cd4509c281f Reviewed-on: https://chromium-review.googlesource.com/775733Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#517523}
-
Dominic Mazzoni authored
The goal of an accessibility hit test is to take (x, y) coordinates and map it to an element in the accessibility tree. When there are iframes, the hit test first goes to the parent frame, and if the result is an iframe element, we have to ping back to the browser process and pong to the child frame's renderer to hit test recursively. Previously this worked correctly on desktop platforms but didn't work on Chrome OS, which uses the same renderer accessibility code but doesn't share the same content/browser/accessibility implementation. Fix it just by moving that browser-side child frame hit test ping/pong to RenderFrameHostimpl. Note: this could be more efficient using RWHInputEventRouter, but that would be a much larger refactoring. Tracking that in bug 785987. Bug: 770248 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I7bdc15114f1599be5ffd9604db365d64adc0fb5c Reviewed-on: https://chromium-review.googlesource.com/747202Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517522}
-
Mathieu Perreault authored
Currently holding on to app_locale but will soon also gain Address normalization tools. This is functionality neutral. Bug: 767931 Test: existing Change-Id: I2dfbf93b4e6b8b891c0f78b4fcde615dedf37b1e Reviewed-on: https://chromium-review.googlesource.com/775813 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#517521}
-
Jamie Madill authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/9c40f80c9998..461b345a815c $ git log 9c40f80c9..461b345a8 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 jmadill Add migration code for no_exceptions configs. 2017-11-16 thomasanderson Fix typo: fuschia -> fuchsia 2017-11-16 thomasanderson Always hide libunwind symbols on desktop Linux Created with: roll-dep src/buildtools TBR=brettw@chromium.org BUG=727437 Change-Id: I6dd70fd5ae642dd6a861e02913469f65e333bd19 Reviewed-on: https://chromium-review.googlesource.com/777031Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#517520}
-
Christopher Grant authored
This paves the way to plug in an AutocompleteController, and associated UI. Also, drive URL bar and WebVR toast state via model, as omnibox will require some of the same data. BUG=777542 R=vollick Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I29e96b5318e0d90b5530c12166db9fe780dba276 Reviewed-on: https://chromium-review.googlesource.com/772393 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517519}
-
Mike Baxley authored
There is an EarlGrey method that does the same thing. Bug: 638674 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic4c0d8af6397477a1653367aeddf8b8ff060f70f Reviewed-on: https://chromium-review.googlesource.com/777385 Commit-Queue: Mike Baxley <baxley@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517518}
-
Hongchan Choi authored
NOTE: This CL will land after https://chromium-review.googlesource.com/c/chromium/src/+/769330. This is to expose MessagePort object in AudioWorkletNode and AudioWorkletProcessor for the bi-directional communication. Spec: https://webaudio.github.io/web-audio-api/#instantiation-of-AudioWorkletNode-and-AudioWorkletProcessor Bug: 774564 Change-Id: I543735fc141460a8c356b52e2d461a82d75422fb Reviewed-on: https://chromium-review.googlesource.com/747621 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#517517}
-
James Cook authored
Document test failures and re-enable passing tests. This brings us to 5200 tests. Bug: 678687 Change-Id: I800f19093e4e614e69fa6d311d9bb767c9e3e759 Reviewed-on: https://chromium-review.googlesource.com/777546Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#517516}
-
Gauthier Ambard authored
This CL makes ToolbarCoordinator conforms to QRScannerResultLoading and VoiceSearchControllerDelegate protocols. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4383e36a97304c7e79b22ee8c5de968d19678744 Reviewed-on: https://chromium-review.googlesource.com/774282 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517515}
-
Samuel Huang authored
This CL adds download_objdump.py to make available binutil tools that dump and analyze binary files. Currently the main user of these tools is Supersize. Bug: 723798 Change-Id: I9427f75d81538835ddb431ca7044398126ba9d11 Reviewed-on: https://chromium-review.googlesource.com/766728Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#517514}
-
Dave Tapuska authored
It is possible that while an input channel is rebound to a new Widget the old WidgetInputHandler had pending callbacks on it. Since we were tossing out the mojo pipe we would discard any pending callbacks for it. Make sure we reset the count and recreate the input router which has state for pending inputs. BUG=722928,615090 Change-Id: I34d3ab1af415c97f3ce5ba10ee5c250cf9e30dd1 Reviewed-on: https://chromium-review.googlesource.com/772321Reviewed-by:
-
Menglu Huang authored
Bug: 785185 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7b432dc42efca64870effc7ff819a8036bb649da Reviewed-on: https://chromium-review.googlesource.com/775792Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#517512}
-
Alex Vallée authored
With the OOPIF implementation of webview, the embedder page is not considered focused when the guest has focus (it does not see any keyboard input). This means that upon reaching the end of the <webview>'s content and focusing an element in the embedder, <paper-icon-button> in this case, the page is first refocused. This event listener only seemed to expect this to happen once at the beginning. This CL prevents the authenticator from focusing the webview if another element is focused when the page itself is focused. The alternative would be to call focus only once, when constructing the Authenticator. Bug: 781748 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iac7020caad90c9e5e617f46bba392caeb09482b0 Reviewed-on: https://chromium-review.googlesource.com/775978 Commit-Queue: Alex Vallee <avallee@chromium.org> Reviewed-by:
-
Will Chen authored
When there's an uncaught exception from running our test, the test times out which is annoying to wait for and it doesn't provide any intermediate output. This executes our test script in an awaited try-catch block so we can print the error and end the test early. This updates our unit tests to follow the async IIFE pattern that the rest of the new tests uses so it plays nicely with our new error-handling code. R=dgozman@chromium.org,einbinder@chromium.org Bug: 667560 Change-Id: I2f693c704ef2991a2970fa925e52422d633bc06c Reviewed-on: https://chromium-review.googlesource.com/773565 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#517510}
-
Vlad Tsyrklevich authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8f5568bfc4fd..954710ddd756 $ git log 8f5568bfc..954710ddd --date=short --no-merges --format='%ad %ae %s' 2017-11-15 vtsyrklevich * include/freetype/ftrender.h: Fix `FT_Renderer_RenderFunc' type. 2017-11-14 madigens Use Adobe hinting engine for `light' hinting of both CFF and Type 1. 2017-11-09 yuri_levchenko * CMakeLists.txt: Add `DISABLE_FORCE_DEBUG_PREFIX' option. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng Bug: 785442 Change-Id: Ib465d6300eb54d0d944e082d8b14b45da8f4bc5f Reviewed-on: https://chromium-review.googlesource.com/775778Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517509}
-
Zhiling Huang authored
Bug: 784527 Change-Id: I6f57b53db6f3f898238efa4617e5d8e0bbbfae36 Reviewed-on: https://chromium-review.googlesource.com/776014Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#517508}
-
Maria Khomenko authored
BUG=783427 Change-Id: Id1a43e33e83c7cfbfa2a86f82adc286e3c2b0c29 Reviewed-on: https://chromium-review.googlesource.com/775995Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517507}
-
David Tseng authored
- uncaught error to Cursor::move. Closure should have caught this as a function that takes two args; only passed one. - remove deep equivalent changes in cursor line movement. This causes us to get stuck in various circumstances. - add AutomationUtil.getLastNode. It computes the last node visited by a predicate. The assumption is that we prefer ancestors that match the predicate. Elsewhere, this is expressed as skipping initial subtree hwne moving forward. Bug: 784699 Test: existing chromevox_tests. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib9713acf4e749cef31c5f816407df0aa45d5f87e Reviewed-on: https://chromium-review.googlesource.com/775083Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517506}
-
Dave Tapuska authored
SetFocus for non-proxy frames are sent input message over mojo. RenderFrameProxyHost based messages are still sent via InputMsg_SetFocus chrome IPC since there is no widget input handler for these situations. In order to grab the mojo input message we are required to subclass the RenderWidgetHostImpl to be able to provide a mock interface. BUG=722928 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ieb34b0e1948583c433891edb9bfc5618b03952ad Reviewed-on: https://chromium-review.googlesource.com/762156 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517505}
-
Shimi Zhang authored
I did about 800 run on Nexus 5x on Android N and 200 run on Pixel on Android master, all of them passed, so try to reenable it. Bug: 767180 Change-Id: Ie373a37271aabb5008ac700ff29779f134e5faea Reviewed-on: https://chromium-review.googlesource.com/776206Reviewed-by:
-
Xiaohan Wang authored
BUG=783973 Change-Id: I74cdc80d3cd4187ce0741fa722e2527329347ec5 Reviewed-on: https://chromium-review.googlesource.com/770991Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#517503}
-
Francois Doray authored
The "AutomaticTabDiscarding" field trial has expired. Not having to read the "AllowMultipleDiscards" param of this field trial will simplify the TabManager refactor. Bug: 775644 Change-Id: Idaded6bbc74c8ceb02379d5b7ddf43715b552a6e Reviewed-on: https://chromium-review.googlesource.com/772090 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517502}
-
Matthew Jones authored
Change "Not now" to "Not yet". BUG=783829 Change-Id: I9699116ea54d3b6f55b344463328c8b07ff2fcb7 Reviewed-on: https://chromium-review.googlesource.com/777020Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/c99db0ab53a4..1e816bccb5ff $ git log c99db0ab5..1e816bccb --date=short --no-merges --format='%ad %ae %s' 2017-11-16 dalecurtis Re-add MIPS configuration. It's still used after all. 2017-11-16 gordana.cmiljanovic [MIPS] Put mipsel Linux configuration options Created with: roll-dep src/third_party/ffmpeg Bug: None Test: None Tbr: chcunningham Change-Id: I2cf10050a3abc16f183982b8e16042fb03e463cc Reviewed-on: https://chromium-review.googlesource.com/776036 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#517500}
-
Charles Harrison authored
Don't need to store the previous_url, NavigationHandle does it for us. This removes 1 copy on navigation start and 4 copies on commit. It also simplifies the code a reasonable amount. Bug: None Change-Id: I1f19f87a254c6b6fb5147a38da23f66b5db55c01 Reviewed-on: https://chromium-review.googlesource.com/774985Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#517499}
-
Conley Owens authored
Similar adapter observer methods have already been marked deprecated. GattServiceChanged is not all too different since it is fired when essentially the device changes shape (attributes are added/removed). This change also removes a platform-specific use of gatt_service_changed_count() and gatt_characteristic_added_count(). BUG=710352 Change-Id: Iffe8118083ec10ba762eacb18886bca3acda2d58 Reviewed-on: https://chromium-review.googlesource.com/776354 Commit-Queue: Conley Owens <cco3@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517498}
-
Koji Ishii authored
This patch fixes PaintInvalidator to use NGPaint code path not only for LayoutNGBlockFlow but also for LayoutNGMixin. This fixes inline children in table cells not be painted at all. ~700 tests turn to green. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I36fec7263b2a1e1d06271c9f672f9e0e12b25230 Reviewed-on: https://chromium-review.googlesource.com/776177 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517497}
-
Abhishek Arya authored
R=etienneb@chromium.org Bug: 783296 Change-Id: Ie096d3d407249844a546ec9e17863854fe666c8c Reviewed-on: https://chromium-review.googlesource.com/776239 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517496}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/08b26a8a257e..535ecf6b31fe $ git log 08b26a8a2..535ecf6b3 --date=short --no-merges --format='%ad %ae %s' 2017-11-15 jzern av1_txfm,round_shift: remove implicit conv warning 2017-11-13 huisu Fix integer overflows in av1_iidentity*_c() 2017-11-13 huisu Fix int overflow in decode_coefs() Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@chromium.org Change-Id: I872329cccab87a81683a8359e2dfde63f2e49bf5 Reviewed-on: https://chromium-review.googlesource.com/776240Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#517495}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/feee08f4da81..12ab00b4d856 $ git log feee08f4d..12ab00b4d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id803bbe8056b4792c81a59b685c6e6d3d481a624 Reviewed-on: https://chromium-review.googlesource.com/776241Reviewed-by:
-
Sergey Volk authored
CMA backends might choose to implement GetCurrentPts in such a way that it reports the current position to be kStartPts immediately after Start(kStartPts) is called, rather then after playback actually starts, and that should be ok. Bug: none Test: cast_media_unittests Change-Id: I4e232504c0a664fb0e715eed96982c2a6d62b2e2 Reviewed-on: https://chromium-review.googlesource.com/775873Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#517493}
-
Lei Tian authored
Use TabPersistentStoreObserver.onMetadataSavedAsynchronously to background the Browser Actions tab creation service Change the logic to background the Browser Actions tab creation service based on TabPersistentStoreObserver.onMetadataSavedAsynchronously. The callback indicates that tab model lists are backuped so the saved tabs can be restored succesfully. Also for the notification when a new tab has not been created (tabId is not available), the Intent to bind the notification will be a VIEW intent. This notification is necessary to make the service foreground. Bug: 766349 Change-Id: I73d49e2a1e26410b2dd6e51a07f35e9965b9a38a Reviewed-on: https://chromium-review.googlesource.com/769852Reviewed-by:
-
Yuke Liao authored
This reverts commit 02bddfd9. Reason for revert: NavigationCallbacksTest.FailedNavigation is failing on devices, and only devices, both iPhones and iPads with iOS 10 and iOS 11. Original change's description: > Fixed Navigation callbacks for failed provisional navigation. > > Verified callbacks correctness with > NavigationCallbacksTest.FailedNavigation integration test. > > Before this CL DidStartNavigation was called twice (second time > for presenting error in Native Content). DidFinishNavigation was > called once (also for presenting NativeContent). First > DidStartNavigation did not have a matching DidStartNavigation > call. > > This CL removes DidStartNavigation/DidFinishNavigation callbacks > for for presenting error in Native Content and adds balanced > DidFinishNavigation callback in handleLoadingError:. > > Bug: 725241 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c > Reviewed-on: https://chromium-review.googlesource.com/758718 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517420} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I76bc2987780795fd72284b22203e945387f04c53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777279Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517491}
-
Andrew Grieve authored
Also refactors our proguard wrapper a bit by having it: * Ensure all outputs exist before short-circuiting * Only touch missing files after building (avoids creating 0-length files for a failed run). Change-Id: Ie57a925a9258dd9c304e7af4bcccaf94b24b1129 Reviewed-on: https://chromium-review.googlesource.com/770790Reviewed-by:
-
dpapad authored
This fixes a crash where the user could still request a profile reset while one was already in progress, by closing and re-opening the dialog. Bug: 616089 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia99f6ceea4d6f3c1ba797ba47affc42804c3fd5f Reviewed-on: https://chromium-review.googlesource.com/772939Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#517489}
-
Min Qin authored
TBR=dtrainor@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8e277d2ab135195a2848b07f6bd922fe5dc392c3 Reviewed-on: https://chromium-review.googlesource.com/777032Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517488}
-
