- 17 Aug, 2018 40 commits
-
-
Tonko Sabolčec authored
Bug: 791541 Change-Id: Ibf11c698d40b29299510f73e8a6b308c618d506b Reviewed-on: https://chromium-review.googlesource.com/1178284Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Cr-Commit-Position: refs/heads/master@{#584045}
-
Valeriya Sinevich authored
Now CookieManagerService inherits from TokenServoice::consumer and can fetch access tokens. Change-Id: I0329257b9cb5908576beb7dae7b938c0d39cd487 Reviewed-on: https://chromium-review.googlesource.com/1169816 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584044}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/92f1422f..4e86b694 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I515b7c2224ec22db8d24f9cb2fecdaefce6b22ae Reviewed-on: https://chromium-review.googlesource.com/1179802Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584043}
-
Christopher Grant authored
Use of the material design controller in VR is generating crashes. Its use was likely unintentional. BUG=874552 R=jdonelly Change-Id: Id10449ebe736c3217fd4559c1b941d6e45404214 Reviewed-on: https://chromium-review.googlesource.com/1178963Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#584042}
-
Balazs Engedy authored
This CL also delays creating the AuthenticatorRequestDialogModel and showing the dialog until after ChromeAuthenticatorRequestDelegate's OnTransportAvailabilityEnumerated is called, plus renames Step::kInitial to ::kWelcome. Bug: 847985 Change-Id: I3b46781ccea0309e1efc7c3fec45cbe4c43e9017 Reviewed-on: https://chromium-review.googlesource.com/1175120 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584041}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2ae6f8e569a3..c6b2cf82b09b git log 2ae6f8e569a3..c6b2cf82b09b --date=short --no-merges --format='%ad %ae %s' 2018-08-16 bridgwater@google.com Update URL for GN quick start guide. Created with: gclient setdep -r src/third_party/perfetto@c6b2cf82b09b The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2a826cebe51ae015928e18c3e51462136ab5d4f2 Reviewed-on: https://chromium-review.googlesource.com/1179331Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584040}
-
Hans Wennborg authored
These were created following the instructions from https://chromium.googlesource.com/chromium/src/+/master/docs/win_order_files.md using Chromium #584022. Bug: none Change-Id: I01b4fc550f237091c2486194edf6c0dc7ea1387b Reviewed-on: https://chromium-review.googlesource.com/1179755Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584039}
-
Maja Kabus authored
Created new dictionary TrustedTypePolicyOptions with callbacks and adjusted TrustedTypePolicyFactory and TrustedTypePolicy to accept the dictionary. Added createURL() and createScriptURL, and adjusted createHTML() in TrustedTypePolicyOptions. Bug: 739170 Change-Id: Ie63fdf90b5aac53188fcd8141c95d287c3e726fd Reviewed-on: https://chromium-review.googlesource.com/1167282Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Maja Kabus <kabusm@google.com> Cr-Commit-Position: refs/heads/master@{#584038}
-
vitaliii authored
Delete .cc files of UserEventService and ConsentAuditor interfaces. Change-Id: Ic5f19f38b65359365dde91441e95426c0fafcd08 Reviewed-on: https://chromium-review.googlesource.com/1135310Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584037}
-
Oriol Brufau authored
They should be allowed like the physical border colors. Spec: https://drafts.csswg.org/css-logical/#border-color Spec: https://drafts.csswg.org/selectors/#visited-pseudo BUG=860313 TEST=fast/css/css/logical-box-border-color-visited-001.html TEST=fast/css/css/logical-box-border-color-visited-002.html TEST=fast/css/css/logical-box-border-color-visited-003.html Change-Id: I20967bf4b00716e5c4ec2bac2e3781c81cdaa688 Reviewed-on: https://chromium-review.googlesource.com/1178043 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#584036}
-
Peter E Conn authored
State was getting slightly out of sync with the following sequence of events: 1. Open a TWA to a non-verified origin. 2. Navigation finishes, we notice and disable TWA UI. 3. finishNativeInitialization occurs, which is where we initially try to show the Disclosure Snackbar. Bug: 871266 Change-Id: Iaf152b49de18cf22eca90b61df570e582dd2a435 Reviewed-on: https://chromium-review.googlesource.com/1179680Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#584035}
-
Rakina Zata Amni authored
Currently scoping (searching for all find matches) is done in 100ms chunks and uses timers. We want to make it use idle tasks instead to ensure this doesn't block important tasks. Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iaa9f40580fe5c69af398ae43a339d06305767503 Reviewed-on: https://chromium-review.googlesource.com/1152710 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584034}
-
Friedrich Horschig authored
Marking some idlharness tests flaky as they have been the main point of failure on a significant amount of Linux tests. Tbr: mgiuca@chromium.org Bug: 873045 Change-Id: I798aeeadde74b34b458b8d05862dde5535a37d41 Reviewed-on: https://chromium-review.googlesource.com/1179750Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584033}
-
Leszek Swirski authored
Posted blocking ScriptStreamer tasks can end up in a queue, and have their Resource complete loading before the task even starts. When this happens, these tasks will no longer block on network input, but they will still be posted to the blocking task runner, which does not spin up new threads if the running task is not blocked. When there are a lot of small functions posted for streaming, this results in a slightly paradoxical starvation, where the blocking task runner is processing lots of no-longer-blocking tasks all in one thread, as it has no reason to spin up new threads. To avoid this, if a streaming task isn't started before the resource finishes loading, we can cancel this posted task, and instead post a new non-blocking task to the non-blocking thread pool. This frees up the blocking task runner to process only blocking tasks (and thus allows it to spin up new threads for them). TBR=kouhei@chromium.org Bug: chromium:865098 Bug: chromium:866868 Change-Id: I930b10d23fd538b3529ab3a31f6caba13a8661fb Reviewed-on: https://chromium-review.googlesource.com/1179744Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#584032}
-
Hans Wennborg authored
Clang and the macOS SDK are starting to drop support for targeting versions before 10.6. Bug: 874997 Change-Id: Id3ac6b42f49e0cdb28f85f127fb41305ba1af4cb Reviewed-on: https://chromium-review.googlesource.com/1179748Reviewed-by:
-
Yuta Kitamura authored
Utility thread is a thread for utilities that make use of Blink. Currently, the WebThread object for that thread is defined as WebThreadImplForUtilityThread, but we can remove it if we initialize Blink with blink::CreateMainThreadAndInitialize(), because the utility thread does not require multi-thread nor other complex functionalities. UtilityBlinkPlatformImpl inherits from BlinkPlatformImpl, which is a base class for blink::Platform defined in content/. This patch makes it directly inherit from blink::Platform, since the utility thread does not require functions defined in BlinkPlatformImpl -- BlinkPlatformImpl's functions are basically for full-fledged browser, and we don't need them in the utility thread. Bug: 826203 Change-Id: I57af86931af176ef5d1bd08d0f0ceb5e60d9d65b Reviewed-on: https://chromium-review.googlesource.com/1175746 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584030}
-
Juan Antonio Navarro Perez authored
Disabling the following storie currently showing consistent failures on android-pixel2-perf bot. TBR=nednguyen@google.com NOTRY=true Bug: 865400 Change-Id: I0df6999497e00abfd71bbd00e98a1e274b347aad Reviewed-on: https://chromium-review.googlesource.com/1179751Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#584029}
-
Koji Ishii authored
When computing margins for orthogonal atomic inlines, the old code was using the writing-mode of the atomic inline to determine whether to flip line or not. This patch fixes to use the constraint space's writing-mode. For other computation than flipped-lines, ComputeMarginsForVisualContainer already uses the writing- mode of the constraint space. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I85d12a29cf5e845d3fef00b9832c68d106e80dca Reviewed-on: https://chromium-review.googlesource.com/1179519 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#584028}
-
Oriol Brufau authored
Spec: https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue BUG=873760 TEST=external/wpt/css/css-logical/logical-box-border-color.html TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html TEST=external/wpt/css/css-logical/logical-box-border-style.html TEST=external/wpt/css/css-logical/logical-box-border-width.html TEST=external/wpt/css/css-logical/logical-box-inset.html TEST=external/wpt/css/css-logical/logical-box-margin.html TEST=external/wpt/css/css-logical/logical-box-padding.html Change-Id: I60fca339c419d1d19eb6b31f0426c11f9d1cf95f Reviewed-on: https://chromium-review.googlesource.com/1176084Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#584027}
-
Kyoko Muto authored
Nodes are assigned to a slot only when nodes are host's children and the slot is in the shadow tree. BUG:869308 Change-Id: I10b9b58725d7550a7174a3f4a8e769a9f0c39996 Reviewed-on: https://chromium-review.googlesource.com/1176896 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#584026}
-
Oskar Sundbom authored
Putting parameters in a struct like this will make it easier to change parameters going forward, as it should be less necessary to update implementations that don't care about certain parameters. This CL also adds processing configuration as a new, optional audio source parameter to this struct. It is used to configure audio processing when it's supported directly in the source, as will be the case in the audio service. For an outline of the project this CL is part of, see: https://docs.google.com/document/d/1u4POff_ts_1LE3WDLA_wDDFnUswdlsuHL5DsiTE0a3U/edit?usp=sharing It's accessible to everyone @chromium.org. Bug: 851959 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibdcddf1bfc741467dcab68776872c6fcda0f43ad Reviewed-on: https://chromium-review.googlesource.com/1167849 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584025}
-
Anders Hartvoll Ruud authored
In StyleValueToCSSValue, when checking whether a certain CSSStyleValue matches the property in question, we now ask the registration (via CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw a TypeError like for normal properties. If it does match, the CSSStyleValue is stringified, tokenized, and set on the style rule as tokens. I have postponed support for <color> and <transform-function>, because CSSUnsupportedStyleValue currently does not handle registered custom properties at all. This is appropriate to fix in a separate CL. Note that, because the string version of StylePropertyMap.set also uses StyleValueToCSSValue, it will no longer be possible to set registered custom properties with a string--even if the syntax is matched. A subsequent CL will fix this. R=futhark@chromium.org Bug: 641877 Change-Id: Ib5c31640f81e957620339c9bdf617ab1af5d3d47 Reviewed-on: https://chromium-review.googlesource.com/1179153Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#584024}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/984f1a80c001..aea32f9d6ad3 git log 984f1a80c001..aea32f9d6ad3 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 buildbot@webrtc.org Roll chromium_revision d75446b2..409b9c00 (583888:583992) 2018-08-17 kwiberg@webrtc.org Audio encoder tests: Create audio encoders the new way 2018-08-17 buildbot@webrtc.org Roll chromium_revision 012c9b03..d75446b2 (583774:583888) Created with: gclient setdep -r src/third_party/webrtc@aea32f9d6ad3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1d388503dde8ee6a18a7360cd665e82f039f1dfc Reviewed-on: https://chromium-review.googlesource.com/1179329Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584023}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b44fe61d..92f1422f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I90db469f7e7837a6ae2cb99dcba5bf30f2b68905 Reviewed-on: https://chromium-review.googlesource.com/1179477Reviewed-by:
-
Findit authored
This reverts commit d6bbb56c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 583976 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q2YmJiNTZjMjZhYmMxNmNmOWIyMzJkMTQ1NTZjZGFjOWJjNGE0MjYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28647 Sample Failed Step: unit_tests Original change's description: > Remove pre-installed demo mode resources on low disk space > > Introduces a class that will handle removing pre-installed demo mode > resources when needed. > First incarnation observes low disk space signal from cryptohome > service, and removes pre-installed resources when low space is detected > (provided that the device is not in demo mode). > When demo mode resources get removed from disk, this is recorded in > local state, to avoid future attempts to remove these resources. > > More logic for requesting demo mode resources removal to come. > > BUG=827368 > > Change-Id: I721d1995fa818fc2fc1d056e33ba513380bf441e > Reviewed-on: https://chromium-review.googlesource.com/1173670 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583976} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=827368 Change-Id: Ib4fb21229e8be9894bff6d22c1fa4d7c894c1e2a Reviewed-on: https://chromium-review.googlesource.com/1179781 Cr-Commit-Position: refs/heads/master@{#584021}
-
Friedrich Horschig authored
This reverts commit dea0b13b. Reason for revert: As described in https://crbug.com/875202, this rework broke the PRE_CookiesEnabled test. I haven't seen CookiesEnabled fail (but there has been a lot of nose, so please check that as well before you reland). Original change's description: > OSX: Try to fix NetworkContextConfigurationBrowserTest.CookiesEnabled. > > Looks the CookieStore isn't flushed on browser exit, by default. > > BUG=847555 > > Change-Id: I2596f8ea3d62a5d5e71e0514ba8e7caa6049605d > Reviewed-on: https://chromium-review.googlesource.com/1178803 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583846} TBR=mmenke@chromium.org,morlovich@chromium.org Change-Id: I7e2fd7c874026fccdc200b0fd78af2faa4614095 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847555 Reviewed-on: https://chromium-review.googlesource.com/1179761Reviewed-by:
-
David Davidović authored
https://chromium-review.googlesource.com/c/chromium/src/+/1145066 adds a new STL-compatible interface to EnumSet and EnumSet::Iterator. https://chromium-review.googlesource.com/c/chromium/src/+/1145182 and https://chromium-review.googlesource.com/c/chromium/src/+/1145186 completely remove usage of the old one. Due to this, the old interface is not needed anymore. This refers to the methods EnumSet::First (superseded by EnumSet::begin), EnumSet::Iterator::Get (superseded by unary operator * for dereferencing) and EnumSet::Iterator::Inc (superseded by unary operator ++ for incrementing). Therefore, remove them. EnumSet::Iterator::Good remains because it is used internally, but its visibility has been changed from public to private to reflect this. Bug: 860435 Change-Id: I7d27123cea02701795b6b9d278a3d9556fefc697 Reviewed-on: https://chromium-review.googlesource.com/1146929 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584019}
-
Ian Vollick authored
This reverts commit a2ce72e4. Reason for revert: this test should now pass. Original change's description: > [vr] Disable WillNotFailOnNonAsciiURLs > > This will currently not pass with new versions of HarfBuzz. > > Bug: 731894 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ib5ae456bf44bfdedd6a0edf36b54dbbf12bae18a > Reviewed-on: https://chromium-review.googlesource.com/1169774 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582298} TBR=vollick@chromium.org,mthiesse@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 731894 Change-Id: Id02d8c770a763c5c37f993d701d03e518a043ee7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1178164Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This reverts commit 7d8cd352. Reason for revert: The test DemoSetupDerelictTest.DerelictSetup failed two consecutive times right after it landed: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/8241 and https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/8242 Original change's description: > Enroll device into Demo Mode when derelict > > When a device is "derelict" (idle at OOBE), we currently auto-launch a > very old Kiosk demo app. This CL changes the idle detector to enroll > into offline Demo Mode instead if Demo Mode and offline Demo Mode are > enabled. > > More specifically, "derelict" is defined as: > * Spending a total of 8 hours on the Welcome screen, followed by > * Being idle on the Welcome screen for 5 minutes > > So a device that has progressed past the Welcome screen shouldn't be > considered derelict; nor should a device that goes idle for 5 minutes > but has only been in OOBE for <8 hours. > > We will follow this CL with actual derelict policies; until then it > will fail to enroll and simply return to the Welcome screen. > > Bug: 869273 > Test: browser_tests, and manually at OOBE with the following command line: > --enable-demo-mode --enable-offline-demo-mode --derelict-idle-timeout=1 > --derelict-detection-timeout=1 --oobe-timer-interval=1 > (manual testing requires copying policies from > /usr/share/chromeos-assets/demo_mode_resources/policy/ to > /usr/share/chromeos-assets/demo_mode_resources/derelict_policy/) > > Change-Id: I81572e447ce5082c0bf534ab32b0c4b34f0570a0 > Reviewed-on: https://chromium-review.googlesource.com/1164398 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583927} TBR=alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org Change-Id: Ieeeb3973303588be8f84443b221fe560a52dc105 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869273 Reviewed-on: https://chromium-review.googlesource.com/1179622Reviewed-by:
-
Mike West authored
The layout tests aren't testing much at the moment, as they're never served over HTTPS. This patch creates `.https` versions of the tests and reworks them to actually exercise the behavior of `__Host` and `__Secure` cookie prefixes. Bug: 843945 Change-Id: I31968133ca8846f3ffc4faec2339e3d0d03c77f8 Reviewed-on: https://chromium-review.googlesource.com/1179150 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#584016}
-
Egor Pasko authored
Trivial cleanup: removing parameters/functions that are not used in producing startup metrics (The RecordMainEntryPointTime() used to take wall clock time into account, but now on all platforms wallclock time is not needed except for executable start time). Bug: 797762 Change-Id: I1242246ad6af2b4b3e955b0225144154084e568f Reviewed-on: https://chromium-review.googlesource.com/1174548Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584015}
-
Mark Cogan authored
This CL adds corner roundedness matching for the reduced motion tab grid transition animation (which is also used when exiting the tab grid from a tab that isn't visible). The free function that exposes the device's (approximate) corner radius is facored into a ui_utils method. Bug: 870659 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5abdd190140f2a4a4fd3b0b18f0d300a6d0dd5ea Reviewed-on: https://chromium-review.googlesource.com/1177606Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#584014}
-
Friedrich Horschig authored
Disabling AutoCloseAfterOpenWithMouseOffShelf which wasn't for some reason disabled yet although it's similar flaky as all others. Latest recorded failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4744 The flakiness dashboard supports this action: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=unit_tests&tests=DownloadShelfControllerTest.AutoCloseAfterOpenWithMouseOffShelf TBR=sdy@chromium.org,benwells@chromium.org Bug: 849477 Change-Id: Ic793f6f0139c5d56148383caf9ff2890cdfe2420 Reviewed-on: https://chromium-review.googlesource.com/1179674Reviewed-by:
-
Sergio Villar Senin authored
There was some leftover code from https://crrev.com/c/1143261 BUG=865350 Change-Id: Ibe6561d4da605b4b8802e8f3862a023155c4f051 Reviewed-on: https://chromium-review.googlesource.com/1175122Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#584012}
-
Vadym Doroshenko authored
No need to wait a navigation since NavigateToURL waits for navigation completed (it eventually calls NavigateToURLWithDispositionBlockUntilNavigationsComplete). Bug: 875052 Change-Id: I96ebd7d5ec4ce0f676a82f6714816a7ddefb2b08 Reviewed-on: https://chromium-review.googlesource.com/1179160Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584011}
-
Friedrich Horschig authored
Theses tests were known to be flaky for a while and this is not the first time they are disabled for unknown reasons. Reopened and linked bugs with details. TBR=dskiba@chromium.org, tedchoc@chromium.org Bug: 668217, 875130, 875129, 875092 Change-Id: Ifee7d29bbdf28349aea3837a6b1a2525484c6e9a Reviewed-on: https://chromium-review.googlesource.com/1179665Reviewed-by:
-
Trent Apted authored
Bug: 867700 Change-Id: I42172daa50afe7a88b4ae2913371884504d46763 Reviewed-on: https://chromium-review.googlesource.com/1179117 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584009}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/091d6f21..b44fe61d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c6f9d1bcf4984c5a5437c7e1d49d34dead6b2ae Reviewed-on: https://chromium-review.googlesource.com/1179470Reviewed-by:
-
Tetsui Ohkubo authored
This CL adjusts (mainly network) detailed view styles. If fixes the following items. See the bug for detail. - Align sub-section labels even if the row doesn't have an icon. - Change Sub-section label (when single-line) size to 16pt. - Change style of Add Wifi button icon. - Change Sub-section label line heights for double-line row to 20px. - Change "Connected" color to Dark Green 600. Screenshot: http://screen/aNoY7W8uGQn TEST=manual BUG=863618 Change-Id: I2b1e13e53f7c7fc79b57a4f1e64110d7136f0623 Reviewed-on: https://chromium-review.googlesource.com/1175658 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#584007}
-
David Davidović authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1145066, which adds an STL-compatible interface to EnumSet and EnumSet::Iterator, replace all uses of the previous iteration interface with a range-based for loop. This allows eventual removal of the old interface altogether. Also, replace existing usage of |arraysize| with |base::Size|, since the former was deprecated. This is CL part 2 of 2. TBR=dschuyler@chromium.org Bug: 860435 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7839362e3b103e9a1d309f21c7b1bef17da7b8e1 Reviewed-on: https://chromium-review.googlesource.com/1146925 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
-
