GitLab

Every call to base::Bind results in a new class declaration. Since
base::internal::BindState is a virtual class, this also results in a
bespoke vtable being defined. And that's a lot of vtables. Like 1MB
worth of vtables, or 1% of Chrome's binary size.

However, this vtable's sole purpose is for RefCountedThreadSafe::
Release(). Release() _does_ need to know precisely how to delete the
BindState, but it doesn't need a vtable to do it. All it needs is a
function pointer.

This CL de-virtualizes base::BindState and instead moves the vtable
pointer (which is merely an array holding the destructor) to a function
pointer that contains the destructor instead. Since BindState previously
contained a pointer-to-vtable the net memory effect of having the
function pointer instead should be offset.

And of course a 1MB binary size drop also means reduced memory
requirements for the shared text-segment pages.

Locally produced numbers for ChromiumFramework on Mac:
pre-strip:
 - before: 192,031kB
 - after: 185,800kB
post-strip:
 - before: 101,353kB
 - after: 100,353kB

BUG=486594

Review URL: https://codereview.chromium.org/1129353003

Cr-Commit-Position: refs/heads/master@{#329818}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1b19b6f..49baa47

TBR=alancutter@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/1135823006

Cr-Commit-Position: refs/heads/master@{#329817}

Cr-Commit-Position: refs/heads/master@{#329816}

The all slow tests have a possibility to be failed on slow bots (Debug build, ASAN, MSAN, TSAN bots). So this patch disabled them as a whole by defining DISABLE_SLOW_FILESPAPP_TEST macro.

BUG=none
TEST=run Debug, ASAN, MSAN, TSAN bots

Review URL: https://codereview.chromium.org/1139823003

Cr-Commit-Position: refs/heads/master@{#329815}

BUG=486571
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1137373002

Cr-Commit-Position: refs/heads/master@{#329814}

An N pattern cadence is simply figuring out if N times the
frame duration has an integer cadence (M) relative to the
render interval, then figuring out how to distribute N
values such that sum(x1 + x2 + x3 ... xN) == M.

I haven't dug through our discussion on how to compute this
for N > 2, but for N == 2, it's simple to just use
x1 == ceil(M/2), x2 == floor(M/2)

This change refactors the main function in VideoCadenceEstimator
into smaller pieces (an original review request :) in order to
reuse them for detecting 2-pattern cadence.

BUG=439548
TEST=all unit tests still pass, 3:2 cadence tests pass.

Review URL: https://codereview.chromium.org/1125893002

Cr-Commit-Position: refs/heads/master@{#329813}

BUG=487474
TEST=manual

Review URL: https://codereview.chromium.org/1132983005

Cr-Commit-Position: refs/heads/master@{#329812}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0f5ff62..1b19b6f

TBR=alancutter@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/1137963003

Cr-Commit-Position: refs/heads/master@{#329811}

TBR=suzhe@chromium.org
BUG=407456
TEST=Verified on linux_chromeos & clapper device.

Review URL: https://codereview.chromium.org/1132333002

Cr-Commit-Position: refs/heads/master@{#329810}

Previously BatchableRequestBase can be used both as a normal request and as a
child request in BatchUploadRequest. Even when BatchableRequestBase is used as
child request, its lifetime must be managed by RequestSender, and it makes hard
to track the lifetime in BatchUploadRequest.

To simplify lifetime management in BatchUploadRequest, the CL extracts the core
part of BatchableRequestBase into BatchableDelegate, and lets BatchUploadRequest
use the delegate as a child request. Because the delegate is nolonger owned by
RequestSender, BatchUploadRequest can own its child requests without caring
RequestSender.

BUG=451917
TEST=googleapis_unittests

Review URL: https://codereview.chromium.org/1132693006

Cr-Commit-Position: refs/heads/master@{#329809}

And avoid dispatching onActivate & onDeactivated events to IME
extensions if the profile is not the active profile.

BUG=485835
TEST=Verified on linux_chromeos & clapper device.

Review URL: https://codereview.chromium.org/1136463005

Cr-Commit-Position: refs/heads/master@{#329808}

MessageLoopProxy is deprecated.
This basically does a search and replace of:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

MessageLoopProxy -> SingleThreadTaskRunner

BUG=391045

Review URL: https://codereview.chromium.org/1124813003

Cr-Commit-Position: refs/heads/master@{#329807}

BUG=487505
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/background/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/1140873002

Cr-Commit-Position: refs/heads/master@{#329806}

It's been off by default since Chrome 40 with a policy opt-in. The policy was
documented to stop working after Chrome 43, so remove all logic for SSL 3.0.
Chrome will no longer honor a --ssl-version-min=ssl3 flag and the option is
removed from about:flags.

This CL also removes the SSL 3.0 support from the extensions' TLS socket API.

BUG=487730

Review URL: https://codereview.chromium.org/1139013002

Cr-Commit-Position: refs/heads/master@{#329805}

TEST=Tested manually in open dialog, and standalone Files app.
BUG=487905

Review URL: https://codereview.chromium.org/1134213006

Cr-Commit-Position: refs/heads/master@{#329804}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7aa732b..0f5ff62

TBR=alancutter@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/1138953005

Cr-Commit-Position: refs/heads/master@{#329803}

R=mkwst@chromium.org
BUG=478250

Review URL: https://codereview.chromium.org/1142463002

Cr-Commit-Position: refs/heads/master@{#329802}

The ResourceRecords must contain the ServiceWorker's main script.
So the size of it must be bigger than 1.

If the method returns STATUS_ERROR_CORRUPTED, DeleteAndStartOver() will be executed.

BUG=485900,478732

Review URL: https://codereview.chromium.org/1135743002

Cr-Commit-Position: refs/heads/master@{#329801}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/88c23fc..c30806f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1145443002

Cr-Commit-Position: refs/heads/master@{#329800}

Previously we would invoke 'gn refs' once for each file modified in
a CL; this was terribly inefficient. Switching to a response file
makes things run much faster. This is a precursor to fixing
the actual problem in bug 487035, because we will be doubling the
number of times we need to call gn refs in the fix.

R=scottmg@chromium.org
BUG=487035
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/1131623006

Cr-Commit-Position: refs/heads/master@{#329799}

This is the Chromium side changes to record UMA stats for Gesture Editing on the Virtual Keyboard. A follow up CL will be written on Google3 to populate these stats.

BUG=487323

Review URL: https://codereview.chromium.org/1135283003

Cr-Commit-Position: refs/heads/master@{#329798}

Changes:
- Show "Retry" button only download is resume-able.
- Open chrome://downloads when user clicks a notification

BUG=477970
TEST=manually tested

Review URL: https://codereview.chromium.org/1087843004

Cr-Commit-Position: refs/heads/master@{#329797}

TEST=Tested manually with a fake provider extension.
BUG=474146

Review URL: https://codereview.chromium.org/1136193002

Cr-Commit-Position: refs/heads/master@{#329796}

BUG=487364

Review URL: https://codereview.chromium.org/1138363004

Cr-Commit-Position: refs/heads/master@{#329795}

Review URL: https://codereview.chromium.org/1140063003

Cr-Commit-Position: refs/heads/master@{#329794}

Gallery applies viewport both screen size cache, and full resolution image. To
handle the different size of two images, it used to set CSS 'width' and 'height'
style to the full resolution image so that the full resolution image can be
regarded as the same size of screen cache image.

But ImageView.Effect class, which is used for playing edit animation, does not
update the CSS properties. It causes wrong layout during the edit animation.

The CL removes the trick of CSS property, and let ImageView.Effect take into
account of the size of target canvas.

BUG=487129
TEST=Do and undo cropping and rotaiton.

Review URL: https://codereview.chromium.org/1138053003

Cr-Commit-Position: refs/heads/master@{#329793}

There is no need to limit the FSP API to non-incognito only. Especially, such
limitation was causing crashes in Files app running in incognito, which
assumed the service exists, but it didn't.

With this CL the service is created for both non-incognito and incognito pages.
Both instances are *same*, so mounted providers will be shared between incognito
and non-incognito windows.

TEST=Tested manually by launching with --incognito
BUG=487901

Review URL: https://codereview.chromium.org/1138423002

Cr-Commit-Position: refs/heads/master@{#329792}

TBR=suzhe@chromium.org
BUG=487914
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/1144493005

Cr-Commit-Position: refs/heads/master@{#329791}

BUG=487674
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1132783005

Cr-Commit-Position: refs/heads/master@{#329790}

BUG=485381

Review URL: https://codereview.chromium.org/1132223005

Cr-Commit-Position: refs/heads/master@{#329789}

Cr-Commit-Position: refs/heads/master@{#329788}

Adds paper-fab, paper-toolbar and polymer/layout, which are required by
the material PDF viewer. Also adds required files from existing
components to polymer_resources.

BUG=482793

Review URL: https://codereview.chromium.org/1140583003

Cr-Commit-Position: refs/heads/master@{#329787}

During startup, Chrome expects synchronous display configuration, so we
need to present the list of displays before we get a chance to connect
to the GPU process. This patch will populate a list of dummy displays on
startup and the platform will pretend it can configure them until the
connection to the GPU process is established.

BUG=484294

Review URL: https://codereview.chromium.org/1131813003

Cr-Commit-Position: refs/heads/master@{#329786}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d7eac4f..7aa732b

TBR=alancutter@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/1129073003

Cr-Commit-Position: refs/heads/master@{#329785}

* Add a <select> element to the dialog allowing the user to choose a category, or "other".
* Disable the OK button and hide the reset options until a category is selected.
* Clean up some duplicated code now that this dialog depends on base.js.

BUG=b/20950552

Review URL: https://codereview.chromium.org/1131153003

Cr-Commit-Position: refs/heads/master@{#329784}

Noteworthy in this roll is that InterfacePtrs may no longer be
bound-to or passed-as simple pipe handles, but instead as
InterfacePtrInfos. This requires updating several call sites
of InterfacePtr's Bind and PassMessagePipe.

BUG=
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1127293003

Cr-Commit-Position: refs/heads/master@{#329783}

BUG=486187
TEST=covered by test

Review URL: https://codereview.chromium.org/1138253003

Cr-Commit-Position: refs/heads/master@{#329782}

Prior to this CL, the AutocompleteTextField becomes first responder if the user
left-clicks a decoration. This is a bug that this CL fixes. This also fixes a
bug where ZeroSuggest did not disappear when the user drags the origin chip.

BUG=356887

Review URL: https://codereview.chromium.org/1011943002

Cr-Commit-Position: refs/heads/master@{#329781}

Previously MessageReader was stopping reading after the first error,
but wasn't notifying the client about the problem. This results in some
errors (e.g. from SSL layer) being ignores while they should terminate
connection.

BUG=487451

Review URL: https://codereview.chromium.org/1143443003

Cr-Commit-Position: refs/heads/master@{#329780}

TBR=
BUG=

Review URL: https://codereview.chromium.org/1140093004

Cr-Commit-Position: refs/heads/master@{#329779}