- 28 Jan, 2019 30 commits
-
-
Kent Tamura authored
Restarting Chrome application, duplicate a tab, and back/forward navigation call 'restoreValueCallback' of form-associated custom elements to restore their state. Implementation: * element_internals.{h,cc}: Hook some methods to support the state restore feature. ElementInternals::RestoreFormControlState() posts a microtask to call 'restoreValueCallback'. * form_controller.{h,cc}: - ControlType() supports ElementInternals. We store custom element name as a type. - SavedFormState::Deserialize(): Accept custom element names. - FormController::RestoreControlStateOnUpgrade(): Added for upgraded custom elements. * html_element.{h,cc}: FinishParsingChildren() Hook it to restore the state of form-associated custom elements which are not owned by a <form>. * file.{h,cc}, file_input_type.cc: Move logic to save/restore File state to blink::File in order to share it with ElementInternals. Change-Id: Idb8ea5d333afbd566ae838334800cbf0b8128af5 Reviewed-on: https://chromium-review.googlesource.com/c/1436416Reviewed-by:Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#626447}
-
Donna Wu authored
This CL introduced a new class extensions::UsbDeviceManager and merged it with existing extensions::UsbEventRouter. This new class will proxy all USB mojo requests in chrome.usb extension implementation. Bug: 716628 Change-Id: Ie296e6682dedd938e59432dd3b35f2a92fc9a69a Reviewed-on: https://chromium-review.googlesource.com/c/1424739 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626446}
-
Leon Han authored
After crrev.com/c/1433854, this CL moves content/public/common/renderer_preference_watcher.mojom -> third_party/blink/public/mojom/renderer_preference_watcher.mojom BUG=869748 TBR=thestig@chromium.org for trivial changes in chrome/ Change-Id: I7d2c1ce4d9b353bf3020f9cdcc4f354909bba3fc Reviewed-on: https://chromium-review.googlesource.com/c/1436879 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#626445}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 925652 Change-Id: Id5d334e4d4baa89dac5aa5a5e64d558c8bef14e2 Reviewed-on: https://chromium-review.googlesource.com/c/1438320 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#626444}
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: Ic8ff151b1980b55a31106f93a1ad5b174fdfeae2 Reviewed-on: https://chromium-review.googlesource.com/c/1438676 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/381f6a7d336b..47a5a2d44bec Created with: gclient setdep -r src-internal@47a5a2d44bec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idb39b0f745cea87d582214cefae3aa3d736d1916 Reviewed-on: https://chromium-review.googlesource.com/c/1437636Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626442}
-
Leon Han authored
crrev.com/c/1426522 enables us to move renderer_preferences.mojom out of //content, this CL does so. content/public/common/renderer_preferences.mojom -> third_party/blink/public/mojom/renderer_preferences.mojom BUG=869748 TBR=skyostil@chromium.org, boliu@chromium.org, rockot@google.com for trivial changes in headless/, android_webview/, and extensions/. Change-Id: I08b0a975b5b2760dde0abbe0ed664c3ddf680312 Reviewed-on: https://chromium-review.googlesource.com/c/1433854Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#626441}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Icb70b334ef0da71d912b416f6e27bae3eb66fd34 Reviewed-on: https://chromium-review.googlesource.com/c/1438464Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#626440}
-
Dmitry Gozman authored
We are not using loader for main resources anymore. Bug: 855189 Change-Id: I56c5d04e0088f1ae2c1ce6fe2cee9cbfe3ac90d2 Reviewed-on: https://chromium-review.googlesource.com/c/1424166 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This is a followup of crrev.com/c/1436464. With the previous patch, callers of NGOffsetMapping::GetMappingUnitsForDOMRange() no longer need to clamp out-of-range portions of the units by themselves. As a followup, this patch removes the code handling partially out of range units. Change-Id: I5a7452d995365939509ba7a763de20ee2acf47a4 Reviewed-on: https://chromium-review.googlesource.com/c/1437193Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626438}
-
Weiliang Chen authored
Using mipmap for render pass is essential for trilinear filtering. This CL make sure the mipmap information is passed through and uses SkiaRenderer for trilinear filtering pixel test as well. Bug: 763664 Change-Id: Ief187424c75a73941ef6dc54ee38c30a83f87aa2 Reviewed-on: https://chromium-review.googlesource.com/c/1432096 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#626437}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/chromeos/system/tray_accessibility_browsertest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=tetsui@chromium.org Bug: 925652 Change-Id: Ibda100f51a5749a1489641d0b86674f874175fc4 Reviewed-on: https://chromium-review.googlesource.com/c/1438257Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#626436}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /content/renderer/media/webrtc/rtc_video_encoder_unittest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=hiroh@chromium.org Bug: 925652 Change-Id: Ifab14da6b1e5f03f4f15eeee79bf3c334a0c4642 Reviewed-on: https://chromium-review.googlesource.com/c/1438391Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#626435}
-
Yuki Shiino authored
CallbackFunctionTreatedAsScriptValue is a deprecated type, and we'd like to get rid of it. This patch stops using it in TaskWorkletGlobalScope. As several other worklets are going to use IDL callback function of type |any ()|, this patch introduces: callback NoArgumentConstructor = any (); in common_definitions.idl. Change-Id: I1d30b39107077ded1730d4a03efa4f3cde19f06f Reviewed-on: https://chromium-review.googlesource.com/c/1436420Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#626434}
-
Yuki Shiino authored
IDL type definition of CustomElementConstructor in document.idl is no longer used. We have the definition in custom_element_registry.idl. Change-Id: I88b44330c083c337a91a3c90ec4fe3056c688037 Reviewed-on: https://chromium-review.googlesource.com/c/1437035Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/866fe216c906..381f6a7d336b Created with: gclient setdep -r src-internal@381f6a7d336b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4d352de902f11e684bed5607ff52b52a8c6663de Reviewed-on: https://chromium-review.googlesource.com/c/1438651Reviewed-by:
-
Yuki Shiino authored
CallbackFunctionTreatedAsScriptValue is a deprecated type, and we'd like to get rid of it. This patch stops using it in Task Worklet. Change-Id: I49aa194a4432dd8fa9bf97995f7a0465c32b52ee Reviewed-on: https://chromium-review.googlesource.com/c/1436417Reviewed-by:
-
Yuzu Saijo authored
This CL adds devtools protocol method which purges v8 memory forcibly in order to test OomIntervention v2. The plan is to write tests which purge v8 memory using this method, just like OomIntervention v2 does (in OomInterventionImpl), and run the tests on Cluster Telemetry to see if how much memory is actually saved on the real pages. Design doc of OomIntervention v2: https://docs.google.com/document/d/1koOLSc2e2g1pGjONDEERD5Sae1ds9mllEKgjxkJYRCE/ Change-Id: I7f6cbb5d41639095f030b94a7d16ebf53f9f012e Reviewed-on: https://chromium-review.googlesource.com/c/1411712Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#626430}
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/chrome_service_worker_browsertest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 925652 Change-Id: I4afbb4857597507efe889213423b677deec180ac Reviewed-on: https://chromium-review.googlesource.com/c/1438285 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#626429}
-
Shik Chen authored
BUG=b:117810572,chromium:918091 TEST=Pass presubmit checks. Change-Id: If8c05d8a11de12d56dd28fbf50ce5f0412623e4a Reviewed-on: https://chromium-review.googlesource.com/c/1429723 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#626428}
-
David Staessens authored
> This helper provides more flexibility and improves code re-use. Currently only > writing to png files is supported, but it's easy to expand the interface to > writing raw files etc. > > TEST=ran new VDA tests on nocturne > > BUG=879065 > > Change-Id: I08ea462f98c9aba993ec7ef0b64d74fef11360fa > Reviewed-on: https://chromium-review.googlesource.com/c/1420490 > Commit-Queue: David Staessens <dstaessens@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626007} BUG=879065 Change-Id: Idbdabf9aa91fb170f48b21fe05bd4fefe4a2ae6e Reviewed-on: https://chromium-review.googlesource.com/c/1436473Reviewed-by:
-
Yuzu Saijo authored
This CL adds metrics that measures time between the start of detection and the trigger of intervention, which is recorded even in detection-only mode, in order to count how many times intervention is triggered. We will conduct detection-only finch experiment where the metrics are recorded but intervention is not actually triggered, in order to gather data and adjust thresholds. Change-Id: I431d6eebc7ab0860e0db47b09a1ab25f69e09bca Reviewed-on: https://chromium-review.googlesource.com/c/1426498 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Victor Costan authored
test: Replace _TEST_CASE_ with _TEST_SUITE_ in /content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc. Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 925652 Change-Id: I42dfd3ed4aec3b6fba84437cc538c6f3c3b545f4 Reviewed-on: https://chromium-review.googlesource.com/c/1438355 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#626425}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2ab8619548a..866fe216c906 Created with: gclient setdep -r src-internal@866fe216c906 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic1e2f198b9fefc4389b6d9a263321deac29013f6 Reviewed-on: https://chromium-review.googlesource.com/c/1438491Reviewed-by:
-
Hirokazu Honda authored
This reverts commit 233c7717. Reason for revert: crbug.com/925705 Original change's description: > Reland "media/gpu/VEA unittest: Verify encoded content on Chrome OS by default" > > VEA unittest verifies VEA's encoding content by > 1. decode content by FFmepgVideoDecoder > 2. compare it with the original VideoFrame and computes SSIM > 3. check the SSIM less than or equal to the predetermined threshold, 10.0. > > VEA unittest turns on this verifitcation by --verify_all_output and one of test > case parameters. This verification was always disabled on Chrome OS by setting > --verify_all_output false because of https://crbug.com/694131. I think the bug > is already fixed. We can re-enable the verification on Chrome OS now by default. > > TBR=kcwu@chromium.org > > Bug: 923762 > Test: VEA unittest on eve > Change-Id: I597346a9ecd114ccc37ebde1ab284b97103a6e4f > Reviewed-on: https://chromium-review.googlesource.com/c/1429307 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625101} TBR=hiroh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923762 Change-Id: If8863bcbca29a3b78b36a208bff07bc90896a319 Reviewed-on: https://chromium-review.googlesource.com/c/1438674Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#626423}
-
Yoichi Osato authored
Since DevTools doesn't use v0 APIs from crrev/c/1422962, we don't need the exception for v0 removal. Bug: 685385 Test: run_web_tests.py http\tests\devtools on v0-removed patch: https: //chromium-review.googlesource.com/c/chromium/src/+/1433636 Change-Id: Ia1226e43d7b1cf9b07a727537252a6a0bdbbe058 Reviewed-on: https://chromium-review.googlesource.com/c/1436283Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#626422}
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=horo@chromium.org Bug: 925652 Change-Id: I4b558b880e6c19e396bb257d3ac6cbab335968f8 Reviewed-on: https://chromium-review.googlesource.com/c/1437347 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#626421}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5c6a1734. With Chromium commits locally applied on WPT: 20defaa4 "[LayoutNG] ComputeReplacedSize min/max width/height fix" 40748e1e "Upstream fast/workers to external/wpt/workers: first batch." 6691ad3f "Fix preload tests failing on wpt.fyi dashboard, second attempt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If8f6e28ff53543e3b0df166a5128809a0b02f0cd Reviewed-on: https://chromium-review.googlesource.com/c/1437990Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626420}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3aa7a422f9a0..d2ab8619548a Created with: gclient setdep -r src-internal@d2ab8619548a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4aa5d37c34853148cb3f12bb838b1673442ef6b1 Reviewed-on: https://chromium-review.googlesource.com/c/1438486Reviewed-by:
-
Wenzhao Zang authored
I'm not able to reproduce the failure locally, but I think the analysis in crbug.com/908481 should be the cause of the failure. Bug: 904644 Change-Id: Ie532f5060d2b745c2f92720213480af0b711cd5e Reviewed-on: https://chromium-review.googlesource.com/c/1354648 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#626418}
-
- 27 Jan, 2019 10 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad3ab831db32..3aa7a422f9a0 Created with: gclient setdep -r src-internal@3aa7a422f9a0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I50ed01b09354f67e0a9723bd908056a5554b917c Reviewed-on: https://chromium-review.googlesource.com/c/1438485Reviewed-by:
-
Weiliang Chen authored
Take into account resource's color space information in SkiaRenderer so color correction gets applied. This is done by plumbing through color space information. Since SkColorSpace does not cover everything in gfx::ColorSpace, this patch does not pass all the color transformation pixel test. Further investigation is needed for the failure cases. Bug: 795132 Change-Id: I1712e4625a055fd93af7702509d167e33667671d Reviewed-on: https://chromium-review.googlesource.com/c/1374460 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#626416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04c2991c29c1..ad3ab831db32 Created with: gclient setdep -r src-internal@ad3ab831db32 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I64a7697cc3f5fb30be0d301ffee879a87c317785 Reviewed-on: https://chromium-review.googlesource.com/c/1438484Reviewed-by:
-
Mike Reed authored
TBR=vmpstr Change-Id: I860af82ac6e3d0276e54a1d6e1f0bc77a4e5634b Reviewed-on: https://chromium-review.googlesource.com/c/1438460 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#626414}
-
Morten Stenshorne authored
Avoids some code duplication. Change-Id: Ic795ad509ffa3b3fa72c954351fb8ae58665bf50 Reviewed-on: https://chromium-review.googlesource.com/c/1433621Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#626413}
-
Matt Menke authored
Also rewrite most SSLClientSocketPool tests to only test SSLConnectJob. This is a step towards expressing SSLConnectJob in terms of other ConnectJob types, removing its dependency on other SocketPools, and having the TransportClientSocketPool to create SSLConnectJobs directly, pooling SSL sockets with TCP sockets. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: Ibbcc83d83308426ec14f6a631b372a4d144b705f Reviewed-on: https://chromium-review.googlesource.com/c/1419502 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#626412}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cda71886b57b..04c2991c29c1 Created with: gclient setdep -r src-internal@04c2991c29c1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5476ebd5e2426c58a6e30ad2dad57804b0add74f Reviewed-on: https://chromium-review.googlesource.com/c/1438483Reviewed-by:
-
Victor Costan authored
Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googltest version that supports _TEST_SUITE_ macros instead of _TEST_CASE_, so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature This CL was uploaded by git cl split. R=tonikitoo@igalia.com Bug: 925652 Change-Id: I700e98ab09e7f15d3aaded10bf66c1ae309a0605 Reviewed-on: https://chromium-review.googlesource.com/c/1438258 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#626410}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/632d2722dda6..cda71886b57b Created with: gclient setdep -r src-internal@cda71886b57b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7a9aaf8bef140441750b7cbe8926ad2c5c4c5699 Reviewed-on: https://chromium-review.googlesource.com/c/1438482Reviewed-by:
-
Robert Ma authored
On Windows, when a partial path to a virtual suite (or tests) is given, the runner may fail to find all the tests because it adds an OS-dependent path separator ('\' on Windows) instead of TEST_SEPARATOR (always '/') to the given path. Also fixes some code-health issues (unused imports & pylint warnings). Bug: 880609 Change-Id: I2f5ba3f0864c164432d7b81379c1b81719ec7b79 Reviewed-on: https://chromium-review.googlesource.com/c/1437708 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#626408}
-
