- 12 Oct, 2020 40 commits
-
-
David Manouchehri authored
Bug: 1136327 Change-Id: I8ced300d7de0e2465e54d5111f915af425c66c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463708 Auto-Submit: David Manouchehri <david@davidmanouchehri.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#816320}
-
Bo Majewski authored
Bug: 1113981 Change-Id: I90081b67e4e1cc4313e8a9c441ac05fed7ba7320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437715Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#816319}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4aa4c6014d56..3637a44a3643 2020-10-12 mtklein@google.com update comments and rearrange SkVx.h 2020-10-12 egdaniel@google.com Update attachment unique key to handle format and protected. 2020-10-12 michaelludwig@google.com Take crop rect into account for input bounds/reverse filter bounds 2020-10-12 mtklein@google.com power up skvx::map 2020-10-12 bsalomon@google.com Revert "Revert "Use ManagedBackendTexture in place of TestUtils backend texture helpers."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I977022183f836d44307e59607298d631b2f8f090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816318}
-
Xianzhu Wang authored
Change-Id: I84a1149e64d477ade11df1b114187feeea6757aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466384Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816317}
-
Antonio Gomes authored
This replaces the use of ash::TabletMode and ash::TabletModeObserver in BrowserNonClientFrameViewAsh. This corresponds to phase 2.6 on the design document [1]. Covered by existing tests, eg BrowserNonClientFrameViewAshTest.BrowserHeaderVisibilityInTabletModeTest HomeLauncherBrowserNonClientFrameViewAshTest.TabletModeBrowserCaptionButtonVisibility [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=sky@chromium.org Change-Id: I6a21ca44538e52a2712bbb936221aa24063daa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462560 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#816316}
-
rajendrant authored
Currently throttling is temporaily stopped, i.e., new requests will get throttled, on too much rebuffer events. This CL changes it to stop permanently. Bug: 1137505 Change-Id: Iae6453c3799229939415bac5205450b82c4a4ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466605Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#816315}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30127e006a5b..b49605bd62cd 2020-10-12 patrick.brosset@microsoft.com Track when custom properties are edited If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifd7696b78bc11639c6e8c27238bdde2d1fdd3e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466331Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602503558-f6db874387e2078784a354d0f7c8c59a21bebaa6.profdata to chrome-mac-master-1602525418-295b1a16e5c5eb1a611980e5afdf689a2be9286a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1c019a5b5153f9b13febc77377cc4eb1743f3bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466639Reviewed-by:
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Ic8080d5d61bb7b74a445f70240611aff5c4d9148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462080 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#816312}
-
Michael Irani authored
Add aria tags so that label and value for fields announced when in ChromeVox mode. Bug: 1034104 Change-Id: I47e7b98a01fb8ef694f179f26e120a67d4341859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464054Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Michael Irani <michaelirani@chromium.org> Auto-Submit: Michael Irani <michaelirani@chromium.org> Cr-Commit-Position: refs/heads/master@{#816311}
-
Nick Czajka authored
This change modifieds the behavior of night_light_controller.cc to selectively apply ambient color to only internal displays. It also restructures night_light_controller_unittest.cc to allow for multiple displays in AmbientEQTest. The two tests affected by this change are also moved from NightLightTest into AmbientEQTest. Bug: 1078901 Change-Id: Ie967698d99713026591b44ddeaee294f80e2df60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453904 Commit-Queue: Nick Czajka <czajka@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#816310}
-
Hiroki Nakagawa authored
These functions are declared in prerender_util.h, but not defined. - ReportPrerenderExternalURL() - ReportUnsupportedPrerenderScheme() According to the Git history, the definitions were removed by this CL: https://crrev.com/c/c2157903 Bug: 755921 Change-Id: Id070c760d5769be2f97b36213e4fd9360a01fd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465355 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#816309}
-
Hiroki Nakagawa authored
This directory contains only OWNERS file. Files existed there were moved into components/ for supporting NoStatePrefetch on WebLayer, for example, by https://crrev.com/c/2310329. Bug: 1096088 Change-Id: Ie22858163b75cfb825acaca8b01017a4a04b0afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463050Reviewed-by:
-
Gang Wu authored
1. Add a custom view for "Add to" menu item, which contains a divider line and an "Add to..." menu item. Also split "Add to Home screen" and "Install app" two menu items because of https://docs.google.com/presentation/d/1z9yWp7-qcP0BCLo9_3z-8X6xGntkH1tqRjbGP0lXyiw/edit#slide=id.g980eadd427_0_423 2. Using ModalDialogManager to create "Add to:" window. Bug:1135185 Change-Id: I707ac343d9de6f252e93ab97b1a8bc083d8f1138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446450 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#816307}
-
Tim Judkins authored
The nodefine property was added over 4 years ago when deprecating some Media Gallery APIs. This CL removes those deprecated APIs, along with the nodefine property. Bug: 1136659 Change-Id: Idf087287926903fbaa83ee13c2340320043fc038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462254Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#816306}
-
Collin Baker authored
This behavior broke in a recent change, causing stale thumbnails and a DCHECK in enabled builds. Fixed: 1137330 Bug: 1136247 Change-Id: I70bee4d25e2c0693bcf55fe95dc2744dfb354456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464785Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#816305}
-
Dana Fried authored
Capture was banned for current tab as a workaround for crbug.com/1112607, but a fix for the root cause has been submitted and is in M87. Now the workaround - a lesser of two evils - is causing trouble and no longer necessary (see attached bug). Bug: 1137133 Change-Id: If00ddacf3b55d7b17d28ab5064410bbc13b7779c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463871 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#816304}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602482293-b6c9af61d9b709e1e409c88a2a609d5546a5c2ce.profdata to chrome-win64-master-1602503558-c2e745b5a37c8ee5f138ede7ee7fff767428f64a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I739f37103933c59b09a08d939e8974b44133785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465771Reviewed-by:
-
Lucas Radaelli authored
The Fuchsia Semantics API changed, so this change converts the new added roles. Note that this change is not converting the added roles related to lists, which will be solved in a future change. Test: AXTreeConverterTest.ConvertRoles Bug: fuchsia:60180,1136536 Change-Id: I23e8b0dc02e2e9f85cae16be81c400744831905a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461954 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816302}
-
Elly Fong-Jones authored
Replace it with a vanilla WidgetDelegate using the default contents view. Bug: 1075649 Change-Id: Ia3beabd4bedc512452cc9430ed605d4b829c727e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461212Reviewed-by:
-
Alex Newcomer authored
If the profile being left had a folder, we kept a reference to that folder in AppListModel's ScopedObserverList. But when profiles are swapped, we delete everything in the AppListModel::top_level_item_list_. This means the folder is deleted. Remove the item from the ScopedObserverList if it is a folder. Bug: 1130901 Change-Id: I1d6ab268739f81904debcc4654e5663ddf768013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464151 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816300}
-
Anders Hartvoll Ruud authored
Having a separate copy-pasted codepath for selector matching is not acceptable for maintainability reasons. Instead we can lazily create an actual Element to represent the almost-featureless element described by the spec [1], and use this as the originating element during selector matching. The element has no ID, no classes, no attributes, no tag name, no namespace, no parent, no siblings; so it should be pretty hard to match against it. Longer term it would be nice to make the originating element actually featureless [2]. Bug: 1137349 TEST=external/wpt/webvtt/rendering/cues-with-video/processing-model/support/embedded_style_selectors.html [1] https://w3c.github.io/webvtt/#obtaining-css-boxes [2] https://github.com/w3c/webvtt/issues/477 Change-Id: I06d618546893be3942ea5406507a01bc508340d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462274 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#816299}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716915427088..933ae5eaad9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mahmadi@google.com,gab@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1133394,chromium:1137431 Tbr: mahmadi@google.com,gab@google.com Change-Id: Ib05920163f5725801ddd34b9907e4836b5ff80ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465514Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816298}
-
adamta authored
Adds the content suggestions collection view to the VC hierarchy from the BVC. The named guide for the Discover feed IPH was not usable since it could not make its way up to the BVC through its view hierarchy. Bug: 1131571 Change-Id: I97d6f4d9e0dc8642b93b040c2c1003f3588f853d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414613 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#816297}
-
Akihiro Ota authored
This is a temporary fix for the blank display name for yue-HK. The reason we were returning a blank string is because we were calling GetDisplayNameForLocale() with the disallow_default parameter. Remove this parameter so we at least get a return value. Please see the bug for more context. readable text label on TTS settings page. Bug: 1136353 Change-Id: I123c05134782e90c8b297fea6c48287e7fc5dd8c AX-Relnotes: Fix an issue where the Yue (Hong Kong) voice had no Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463600 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816296}
-
Akihiro Ota authored
This change further refines the locale announcement given when switching between locales within the same language. We announce the locale once when switching to more specific locales, e.g. en -> en-us. We never announce the locale when switching to less specific locales, e.g. en-us -> en. Finally, all subsequent switches from en -> en-us will not be announced. The above logic only applies when we stay within the same language. If the language changes e.g. en -> pt, then the above state will reset. This change also adds a test to confirm behavior. We also removed a test since it can be merged into the new test. same language. Bug: 1098548 Change-Id: Ie7015f68bc6c6c747065d815697584f5fd642092 AX-Relnotes: Refine voice switching behavior when switching within the Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466497 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Nathan Zabriskie authored
In OOPR Canvas mode we don't use |skia_canvas_| in the renderer process. This CL skips the DCHECK in CanvasResourceProvider::OnContextDestroyed since we know |skia_canvas_| won't be present. Bug: 1018894 Change-Id: I98a0ba4e4c819912e155e2785dd60354f429e42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462633Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816294}
-
David Tseng authored
Rename IsEventTypeHandledByAXEventGenerator -> ShouldIgnoreAXEvent to mirror the variant for AX event generator. R=dmazzoni@chromium.org AX-Relnotes: n/a Test: existing tests Change-Id: I5600ac87fb4369330c27c0b52c70ab112958b41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464981 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#816293}
-
Carlos IL authored
crrev.com/c/2451549 broke the proceed action on interstitials. This adds a tab storage class that stores when we are in the middle of a proceed, and we no longer show an interstitial if that is the case. This also fixes the "reload is proceed" bug (crbug.com/1093955). Bug: 1134466, 1093955 Change-Id: Ibe6f6eab757cf8ea58def940793ffb7a7f68d1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454387 Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#816292}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602503558-6db36755351afd56b86dda41eeed03adf268112f.profdata to chrome-linux-master-1602525418-afe56390c440c08698d6b71f1c497e873e6a051a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I25942ad772f54767f18ec12dead10be97604b950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466329Reviewed-by:
-
Dmitry Gozman authored
Bug: 1137291 Change-Id: Ic715eccbbbc9bd8b7eb8877df786f21c5f54db94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462091 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Currently, we crash. Bug: 1136823 Change-Id: I4570e8edaab9f95d81eaed2ae2f22570444b6659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462262Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#816289}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1da46abbddb6..1e73818c7ac8 2020-10-12 mbonadei@webrtc.org Triggering all the bots. 2020-10-12 eshr@google.com Reland "NV12 support for VP8 simulcast" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd6e034911f909a175388d8875154e83920b5b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465580Reviewed-by:
-
Nico Weber authored
Bug: 1137503,1132930,1103490 Change-Id: Ib189602b324508ffded4fdc00e175d56fe6d8903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465067 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816287}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0f55e3e5d266..336202d7d601 2020-10-12 jmadill@chromium.org Test Runner: Pass batch ID to child processes. 2020-10-12 cnorthrop@google.com FrameCapture: Move compressed texture cache to shared location If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Test: Test: Asphalt 8 MECTest: Test: https://chromium-swarm.appspot.com/task?id=4f2b87c4f8234910 Change-Id: I7074836b4d3dee092c6ec67bed877922513f91cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465867Reviewed-by:
-
Egor Pasko authored
This reverts commit 6c09107f. Reason for revert: in favor of https://chromium-review.googlesource.com/c/chromium/src/+/2466057 Original change's description: > Disable monochrome_apk_checker on bots running with Android emulator > > At least one bot (see crbug.com/1137405) started failing after > crrev.com/814863 with a message: > > 'unrecognized arguments: --avd-config=...' > > Since a few related changes landed on top, I'm not comfortable reverting > it. Rather making the check pass with this configuration. Tested locally > by providing the same command line arguments as on the bot. > > Tbr: dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org > Bug: 1137405, 1115604 > Change-Id: I28c9e3179fdbbc36ec515ed6aba8ce12f78a9417 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464270 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816171} TBR=pasko@chromium.org,dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org Change-Id: Idbf4716df8f967209ff155756186a41e2b6e7a93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137405 Bug: 1115604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466423Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816285}
-
Sunil Kumar authored
Bug: 168739659 Test: CQ Change-Id: Ib08ee3223f32318653b3bd6924fedf718887bb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453916 Commit-Queue: Sunil Kumar <skx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816284}
-
Peter Boström authored
Moves ChromeLayoutProvider::GetDistanceMetric() values of views::DistanceMetric into views::LayoutProvider::GetDistanceMetric(). As ChromeLayoutProvider was effectively always overriding these, the set of constants in views::LayoutProvider were effectively unused. This calls views::LayoutProvider::GetDistanceMetric() for any values defined in views::DistanceMetric. It also (by static_cast<>) ensures that all values of views::DistanceMetric and ChromeDistanceMetric are handled in their respective switches. Finally, DISTANCE_BUBBLE_PREFERRED_WIDTH and DISTANCE_MODAL_DIALOG_PREFERRED_WIDTH are both moved into views:: as they are used (but previously inlined with a TODO) in BubbleDialogModelHost. Bug: None Change-Id: I5d890895eacca02d8a59d20714b8bf56040de97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461220 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#816283}
-
Stefan Zager authored
BUG=1137432 Change-Id: Id58e5ba66e1ca0c03df0c51fcb4615d2ab1ae3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465209Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#816282}
-
Pavel Yatsuk authored
InfoBar.java has a native reference to InfoBarAndroid which should be cleared before InfoBarAndroid is destroyed. Calls to java_info_bar_.Reset() without corresponding onNativeDestroyed() or setNativeInfobar() allow scenarios where java InfoBar still has non-null pointer after native object was destroyed. This results in occasional use-after-free. This CL: - renames onNativeDestroyed method to resetNativeInfoBar to indicate that it is not necessarily called when native is destroyed, but in general when native-java association changes. - adds a call to reset native infobar into CloseJavaInfoBar to prevent java infobar from referring potentially destroyed native object. - removes unused ReassignJavaInfoBar(). BUG=1135130 R=mdjones@chromium.org Change-Id: I1329ed6a78cc589d8f23df883a8fcb60689230a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459268Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#816281}
-
