You need to sign in or sign up before continuing.
- 01 Jul, 2020 40 commits
-
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I6a0e4f1c679d72cb799374dc1e20b93a71b872cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277975 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784482}
-
Fabrice de Gans-Riberi authored
This reverts commit 30df8d48. Reason for revert: Broke linux-chromeos-chrome compile. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/6735 Original change's description: > Refactor platform keys service token ID > > This CL changes how platform keys service expects token IDs from the > service consumers and makes it clear what to expect in special cases > like empty/unprovided token IDs. > > Before this CL, platform keys service was accepting token IDs as strings > which is not as clear as enums especially for the cases of empty > strings. > > Bug: 1073512 > Change-Id: I4cbdfdc8f22b23ce0297314915e52804b2e495f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270069 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Michael Ershov <miersh@google.com> > Cr-Commit-Position: refs/heads/master@{#784448} TBR=emaxx@chromium.org,pmarko@chromium.org,miersh@google.com,omorsi@google.com Change-Id: Ib163fce34664943e586b43a8c4a9f79eb59be260 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277117Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#784481}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Id57510e812405bdd453adbbb0b2d23c96a2fc34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274721Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#784480}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fdee3989..9e077af8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If528c8ad5193fd08196c0d0188fca23605073c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277663Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784479}
-
Swapnil authored
ExtensionInstallEventLogUploader class acts as an adapter between the system that captures and stores extension install event logs and the policy system which uploads them to the management server. Add unit tests for the class. Bug: 1100862 Change-Id: Id0e753ebe846ce25417e8ce6be8159007b9335f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275894Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#784478}
-
Antonio Gomes authored
This is part of the effort to move as much public headers out of the Blink platform topmost public directory (//third_party/blink/public/platform/). CL also removes web_media_stream_sink.h inclusions that were needless (ie the class was not being referenced directily in the file anymore). BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I17c10db7fedd64f8f7b204bbb8fba4bf66ba1a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276403Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Fergal Daly authored
This is a reland of 8d6a9454 Difference is that this returns early on All/NavigationControllerBrowserTest.SameDocumentNavigationToHttpPortZero/2 Original change's description: > Parameterize NavigationControllerBrowserTest etc for RenderDocument. > > These tests are sensitive to RD's type of changes and several of them > needed fixing already. > > Bug: 1100745,1068965 > Change-Id: I1bd93ebac207c502d0dda7f749a4c5f25f4e506b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275459 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784274} Bug: 1100745, 1068965 Change-Id: I4e220c7847f02a7da7326fb44cabc9cc97627a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275506 Auto-Submit: Fergal Daly <fergal@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#784476}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22dad5763e9..31d659da1759 2020-07-01 almuthanna@google.com Save console selector in a constant 2020-07-01 yangguo@chromium.org e2e test: set threshold for slow test to 1000ms 2020-07-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-07-01 tvanderlippe@chromium.org Extract external module computation into rollup.config.js 2020-07-01 tvanderlippe@chromium.org Run terser minifier as part of rollup_entrypoint 2020-07-01 tvanderlippe@chromium.org Fix build configuration for acorn-numeric-separator 2020-07-01 tvanderlippe@chromium.org Fix rollup inputs for restat computation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e9fa903b524e3d9ece84b7aab0085a25967a042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784475}
-
Francois Beaufort authored
This CL makes sure the fake device stream gets updated when pan and tilt options change so that web developers get to see effects in real-time. Bug: 934063 Change-Id: Idaddacdbc22f1eb77a3b4e2fb9546c33e37f2fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276424Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a962afa04fee..c50b1e5063fe 2020-07-01 fmayer@google.com Merge "-Werror=global-constructors for heapprofd_client_api." 2020-07-01 lalitm@google.com Merge "tp: add small section on span join" 2020-07-01 fmayer@google.com Merge "Produce one pprof file per heap." 2020-07-01 lalitm@google.com tp: add link to internal metric documentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I01a24122676cc0ead8f195f69df11ccae5a8f14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278005Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I334e4309d9d5dfe1a0fb45836925dddc532b4fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277973 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mike Klein <mtklein@google.com> Cr-Commit-Position: refs/heads/master@{#784472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f4e87cd92c2..4d49a3c328fd 2020-07-01 jnchase@google.com config: build factory-endeavour daily to prep for pvt 2020-07-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-07-01 jiancai@google.com toolchain: create artifact of clang crash diagnoses 2020-07-01 saklein@chromium.org artifacts: Fix error on missing artifact. 2020-06-30 engeg@google.com trigger_cr50_signing: Validate presence of artifact before submitting 2020-06-30 achuith@chromium.org vm: Rename _SetDefaultBoard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0af66b7c48c116e3d12b8cb5a096034becb8841f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278006Reviewed-by:
-
Andrey Kosyakov authored
Note that changes in test expectation come from a more verbose error diagnostics for expected errors around input parameter validation. Upstream change: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2270757 Bug: 1099809 Change-Id: Ief16b3f8f3d083fbe33725582258fe318fa878c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254707Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784470}
-
Ravjit Singh Uppal authored
This CL addresses the comments that were made on the following CL https://chromium-review.googlesource.com/c/chromium/src/+/2232370 Bug: 1073883 Change-Id: I2b3f0faed4920888b42b9ed0f992f54e11892fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275443 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#784469}
-
Nektarios Paisios authored
This reverts commit d40c7abd. Reason for revert: Broke Linux and Win builders Original change's description: > Added back accessibility word boundaries Blink web test > > In https://crrev.com/c/2237930/ the Blink web test for accessibility word boundaries > was removed due to an issue with some, but not all, of the try bots. > > TBR=dmazzoni@chromium.org, aleventhal@chromium.org > > AX-Relnotes: n/a. > Bug: 1028830 > Change-Id: Ib5b05c68203a627f52081a6d423ed50a890f3566 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275885 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784438} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org Change-Id: Ic25df1619a2c665290ca54d405a2cc8b5c1f7eb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277738Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784468}
-
Chris Harrelson authored
Previously, PaintInvalidator optimized subtree and subpixel paint invalidation at compositing boundaries (known in the code as a "paint invalidation container"). However, these are just optimizations, and can be replaced with an optimization based on direct compositing reasons. Bug: 1100711 Change-Id: I08ad0ec10ea3d68322ddb6958e5ddce3e1cb808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276656 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784467}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie1a6057e84dd1edbbfdb06caf036cd645fb749a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277207Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784466}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e100526c3df..7bb44abccf03 2020-07-01 dproy@chromium.org [trace-viewer] Fix custom filename when saving traces 2020-07-01 dberris@chromium.org exec: Use successive doubling for sample sizes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100973,chromium:1101200 Tbr: wenbinzhang@google.com Change-Id: I36136a6f8a0be555811f301b3d9dafcc68c423c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278003Reviewed-by:
-
Clark DuVall authored
implTypeToJavaType was never getting called on the int that got passed back to the client. Change-Id: I3ae969989d5c2b6fec5842e0cf026ee296a24337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276764 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#784464}
-
Justin Donnelly authored
Per https://tools.ietf.org/id/draft-knodel-terminology-00.html, we should not have any uses of this term in our code. There are clearer and more inclusive ways of describing this concept. In this case, the geolocation header code is particularly egregious since, aside from the use of oppressive language, it doesn't even match the terminology in the histogram enum it corresponds with*, which inhibits readability. * https://source.chromium.org/chromium/chromium/src/+/master:tools/metrics/histograms/enums.xml;l=32162-32170;drc=1ed3a9904c7e5325fe034dba8817a99c343bd484 Change-Id: I83c38d82d7808964d10505b448af247499980f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269406Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#784463}
-
chrome://resources/dpapad authored
Previously the redirects dictionary had to include several subpaths separately. For example it included the following keys chrome://resources/polymer/v1_0/ chrome://resources/html/ chrome://resources/cr_elements/ This was necessary because the redirects where not applied in any particular order. By turning the dictionary to an OrderedDict there is no need to hold all these paths, and instead it can only hold the following chrome://resources/polymer/v1_0/ (special case redirect) chrome://resources/ (default redirect) Which is more robust, and allows correctly redirecting other non-special subpaths like chrome://resources/cr_components/ without having to update the dictionary. Bug: None Change-Id: I57eb1f0e9241e05a5150b6463410b653fcbf0c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274324Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#784462}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 12c233c2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: creis@chromium.org, lukasza@chromium.org: external/wpt/fetch/corb external/wpt/fetch/cross-origin-resource-policy mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I3866265717146e6986e8e850730ae5b2383a4327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277924Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784461}
-
Rune Lillesveen authored
ownerDocument() is the API for javascript bindings. GetDocument() is the more straightforward method used internally. Additionally, call UpdateStyleAndLayoutTreeForNode() earlier for getMatchedStylesForNode() which means we can remove a call to UpdateDistributionForUnknownReasons() since that is done as part of the style and layout tree update. Also removed parent_style_resolver retrieval since we can just re-use the style_resolver we already had and is always the same object. This CL is in preparation for getting rid of EnsureStyleResolver and specifically getting rid of UpdateActiveStyle() inside EnsureStyleResolver. Change-Id: I9de4fbf1896526d89b983bba2784d0cfba22b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274392 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784460}
-
Bartek Nowierski authored
Improve readability of AllocFromBucket while at it. Bug: 1092288 Change-Id: I58d6096cdeb98e36dc65db2aeb3c4b3465589736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277659 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#784459}
-
Andrew Walbran authored
BUG=1073130 Change-Id: I5b21092d16df6f27b4d8f959bd7e09ab24f66cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245485Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#784458}
-
Tao Bai authored
Change-Id: Iaa88235408b6dee758ca88d638db40a25f74e2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276751Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#784457}
-
Dominic Mazzoni authored
Previously we used an enum to select the structure element node type when building a tagged PDF. Update this to set the node type by name (as a string), so that Skia doesn't need to maintain the set of all possible node types. Also, export the appropriate specific type for headings with heading levels where possible, just like in HTML (H1 through H6). This requires plumbing through one additional accessibility attribute from blink_ax_tree_source.cc. Bug: 1100698, 1039816 Change-Id: I8189d6dac41c29cbe8662076b752a9b44901e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276580 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#784456}
-
Andreea Bacanu authored
ClosedTabCache aims to make the "Reopen closed tab" button instant for recently closed tabs. Design doc: https://docs.google.com/document/d/1SF230MYWgroe4WikDMn82ETd3-HFRzylKtIk0HZRaOU BUG=1100946 Change-Id: I43934b0fe8b60ca9bbc09f27bbb62b38e33891d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274509Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Andreea Bacanu <aebacanu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784455}
-
Jan Wilken Dörrie authored
This change implements the ranges algorithms in alg.move and alg.swap and the unary version of alg.transform. Bug: 1071094 Change-Id: Ia98681bd73702b8800dc6bdc5e37873373e7311d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267080 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784454}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5638f489af56..ba7cbf76d498 2020-07-01 zepenghu@google.com Add SkSVGCanvas api Fuzzer 2020-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 277fb4f3 to 13ebce23 (489 revisions) 2020-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 06462adde69b to 2761f01d68a7 (13 revisions) 2020-07-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b3240d0c355a to 2d6b37bbda59 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091259,chromium:1100613 Tbr: ethannicholas@google.com Test: Test: Test: CQTest: Test: Test: angle_end2end_tests --gtest_filter=*CopyTexImageTestES3.2DArraySubImage*Vulkan*Test: Test: Test: angle_end2end_tests --gtest_filter=*WebGLReadOutsideFramebufferTest.CopyTexSubImage2D*Vulkan* Change-Id: Ic270cc7996ad34bf04a570b23ed80df4a767970d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278002Reviewed-by:
-
Tao Bai authored
The test actually waited for the less events than it should. Autofilling the select control will move the focus on it and trigger additional value change event. Bug: 1069888 Change-Id: Id886e4ae3a6b665d72861ac2b6844db32d3d6451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277179Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I80e421a98f13416626d2e92dc13bd8727b422a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277967 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784451}
-
Robert Phillips authored
Due to GrContext refactoring on the Skia-side, this call site of SkSurface::MakeRenderTarget (on line 2674) will need to know that GrContext is derived from GrRecordingContext to permit an upcoming Skia roll. Here is the responsible Skia-side CL: https://skia-review.googlesource.com/c/skia/+/299867 (Make SkGpuDevice hold a GrRecordingContext) Change-Id: Ib425d1572f6dc4c8902ff2eb5a4f55c64e7096a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277964Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#784450}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ida29dc452a4add2a8a7eedc7269022769a58a234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277970 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Omar Morsi authored
This CL changes how platform keys service expects token IDs from the service consumers and makes it clear what to expect in special cases like empty/unprovided token IDs. Before this CL, platform keys service was accepting token IDs as strings which is not as clear as enums especially for the cases of empty strings. Bug: 1073512 Change-Id: I4cbdfdc8f22b23ce0297314915e52804b2e495f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270069 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#784448}
-
Haiyang Pan authored
This reverts commit 5a04dad7. Reason for revert: Tests crash consistently since the builds https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1294 https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2083 And flakily since https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel/5696 Original change's description: > Download later: Implements lots of things in download later dialog. > > This CL does the following: > > 1. Implements the checkbox. > 2. Implements the edit location text, which triggers location dialog. > 3. Make download later dialog owns a date time picker, so other callers > can share the glue code between later dialog and date time picker. > 4. Lots of tests added, lots of code refactored. > > TBR=dtrainor@chromium.org > > Bug: 1099989,1078454 > Change-Id: I3dd53c0a0694c91789398382c6deb11fbfe8006d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268467 > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784260} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: Idd5217d490c209c38a2fc1174d771daa9c877c62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099989, 1078454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278124Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#784447}
-
Haiyang Pan authored
This reverts commit b0e78262. Reason for revert: Tests crash consistently since the builds https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1294 https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2083 And flakily since https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel/5696 Original change's description: > Download later: Change the title of the location dialog. > > The location dialog title is changed to "Choose where to download" to > match the download later dialog's "Choose when to download". > > The file size is kept, the text could be "Choose where to download 15Kb" > when the file size is available. > > Also does layout polish to make the title and subtitle to match the > new download later dialog. > > Bug: 1101010,1078454 > Change-Id: I08c4965ca007afa74b5c23e019d615fbb8fcbc81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276347 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784266} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: Ic5a474e211c12fe6351a2531e5e647f553532779 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101010, 1078454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278087Reviewed-by:
-
Sangwoo Ko authored
This is cleanups to make access control of ToolbarButton's subclasses match the superclass. in order to do this, reorder some functions and modify comments. There's no intended behavior change. Bug: 1048901 Change-Id: I2f956cb40042ab9385d1b7e9203988d7c9a377e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275165Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#784445}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ie1c070801057c642961397f02dd31bad2945abdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277969 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784444}
-
Saurabh Nijhara authored
As we use std::lround(...) for calculating the number of remaining days from time remaining to reach the deadline, it can result in return value of zero if we are very close to the deadline. In this case, we need to use the last day notification strings (days_remaining = 1). The plural string IDS_UPDATE_REQUIRED_NETWORK_LIMITATION_TITLE_DAYS only has two options i.e. 1 and Other. Bug: 1048607 Change-Id: I60de9aac659503557ccc4ead60a434ae6d5184d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270186Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
