- 09 Oct, 2020 40 commits
-
-
Bruce Dawson authored
Chrome's handling of latency sensitive tasks such as video playback can easily be affected by the frequency of the Windows timer interrupt. This timer interrupt is a global resource and any process can raise its frequency. Previously this would affect thread scheduling for all processes but with Windows 10 2004 Microsoft appears to try to simulate "normal" thread scheduling in processes that did not themselves alter the timer interrupt frequency. This is suspected of causing frame drops during video playback. The easiest way to rule out this as the cause is to get all Chrome processes to raise the timer interrupt frequency to the maximum level so that they will all get scheduled according to that raised frequency. This flag should not be generally used and may be removed in the future. Bug: 1128917 Change-Id: I97fddebab251240fdb6181d6960b0dea86b9f0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458854 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815530}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6c09fd66372e1ad8456b1c9ebd832cfee5bff92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815529}
-
Sigurd Schneider authored
Bug: chromium:1135143 Change-Id: I1646dd57e0a6255d6437a58645737f2a17c9e64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461014 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815528}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.13-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I58c572e932f4affaf1a6de8017505450534c1456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463171Reviewed-by:
-
Glen Robertson authored
No functional changes. Change-Id: I0868bbd38bac1e1fd1fe366a844ae01390af40f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454553 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#815526}
-
Jan Krcal authored
This CL adds another information to the Profile.Status.* collection of histograms, namely the is-sync-enabled boolean. Bug: 1136483 Change-Id: Ibd589d9f6fb75b3732abcf83279f6f2345f39969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461274 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815525}
-
Koji Ishii authored
When |NGBoxFragmentPainter::HitTestLineBoxFragment| ported the logic from |InlineFlowBox::NodeAtPoint()|, it missed the early return by using |InkOverflow()|. This patch adds this. Test case: blink_perf/layout/culled-inline-hittest Before r793989: 420ms Before r807114: 9,064ms ToT: 374ms ToT (PaintFragment): 421ms ToT (legacy): 4.5ms This patch: 2.9ms crbug.com/1127976 added a heuristic switch, which is effective when there are many lines (and therefore |IsDescendantsCursor| is very small subset), but it may have negative effects in other cases. The root problem is NG calls it too much because of the lack of this early return. I'll remove the heuristic switch in a separate patch because it is probably no longer necessary with this numbers. Bug: 1128937, 1127976 Change-Id: Icb26007d90461c0e763d5af424704e56489e626f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463086 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815524}
-
Paula Vidas authored
This CL adds tests that check if interested data types and FCM token are included in device info when relevant feature flags are enabled. For now, FakeInstanceID::GetToken() always returns the same token, but that will be changed when FakeServerSyncInvalidationsSender is added. Bug: 1135167 Change-Id: Ide98c9371ad788be804342899b6a561ef2b30e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450150 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#815523}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: If2f121ff622e2cc86ca6d2352307543e41e1ab72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458911 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#815522}
-
Aya ElAttar authored
No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: altimin@chromium.org Bug: 1136766, 1136683 Change-Id: I8a55ab837dd54858e2a9a46485023574edef58bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461313Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815521}
-
Yoshifumi Inoue authored
This reverts commit c00ca060. Reason for revert: EditingNG is ready on Canary. Original change's description: > Change EditingNG from experimental to test > > This patch changes runtime enabled feature EditingNG from experimental > to test to avoid users who turn on "Experimental Web Platform features" > not to hit EditingNG issues. > > Bug: 707656, 1125477 > Change-Id: I81b56ff56c44da74b0702e4e2f2d81355a0a0c2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437834 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812020} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 707656 Bug: 1125477 Change-Id: Idd23638d2d3c028d3452f237c35288915154691a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463045Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815520}
-
Victor Hugo Vianna Silva authored
These tests were disabled a while ago by previous sync owners, let's try re-enabling them. Bug: 597319 Change-Id: Id66800f53f2af4ae0accb368f06dbf8c33642e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462257Reviewed-by:
-
dpapad authored
Bug: 1132403 Change-Id: I8a7d2c9c9fb54cbb7394d89afa7e91398a3ce1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460710Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815518}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.13-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1b41d7f35ea1df9c659d14601f83a277ef631dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463164Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602179909-b26649051a7d8d0314e04dcc1e82c76ad349e786.profdata to chrome-win32-master-1602201537-a14eb3c04e9257cb13970f54aebda7b1af96d2f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I46d12e9fe2b68b5a94e32c61db6729a276a778f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462768Reviewed-by:
-
Shakti Sahu authored
This CL adds : 1 - Unit test for NewTabPageVideoIPHManager 2 - Fixed video duration string and added test Bug: 1117157 Change-Id: I2026c78fcc78c90da639499c3fba799fce31c2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448109Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd8eb564689a..e078093198e5 2020-10-09 kainino@chromium.org Suppress gl_test failures on Mac ARM64 (Apple DTK) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132295 Tbr: timvp@google.com Change-Id: Iffac9c8227b46f4c03d489b3befe59a47c67bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462769Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.13-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3e9bbfc4f6a80f246ca84e8da970ba5787b0a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463162Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie74c3e151fbb69f1e07d167341a5e8dfc1adceda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462773Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/528ecb920d34..898333a6b68f 2020-10-09 szuend@chromium.org [ts] Type-check network/NetworkFrameGrouper.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36ec58707b558cbd904423a048ecc36f398efdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462772Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ae1dd93d853..aa8c4617869e 2020-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from af82ff26 to 4a368eae (468 revisions) 2020-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5f4e70b81046 to 952149303d06 (1 revision) 2020-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6b4a4a85dfd7 to 793a07e36636 (12 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ic865b9a3a661c23e2e6cf872160be7a2c9745331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462774Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The file and classes no longer need BMO in their name. Not yet done: Rename two_client_web_apps_bmo_sync_test.cc Bug: 1065748 Change-Id: I72fb70bab73f6738458b17867a00afe3e47dc942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460872 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ida6c0246026bc6aa937f42db7596ef4b902b2a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458874Reviewed-by:
-
Hajime Hoshi authored
This reverts commit 8e4ad533. Reason for revert: crbug.com/1136758 test failures on macOS Original change's description: > Add fieldtrial testing config for ButterForPasswords > > Bug: 991510 > Change-Id: I447e99f11c322478f007557ab268823ed2616042 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455446 > Commit-Queue: Jesse Doherty <jwd@chromium.org> > Auto-Submit: Marc Treib <treib@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815355} TBR=jwd@chromium.org,treib@chromium.org Change-Id: I41a6d02cb9dce80e5bc41e087c53f8b6b5be0335 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 991510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462884Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815507}
-
Hajime Hoshi authored
This reverts commit 96c04c00. Reason for revert: crbug.com/1136750 Original change's description: > Enable fetch send ArrayBuffer more than 128 MB > > This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> > so that fetch can send big ArrayBuffer. > > Bug: 919361 > Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815479} TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,yoichio@chromium.org Change-Id: Ie4339d0cf4b709efb961abe569cbe1fa7cb116e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462908Reviewed-by:
-
Antonio Sartori authored
The PolicyContainer will serve as a container for security policies (such as Content-Security-Policy, Referrer Policy, COOP, COEP) that are applied to a document and have similar lifecycles. This is the first of a series of CLs implementing the PolicyContainer. We define a PolicyContainer class in content and attach a PolicyContainer to each RenderFrameHostImpl. Change-Id: Ief6d3b342c3f458aa21b53bee265732e65f3bd1e Bug: 1130587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418316 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815505}
-
Ramin Halavati authored
On Lacros, when a browser is deleted and a new one is created, the pointer to the new browser can be the same as the old one and this could result in flaky failures. Pointer inequality check is restricted to non-lacros and and a check is added for the old and new browser profile paths. Bug: 1130131 Change-Id: Ibf7004b126587f2341623d69c7c25775fb460018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442530 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815504}
-
chrome://media-appDavid authored
Previously we were writing to loadTimeData in ChromeMediaAppUIDelegate::PopulateLoadTimeData but it was not made available via window.loadTimeData. This change adds load_time_data.js to our untrusted context so we can make use of it. Note: "/strings.js" is required to ensure LoadTimeData is non empty. Now loadTimeData looks like ``` { "data_":{ "appLocale":"en-GB", "fontfamily":"Roboto, sans-serif", "fontsize":"75%", "language":"en", "textdirection":"ltr" } } ``` Side note: also fixes html lint (don't close single tags) & sorts DEPS Bug: b/170160681, b/170423915 Change-Id: I4d73037577534ef516641e2acf86c45126d444f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437582 Commit-Queue: David Lei <dlei@google.com> Auto-Submit: David Lei <dlei@google.com> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#815503}
-
Daniel Ng authored
Followup to CL:2454914. Launches the Borealis VM if it has already been installed. Tests: Ran on DUT. Bug: b:166180697 Change-Id: I7512ce16cfc9f2e17320dce7b69732e35dc7fd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463082 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#815502}
-
Marko Ivanovich authored
In CanceledBeforeUnloadShouldNotClearRemoteFrameView test, it is possible that after executing line: document.querySelector('iframe').src = 'about:blank'; in main page's renderer process, that this process is stopped by OS scheduler. In such case, by the time we finish executing JavaScript and return to browser process, dialog might already be requested from OOPIF's process. In BackForwardCacheBrowserTest.CanUseCacheWhenPageAlertsInTimeoutLoop there is already existing class that can prevent such race conditions. Here that class is made generaly available and replaced function WaitForAppModalDialog(), to decrease chances of such problems appearing again. AX-Relnotes: n/a. Change-Id: Icf96383da1e021f2c159fccb33f37d63c23c1839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437393 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815501}
-
Wei Lee authored
This reverts commit 77826976. Reason for revert: The failure is not related to the CL. Original change's description: > Revert "[CCA WebUI] Add deploy_swa function in cca.py" > > This reverts commit 2a4aa8b6. > > Reason for revert: Speculative, suspected in breaking cros_browser_sanity_test, see https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10590 > > Original change's description: > > [CCA WebUI] Add deploy_swa function in cca.py > > > > It can help to boost the development when simply changing JS/CSS/HTML > > on CCA (SWA). > > > > Bug: 1127459 > > Test: cca deploy-swa [BOARD] [DEVICE] > > Change-Id: I3f494a8d455b4c5632f91942f95b428b03294af9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456706 > > Reviewed-by: Shik Chen <shik@chromium.org> > > Reviewed-by: Inker Kuo <inker@chromium.org> > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815087} > > TBR=shik@chromium.org,inker@chromium.org,wtlee@chromium.org > > Change-Id: I0ec15027ea4000d30ca7f7851dd8a6c806c37e0a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1127459 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461270 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815108} TBR=shik@chromium.org,olka@chromium.org,inker@chromium.org,wtlee@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1127459 Change-Id: I2745f6e90318f0051e4f03c3800a47d93c648295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463044Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#815500}
-
Hiroshige Hayashizaki authored
Bug: 824647, 1020812 Change-Id: I76a39e2bf114eb080153952a7f9abc80a1696cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454555Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#815499}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2455947 Change-Id: I31507f9c386803dc1a379177cc62472fe674ba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463043 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815498}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/19899becb76e..793a07e36636 2020-10-08 senorblanco@chromium.org Fix MSVC build of SerialStorage.h. 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 6d6aed546061 to 4311dd05c883 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f600d3aa9f26 to 6d6aed546061 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I3b75ebbd6ee35b10817a01dce21a357647207b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462009Reviewed-by:
-
Andrew Xu authored
Use the interface provided by MenuController to update the selection instead of sending the synthetic key event. Bug: 1134422 Change-Id: I30d2f05a609e6406aaaf6d4f983ac3d18fd8c498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459127 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#815496}
-
Peter Kotwicz authored
This is in preparation for a new tester which tests Monochrome.apk BUG=1115604 Change-Id: I8e817c1d4ae88c5b410aca502172f881c0864975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460714 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#815495}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I271ae6c81a3c16f65ca2e6c0027e5ce832cb5368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463062Reviewed-by:
-
Hajime Hoshi authored
Disable virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html on Linux Bug: 1136726 Change-Id: I5a1abcf0de40eb7a1fe4826d7c2676d701ff1c46 Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463023Reviewed-by:
-
Hayato Ito authored
This is a follow-up CL of https://crrev.com/c/2460366, adding more tests to cover edge cases. Bug: 1082020 Change-Id: Ia41288dfdc2d693d5be17d9b28af0657926baaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461446Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#815492}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bce4b0b83a5..528ecb920d34 2020-10-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f6c2eab2e64d6d91b0738b6afbd0da9e0c8577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462282Reviewed-by:
-
