- 05 Mar, 2020 40 commits
-
-
Alex Danilo authored
Bug: 1035691 Change-Id: I4aac6e02a90dd7e466f937e7f77a928480fb14e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087860 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747113}
-
Toni Barzic authored
If the test takes long enough, the contextual nudge will pop up, and add a ChromeVox announcement unexpected by the tests - for now, disable nudges for the test. BUG=1058682 Change-Id: Idfa7d452958c7052435f43d7c8a997fb527d5402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088688Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#747112}
-
Shakti Sahu authored
This CL fixes : 1 - ContentIndex.NumEntriesAvailable - Fixed units 2 - Extended expiration milestone Bug: 1057542 Change-Id: I1a738d5a28ac6ca9f37634cec888330416a609c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082875Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747111}
-
Yi Xu authored
In my previous cl, "Discard canvas content from frame if canvas is fully repaint", I set the |mode_| to discard canvas content from previous frame if there is some paint command in the current frame. These two are not related. So I removed the dependence in this cl. Bug: 1054666 Change-Id: Icc47a03aced6b0033cfe1b9bc5267aa514b8c456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088122 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#747110}
-
Xiaocheng Hu authored
The unit test framework unnecessarily enables async parsing and complicates the test cases. So this patch stops it. Bug: 1040632 Change-Id: Iabed725367d987c4a852d35facda96678834b4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088808Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#747109}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1d78a6c68da..f6ed96d1c23b git log f1d78a6c68da..f6ed96d1c23b --date=short --first-parent --format='%ad %ae %s' 2020-03-05 egdaniel@google.com Revert "Move GrGpuResource GrSurface and GrTexture into src." Created with: gclient setdep -r src/third_party/skia@f6ed96d1c23b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Icea13ba4f010bd5f91c02ef57bd9bbcbcf0fccbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088803Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747108}
-
John Budorick authored
Bug: 1058570 Change-Id: Icee377f781b9628b9a2683266124531134094c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088039Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747107}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/31b40ecf7208..35da12b1c3de git log 31b40ecf7208..35da12b1c3de --date=short --first-parent --format='%ad %ae %s' 2020-03-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-03-05 vidorteg@microsoft.com Sanitizing check_localizable_resources description Created with: gclient setdep -r src/third_party/devtools-frontend/src@35da12b1c3de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47f5b93fa21e2b40864a8e0b0a683d1e402ba883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088299Reviewed-by:
-
Danyao Wang authored
Before this CL, ManifestIconDownloader always downloads icons from the main frame. This creates a buggy interaction with Content Security Policy, when the manifest icon download is initiated from inside a frame. After this CL, the callers of ManifestIconDownloader can specify an initiator frame (as a GlobalFrameRoutingId) in which to download the image. The frame routing ID is passed to WebContents to find the correct frame that exposes the mojo.ImageDownloader interface. This CL also exposes the mojo.ImageDownloader interface in all frames instead of just the main frame. A subsequent CL will update the callers of ManifestIconDownloader to pass in the correct frame routing ID. Bug: 1055360 Change-Id: I31fd58453392ec4e1165ac20dc3a1284dc05f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085752 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#747105}
-
Ben Pastene authored
This is mostly a no-op, save for the fact that the hook will populate //build/args/chromeos/ with *.gn files for the affected board. Bug: 937821 Change-Id: I003d601cd463847a1b16c3ec777ea500517e5a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088331 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747104}
-
Evan Stade authored
Bug: 1058495 Change-Id: Idcc16972171811e9a338fab4659fd38f413158de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088221 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#747103}
-
Liquan (Max) Gu authored
Context: PH UI = Expandable Payment Handler UI Before change: * As users drag the PH UI, the WebContents resize after users stop dragging for 100ms. * As the PH UI opens, the WebContents flashes. It's because the sheet's offset keeps changing as during the opening animation. Each offset call WebContents to resize. After change: * The WebContents is set to its full height all the time (aka non-resizable). * As the PH UI opens, the WebContents no longer flashes. Change: * Set ThinWebView a height only when the toolbar has been laid out or the Tab view layout has changed. * Remove resizing logic Note that: * The WebContents' full height is different from FILL_PARENT, because at bottom-sheet's full height, the content area still have a part extending below the screen. This is why a delicate computation for the the height of the content visible area is still needed. Bug: 1054562, 1037646, 999196, 1058317 Change-Id: I04bab360f65109968a240c095d9c54133ecd9566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083305 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747102}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/6ffd816ce45b..af823daff93a git log 6ffd816ce45b..af823daff93a --date=short --first-parent --format='%ad %ae %s' 2020-03-05 rwkeane@google.com mDNS: Change MdnsService ctor Created with: gclient setdep -r src/third_party/openscreen/src@af823daff93a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5374f7c0d7974801d970f08d802ef60cc7cdb88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088831Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/986058e2b8a4..ca204ee2e1ed Created with: gclient setdep -r src-internal@ca204ee2e1ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iade8cf883a84b08570faad810523c4c1bf9567cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747100}
-
Eric Willigers authored
WebAppBrowserController is now consistent with HostedAppBrowserController in using a 32x32 icon. Bug: 1057986 Change-Id: I9171ce25cb3591881a30d249f95c19a511c54882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086366Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#747099}
-
Kei Nakashima authored
Implemented NewLinkedHashSetConstIterator, const iterator for NewLinkedHashSet. Also added test for it. Change-Id: I84299d866e0cdb94ac2fbf2c31362a22779e0184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086376 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Auto-Submit: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#747098}
-
Miguel Casas authored
This CL follows up on the previous by updating the uses of BGRA_1010102 (which used to be BRGX_1010102) in resource_format_utils.cc and gl_image_io_surface.mm, basically allowing for its correct usage now that the gymnastics of pretending that the alpha format is opaque. Of note here is the CGLTexImageIOSurface2D we use for these types: https://github.com/phracker/MacOSX-SDKs/blob/HEAD/MacOSX10.12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers/CGLIOSurface.h#L102 TEST=display and gl_unittests passing and http://crosvideo.appspot.com/?codec=vp9.2_30&loop=true&mute=true reproducing correctly on Mac. TBR=kbr@ for gpu/command_buffer/service/feature_info.cc (comment fix) Bug: 949260 Change-Id: I8a422192a27833846482d14a1106d7d662ab9bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072780 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#747097}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/83bc671bd217..3ccfc90f5032 git log 83bc671bd217..3ccfc90f5032 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ukai@google.com Roll out new goma client binary VERSION=193 2020-03-04 ehmaldonado@google.com gclient: Don't allow duplicate entries on deps 2020-03-04 qyearsley@chromium.org depot_tools: git-cl: Rename try job to tryjob for consistency Created with: gclient setdep -r src/third_party/depot_tools@3ccfc90f5032 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:809671 Tbr: agable@chromium.org Change-Id: Ib148aee158252697f8db869b789a48ff8f410d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088800Reviewed-by:
-
Alex Danilo authored
Files App menus have a number of style properties applied to them. Adds properties to the elided drop-down to match the visual appearance of the frame of the drop down to the existing menu frames. Changes the font used in the drop down buttons to match the font used in our other menus. Style change only so no-try: true No-try: true Bug: 1035691 Change-Id: Ic822b5bccb5f2daca5053630ec3256e7c2399427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087241Reviewed-by:
-
Keita Suzuki authored
This commit updates DEPS file to add pywebsocket3 to //third_party. Change-Id: I41a402d7d640f365712e93db01dbd85618fe082e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059041Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#747094}
-
kylechar authored
It's expired and not useful. Bug: 1043702 Change-Id: If5dcb23c5daa084c1cf524b18ac5c3e28483d920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083222Reviewed-by:
-
sauski authored
As part of the Privacy Settings Redesign, controls which are currently present on the main privacy card have been moved to subpages. This CL adjusts the main privacy card to contain links to these subpages and remove any now duplicated controls. All of the changes in this CL are hidden behind the privacySettingsRedesign flag. Test have been added to ensure the existing behaviour is preserved when the flag is off. Bug: 1032584 Change-Id: I174cd6b404c9d704165e3a8d7991e8429088dbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088233 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747092}
-
Danan S authored
Includes methods to: - Show Parent Permission Dialog - Record addition or removal of parental approval for specific extensions - Check whether a specific extension can be installed/enabled - Check whether a child user can install extensions at all. - Verify that a user is a child - Verify that a child user has custodians The factory has a new method to: - Get a service instance from a browser context. Needed because some APIs that depend on this code can't access the browser profile. Bug:957832 Change-Id: I15259c8f27b0b44d579615f1f312cb2a42bcb217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070598 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747091}
-
Wenyu Fu authored
Seems every RadioButtonWithDescription has the xml attribute of android:background="?attr/selectalbeItemBackground". Adding this attributed into widget constructor for simplicity. Bug: 1048863 Change-Id: Ia335afe12cd5130bdddccf0e083db1b35e28a572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067279 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#747090}
-
Alex Cooper authored
Currently, SessionMetricsHelper tracks both WebXr and VRB state. WebXr state is triggered from VrServiceImpl as the "source of truth" that a VR Session has started, while various vr_shell classes are the source of truth for whether or not the user is in the VR Browser. In order to move the VRService out of chrome/ its dependencies also need to be able to be moved out of chrome. This includes the WebXr metrics portions of SessionMetricsHelper. Given the dwindling usage of the VR Browser, it was decided to remove metrics that were specific to it. This allows for breaking any dependencies on SessionMetricsHelper except to log WebXr metrics. Much of SessionMetricsHelper's complexity stems from the fact that it tracked whether the browser was in VRB, WebXr, or Fullscreen (VRB). However, since we no longer need to differentiate between these modes, and can simply track WebXr, the class was dramatically simplified. RecordImmersiveSessionStart and RecordImmersiveSessionStop become the only methods that actually drive the "state" of the core metrics, with the video metrics aided by their listeners. The class also still listens to navigation events as an extra way to ensure that all sessions are cleaned up appropriately. The following changes were also made: * SessionTracker class split into its own file * Given that the only "SessionMetricsHelperTest" was actually a SessionTracker test, the UT was also renamed. * WebXrSessionTracker split into its own file * SessionTimer was split into its own file * Dependency on explicit WebXrSessionTracker class was abstracted from callers of SessionMetricsHelper * This includes abstracting the logging of initial session data. * Update logging levels that were overly verbose and impede validation. BUG: 1031622,1021314 Change-Id: I2c52189ccec978f378df384d7342524af4680b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076431 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#747089}
-
Eric Willigers authored
The tests in ShelfWebAppBrowserTest use no extensions APIs to create web apps. Note that a number of these tests do not yet pass when the flag DesktopPWAsWithoutExtensions is enabled. TabbedHostedAndBookmarkApps and WindowedHostedAndBookmarkApps have not yet been ported. Bug: 1054116 Change-Id: I3d806138bebdaa672b67fa4c1772daf7992a75f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082425Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/628f3e70ee01..f1d78a6c68da git log 628f3e70ee01..f1d78a6c68da --date=short --first-parent --format='%ad %ae %s' 2020-03-05 mtklein@google.com add an ulp of error on the clamp asserts 2020-03-04 mtklein@google.com better SKVM_JIT_STATS output 2020-03-04 mtklein@google.com skip dump checks on machines w/o FMAs 2020-03-04 reed@google.com detect when the localmatrix forces us into a perspective stage 2020-03-04 egdaniel@google.com Move GrGpuResource GrSurface and GrTexture into src. 2020-03-04 mtklein@google.com async llvm compile, take 2 2020-03-04 mtklein@google.com turn off LLVM FMA discovery 2020-03-04 mtklein@google.com do our own fma discovery 2020-03-04 mtklein@google.com get rid of troublesome Op::round Created with: gclient setdep -r src/third_party/skia@f1d78a6c68da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057418 Tbr: herb@google.com Change-Id: I89fb9043914c2f3d7864f1cd57f6844e6f9ecaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088792Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1057599 Change-Id: I31661c23763cb9861ec883b203a022c9e2d324da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085836Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#747086}
-
Luciano Pacheco authored
For Grid View, add titles "Folders" and "Files" for the respective sections. Add test to check that the title is available. Add translations and their screenshots. Test: browser_tests --gtest_filter="*showGridViewTitles*" Bug: 992822 Change-Id: Ic71d31891e2d8575920fa815b0a9df5e49bc5ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087231 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Alex Danilo authored
Bug: 1035691 Change-Id: I23db4dc4ad0d98e86bb4887842ed520a884f096e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087494Reviewed-by:
-
Danan S authored
This dialog's purpose is to prompt a parent of a child-type user to enter their credentials to approve an action. This dialog will also allow you to pass in an extension::Extension, whose details (i.e. permissions, title) will be displayed above the credential entry form. This CL is inspired by the functionality of ExtensionInstallPrompt, but simplifies the approach used by that code. Bug: 957832 Change-Id: I3a9395f56505b43cd5c8f8c269b0b19c99ce6379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972417 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747083}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I45628359441887e4843dc01e2f08410a708142d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088802Reviewed-by:
-
Kent Tamura authored
This CL also moves: - ObserveTreeMutation() - UnobserveTreeMutation() - DidMutateSubtree() - popup_updater_ This CL has no behavior changes. Bug: 1052232 Change-Id: I381d18022b5b08e04214a9d2e163e1a33b929f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087491Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#747081}
-
Sinan Sahin authored
This CL implements the color and text transition animations that run when showing or hiding the status indicator. Show: 1- Transition the status bar color. 2- Wait for the browser controls animation in cc to finish. 3- Fade in text. Hide: 1- Transition the status bar and the indicator color. 2- Wait 2 seconds. 3- Fade out text, and transition the status bar and indicator color back to the original status bar color. 4- Let the browser controls hide animation run in cc. Bug: 989148 Change-Id: If19a51e6c5091436d78e34ef50f11ffa0118ee0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067095 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43d8e93fa7bf..14e5f0b2cb03 git log 43d8e93fa7bf..14e5f0b2cb03 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ouj@fb.com Update RTC_CHECK and RTC_LOG macros so they work when called from xxxxx::rtc namespaces Created with: gclient setdep -r src/third_party/webrtc@14e5f0b2cb03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7779442dbd498ce63bc992dcbf2ff31889ef034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088469Reviewed-by:
-
Lijin Shen authored
There exists some unknown issue on the measurement of a text view with a compound drawable. Using a linear layout containing an imageview and a textview inside can avoid this issue. Bug: 1053448 Change-Id: Ibdcd220e0eba7218c1d500d870da17d37c7e767c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083729 Commit-Queue: Lijin Shen <lazzzis@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
We already filtered out writable directories from the list of readable directories in the usage indicator bubble, this CL extends that to also apply to files. This way the same file will only show up once in the usage indicator bubble. Bug: 992158 Change-Id: I04c4a45c41701d9291f0fee3edd4cd9797f6ac5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088675Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#747077}
-
Joshua Bell authored
The DirectoryReader readEntries() call fails if invoked a second time while there's an outstanding request. But the failure was being reported on the first call's callback, which is non-inuitive. Fix by reordering the duplicate call logic and not relying on the reader's OnError handler. Manual Test: entries-api/filesystemdirectoryreader-manual.html Bug: 1054981 Change-Id: Ieaaea993c48af5d9c1fabe4ec509afe3d22b3477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069017Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#747076}
-
Will Cassella authored
Previously, the way time progression was simulated for FakeWebMediaPlayer in tests was to increment the current time by a whole second every time a call to |FakeWebMediaPlayer::CurrentTime| was made. This is kind of strange, since it relies heavily on the implementation of |HTMLMediaElement| to not call |CurrentTime| more than once per update. Additionally, it led to scenarios where time in FakeWebMediaPlayer would progress more quickly than test time (such as in HTMLMediaElementWithMockSchedulerTest.PeriodicTimeupdateAfterSeek). The new mechanism uses a recurring delayed task to increment time, and also calls |Microtask::PerformCheckpoint| in order to update |HTMLMediaElement::official_playback_position_|. Previously, tests would fail unless they were specifically designed to avoid code paths that rely on that value of |HTMLMediaElement::official_playback_position_| (which ideally shouldn't be necessary). This CL resolves all of the above issues, allowing some tests to be simplified (such as HTMLMediaElementWithMockSchedulerTest.CueEnterExitEventLatency, which is implemented in a pending CL: 2008079). Change-Id: Ia0392a77a013b33a492f9a29402605ceb7f147ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048415 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#747075}
-
Artem Bolgar authored
WebXR is using so called 'opaque' framebuffer, i.e. all attachments are made on GL level and not visible by WebGL. When 'enable(gl.STENICL_TEST)' is called, the on WebGL context checks the WebGLFramebuffer object for presence of the STENCIL attachment and fails (because the opaque framebuffer doesn't have those). I am adding an additional state to WebGLFramebuffer to track if the opaque framebuffer has the stencil buffer or not. Note, I can't check if the actual GL framebuffer object has the corresponding attachment, since the framebuffer might not be bound (yet). The repro case: https://artyom17.github.io/webxr-samples/tests/stencil-cube-sea.html In 2D mode you'll see that the green triangle has a cutout, while in VR mode it doesn't. This is because gl.enable(gl.STENCIL_TEST) is failing. Bug: 1057571 Change-Id: I8b94a60de8c14ac7e435f17e57523ec430f22fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084067Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Artem Bolgar <artyom@fb.com> Cr-Commit-Position: refs/heads/master@{#747074}
-
