- 01 Nov, 2017 34 commits
-
-
Kenneth Russell authored
Copy WebGL 1.0 Linux P400 expectations to WebGL 2.0; they weren't being run on that configuration previously. BUG=712469 NOTRY=true TBR=jmadill@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iec9def1894e30ef95f1743b64483cf61798c5d2e Reviewed-on: https://chromium-review.googlesource.com/748319 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513049}
-
Yoichi Osato authored
This patch converts editing/pasteboard/copy-null-characters.html with assert_selection to promote the use of w3c testharness and improve code health. Bug: 679977, 775701 Change-Id: Ib89e9f246b7c7ef559b0d67ac2a4937405524145 Reviewed-on: https://chromium-review.googlesource.com/746341 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513048}
-
spqchan authored
There's a bug where the thumb in the Cocoa overlay scrollbar becomes more narrow than the track width. This bug is caused by BaseScrollBarThumb::SetLength() which sets the thumb's size according to its preferred size. Since the CocoaScrollBarThumb::CalculatePreferredSize() returns the thumb's minimum's size, SetLength() would set the thumb's size to be too small. This CL fixes this issue by returning the thumb's current thickness instead of the minimum size in CocoaScrollBarThumb::CalculatePreferredSize(). Additionally, this CL changes the logic so that the thumb and track bounds and size won't be insetted. Instead, the thumb's painting will be inset in the OnPaint() function. The kExpandedScrollbarThumbInset value is also removed. Bug:682466 Change-Id: I59411650df8acfb4e628efbb1a9f0646c2ce385b Reviewed-on: https://chromium-review.googlesource.com/741039 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#513047}
-
Abhishek Arya authored
R=dpranke@chromium.org,hans@chromium.org Bug: 780048 Change-Id: I124805ca7fc97ed1d04ab8af213a376540425b3f Reviewed-on: https://chromium-review.googlesource.com/745810Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#513046}
-
Philip Rogers authored
When painting composited overflow, kPaintLayerPaintingOverflowContents is set to paint all content. When painting a nested, transformed scroller, we need to ensure this flag is unset so the contents are clipped. Because root layer scrolling (RLS) paints the root layer as a regular overflow scroller, this bug affected more tests with RLS. With this patch, 5 more tests pass with root layer scrolling. Bug: 779885 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I311cfa9e3244192b24ec3dd566aa2c65e9dba851 Reviewed-on: https://chromium-review.googlesource.com/748081 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513045}
-
Adam Langley authored
This is the result of running tools/metrics/histograms/update_policies.py in a clean branch. Both of these changes appear to be correct based on the names in components/policy/resources/policy_templates.json. This allows future users of update_policies.py to get a clean diff. Change-Id: I28245240d594e1c82481663aa17a9ff099a1864f Bug: None Reviewed-on: https://chromium-review.googlesource.com/747691Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#513044}
-
Miguel Casas-Sanchez authored
This CL moves the file v4l2_stub_header.fragment to //media/gpu/v4l2/ folder. This file is used in conjunction with the signature files in the said folder, to produce an include file with the functions used for v4l2 video acceleration. Right now having the fragment in //media/gpu is unnecessary. TEST= ** No new code added, if it compiles, we're good ** (Note that this code is compiled in the bot chromeos_amd64-generic_chromium_compile_only_ng which is part of the CQ). This CL is kind-of a continuation of crrev.com/c/744462. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I11ea24e3feb27f53d06e3dcacccc2fdb0f0ac6fa Reviewed-on: https://chromium-review.googlesource.com/747532Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#513043}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/4dbdc677affd..a44b013a328d $ git log 4dbdc677a..a44b013a3 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I0319a822d0c0a4d0fbfb2e64ef0bb7788d325244 Reviewed-on: https://chromium-review.googlesource.com/748262Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513042}
-
Thomas Guilbert authored
The devices added in this CL are accountable for 80% of the crashes in the attached bug. There is no good stack trace to investigate the crash further, but all crashes seem to happen at MediaCodecBridgeImpl destruction time. Using the fallback path on those devices on JellyBean should mitigate further crashes. Bug: 693216 Change-Id: I58f5a1522105a87d48470452f28634dc9bf806c7 Reviewed-on: https://chromium-review.googlesource.com/748205Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#513041}
-
Eugene Ostroukhov authored
Bug: 738065 Change-Id: Ia706f3a5edd451de462ab8c6a26abc394d493e9e Reviewed-on: https://chromium-review.googlesource.com/731405 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#513040}
-
Makoto Shimazu authored
This reverts commit fd502dfe. Reason for revert: This patch seems causing interactive_ui_tests failures on Linux Chromium MSan/LSan Tests bots. https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/3892 Original change's description: > Make PendingWallpaper pass weak pointers with a default delay > > After applying a default delay to PendingWallpaper, some tests > failed (crbug.com/779504) or have memory leak [1]. > > These tests indirectly called SetUserWallpaper, but they do not > care/know about this, so they do not actively wait until wallpaper > loading is done, but start the destruction directly. > > This used to be okay when SetUserWallpaper had zero delay. > > But when it has the default delay, the timer is still running when > the destruction starts, and the timer holds a reference to the shared > pointer of PendingWallpaper, which results in memory leak. > > What's worse, if the WallpaperManager already destructs itself, > PendingWallpaper::ProcessRequest does not know it, and it crashes. > > After changing the shared pointer to a weak pointer, WallpaperManager > will be able to completely manage the lifetime of PendingWallpaper. > > [1] https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/24405 > > Below are the description of the original CL: > > 1) All the PendingWallpaper requests are now subject to a delay > calculated from average loading time. However, in most cases the delay > is still zero, and this change only affects corner cases that multiple > requests coming together, which may result in wallpaper being stuck. > > 2) Add the account_id update in PendingWallpaper. Did not modify > the functionality of PendingWallpaper, except for some renaming. > > TBR=oshima@chromium.org > > Bug: 779504, 778451 > Change-Id: Iae943f88bbe046849c3afab75f35a253934fe75b > Reviewed-on: https://chromium-review.googlesource.com/745022 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512883} TBR=oshima@chromium.org,alemate@chromium.org,wzang@chromium.org Change-Id: I62ae0d91bc1cbe953de45a77402f38754de858cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779504, 778451 Reviewed-on: https://chromium-review.googlesource.com/748381Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513039}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32a6cc20..1facfc82 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I67d1e6588f934ae8682f6c630505780469987bf4 Reviewed-on: https://chromium-review.googlesource.com/747512Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513038}
-
Chris Bentzel authored
These are pretty trivial, but possibly worth keeping. Change-Id: I89866f829699ac597d44cd87e94f948211539174 Reviewed-on: https://chromium-review.googlesource.com/746365Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513037}
-
Max Moroz authored
R=vitalybuka@chromium.org Bug: 676024 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2c1d8f28ffcce5e657e383ab70ad1dbb4ec9668e Reviewed-on: https://chromium-review.googlesource.com/736669 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513036}
-
Bailey Forrest authored
The main changes are in chromecast/chromecast.gni The rest of the files were modified with these commands: - Change source_set -> cast_source_set git ls-files "chromecast/*.gn" | xargs sed -i 's/source_set(/cast_source_set(/g' - Include chromecast.gni for any GN files missing it git ls-files "chromecast/*.gn" | xargs grep -L '//chromecast/chromecast.gni' | xargs grep -l 'source_set' | xargs -L1 ~/src/scratch/add_line_after_first_comment.py 'import(' '"//chromecast/chromecast.gni")' add_line_after_first_comment.py can be found under chromecast/internal/tools BUG=b/68723969 TEST=Build and run Change-Id: I38a06ac4d8a45ebc7963b58e5a2db81fde84e635 Reviewed-on: https://chromium-review.googlesource.com/747894Reviewed-by:Stephen Lanham <slan@chromium.org> Commit-Queue: Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#513035}
-
Dirk Pranke authored
We're not actually going to use that particular config. R=jbudorick@chromium.org BUG=732531 Change-Id: I6ab1cda23fdb621cccd19418263a57e955d032f8 Reviewed-on: https://chromium-review.googlesource.com/744594 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513034}
-
Wei-Yin Chen (陳威尹) authored
Some of the partner customization logic is extracted to AppHooks, so that it can be overriden in downstream. Bug: 778805 Change-Id: I6dcd4b0a14ed76f7a9c447452ce313f59ca98a65 Reviewed-on: https://chromium-review.googlesource.com/741086Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513033}
-
Matt Reynolds authored
GamepadHapticActuator receives haptics commands and forwards them to GamepadDispatcher, which dispatches them to the device service. It also manages the state of promises which have been returned to the user as the result of haptics commands. Haptics commands include playEffect, which plays a vibration effect on the target gamepad, and reset, which stops vibration and resets any vibration-related state on the gamepad. Both commands return a promise that is resolved with a result code once the command is completed. BUG=749295 Change-Id: I457c4b0e024c88adcaecdf6695959e06acb20a8e Reviewed-on: https://chromium-review.googlesource.com/747050 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513032}
-
Matt Reynolds authored
Add MeasureAs attributes for geolocation methods so usage of the feature can be tracked through UseCounter. BUG=780267 Change-Id: I8994be04aa750971204f515d66f5834ce38ab8c8 Reviewed-on: https://chromium-review.googlesource.com/747862Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#513031}
-
Reilly Grant authored
This patch devirtualizes calls to interface methods made through a mojo::InterfacePtr<T> and mojo::AssociatedInterfacePtr<T> by making get() and the -> and . operators return the proxy type directly and marking the interface methods on the proxy as final. The motivation of this change is performance and binary size. The non- virtual call sites are slightly smaller but not enough to effect the complete binary. Performance should be net-positive but as yet has not been accurately measured. Bug: None Change-Id: I463bc32c1989853606d118f57ded5c9dd9f34e2f Reviewed-on: https://chromium-review.googlesource.com/747884 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513030}
-
Tien-Ren Chen authored
With a recent change we removed bounds parameter from drawing display items, now all drawing display items are assumed to be bounded by its owning client's visual rect. This does not necessarily hold true for clip-path, because clip-path can be bigger than its reference box. This CL expands the visual rect of a layout object with its clip-path's bounding box (if one is present). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I117169b302c4574df4628ffe67496e9f95aab8fb Reviewed-on: https://chromium-review.googlesource.com/742354 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513029}
-
Alex Loiko authored
The test WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio sets up a WebRTC audio-only one-way connection between two Chrome tabs. The first tab receives recorded audio from a fake microphone and sends it to the second tab. The second tab plays the audio which is then recorded. The WebRTC connection is negotiated with constraints "{audio: true}", which enable the AEC. The AEC affects audio levels, and changes in it potentially cause alerts such as this one: https://chromeperf.appspot.com/group_report?bug_id=779057 On some test settings (with '--single-process'), the AEC of one tab sees the playout stream (reverse) of the other tab, causing it to cancel the 'echo'. That leads to heavy speech distortion and often test failure (see the bug chromium:779057). This change disables AEC in the AGC tests. Bug: chromium:779057 Change-Id: Ie774e2faba41f057e47fb2ed4ee402217da8aaf3 Reviewed-on: https://chromium-review.googlesource.com/746641Reviewed-by:Patrik Höglund <phoglund@chromium.org> Commit-Queue: Alex Loiko <aleloi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513028}
-
Becky Zhou authored
Before this fix, bottom sheet contents are not updated when creating new tab in a different mode with a new tab already opened. It also causes duplicate calls to destroy pref observers. OffTheRecordProfile is not necessary for PrefChangeRegistrar, and to fix bottom sheet content separately, we now remove BottomSheetContent when switching mode. Bug: 779474 Change-Id: I263d9041184701c737cbada78e725a96ca9ade6b Reviewed-on: https://chromium-review.googlesource.com/745221Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chrome://interventions-internalsThanh Le authored
The tab navigation bar is now stretch across the page The table also fit to the device width, and the "URL" column in the "Logs" tab is now scrollable to make it nicer for longer hostnames on mobile Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3MlA2bnNYNUhfdVU Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3RXQ3clFLRFBtaVU Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3THd0Q3JVcm44c00 Bug: 764419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieba316275f2acfa60dea480be701995c68fb2f7a Reviewed-on: https://chromium-review.googlesource.com/747865Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#513026}
-
Tommy Steimel authored
This CL adds a WasEverAudible method to WebContents which returns true if audio has played since the last navigation. This is then used by the Page Info bubble to decide whether or not to show the sound content setting. Bug: 779878 Change-Id: I66453161dfe17df6868e66f11e7fce0b3c3a87b8 Reviewed-on: https://chromium-review.googlesource.com/747069Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513025}
-
John Chen authored
Use the MediaLog ID associated with each WebMediaPlayerImpl object as a unique identifier, to allow the media metric to handle multiple media playbacks in a single trace. Bug: 775264 Change-Id: I412bbf5bf8ccab223c027cb5c936fac3de47251e Reviewed-on: https://chromium-review.googlesource.com/741143Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Philip Rogers authored
The app shell (content shell) sets the default LOG setting to have tick counts. This means a LOG(INFO) looks like: [42745:775:1031/103842.350408:395648516798307:INFO:LocalFrameView.cpp(3456)] test This patch updates the default setting to not have the tick count so LOG is less verbose. I think this will promote more LOG usage and happier developers. A LOG(INFO) now looks like: [42846:775:1031/104021.499705:INFO:LocalFrameView.cpp(3456)] test Change-Id: I37b27730114519e8f08f59bf076eb3b090bcb12e Reviewed-on: https://chromium-review.googlesource.com/747363Reviewed-by:
-
Sonny Sasaka authored
This is a continuation from crosreview.com/737056. When Stop() discovery fails because Discovering property changes to false, that means all the discovery sessions have been stopped bluez, so Stop() is expected to fail and there is no need to log this as error. BUG=777953 TEST=Reproduce the case and check that device event log is categorized as DEBUG instead of ERROR. Change-Id: I41f6e3e83e9f6377bf28f4bb2210be34bdf1c732 Reviewed-on: https://chromium-review.googlesource.com/747603Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#513022}
-
rbpotter authored
Test that PrintPreviewHandler forwards renderer messages from the PrintPreviewUI to the Print Preview javascript correctly, and that it tries to kill the renderer if it receives unexpected messages. Bug: None Change-Id: Iec26fcd115270a167de6370aba2b90d5c68cf380 Reviewed-on: https://chromium-review.googlesource.com/742649 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#513021}
-
Mark Pearson authored
In many memory histograms, the last sentence is "Emitted once per UMA ping." But actually some subset of those are emitted multiple times, one for each process. In most of those cases, reading the rest of the histogram description will make that clear. In a few, it's not crystal clear; one of them confused me for example. I was going to simply fix the more confusing ones, then simply decided that it's best to be consistent. This changelist adds "per process" to the last sentence as appropriate on all memory histograms. Bug: 765470 Change-Id: Ia8187581381a13913f9eada5a1b0d82b8d1b3fbe Reviewed-on: https://chromium-review.googlesource.com/747629Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Mark Pearson (busy Oct 31) <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#513020}
-
Chris Bentzel authored
The comment indicated that blob, data, and other URLs could be included. However, the implementation in MetricsWebContentsOvbserver::OnRequestComplete filters out requests that do not have HTTP or HTTPS schemes. Change-Id: I8873a2bb57eb8a548ae2a8c8b4a4f32596fd5bed Reviewed-on: https://chromium-review.googlesource.com/745827Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513019}
-
James Cook authored
Many ash_unittests fail under --mus and --mash because the TestScreenshotDelegate is not created. This happens because of some legacy AcceleratorControllerDelegate code that dates back ~18 months to when we couldn't use aura::Window* in mash code. That isn't a problem anymore. * Move ownership of ScreenshotDelegate to ScreenshotController * Create the delegate in ShellDelegate, similar to how we do other ash delegates * Move screenshot accelerator code back into AcceleratorController * Re-enable tests under mus and mash via filter files Screenshots don't work yet under --mus and --mash due to lack of graphics readback support and lack of a mojo interface, but we now exercise more of the UI and accelerator handling code. Bug: 557397, 632111 Test: ash_unittests (--mus, --mash), manually take screenshots Change-Id: I7dd1946ddc30bddb407c9dbf6095caf8efb4fd1f Reviewed-on: https://chromium-review.googlesource.com/744295Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#513018}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/90dabec62f9b..4dbdc677affd $ git log 90dabec62..4dbdc677a --date=short --no-merges --format='%ad %ae %s' 2017-10-31 csmartdalton Fix undefined behavior in normalize_t_s 2017-10-31 csmartdalton Allow GrAppliedClip to have >1 clip coverage FP 2017-10-25 mtklein Some lowp refactoring 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ b8ee9dd35..c1f14fbea (1 commit) 2017-10-31 brianosman Use color filter to undo GBR (actually BRG) 2017-10-31 mtklein Revert "Fix int overflow issues with clip and path bounds." 2017-10-31 caryclark cataloger 2017-10-31 bsalomon Devirtualized token management in GrDeferredUploadTarget. 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 1b605ee34..b8ee9dd35 (1 commit) 2017-10-31 kjlubick Add Pixel 2 XL to waterfall 2017-10-25 mtklein clean up SK_LEGACY_LOWP_STAGES 2017-10-31 bsalomon Make deferred upload handling and draw recording be virtual interfaces implemented by GrOpFlushState. 2017-10-31 scroggo Simplify SkColorSpace::MakeICC 2017-10-31 bungeman Remove SK_IGNORE_SUBPIXEL_HINTING_FIX. 2017-10-31 fmalita Don't store legacy colors in gradient shaders 2017-10-31 mtklein Revert "gbr- has been brg- this whole time..." 2017-10-31 robertphillips Add a GM to test out odd matrix draws (take 2) 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 2c5c41f9b..1b605ee34 (1 commit) 2017-10-31 mtklein gbr- has been brg- this whole time... 2017-10-31 jvanverth Fix int overflow issues with clip and path bounds. 2017-10-31 robertphillips Revert "Add a GM to test out odd matrix draws" 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ d922775b6..2c5c41f9b (1 commit) 2017-10-31 mtklein update valgrind suppressions for revised keepalive thread Created with: roll-dep src/third_party/skia BUG=743617,779346 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I6c60d600f1b6ac2555e482e37465f2220492326a Reviewed-on: https://chromium-review.googlesource.com/747886Reviewed-by:
-
Ted Choc authored
This removes the similar Activity launching logic in SearchActivityTest and replaces it with the same functionality in ActivityUtils. In addition, it adds additional logs in ActivityUtils on failure to attempt to help figure out what the state of the system is. BUG=778239 Change-Id: Ic2aac185958044a8ba733213ac8daf5a4c8aa618 Reviewed-on: https://chromium-review.googlesource.com/738843 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#513016}
-
- 31 Oct, 2017 6 commits
-
-
Matt Falkenhagen authored
* Add //static annotation for some static functions. * "WebEmbeddedWorkerInstance" doesn't exist, replace with WebEmbeddedWorker or delete. * Clarify ServiceWorkerNetworkProvider documentation. Change-Id: Id540473565059c1c5aadeffd3bb0ee136fd9e5b1 Reviewed-on: https://chromium-review.googlesource.com/746508Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#513015}
-
khmel authored
This modifies ChromeOS settings for metrics instead of lower level metrics preferences. ChromeOS settings change has mapping to lower level metrics but not the opposite way. That is why change in metrics mode from ARC OptIn page was not propogated to Chrome settings. Test: Manually on device Bug: 755716 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81ce5d38d34ade6d6f2737804eee5c1e7fa0822e Reviewed-on: https://chromium-review.googlesource.com/736145Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#513014}
-
Kevin Bailey authored
There is a large piece of code within |HQP::DoAutocomplete()| that can be on its own trivially. This change moves it to another method, and should not change behavior. This is to facilitate a downstream change. Bug: Change-Id: Ifdbbac697aee1efd0f42068f2e0825bb176a8076 Reviewed-on: https://chromium-review.googlesource.com/747064 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#513013}
-
Lei Zhang authored
Change-Id: Ic6489f81849456c7ce225cda73c5c08ec41e8e29 Reviewed-on: https://chromium-review.googlesource.com/747161 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Peter Boström authored
Removes IDS_IMPORTER_LOCK_CANCEL as the dialog is no longer intended to be distinguished from other Cancel button labels. This specialized label caused translation confusion as it looks like it is intended to be specialized for the import dialog but is not "Cancel import" or similarly specialized content. Bug: b:68235708, chromium:754034 Change-Id: I15e35d90eafb621ce6a5d90a0e573edceae99ef1 Reviewed-on: https://chromium-review.googlesource.com/747633Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513011}
-
Xiaocheng Hu authored
This patch changes the API to take Position parameters to better support mapping non-text anchored positions to LayoutNG canonical text. After this patch, NGOffsetMapping is fully converted to take Position parameters. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iee9956dc59c1ab34fe03f9f0f11fe890ddf9e568 Reviewed-on: https://chromium-review.googlesource.com/744733 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
-
