GitLab

This lets tests supply PageRenderData to the MetricsWebContentsObserver
through the plumbing added in crrev.com/603785.

Also remove an unused declaration and make SimulatePageLoadTimingUpdate
private in PageLoadMetricsObserverTester.

Bug: 581518
Change-Id: I89409eff3346855c03450ceeb2030b63068d6d3a
Reviewed-on: https://chromium-review.googlesource.com/c/1318058
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606275}

This CL removes a few unused libraries from HatService and fixes small
style nits. Funcionality is untouched.

Bug: None
Test: Build.
Change-Id: Ic6132da73f728b86a0a8b58afb7021125166a3ac
Reviewed-on: https://chromium-review.googlesource.com/c/1324609
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606274}

Recently the chrome pip windows have WindowStateType::PIP and behaves as
pip windows. Pip windows moves with animation but the mask bounds was
not synced with these animation. As the result, the test was flaky (see
the bug).

This CL adds the observer of window bounds and make it sure that the
layer bounds is synced with the window bounds.

Bug: 901235
Test: Ran PictureInPictureWindowControllerBrowserTest.
    EnterPictureInPictureThenFullscreen 10 times and observed no error.

Change-Id: Ide03ab1465170ccaf35af08377d3dd1df0cf7ee2
Reviewed-on: https://chromium-review.googlesource.com/c/1316986
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606273}

This allows mocking of the NotificationManager in places where
areNotificationsEnabled() is called.

Added in preparation of the mobile tracing feature, which requires
mocking this method for tests.

TBR=mvanouwerkerk@chromium.org,nyquist@chromium.org

Bug: 898512
Change-Id: Ic739269858970a2365ae6772f269e0aff19d4f5c
Reviewed-on: https://chromium-review.googlesource.com/c/1321730Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606272}

I'll switch ffmpeg over in a future CL since it seems to need some
work before it's ready to go.

Per davidben at chromium.org who originally authored this update
on https://chromium-review.googlesource.com/c/chromium/src/+/1119211:
Yasm has been unmaintained for a few years, while NASM is actively
maintained. Yasm is already missing some of the newer Intel
instructions, and will continue to miss newer ones. Additionally,
BoringSSL gets its assembly from OpenSSL which natively tests with NASM,
not Yasm, so using NASM puts us closer to the tested path.

BUG=766721
TEST=CQ is happy
R=brucedawson, davidben

Change-Id: Ifa49686e2985967c19b7fc91f94ef6350038fb7c
Reviewed-on: https://chromium-review.googlesource.com/c/1313832
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606271}

Adds a general CQ documentation page. Will add an auto generated
markdown doc based on cq.cfg once this lands.

Bug: 902507
Change-Id: I153efab72885faa2d70051f4372bfbcc2164f6d4
Reviewed-on: https://chromium-review.googlesource.com/c/1321579
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606270}

This fixes some regressions which caused Answer Card display handling to
interfere with normal search UI behavior in the app list. Namely,
automatic selection of top non-Answer-Card results, and autocomplete of
text in the input box.

Bug: 902563
Change-Id: Ie45672ae64184d7ed6116752bad1c7a0ca38c646
Reviewed-on: https://chromium-review.googlesource.com/c/1325081Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#606269}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/421605af68e3..49c8eafcd54c


git log 421605af68e3..49c8eafcd54c --date=short --no-merges --format='%ad %ae %s'
2018-11-07 ehmaldonado@chromium.org git-cl: Stop logging response headers on 404 Gerrit RPC status.


Created with:
  gclient setdep -r src/third_party/depot_tools@49c8eafcd54c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:881860
TBR=agable@chromium.org

Change-Id: Ic7135e3c7f4b082ba5407ee2ff44670d41a4929b
Reviewed-on: https://chromium-review.googlesource.com/c/1324809Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606268}

These will help us know how often these special headers are changed
or removed. Also added a histogram to track the number of users with
a webRequest extension installed.

Bug: 827582
Change-Id: Ia4e53d528363eb29a9271e6b635b97dd90117a7d
Reviewed-on: https://chromium-review.googlesource.com/c/1320469
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606267}

These failures have been added since BGPT was initially turned on and
I have verified that each of these is not a real failure.

Change-Id: I9aa8210ad071cf1aad517bc18b7bc1dcba0acc5a
Reviewed-on: https://chromium-review.googlesource.com/c/1324882
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606266}

Updates color from yellow to black (by relying on default color)
to improve contrast and better match neutral state icon color.

Screenshot: https://drive.google.com/file/d/1JMptH0qC9cIyPIzSD99T29Qvm22M4fr-/view?usp=sharing

Bug: 900027
Change-Id: I1732de356aed28c4c505b5b24cf0e3c666b927fb
Reviewed-on: https://chromium-review.googlesource.com/c/1321858
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606265}

Replacing suggestion source with an empty suggestions source, once
SuggestionsUiDelegateImpl is destroyed.

Bug: 898078
Change-Id: Ic6f05da92e0c90f566275d4b9f0e1fb12afeb2a6
Reviewed-on: https://chromium-review.googlesource.com/c/1324611Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606264}

YUV decoding is currently hardcoded to jpegs and the decision is
spilled to a couple of places. Since we want to add it for WebP,
centralize it to DeferredImageDecoder which makes the decision at paint
time based on whether it is supported by the ImageDecoder implementation
for each format.

R=pdr@chromium.org

Change-Id: I156d397c578c45a1490385aecbd96546c4ce798b
Reviewed-on: https://chromium-review.googlesource.com/c/1320750Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606263}

Bug: 878324
Change-Id: I09976b84a4016d687c505f0808d92d57ab87ee7c
Reviewed-on: https://chromium-review.googlesource.com/c/1312138
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606262}

This also required implementing the type tables for int64/uint64 as
BigInt. Additionally, some test support code to pull BigInt out of V8 as
64-bit types because gin assumes always-Number.

Bug: 883496
Change-Id: I10d07124e59f0fdde8f053007eca30508751b211
Reviewed-on: https://chromium-review.googlesource.com/c/1318729
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606261}

This is because we don't want to allocate dedicated hardware for this
cq builder yet, as it's optional and still under development.

R=stgao,smut,liaoyuke

Change-Id: Ie0d896993ed54172c502af938229612e9e268714
Reviewed-on: https://chromium-review.googlesource.com/c/1325073
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: smut <smut@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606260}

The documentation for ScopedTaskEnvironment recommends making it the
first member of the test fixture:
  https://cs.chromium.org/chromium/src/base/test/scoped_task_environment.h?l=54-59&rcl=376db7a96e0287f0d010acd18e7a379d190cac71

We are chaning this particular case because we want to make the
constructor of ScopedTaskEnvironment set a global variable that is
read by PlatformThread::SetCurrentThreadPriority(). If
ScopedTaskEnvironment is initialized late in the test execution,
setting this global variable races with a call to
PlatfromThread::SetCurrentThreadPriority() on the thread created
from this stack:
  base::(anonymous namespace)::CreateThread
  base::PlatformThread::CreateWithPriority
  base::Thread::StartWithOptions
  net::test::QuicHttpProxyBackendStreamTest::CreateTestBackendProxy
  net::test::QuicHttpProxyBackendStreamTest::SetUp

Bug: 902441
Change-Id: I4869410f43383bd7f94f68fc7790e3305f3d1b4a
Reviewed-on: https://chromium-review.googlesource.com/c/1320654
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606259}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I4d1f6b4f7eec6ec938360dd955ce37b9df4a5914
Reviewed-on: https://chromium-review.googlesource.com/c/1325031Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606258}

This will add a comment to the gn_arg log link on chromium bots:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930669115526655984/+/steps/lookup_GN_args/0/logs/gn_args/0

This will hopefully help avoid confusion when a non-CrOS chromium dev
gets a CL blocked by a simplechrome bot. (See the linked bug where
someone wasn't familiar with it and tried copy-pasting the arg dump
outside the SDK.)

I looked into adding the comment further upstream in chromite's
cros_chrome_sdk libs, but it makes heavy use of gn_helpers, and adding
comment support to that is non-trivial.

This can't land until https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1320309
and gets rolled into chromium.

Bug: 901471
Change-Id: I9ad646a9b6ab6fd29d4adb7acfd842b26c3825ae
Reviewed-on: https://chromium-review.googlesource.com/c/1318179Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606257}

Adds new experimental protocol method, which uses
`WebContents::GenerateMHTML` underneath.

Bug: 901933
Change-Id: I52e707f89378fe3a1488a3cd8afd7cdded1b77ea
Reviewed-on: https://chromium-review.googlesource.com/c/1297732
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606256}

This'll be the builder that triggers nightly flashing jobs into the
cros-dut-flash builder.

Adding it to dev while I develop & experiment with it and the flashing
builder.

Bug: 866062
Change-Id: I0319bbcb3591a6488940a9a61330a787d9dbdc01
Reviewed-on: https://chromium-review.googlesource.com/c/1325013Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606255}

This adds a fake implementation of WinWebAuthnApi along with a scoped
override of WinWebAuthnApi::GetDefault, as well as a test to verify USB
authenticator instantiation depending on API availability and feature
flag state.

Bug: 898718
Change-Id: Iff3a317b4540986775a40fc872754ba0571ae88a
Reviewed-on: https://chromium-review.googlesource.com/c/1316839
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606254}

Needs https://chromium-review.googlesource.com/c/catapult/+/1320592 to
roll in first.

Bug: 892670
Change-Id: I71a8b9be3a0a2123e86ad4870d54fef5946c2835
Reviewed-on: https://chromium-review.googlesource.com/c/1321153Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606253}

This method will show our in-product help and notify when the promo is
finished. This will serve as the plumbing between chrome/browser/ui/
and chrome/browser/ui/views for in-product help.

Bug: 887991
Change-Id: I357853b7f21910945b19022eddda9294a8bebcf3
Reviewed-on: https://chromium-review.googlesource.com/c/1310494
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606252}

R=abdulsyed@chromium.org

Change-Id: I3b214ce6f4b97cabfb6de17412d3323ff24f0260
Reviewed-on: https://chromium-review.googlesource.com/c/1325084Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606251}

Preparing work for migrating ThreadRestrictions::ScopedAllowWait to
ScopedAllowBaseSyncPrimitives.
This CL updates the friendlist for ScopedAllowBaseSyncPrimitives and
ScopedAllowBaseSyncPrimitivesWithoutBlockingScope.
Some cases might need to be adjusted if it was labeled wrong, but we can assume
that most cases are correct. This saves us from updating this file for each
cases.

Bug: 766678
Change-Id: Ie11bca133f7664355425cfaefcffb4acc0373731
Reviewed-on: https://chromium-review.googlesource.com/c/1324100
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606250}

https://android.googlesource.com/platform/external/perfetto.git/+log/134e0525ddad..8621cb09ab31


git log 134e0525ddad..8621cb09ab31 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 fmayer@google.com profiling: Allow to tear down BoundedQueue.


Created with:
  gclient setdep -r src/third_party/perfetto@8621cb09ab31

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I881862146e963b79ee4392edc9eeced1811bba29
Reviewed-on: https://chromium-review.googlesource.com/c/1324470Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606249}

The renderer process is blocking long enough in
Gpu::EstablishGpuChannelSync() that hung renderer detection code is
killing it. Add histogram to track duration from when the request
arrives in the browser to when a response is sent back to the renderer.
This should narrow down where potential problems occur.

Bug: 874797
Change-Id: I1d1825a6c3dbbadb916c64b97275a1593ac05f28
Reviewed-on: https://chromium-review.googlesource.com/c/1324189Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606248}

r605518 fixed a modified URL from URLLoaderThrottles not being sent over the network. However it didn't fix the headers case, which is used by other policies. This fixes the ForceYouTubeRestrict and AllowedDomainsForApps policies.

Bug: 899268,900574
Change-Id: I5d9666a7497c2c7e5642e5c74d5bc65dc0407ea9
Reviewed-on: https://chromium-review.googlesource.com/c/1324932Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606247}

Add a play pause button that will trigger the delegate
to call MediaController and toggle playback.

This also moves the play pause icons from //chrome into
//ui as they are needed in both //chrome and //ash.

BUG=897836

Change-Id: I691695f6ac1ba11bbd17537637d4d66e37f9725b
Reviewed-on: https://chromium-review.googlesource.com/c/1298250Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606246}

viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
allocation time for that viz::LocalSurfaceId. The purpose of this allocation
time is to determine how long it takes for a surface to get embedded once
an ID has been allocated for it.

There was some concern raised about drift between LocalSurfaceIds and allocation
times and so a previous CL bundled the two together in a class. This CL plumbs
LocalSurfaceIdAllocation to more places to ensure the two quantities remain
in sync with one another.

This CL plumbs LocalSurfaceIdAllocation through VisualProperties which ensures
we plumb valid timestamps from the browser to the renderer.

Change-Id: I4589a5835b82699de106b28cac4a85776975a1bf
Bug: 655231
Reviewed-on: https://chromium-review.googlesource.com/c/1321791Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606245}

004-vertical is removed per discussion on Slack.

svg/zoom/page/zoom-svg-float-border-padding.xml
There is no anti-aliasing in NG for top left corner.

tables/mozilla/bugs/bug2973.html
<td>inside of table<img src=""></td>
NG is consistent with FF/Edge.

Bug: 902591
Change-Id: Ie672601caef16f19914855ba83a2cfe8e58ab5d8
Reviewed-on: https://chromium-review.googlesource.com/c/1323794Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606244}

This is meant to allow Slow Page Triggering of Previews - that is, for
previews that may specify variable network quality thresholds based
on the URL (via OptimizationHints), the ECT is deferred until commit
time.

It renames and refactors the ShouldAllow* and IsURLAllowed* methods
to give them more power (it pushes down the ECT threshold determination
instead of having multiple call sites try to provide). There is some
reordering of the PreviewsAvailablity passed reasons.

Some more cleanup is merited but deferred to keep the diffs simpler for
this change.


Bug: 895581
Change-Id: Id8636312a9e707dd1181ca0df514f3f743347671
Reviewed-on: https://chromium-review.googlesource.com/c/1310562
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606243}

Bug: 896736
Change-Id: I3ccfd2188fb15704af14c8af050e0a5667855d34
Reviewed-on: https://chromium-review.googlesource.com/c/1324231
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606242}

|num_frames| can be 0 when mixer input is not ready to play yet. In this
case, all the previous_ended_in_silence_ logic should be bypassed.

Bug: b/119133585
Test: bulid and run on device, ensure crashes go away
Change-Id: I9a7eb69ecb015dffc9181e94d40d6a8de07d84ba
Reviewed-on: https://chromium-review.googlesource.com/c/1324417Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Linkun Chen <lkchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606241}

Experiments with hb-shape show that enabling compiler optimizations
improves performance of text shaping (therefore should help layout).

Initial tests show an improvement of 10.4% in hindi-line-layout
and 12.1% in latin-ebook performance layout tests.

Binary-Size: compiler optimized library will increase the size of the apk.
Bug: 902782
Change-Id: Iee50a04403ec634efec17be5ef8a72b996711a2f
Reviewed-on: https://chromium-review.googlesource.com/c/1321250
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606240}

TBR=wez@chromium.org

Change-Id: I68e17769dec2d0bdc92c7cad609b243b78aec69b
Reviewed-on: https://chromium-review.googlesource.com/c/1325071Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606239}

Bug: 899602
Change-Id: I58371b62f9e810b25fa05e431db8e17b82ff0d10
Reviewed-on: https://chromium-review.googlesource.com/c/1308908Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606238}

Added UKM and UMA metrics that trigger when a site displays or runs mixed
content.

Bug: 901403
Change-Id: I855682e2c0999a859070e89907838bcc133f8673
Reviewed-on: https://chromium-review.googlesource.com/c/1319189Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606237}

This CL makes HostBrowserUtilsTests easier to understand and modify.
Changes:
- Tests are now parameterized so that they run on both a bound and
  an unbound WebAPK.
- Comments for the tests are shorter and more concise.
- Global constants do not state whether the browser should be
  installed or not.

BUG=None

Change-Id: Ie1ce96892bf99001e07b42e3e4aaa4cdc53dfcb6
Reviewed-on: https://chromium-review.googlesource.com/c/1316364
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606236}