- 12 Mar, 2020 40 commits
-
-
Luca Hunkeler authored
Bug: 1059442 Change-Id: I150d2d3f7c4ead040bd144891b4d1e045ec5b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100791 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749748}
-
Jun Mukai authored
A lot of performance tests have been disabled but most of the cases they're flaky only on asan/lsan/msan bots, and that is natural because the performance is worse due to additional sanitizing. Also those performance numbers won't be helpful anyways. Considering that, it would be better to simply exclude them from sanitizer builds. This CL does not re-enable disabled tests. I'll do that after this CL is landed, one-by-one, so that we can handle the problem separately in case of unexpected failures on dbg/rel bots. Bug: 1057868 Test: build interactive_ui_tests on asan flag Change-Id: I69c22ab575d95d2ba500556ae81ab603fde44b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099328Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749747}
-
Clark DuVall authored
bundletool was updated with the fix needed for shared_resources=true. Bug: 1033098 Change-Id: I7b6f540a02d9ab4335e002726d83555d01655c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099285 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749746}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3181426885c3..8297869795cb git log 3181426885c3..8297869795cb --date=short --first-parent --format='%ad %ae %s' 2020-03-12 jacktfranklin@chromium.org Generate `protocol.d.ts` files in devtools-frontend 2020-03-12 taoalpha@google.com Fix “open in new tab” for URLs with newlines 2020-03-12 tvanderlippe@chromium.org Add missing license headers Created with: gclient setdep -r src/third_party/devtools-frontend/src@8297869795cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9cb1aeaacf799fd6f182c0e353d03ec9970edd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749745}
-
Oksana Zhuravlova authored
This reverts commit 756820dd. Reason for revert: content_browsertests failing on https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81901, https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/64935, https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100660 Original change's description: > Ensure UI Automation GetFocus reaches focused node in web content > > AXPlatformNodeDelegate::GetFocus() returns the node within the called > node's subtree that currently has focus. When an element in web content > has focus, and a delegate in Views is asked for focus, that delegate can > only reach as far as the web content root. Calling GetFocus() again on > the web content root ensures that the platform API returns the currently > focused node. > > Bug: 928811 > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162 > Reviewed-by: Ian Prest <iapres@microsoft.com> > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#749386} TBR=kbabbitt@microsoft.com,iapres@microsoft.com Change-Id: I824a736750c54aaa81e9ef0bf6d8e23d41089a25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100892Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#749744}
-
Friedrich Horschig authored
The new error state TOO_MANY_PASSWORDS_AND_QUOTA_LIMIT allows users to start a check in the already existing state TOO_MANY_PASSWORDS until the quota is exceeded. Screenshots are available at https://crbug.com/1047726#c64 Bug: 1047726 Change-Id: Ibf8dace79cbd612701e5e6b35fea473fc8be797b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098687 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#749743}
-
Eugene But authored
This histogram existed to check if specific condition still occurs, and that condition still occurs. Bug: 1059796 Change-Id: I8d52b04b6fafa274c0ced21fe619608ef0069e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095351 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#749742}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7e857092052e..7e366320bba5 git log 7e857092052e..7e366320bba5 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 bclayton@google.com Update Marl to 64d123947 2020-03-12 bclayton@google.com VkImage: Implement BC7 texture format 2020-03-11 bclayton@google.com Update Marl to 94a361cf0 Created with: gclient setdep -r src/third_party/swiftshader@7e366320bba5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058107 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic6e430df23520a2cbca93671c22edecb2e5fd7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100578Reviewed-by:
-
David Van Cleve authored
While field trial testing configs' _experiment_ names don't matter, I just learned it's necessary that their _study_ names match their server-side configurations. This change renames the ReducedReferrerGranularity field trial testing config entry to LimitReferrerGranularity in order to meet this requirement. Change-Id: I2403ebc3b20919639b875553d588209e46ed6b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036663Reviewed-by:
-
Christos Froussios authored
Bug: 1047726 Change-Id: I090fa23b5d3b4edc94cd9b40b5385be6a01fe14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100971 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749739}
-
Allen Bauer authored
Bug: 1044687 Change-Id: I698ba7bba434d30c6f2ed0928cc9c2059eb6a586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097834Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#749738}
-
Khushal authored
The GPU service code assumes that all textures uploads made directly to shared image interface are 4 byte aligned. While this is true for RGBA resources, which have 4 bytes per pixel, its not the case for ALPHA_8 resources. A mismatch in the expected size causes the upload to fail and the service side tears down the GL context. This change fixes the above by ensuring that UI resource creation code allocates and initializes the SkBitmaps with a 4 byte alignment. Bug:1013992 R=kbr@chromium.org,skyostil@chromium.org Change-Id: I2bd8e4ce7764573f2cc7b78ac8582346cf9baf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093272Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#749737}
-
Marc Treib authored
TiclInvalidationService doesn't exist anymore, and PerUserTopicRegistrationManager is now called PerUserTopicSubscriptionManager. This CL updates the class diagram to reflect these changes. Bug: 1054367 Change-Id: I8fe14265e1ff14fc8b5488f795b2c15fc179d173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100972 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#749736}
-
Evan Stade authored
This API is of questionable utility given Tab#dismissTransientUi. It was added in 82, so it can be removed in 82 without going through deprecation. If it's deemed useful in the future, it will be possible to add it back. Change-Id: I553a42e44c36471ef7b236c584a98f09d38c5c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099763 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Scott Violet authored
TimeTicks::Now() may be mocked, which means the retry logic in this file may get stuck in an infinite loop causing tests never to shut down. This converts to using TimeTicksNowIgnoringOverride() which is not mockable. BUG=1059965 TEST=none Change-Id: I3398187f034588ce41e15bb7084328e81046f48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096093 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#749734}
-
Theresa Wellington authored
If the activity is finishing or being destroyed, exit from ChromeBrowserInitializer#handlePreNativeStartup before firing pre-native and pre-inflation startup calls. BUG=1059447 Change-Id: Ia907da1c39321b97cf3405b358831b71e0add482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100110 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749733}
-
sauski authored
Previously landed strings for components of the Privacy Settings redesign used place holder or slightly incorrect strings. This CL uploads the final copy of these strings. Bug: 1032584 Change-Id: I640636ea782e1dc2de63c0f055fc29ff793953ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100007 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#749732}
-
Michael Thiessen authored
Problems this is addressing: 1. The TaskRunnerImpl hierarchy is currently too complicated, with derived classes changing how base classes function in ways that require the two classes to update in sync without breaking each other. 2. BrowserTaskExecutor holds onto WeakReferences to SingleThreadTaskRunnerImpls, allowing them to leak the native memory if the caller doesn't destroy, or continuing to return destroyed runners if the caller does destroy but GC hasn't cleaned up the runner. 3. SequencedTaskRunnerImpl creates and deletes the native side potentially with every posted task, taking time. 4. TaskExecutors aren't reset between tests leading to tasks flakily failing to run, or crashes in native code (haven't figured out what's not holding onto what it should hold onto, it was too complicated, so I fixed the caching instead). 5. UnitTestUtils#pollUiThread could time out if nothing posts tasks to the UI thread while waiting on an AtomicBoolean or similar. TaskRunnerImpl is now in full control of its native pointer, not exposing it or its lock to derived classes, and only creates its native side if a task is posted to it, as many task runners are created statically and may never actually have a task posted to them. A ReferenceQueue is used to detect when the TaskRunner is GC'd (or about to be), and that queue is polled when creating new TaskRunners, or when initializing native for a TaskRunner (basically the two operations that aren't performance critical). In practice when running Chrome we have approximately 5-10 TaskRunners alive at any given time, and we can't build up many TaskRunners without creating them, so polling for deletion at creation time should be sufficient to keep the number of dead but in memory task runners small. PostTask now also holds a Strong Reference to the PreNativeTaskRunners so that they can't be deleted before their tasks are placed on the refcounted native runner. Bug: 1058790 Change-Id: Ib58320e6f23d83ff95dc52c52bbdcf5bf7435968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091899Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#749731}
-
Michael Hablich authored
This is a roll-back to 8.2.297. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org,vahl@chromium.org Change-Id: Ie5bd476974c8c9af7a5dfa008ff7755640a03277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100848Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#749730}
-
zhaoyangli authored
This change will forward the build arg to iOS test runner scripts. CL changing how test runner scripts are consuming this arg is at crrev/c/2092941. Bug: 943883 Change-Id: I4f52cf5fcc83cdca75570c812fd1c0629a96f4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099479Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#749729}
-
John Abd-El-Malek authored
Change-Id: Ia53892d8c17d8caa689c1b5e74e4df249626dfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099477Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#749728}
-
Collin Baker authored
The Omnibox consumes all ET_GESTURE_SCROLL_* events in its bounds for text scrolling. All drags in the Omnibox area therefore weren't compatible with drag-to-open using a post-target handler. This uses a pre-target handler instead. To allow text scrolling to work, only scroll events starting with a larger vertical component are handled. Bug: 1043374 Change-Id: I589d6716e333f587952cf3e64e90171fb03a6dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099362Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
This reverts commit 99ffda8e. Reason for revert: browser_tests failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37129 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18174 Original change's description: > Changes to Webstore Private API to support child extension installation > > These changes are required in order to prompt a child user to get > parent permission when they attempt to install an extension in the > Chrome Webstore. > > This CL also enables the feature by default. > > Bug: 957832 > Change-Id: I3a2011b418e31dd491fd35e37d976b492eef197b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079620 > Commit-Queue: Dan S <danan@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749436} TBR=karandeepb@chromium.org,danan@chromium.org Change-Id: If262ccd3dad279dc60e849f9780e340b18d7384c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 957832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100891Reviewed-by:
-
Avery Musbach authored
Bug: None Change-Id: I33a5a425c1d426c2167fe48fab775f56603f1eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096179Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#749725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95001d898186..a7c0dc142e2f Created with: gclient setdep -r src-internal@a7c0dc142e2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I962c2b04f40497c4879107c17bd9d01bf7d3e8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100575Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749724}
-
Sylvain Defresne authored
Ensure that the markdown are sorted alphabetically (and that directories are sorted before files). Bug: none Change-Id: I1eb286e631bb93717b2f09016990d31ea6c172d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095105 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749723}
-
Jan Wilken Dörrie authored
This change adds a string for "Hide Password" which is supposed to be used in the more actions menu in the Password Check page. Furthermore, this change removes the "Show Password" menu entry for now, as there is no functionality. Bug: 1047726 Change-Id: I0f96d1794715b97754b9d3141dd75c3b0534149e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100748 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Ben Pastene authored
There's sufficient device capacity, so no reason not to run more tests. Change-Id: Ifde890a157e3f78e36a41c974adcff4f5e00937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099330Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#749721}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I27e528322c02724cb115b2b09744561950ce70c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054946 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#749720}
-
Sadrul Habib Chowdhury authored
Report the following UMA in rendering benchmark: . Graphics.Smoothness.PercentDroppedFrames.ScrollingThread.TouchScroll . Graphics.Smoothness.PercentDroppedFrames.ScrollingThread.WheelScroll Stop reporting the following: . Graphics.Smoothness.PercentDroppedFrames.MainThread.PinchZoom BUG=1035460 Change-Id: Ibb959eaff8955e5ec45de4824795516c2e745163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098684 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#749719}
-
Maggie Chen authored
Data has been collected. Bug: 1046001 Change-Id: Ia8b75429b0cd0bef324b32965df1d44c70bdc1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099478Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749718}
-
Jun Cai authored
This CL converts base::bind in //components/payments to Once or Repeating. The choice of using BindOnce or BindRepeating is based on the existing parameter types in the calling functions, which is either OnceCallback or RepeatingCallback, and it can be directly mapped to using BindOnce or BindRepeating. Bug: 1007715 Change-Id: Ifa18e05b3715d10916a7760eb2ed156e92e5a5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099234Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749717}
-
Igor Makarov authored
- added .style.yapf files - reformat *.py files in third_party/blink/renderer/bindings Bug: 1051750 Change-Id: Idb1998fcf425f584a518320889abdcac63b30d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061750 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#749716}
-
Elly Fong-Jones authored
On this OS release certs with SHA1 signatures are considered invalid by the system stack. Reflect this in the test expectations. Bug: 1061026 Change-Id: Ia7119cb84ac9d4176de5452c9ae4f25f4782033b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099570 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749715}
-
Marian Fechete authored
This CL updates the layout and informational messages for the AA onboarding screen, based on intent and experiment ids. Please see the screenshots shared offline already. Bug: b/150927780 Change-Id: I9e6d30a9116c41f1c38362dd5a75907742707c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098789 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749714}
-
Alex Moshchuk authored
This also removes some associated plumbing into SiteDetails and moves tests that depended on the old metric to use Memory.RenderProcessHost.Count.All. This required tweaking tests a bit to account for the spare process, which is included in the new metric but not in the old one. Bug: 1059823 Change-Id: I1a03b9c6acfe8e02b6a479aca8cdebf13a71220d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095974Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#749713}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: Ib25f6ee1dc6949cb340869a1bc439f55be08743d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096689 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Demetrios Papadopoulos authored
Specifically: - Pass focusConfig object from parent privacy-page to security-page. - Populate the route hierarchy based on the PrivacySettingsRedesign flag. - Also fixing a pre-existing bug where the /certificates route was available even in cases when it shouldn't (bug exists on stable) The focus config logic for the security page was initially added at r749030, but it wasn't entirely correct and was never triggered. Bug: 1032584 Change-Id: I6ce387485874f380c4a5c20d42c4ee5b32651245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099298Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749711}
-
arthursonzogni authored
Waiting up to 1s is probably too low. Some bots (mac) are not getting the expected report on time. See: https://bugs.chromium.org/p/chromium/issues/detail?id=1061029#c4 TBR=yhirano@chromium.org Bug: 1061029 Change-Id: Id3f24cc9ea216e6686ccbb4d534592dd9849a82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100931Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749710}
-
tby authored
We use AppLaunchData objects to send training signals about app launches to our ranking backend. We don't set one field of this object, the index of the launched item, which we now need for metrics. This CL adds it in. Bug: 1034842 Change-Id: I908c2b9072d60ae094caf51d76aa4a6be31f4dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099349 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
-
