- 15 Sep, 2020 23 commits
-
-
Tarun Bansal authored
Bug: 1089006 Change-Id: Iad9c6dad4d707c31ef038d739fa9f2e408bc13f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410583 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#806814}
-
David Tseng authored
R=anastasi@google.com Fixed: 1126707 Change-Id: I4a4eb20941d92dd6984eccb01bb37e67b67b2f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404388Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806813}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0acb5b50b342..b0245494c615 2020-09-14 johnstiles@google.com Convert several SkSL->GLSL unit tests to golden outputs. 2020-09-14 johnstiles@google.com Support testing error cases in our SkSL unit test goldens. 2020-09-14 johnstiles@google.com Disable whole-program inliner. 2020-09-14 egdaniel@google.com Add input attachment support to program building. 2020-09-14 egdaniel@google.com Remove command buffer reset bit from vk command pool. 2020-09-14 brianosman@google.com SkSL: When simplifcation requires a rescan, do it right away If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I43432403280664b65aa3a88401b3ad491d74091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806812}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009140800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Efy7gVoSk1mOpec4spFNgvpGxdfwB3frPpVKkwksne8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/128567301,b/166043485 Tbr: help-app@grotations.appspotmail.com Change-Id: I8f7a64f6bd136e62b9f6ff7380e41488c27e5a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410332Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806811}
-
Daniel Murphy authored
This change also modifies the Widget's ClosedReason enum to make the values explicit & add a comment about UMA. Bug: 1117260 Change-Id: Ib12b80b4525f3194178213b6f3a124a8a2a919a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404946 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#806810}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/75d257686e00..2296e7afd748 2020-09-14 timvp@google.com Android: Add forceQueryable="true" to AndroidManifest.xml 2020-09-14 jmadill@chromium.org Samples: Move frame counter to common location. 2020-09-14 cclao@google.com Vulkan: Use color mask to handle draw buffer disabled case 2020-09-14 syoussefi@chromium.org Add Context::renderbufferStorageMultisampleEXT 2020-09-14 lehoangq@gmail.com Metal: autogen for PBO related shaders. 2020-09-14 jmadill@chromium.org Correctly forward 'data' for capture_replay sample. 2020-09-14 jmadill@chromium.org Capture/Replay: Disable swap limit in sample. 2020-09-14 jmadill@chromium.org Samples: Enable Debug callback. 2020-09-14 amy.liu@arm.com Align the sample position in blitResolveStencil compute shader 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 41974f57973e to dc552fcef1fe (1 revision) 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 45f2f18a69eb to 399f7fd741f7 (1 revision) 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 3114c91b037b to e59713d4edda (3 revisions) 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 2de7d3af0c0e to 726af6f78f80 (6 revisions) 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 6a6e311d81dd to f8a5602c5560 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Test: Test: Manual verificationTest: Test: dEQP-GLES3.functional.fbo.invalidate.*.unbind_blit_msaa_* Change-Id: Iccaadf737fbdd0eb38d564a4d6bc44f5f529d7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411169Reviewed-by:
-
Victor Vasiliev authored
The plan here is to switch QUICHE to Abseil types in two steps: 1) Change Chromium to use Abseil implementation of wrapper types. 2) Replace wrapper types with Abseil types once #1 lands. This allows us to perform the switch without introducing churn caused by having to roll back Abseil types in case those break something in Chromium. Change-Id: I7efd58da2487c502aa03548901e370881de69a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410517 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806808}
-
Lan Wei authored
Disable Webdriver wpt test external/wpt/webdriver/tests/release_actions/sequence.py>> test_no_release_mouse_sequence_keeps_dblclick_state, because right now we do not support keep the touch and mouse events' status in gpuBenchmarking.pointerActionSequence. Bug: 1128104 Change-Id: I6060b061fc6ce0ca486e081d9cf04a64bd1342e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410312Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#806807}
-
Philip Rogers authored
This patch extends the Compositing.Rendererer.GPUMemoryForTilingsInKb histogram to M90. This metric is still useful in tracking picture layer tiling memory and we have been tracking it for compositing changes. This patch obsoletes the Compositing.Browser.GPUMemoryForTilingsInKb histogram which is not actively tracked. Memory.GPU.PeakMemoryUsage.* can be used to track overall GPU memory usage. For both, ericrk@chromium.org has sadly left the team so their entry has been replaced with paint-dev@chromium.org. Bug: 1125652 Change-Id: I344a084db9046f5086dc135882a569523d436b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408615Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806806}
-
Mike Wittman authored
std::remove_if may not preserve removed elements if they aren't already at the end of the container. Use std::stable_partition instead to get this behavior and avoid destroying modules prematurely. Bug: 1127466 Change-Id: I90175785e45e6ceea91d04ec332e263eece6f4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406525 Commit-Queue: Mike Wittman <wittman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#806805}
-
dpapad authored
It regressed at r791545, as a result of other layout changes. Should appear at the bottom of the toolbar, and not at the bottom of the entire viewport. Fixed: 1128040 Change-Id: Ia78cc531c62baa6b5a85c1fdd6abe19156d3106c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410957 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#806804}
-
Caitlin Fischer authored
The keys are GOOGLE_WEB_PROPERTIES_FIRST_PARTY and GOOGLE_WEB_PROPERTIES_TRIGGER_FIRST_PARTY. The new keys will be used to limit the set of experiment IDs included in X-Client-Data headers sent in third-party contexts when the RestrictGoogleWebVisibility feature is enabled. Note that the feature is disabled by default. Also, update relevant code to consider IDs associated with the new FIRST_PARTY groups. To do this, GetVariationsVector() and GetVariationsString() were changed to accept collections of IDCollectionKeys. Bug: 1094303 Change-Id: If931d8281f5a687548427101e07f3b3075cd349b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367989Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
For non-official builds, typically Widevine signing certs are not available. This CL updates `enable_widevine_cdm_host_verification` so it's only set to true by default when `is_official_build` is true. For developers enabling `is_official_build` and `is_chrome_branded` locally without Widevine signing certs, the build may fail. In this case simply set `enable_widevine_cdm_host_verification` to false to suppress the error. Bug: 1127616 Change-Id: I4256f8c53d79907eec23782300e223b4edb89d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410311Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806802}
-
Andrew Xu authored
Currently the calculation of the bubble menu bounds fails to take the cached menu position into consideration while calculating the normal menu bounds does. This CL fixes the inconsistency. Bug: 1126244 Change-Id: I783b435c082e766000457cf014c40e0931b2bb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394727 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Orin Jaworski authored
This CL adds a unit test to ensure AutocompleteResult properly attaches Pedals to matches. Bug: 1122622, 893183 Change-Id: I6deff6ae0260a8c286a9538c73f1b319a255ebd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407011Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#806800}
-
K. Moon authored
Calls LoadUrl() from PdfViewWebPlugin with the URL from the "stream-url" attribute. Combined with crrev.com/c/2330933 (WIP), this is sufficient to start testing URL loading locally. Logs NOTIMPLEMENTED() from PdfViewWebPlugin's DocumentLoadComplete() and DocumentLoadFailed(), to make the outcome of loading obvious. Bug: 1099022 Change-Id: I94084fe42151daf5e4084749eb6ba466e2a918df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411329Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Ian Barkley-Yeung authored
Split the code that sends the JavaScript error reports out from CrashReportPrivateReportErrorFunction. Future updates mean this code will also be called from content/browser/webui/. This CL should be have no functional changes other than a few small bug fixes, namely: * Redaction should happen after removing the error message to ensure the string matching works as expected. * Properly convert line number and column number to strings. Bug: chromium:1121816 Change-Id: Ibf1636fc3d32323a7d0350ee3cb91b3d81259d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399577Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#806798}
-
Garrett Beaty authored
The chromium.goma.migration console was used for tracking the migration of chromium builders to the RBE backend. The migration was completed some time ago and so the manually curated console is an unnecessary touch point when removing or renaming builders. Change-Id: I41c1b9a3e418b371a71e2830accb6919f684e063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411328 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#806797}
-
evliu authored
This CL defines the SODA tests to be run in the internal SODA waterfall. Bug: 1124873 Change-Id: I57296bb239dba6c03ef0e231ed30e8d043a35e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406591Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#806796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I88dc0aab84f7532ec8bb0a9abede98e82713e63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411277Reviewed-by:
-
David Black authored
Currently we wait until persistence has been restored but we need to also wait until downloads have been restored. Bug: 1128090 Change-Id: Iec43f87b18267cc7913f2129a4e6bfb2fc8a5e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410842 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#806794}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I3a455297048e8356fb60d1b0a6c4fcce813c827f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411271Reviewed-by:
-
Harald Alvestrand authored
The JS-visible state wasn't always in sync after stop(). Also fix tests: Stop checking for "stopped" attribute that has been removed from spec. Change awaiting to account for negotiationNeeded being fired from setLocalDescription/setRemoteDescription(answer). Change expectations to account for transceivers disappearing from view when finally stopped. Still some remaining issues. Bug: chromium:980879 Change-Id: I5d4cb5482187ab40140ef99ac46f39a2d1628b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375648Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806792}
-
- 14 Sep, 2020 17 commits
-
-
Chris Mumford authored
This reverts commit c663b9ea. Reason for revert: Suspected to be exposing test failures in Accessibility tests in content_browsertests and storage_service_content_browsertests. See https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/15808. Note that the one accessibility CL (r806594) was reverted, which did not fix this failure. Original change's description: > [base] CHECK(str) in BasicStringPiece constructor > > This change adds a CHECK(str) into BasicStringPiece's constructor from > `const value_type* str`. This prepares the code base for switching to > std::string_view, since std::string_view(nullptr) would invoke undefined > behavior. > > Bug: 1049498 > Change-Id: Id5d832bc0586dc16a5e1045ba67602e4dc57317d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407712 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806581} TBR=dcheng@chromium.org,jdoerrie@chromium.org Change-Id: Ie734746c940bad086a189485d792ffd02a6b7a97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411430Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#806791}
-
Matt Jones authored
Bug: 1126872 Change-Id: I2f8696f6e57cc3be78fec1713707478a5ce4a1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406839 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#806790}
-
Takuto Ikuta authored
This reverts commit d2a879a0. Reason for revert: https://crbug.com/1127966#c29 Original change's description: > Roll luci_go to 18502e6a01811b0c2dd2a0250e81bd82e47d2c2d > > https://chromium.googlesource.com/infra/infra/+/18502e6a01811b0c2dd2a0250e81bd82e47d2c2d > > Bug: 1127205 > Change-Id: Ia58d7727f1b877bd4c48b62fa4c0872bd449be50 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409393 > Commit-Queue: Ye Kuang <yekuang@google.com> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806576} TBR=tikuta@chromium.org,jwata@google.com,yekuang@google.com Change-Id: I7edfe4c16543b70e2b3dd2fcbd9822c6ea7d6bf8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205, 1127966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409881 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806789}
-
Tomasz Wiszkowski authored
This change propagated suggestion subtypes to Java, enabling Clank to identify Trending Query suggestions. Bug: 1122669 Change-Id: Id6669bd9c9344e786836486fd5c66087bbc6f1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402135 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#806788}
-
Robbie McElrath authored
This CL modifies our copy of the AndroidX fragment library to include r.android.com/1302016, which prevents a problematic getActivity() call in DialogFragment.java. Bug: 1123216 Change-Id: I33ffcdc00b694ac5b521ba30014053d2acdbdfc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406600Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#806787}
-
Ryan Hansberry authored
BluetoothServerSocket is created on the main thread, but its public methods are used on a separate dedicated thread. mojo::Remote objects (namely, BluetoothServerSocket's |server_socket_|) must be bound on the same thread they are used on, to prevent deadlock. So, we hold onto this mojo::PendingRemote |pending_server_socket_| until Accept() is called, at which point |server_socket_| is bound with it (it is acceptable to pass a mojo::PendingRemote around multiple threads). bluetooth_server_socket_unittest.cc has been adjusted for this change. I have verified that the test fails if this fix is not present. Further, mojo::Remotes expect to be run on a SequencedTaskRunner. Tweak our ImplementationPlatform::CreateMultiThreadExecutor() impl to provide a SequencedTaskRunner to satisfy this requirement. Bug: 1126620 Change-Id: I5dbb11d0d97b8167f60acb08fc1ae962bdf17f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407296Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#806786}
-
Siyu An authored
Bug: 1112095 Change-Id: I7e4d41d8baaafb9d8b900690b5af7811d29615d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410307 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#806785}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/081bc32703b7..0acb5b50b342 2020-09-14 brianosman@google.com Allow casting to lower precision types in runtime effects 2020-09-14 kjlubick@google.com [fuzz] Make libfuzzer defines backwards compatible for roll 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from b1f9041ffe31 to 069b8f699b59 (1 revision) 2020-09-14 egdaniel@google.com Force linux nvida vulkan to use dedicated image allocations. 2020-09-14 adlai@google.com Downgrade SkImage to GrImageContext 2020-09-14 ethannicholas@google.com SkSL optimization now happens in convertProgram rather than being a 2020-09-14 adlai@google.com Elevate caps methods to GrRecordingContext 2020-09-14 egdaniel@google.com Update GrVkRenderPasses to be created to support both input attachments and adv blend. 2020-09-14 mtklein@google.com bazel baby steps 2020-09-14 johnstiles@google.com Generate SkSL golden output files from test inputs during the build. 2020-09-14 johnstiles@google.com Enable the inlining pass during optimization. 2020-09-14 kjlubick@google.com [fuzz] Standardize, document, and backport fuzzing defines. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1127358 Tbr: scroggo@google.com Change-Id: I76d55b9b5b3c4a7ecd6eb65c6632bf5d902448f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410616Reviewed-by:
-
Yulun Wu authored
There is a presubmit error for search_result_suggestion_chip_view.cc as it is missing an include. search_result_suggestion_chip_view.cc:204: Add #include <algorithm> for min [build/include_what_you_use] [4] Bug: 1128107 Change-Id: I167dfb004de9fa4844d5f8138f23b12e556cbee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410589 Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806783}
-
Johann authored
Remove usage of DISALLOW_COPY_AND_ASSIGN from documentation. styleguide/c++/c++-dos-and-donts.md: 'DISALLOW_COPY_AND_ASSIGN` is deprecated. For a non-copyable/movable type, delete the copy operations (the move operations will be implicitly deleted); otherwise, declare either copy operations, move operations, or both (a non-declared pair will be implicitly deleted). Always declare or delete both construction and assignment, not just one (which can introduce subtle bugs). Change-Id: I2d2e0ecf95c3ef764dc90d49c674625c15432d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404905Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#806782}
-
Ken MacKay authored
Bug: internal b/160616014 Change-Id: If764ba82678059a21cda3d9ecd44c7dbe620fb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410926 Auto-Submit: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806781}
-
Mohammad Refaat authored
This will be used by crash restoration logic to know which sessions to backup for restoration. Bug: 1126311 Change-Id: I064d1da30bfcfc368539240b7c9c9a2f65490d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399886Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#806780}
-
Yusuf Sengul authored
Bug: 1127549 Change-Id: Ie996c71a86bd6303f8e82c20086ad34711b89e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407074Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#806779}
-
Filip Gorski authored
Choosing to disable 3 tests failing on an assert, because an alternative is to revert a crash fix. This fails on assert which is compiled out. TBR=peconn@chromium.org Bug: 1128073 Change-Id: Icc5667f4ad1504c7776bc06af010e9f8d94b5a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410923Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Nina Satragno authored
Add partial support to the largeBlobs CTAP2.1 command at the device level. In particular, implement chunking, reading and writing arbitrary blobs. The virtual authenticator command is also implemented in order to test the feature. Missing features are encrypting & compressing the blobs and pin token. Nothing is wired to the web yet. This is part of the large blob storage extension implementation. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I2f85c0b0b17b2054ad5bc0af69432d1765b6f2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388992 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#806777}
-
Robert Sesek authored
This is needed to look up the Metal cache directory, which is used for graphics acceleration by various system frameworks. Bug: 1126350 Change-Id: I79e05c603859aa49082fbbbc09c1da9b4ae3a990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411151 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#806776}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkProxyInputTest* Change-Id: I45813304a2c638cd13bb64a46e2fe14a23037783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406666 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806775}
-
