GitLab

An extension can use the privacy.websites.ThirdPartyCookiesAllowed
extension api to set the kBlockThirdPartyCookies preference.
kCookieControlsMode needs to be set to the corresponding value if
kBlockThirdPartyCookies is controlled by extension.

Bug: 1065392
Change-Id: Ib450349cb33251b3eccc06ff2dcc18a0899a028e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127034
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#755106}

This provides access via the system menus to a new setting that is
currently only present in the omnibox context menu. To achieve that,
this change:

1) Adds a new IDC_SHOW_FULL_URLS command and handling logic
2) Adds a new conditionally-present item to the main menu bound to
   that command
3) Has OmniboxViewView listen for changes in the backing pref and
   update its appearance
4) Remove the logic in OmniboxViewView to manually update appearance
   when changing the pref, since that is now accomplished via
   listening to changes on the pref

This change doesn't have any automated tests. I spent some hours
trying to write one, but ran persistently into two problems:
1) All the existing tests of OmniboxViewView are Views unittests
   and do not have a "real" LocationBarView/Browser/PrefService
2) Adding a new test, using BrowserWithTestWindowTest instead,
   means having to construct a real LocationBarView and quite
   a few other backing services/classes/etc.

The effort involved and brittleness of the resulting test quickly
exceeded the value of the test, so I decided to just do without.

Bug: 1061576
Change-Id: I17d86124e334fb7f85407a16f2c8c31d9f77ebbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120854
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755105}

Add missing trailing semicolon.

Bug: 1065504
Change-Id: I98fe899a3934a1c4e6df34f7e08b171647bd9be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130447
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Auto-Submit: Qijiang Fan <fqj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755104}

This reverts commit 350ec69f.

Reason for revert: After this change, changing android_channel in args.gn and rebuilding doesn't reliably cause a manifest rebuild and some of the built APKs end up still using the package name/etc from the previous channel. crbug.com/1066594

Original change's description:
> Android: Add md5check to compile_resources.py
> 
> Using md5check speeds up the build by not re-compiling resources if its
> dependencies have not changed.
> 
> Shaves 5 seconds off for Chrome Java Signature Change (77s -> 72s).
> Shaves 12 seconds off for Base Java Signature Change (174s -> 162s).
> 
> Bug: 906803
> Change-Id: Idccbc080dfdfb75b1ce801f3fcd934b93c2c3bb1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120047
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Auto-Submit: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754507}

TBR=wnwen@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 906803
Change-Id: I66045a49a1076b1c2644cc1a1b96a5d4c3cf547d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130866Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755103}

* Keydown 'Enter' causes the selected row to trigger a route change.
* If the selected row is focused, keydown 'Enter' triggers route change.
* Clicking on specific row causes the row to trigger a route change
  (iron-list also causes the row to become the selected row on click).
* If a user deselects a row, re-select the row (one row should always be
  selected). Deselection is an <iron-list> behavior we must work around.
* Add test to confirm <os-search-result-row> has the correct behaviors.
* A route change won't cause the cr-input to lose its text, nor will it
  cause the results to be lost, nor the selected item to be deselected.

Bug: 1056909
Change-Id: I00c151acd7439b916b4b01bec188cb48197c775d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123787
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755102}

Problem :
AXObjectCacheImpl accumulates events when it's not clear whether layout
is in a clean state then fires these events when layout is clean.
Unfortunately this means that if an event is enqueued that isn't
associated with a layout change then there's no guarantee the event
will be fired.

This CL attempts to fire these deferred events more regularly by
hooking up an accessibility DocumentLifecycle state, and scheduling
a lifecycle update whenever a deferred event is enqueued to guarantee
the events are fired.

Bug: 1050792
Change-Id: Iceb9fe5252aff5538435710b1d285b93c609bba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055361
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755101}

Extends the expiration of Extensions.Checkup.TimeSpent,
Extensions.Checkup.NtpPromoClicked, and
Extensions.Checkup.NtpPromoShown to after M85.

Bug: 1066034
Change-Id: I082734ceacb0ea66dfd8893dfc35b7b8fb88dbb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129027Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755100}

Measure time between start showing the screen and the ready state.

Bug: 1066489
Change-Id: I6e705c222db8b5bd178f8edfbb35393669f10f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129551
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755099}

Keeping R8 revision the same, but updated local modifications:
* Expose dexsplitter-related R8 flags
   * Taken from reverted change:
     https://chromium-review.googlesource.com/c/chromium/src/+/2014309
* Disable stateless lambda "optimization"
* Makes horizontal & vertical class merging separate flags.
* Make --file-per-class use DexFilePerClassFile rather than
  DexFilePerClass (fixes incremental dexing /w desugar_with_d8).

Also updates update instructions.

Bug: 1032609
Change-Id: I1553785fa103ed3164206e0397fe320cce980f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127512Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755098}

TBR=msw@chromium.org

Bug: 1066607
Change-Id: I745a6851628f5c59431a4a28f7294b1829b361ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130968Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755097}

https://skia.googlesource.com/skia.git/+log/8cbedf985570..8b99b9e1d11c

git log 8cbedf985570..8b99b9e1d11c --date=short --first-parent --format='%ad %ae %s'
2020-03-31 mtklein@google.com flatten skvm type nesting
2020-03-31 herb@google.com Update header list for spirv-tools
2020-03-31 bsalomon@google.com Revert "Revert "Assert that all GrCaps colortype/format -> swizzle queries are legal.""
2020-03-31 herb@google.com Introduce Liveness and Uses into existing scheduler
2020-03-31 egdaniel@google.com Add rasterizer and blend state to d3d pipeline state.

Created with:
  gclient setdep -r src/third_party/skia@8b99b9e1d11c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I7d5d59d0d4d34c99eb78dfba13f7808cbf46e78c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130607Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755096}

Change-Id: Ieff28b1dbafd39f3b38b047553ea67d3f6cea959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129997Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755095}

Index names are at the DB level and some of them
are duplicated so this prefixes them all with
the table name.

BUG=1024351

Change-Id: I9e8ba700625e9d2c42f2fbeaab3ba216f450f0a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129898Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755094}

../../chromecast/media/cma/backend/volume_control.cc:57:7: error: unused function 'DbFsToScale' [-Werror,-Wunused-function]
float DbFsToScale(float db) {
      ^
1 error generated.

Bug: b/152723969
Test: Cast CQ
Change-Id: Ie8553fbf2c5b537d8e493d652e442bb6199030a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130772Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755093}

TBR=govind@chromium.org

Change-Id: I8a3cc83c8e2d08e77bd8b1a4831c81db8952a468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130312Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755092}

This allows adding new payments-specific JNI files without always having
to get //chrome/android OWNERS review.

Bug: 1063118
Change-Id: Ia2c86780c7527ea871902664496105908d2532ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129026
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755091}

After OSSettings is set to be disabled in ExtensionManagement,
it gets re-enabled because it's ComponentLocation & from_bookmark, so an
exception has to be added to enable admins to disable it.
This exception will go away when OSSettings is switched to WebApps,
which should happen very soon.

Bug: 1063404
Change-Id: I457fb5e86aedc54930fb795d90e9fa7650a4f938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124790Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#755090}

Remove unnecessary words to make sure our UI is easy to localize and
free of cultural references that may confuse users.

Bug: 899414
Change-Id: Id5474ea5edd0adf46226c00f00963710dc084234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128317
Commit-Queue: Anqing Zhao <anqing@google.com>
Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755089}

The histogram can be insightful during the transition of the macOS
printing backend to CUPS IPP.

Meanwhile add a secondary owner.

Bug: 1053247
Change-Id: Idb3f5717b89fd5a9fe026d2be4782454d7280589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130328
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755088}

Bug: 1015841
Change-Id: I0a3103628117bd5a46750999a4f6020915df61d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116219Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755087}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Id352eb5c44a590e4b272a2ea1bc239864dd4f558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130826Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755086}

BUG=1052916

Change-Id: I5b402cbda97f83d9abac29d105c469fd890e2e53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112335Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755085}

input-events-typing.html and caretnavigation.html both use
test_driver.Actions which isn't supported yet by content_shell.

BUG=893480

Change-Id: Ic4b0f56ac6a32a97c5b2344cd11536401fa67e2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130673Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755084}

Since only Chrome binds InstalledAppProvider, but a default no-op
behaviour is expected for other embedders (tests, WebView, WebLayer),
this change removed the 'non-Android' condition for the default
InstalledAppProvider binder to avoid renderer termination for the
'no binder found' case.

Bug: 1064644, 1064827
Test: No crash when opening reddit.com in webview shell on an emulator
Change-Id: Ia9e6d98f0abff94929bf10dcd778166c90907f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124872Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755083}

UIKit has fixed orphaned word in UILabel since iOS 11.
Our custom implementation of fixing orphaned words
is no longer necessary.
Furthermore, adding an arbitrary new line in a UILabel
has unintended consequences, such as failing EG tests
that would otherwise pass.

Change-Id: Ifc5ca16d8fca83aa67306d94ceac9db132ded45a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129241Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755082}

This reverts commit 4a7fe529.

Reason for revert: The loading behavior is designed wrong.

The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is.

Currently: the behavior is observed when rendering is delayed by font preloading.

What's actually needed: the behavior is observed when font preloading occurs

Original change's description:
> Record split UMA histograms when rendering has been delayed for font preloading
> 
> This patch adds split histograms of the following metrics when
> rendering delay for web font preloading has been triggered:
> - PaintTiming.NavigationToFirstPaint
> - PaintTiming.NavigationToFirstContentfulPaint
> - PaintTiming.NavigationToLargestContentfulPaint
> - LayoutInstability.CumulativeShiftScore
> 
> This will help us understand the effectiveness of this optimization, and
> adjust the length of the delay to the best value.
> 
> Bug: 1040632
> Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754771}

TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org

Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1040632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755081}

This is a reland of 2412286a. Is not
the culprit for https://crbug.com/1066455, the cause of the revert.

Original change's description:
> Propagate main frame document dimensions through frame intersections.
>
> This change calls OnMainFrameDocumentIntersectionChanged for the main
> frame. The RenderFrame resets the main frame's intersection when the
> frame commits a navigation to ensure we propagate a new intersection
> for each committed navigation (otherwise we may lose updates when the
> render frame observer propagates values for uncommitted loads to
> page load metrics).
>
> This allows consumers to compare frame intersections with the main
> frame's rect. This is a precursor to measuring page ad density.
>
> BUG=993453
>
> Change-Id: I689505c086ed0216af9f216ed4dd3d13f9c3ec1d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105622
> Commit-Queue: Justin Miron <justinmiron@google.com>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: John Delaney <johnidel@chromium.org>
> Reviewed-by: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754626}

Bug: 993453
Change-Id: I5c08939d9cb8181eb4dac2d7fa5d55919fe848c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128984Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#755080}

Blink moved from WTF::RefPtr to base::scoped_refptr long time ago, but
the poor GC compiler plugin was forgotten...

Bug: 763844
Change-Id: Ie61bfcf7fe4ff3c159d573282e09af7c5174bce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130786Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755079}

This is needed to call it on const objects.

NOPRESUBMIT=true

Bug: none
Change-Id: Ib6159b35e56b3e9983b27caea181983f8acb7f5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126250
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755078}

These tests passed on the WPT fyi bot but weren't tested in the
layout tests because the testdriver-vendor.js didn't have plumbing
for the non chromedriver path.

Since our waterfall generally runs this path it is wise to add this
support to this code path.

BUG=626703

Change-Id: I9f0c91198146535a2d5cdb71baa29d463820ddd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129017Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755077}

This is a follow up of [1], where test expectation were using
chrome-specific scrollbar dimensions. The issue has been identified
and logged on mozilla's bugzilla [2].

[1] https://crrev.com/c/2120544
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1625764

Note that, despite fixing the chrome-specific scrollbar issue,
the test won't completely pass on Firefox.
By loading the test on the browsers (eg Firefox and Chrome),
it is possible to observe that the failures actually manifest
as a visual rendering difference between both engines.
This needs to be investigated further.

BUG=1063749
R=cbiesinger@chromium.org, dgrogan@chromium.org

Change-Id: I9e45be0ba836d83483edd8220491a35f22aba00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130046Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#755076}

Bug: 1066209
Change-Id: I8ac47add1032e2a4ce6c490602977e312a3d3300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128095
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Auto-Submit: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755075}

This mirrors the WPT functions for assert_throws_{dom, js, exactly}, and
provides a clearer API for what is being tested. (Previously the code
would guess based on the type of the input).

Bug: None
Change-Id: I916636d9cf3561c3d6cde7cbb0b73a4a8c436dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128379
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755074}

Python 3 doesn't support implicit relative imports.
Fix this by adding the current directory to the search path, so all the files can be found.
This works on both Python 2 and 3.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/bindings/scripts/collect_idl_files.py", line 14, in <module>
    import blink_idl_parser
  File "C:\Google\chromium\src\third_party\blink\renderer\bindings\scripts\blink_idl_parser.py", line 74, in <module>
    from idl_parser.idl_parser import IDLParser  # pylint: disable=import-error
  File "C:\Google\chromium\src\third_party\blink\renderer\bindings\scripts\..\..\..\..\..\tools\idl_parser\idl_parser.py", line 38, in <module>
    from idl_lexer import IDLLexer
ModuleNotFoundError: No module named 'idl_lexer'

Bug: 941669
Change-Id: Ib0e7c88100fd0cc1eee90d252ad8c557e1e25197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124475
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#755073}

This reverts commit fb30c93b.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1066610

Original change's description:
> WebApps: Fix PWA initial positions in certain configs
> 
> Similar to Bug: 783199, when user have two monitors that set to
> different scales, PWA may relaunch off the screen.
> This change does a similar fix for PWA as the original change did
> for devtools.
> 
> Bug: 1046481
> Change-Id: I63230b01c59c5f277298c5bc5e51c8703cc6f54a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074799
> Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#755007}

TBR=pkasting@chromium.org,mjackson@microsoft.com,lomitch@microsoft.com,juxiao@microsoft.com

Change-Id: I8bfbcdb7d1c36492bb116b45464d5e09ca13e01a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1046481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131009Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755072}

Change-Id: I45493078cf97dbe35366b5254e356880c3466359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130668
Auto-Submit: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755071}

This was originally left out of https://crrev.com/d255670 due to an
error when trying to use assert_throws_js. After investigation, it turns
out just to be that the function using assert_reports_js was not passing
a TypeError from the right global.

Bug: None
Change-Id: I8067949ddf6e9108bd862287cb49eef7aa788eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128243Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755070}

Troublesome Privacy Page UMA logging tests were disabled in anticipation
of a major UMA rework. That rework has come and gone but erroneously
did not renable the privacy_page specific tests.

Fixed: 1066182
Change-Id: I9291aa353aeebd581f164615e9e6033d9e53dbad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129698
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755069}

Bug: chromium:1053803, chromium:1063472
Change-Id: Iffa81bf28b74be04772384d690e6cd55b65c95ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130226
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755068}

Bug: 890452
Change-Id: I06a5603ee5a3ce7ba192112070d76729e674f598
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128942
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755067}