- 30 Oct, 2020 40 commits
-
-
chinsenj authored
Currently the desk rename textfield does not account for its padding when eliding its text. This results in the first couple of letters not being visible when a long desk name is typed. This CL fixes this bug by making the desk rename textfield account for its padding. Test: manual Bug: 1142104 Change-Id: I515e9822bd8d1321d62bb976bdfa59ad5fcb48ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505678Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#822712}
-
Andrew Grieve authored
Change-Id: I7151ec2d5161c5ba7b424486f88156a7c6c669f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510091 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822711}
-
Dave Tapuska authored
We can remove the WebWidgetClient callback to get the FrameSinkId and replace it with a parameter passed into the ctor. BUG=1097816 Change-Id: I4369df664776262e9331df8dcc49ff1c97a68325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504748Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#822710}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I4e06a7a480bd6a1f6743fbd035edd52f051f5eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510377Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822709}
-
Igor Britsky authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): In file included from ../../ui/gfx/x/event.h:14, from ../../ui/events/platform/x11/x11_event_source.h:19, from ../../ui/events/platform/x11/x11_event_source.cc:5: gen/ui/gfx/x/xproto.h:2744:16: note: candidate: 'x11::Future<void> x11::XProto::CreateWindow(const x11::CreateWindowRequest&)' gen/ui/gfx/x/xproto.h:2744:16: note: no known conversion for argument 1 from '<brace-enclosed initializer list>' to 'const x11:: CreateWindowRequest&' ../../ui/events/platform/x11/x11_event_source.cc:201:4: error: no matching function for call to 'x11::Connection::ChangeProperty(<brace- enclosed initializer list>)' Bug: 819294 Change-Id: I604af19e3c441bbb788d0b6094c52f12df49269e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506431Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#822708}
-
Yann Dago authored
This is a reland of e977adb7 Original change's description: > PolicyService: Notify when policies from all providers are loaded > > Add a new PolicyService::Observer::OnFirstPoliciesLoaded function to > listen to first policies loaded on a policy domain. This allows > observers to be notified when all policies are loaded. This allows > services that rely on policies to wait for eventual cloud policies > before starting. This can take sometime if the cloud policies do not > have a local cache and need to fetch their policies over the network. > > Bug: 1129065 > Change-Id: I5b50b0b6a1737c818ea2277d905a64151f45c95e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409132 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Yann Dago <ydago@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822342} Bug: 1129065 Change-Id: Ia10604c2332f616bbed45fc117d005334dacbf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509971Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#822707}
-
Elly Fong-Jones authored
This flag has been expired since M76 and controls a disabled-by-default feature, so the code controlled by it has been dead for a long time. Bug: 1110712 Change-Id: I6ffd0bf8050fe6cdc5d0dd9f9bcfdef0c93a0323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507396Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#822706}
-
Hidehiko Abe authored
So, the utilities can be used in ui/ozone/platform/wayland in following CLs. Also, along with the move, this CL introduces more error checks and adds unittests. Bug: 1140536 Test: Ran ui_base_unittests, exo_unittests. Quick manual tests with Lacros. Change-Id: I5de661528f328fd0e79154f8011056d1816e0f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489107 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#822705}
-
Salvador Guerrero authored
This CL disables the following test: * ReturnToChromeTest.testTabSwitcherModeNotTriggeredWithinThreshold_NTP Because it's flaky on builder: * Lollipop Tablet Tester TBR=wychen@chromium.org Bug: 1144184 Change-Id: Ic5940731985e84fedff4d3bccac0825f4ee7d7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510356Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#822704}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/5d40a5621b7d..17e0deaebaa6 2020-10-30 dsinclair@chromium.org One command per line If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: I91018df075b3d37d7d80c119eba1637505460e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822703}
-
Tom Anderson authored
This CL separates all Xlib code into xlib_support.{h,cc}. This is done because in a followup, I'm going to use generate_stubs to remove the link-time dependency on Xlib altogether, and it's nice to have all usages of the stubs in a single file. With this change, the only real usages of the Xlib display are from external components like GLX, VAAPI, Vulkan, and EGL. While XProto does provide GLX requests, some requests contain vendor-specific binary data (x11::Glx::VendorPrivateRequest), thus we cannot get rid of libGLX. Fortunately, the GLX C bindings are already dlopen()ed, so this does not present a link-time issue for systems without X11 that only have wayland. R=sky BUG=1066670 Change-Id: I6cc36207fcfb9211ea8f73abb5411ba8d26393fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492177Reviewed-by: -
Lukasz Anforowicz authored
Bug: 1116320 Change-Id: I44c2f377ffb64cd23480562c7b30a0a9e389607e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506171 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822701}
-
Eric Seckler authored
Since we're using this now also from WebView, where the hosting app's permissions may not include those required for network/wifi state access, we need to check for permissions before we attempt to use RadioUtils. (Otherwise, thrown exceptions will cause crashes.) Fixed: 1144080 Change-Id: I9d39c951df79e10285effadd651d11bbe400a27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509517 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822700}
-
Mohamed Heikal authored
This reverts commit 0a352eeb. Reason for revert: breaking chromium perf Original change's description: > Migrate chime dfm definition downstream (Reland) > > chime is a downstream only DFMs, it should be defined downstream only > and not reference clank from the chromium repo. > > Followup downstream cl crrev.com/i/3358245 > > This reverts commit ba4e63fc. > > Reason for reland: Will be relanding downstream cl immediately > afterwards skipping downstream CQ. > > TBR=agrieve@chromium.org,xingliu@chromium.org > > Bug: 1142775,1143787 > Change-Id: I9042358b942b233e8657306c339b6345e91913ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508471 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822685} TBR=agrieve@chromium.org,xingliu@chromium.org,mheikal@chromium.org,nuskos@chromium.org Change-Id: I913d35a325abfb1b74d5a272093707e4ef6d194c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142775 Bug: 1143787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510212Reviewed-by:
-
Chris Hamilton authored
This lets it be depended on by components that are indirect dependencies of blink/public/common itself, severing the circular dependency that otherwise arises. Change-Id: I8b0bed42775f8e17dd800ee425d701c9d85986fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503230 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822698}
-
Matthias Körber authored
This CL changes Autofill to use the import from a unified section by default. Change-Id: I36a3835ff7e9c069f1d21a5978909bc543ad2254 Bug: 1097125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505893Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#822697}
-
Nick Diego Yamane authored
Context: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This is a follow-up change, that implements the animation disabling for the dragged window when there is extended-drag source attached to the active DnD wl_data_source. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=oshima@chromium.org Bug: 1099418 Test: Manually tested. Change-Id: Ib16842e4d5ca1e5a1f24313ddaddbe3373cfbc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411159 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822696}
-
Robin Lewis authored
Login enforcement is done only when cloud policies is enabled. Bug: 1142903 Change-Id: If870ec909122a39b18af33ff95f90b49ef72a198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503810 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#822695}
-
Andrew Xu authored
ClipboardHistoryBitmapItemView contains a pointer to a RoundedImageView instance which is the item view's grandchild. This CL removes the pointer to RoundedImageView from ClipboardHistoryBitmapItemView. Instead, the pointer is kept by BitmapContentsView, the RoundedImageView's parent. This change should not bring any visual difference. Bug: 1139498 Change-Id: Ie3e2dacd32dcd6500394278c01e1903c35b5f8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508797 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#822694}
-
Tim van der Lippe authored
Required for landing https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2503953 R=aerotwist@chromium.org Bug: 1143170 Change-Id: I05d92cb184326ed8a1574257d0419a67058a92d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504267 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#822693}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a8c01862f57f..42ad02798240 2020-10-30 jmadill@chromium.org Omit types in EVENT macros. 2020-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from a72e7b987746 to f673b4e6ebf3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I7995daf8698827deaab29110e333965067831bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510316Reviewed-by:
-
Liquan (Max) Gu authored
Reason for revert: The original CL breaks the clank build. Changes after revert: No change compared to the original CL. The clank CL[1] needs to be merged first before landing this patch. [1] https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3370809 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2503890 Reverting CL: https://chromium-review.googlesource.com/c/chromium/src/+/2508954 Bug: 1144005, 1129572 Change-Id: I774f8561cd96e9b057d169c38013c4d277b72783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509015 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822691}
-
Nick Diego Yamane authored
Context: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This is the third of a patch series which implements extended-drag in Exo compositor. This one implements cursor locking options, required for Chrome's tab dragging, otherwise DragDropController would update the cursor shape based on the widget under the cursor accept DND operation or not, which is meaningless for tab/window dragging purposes. Refer to the design doc for more details. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=oshima@chromium.org Bug: 1099418 Change-Id: Ie41f487b26e2eda72dd5be25590d8565e6a5edcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401358 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
Lukasz Anforowicz authored
This CL re-enables CrossSiteDocumentBlockingTest.BlockForVariousTargets because we speculate (as explained in https://crbug.com/1075663#c15) that the root cause of the flakiness was unrelated to the test and has been fixed by r792326 which fixed raciness in NestedMessagePumpAndroid in July. Fixed: 1075663 Change-Id: Ie370c65671d9d498056ffb95c4e75e8940e8d1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508910Reviewed-by:
-
Elvin Hu authored
Bug: 1138715, 1141522, 1141524, 1141523 Change-Id: I3f483577c27383be01f5150b72ad1d323d097f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471577 Commit-Queue: Javier Flores <javierrobles@chromium.org> Commit-Queue: Elvin Hu <elvinhu@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#822688}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7060721b4ec0..cf5f19d0ea8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmonette@google.com,mastiz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmonette@google.com,mastiz@google.com Change-Id: I275a207b797d271af6b65a7509c462e47a7684c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510430Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822687}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iea0a6bdc633cc960d9c93ab1202d158284fc5f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510326Reviewed-by:
-
Mohamed Heikal authored
chime is a downstream only DFMs, it should be defined downstream only and not reference clank from the chromium repo. Followup downstream cl crrev.com/i/3358245 This reverts commit ba4e63fc. Reason for reland: Will be relanding downstream cl immediately afterwards skipping downstream CQ. TBR=agrieve@chromium.org,xingliu@chromium.org Bug: 1142775,1143787 Change-Id: I9042358b942b233e8657306c339b6345e91913ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508471 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822685}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e184bf1e5f83..c1ca9469d705 2020-10-30 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseController.js with TypeScript 2020-10-30 andoli@chromium.org Refactor Sources.SourceMapNamesResolver._scopeResolvedForTest to proper accesor 2020-10-30 changhaohan@chromium.org Update popover state to only allow one popover in Styles pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1126178,chromium:1142525 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9237c014c3782dfb5ddd52ffdc4359807a698eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510318Reviewed-by:
-
Roman Arora authored
Bug: 1143854 Change-Id: Ia4e311d04b09c7d90191066f9ad8174bfe34ed58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508183 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#822683}
-
Nick Diego Yamane authored
Context: Wayland Protocol needs to be extended to make it possible to properly support full Chrome's tab dragging experience. Further details in the Design document [1]. This is the first of a patch series which implements extended-drag in Exo compositor. More specifically, this implements the core feature of the protocol: Making it possible to drag toplevel shell surfaces during DND sessions. It does it by making ExtendedDragSource an implementation of the ash::ToplevelWindowDragDelegate interface and plumbing it into ash's ToplevelWindowEventHandler, delegating to it the actual toplevel window drag handling. Refer to the design doc for more details. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=oshima@chromium.org Bug: 1099418 Test: exo_unittests --gtest_filter='ExtendedDragSourceTest.*' Change-Id: I43908dda9f542e5813d96a2e331af8df0a703efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401280Reviewed-by:
-
Richard Knoll authored
This adds metrics for actions of the muted notification as well as stats once the screen capture session ends. Bug: 1131375 Change-Id: I47a5fc9bf6677f3cc248d727b9a95c4048983870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467941 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#822681}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I7ceebe66bc953a0a1211896244fe3bf9e47f1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508201 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
Change-Id: Ib9e6c047c410e2060b8f08d91863fea8372eec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507669Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#822679}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010300700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/wwoFvUm67SLBY3_HfnEX0lkXxs04pITqyLjVOEmfCZAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/171158139,b/171263711,b/172022118 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib87fc65cd51378ba2059fb6acfe5d791ef54f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510317Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie92ef5bf2825c272c5fb30774703e50aabdf7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510234Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#822677}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9615bcf71f2a..b7fc7a467710 2020-10-30 egdaniel@google.com Allow wrapping of protected AHB into vulkan SkSurfaces. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I76e9614f19f477d4d1262489e6e72b241501f731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510429Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603918565-280375955eaa6ff7fe0c1e66a947d33ea408d529.profdata to chrome-win32-master-1604026576-e94043a9563f776b405eb4e60412f883a861885d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54ced00fa9656a8c1c0e749e99a6cb6bd4a0ee9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508567Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: I904276282f6ede9d47c51b5316f528af4c84e017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487082Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#822674}
-
Nazerke authored
This CL creates a mediator for connecting TabStrip to WebStateList and as for now the TabStrip shows the number of tabs open. Bug: 1136834,1128249 Change-Id: I9082b675f88a30002f9113a363b1b1e7c2b62465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461010 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822673}
-
