- 09 Jan, 2020 40 commits
-
-
Robbie McElrath authored
Not setting the process type resulted in an assertion error when loading the library before starting the license activity. Test: Start license activity via adb in trichrome and system webview. Bug: 1039896 Change-Id: I4a5400a8cd6d9644eacb92cca14d59197ad50ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990141Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#729844}
-
Tina Wang authored
Change-Id: If54912bc75c11f7606fceb19b27a5dd09055e545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990488 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729843}
-
Dominic Battre authored
The Presentation API allows to create full screen windows for a secondary display. The corresponding WebContents is not associated with the TabStrip and therefore, TabHelpers::AttachTabHelpers() is not called on the WebContents and the autofill drivers are not registered. As per https://chromium.googlesource.com/chromium/src/+/master/docs/tab_helpers.md, we must not reuse TabHelpers::AttachTabHelpers() but be selective about the helpers we attach to each WebContents. Bug: 1038329 Change-Id: I455a11b997a14ed6e7a7a5dad6a47fdada77cedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986827Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#729842}
-
Patrick Monette authored
Bug: 1035555 Change-Id: Ic4e977a2b0aa3952eef1f54bd1ada62bdd07d4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988741 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#729841}
-
Pavel Yatsuk authored
AutoSigninSnackbarController is specific to password_manager. Moving the file closer to the feature that is using it. BUG=1028382 R=ioanap@chromium.org,dvadym@chromium.org,twellington@chromium.org Change-Id: Ia000c1935367386667fec2dd514b7d978b3dde44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992307Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#729840}
-
Miguel Casas authored
This CL removes the #if defined(OS_LINUX) in platform_video_frame_utils since it's unnecessary given [1], and takes the chance to fold the file static function CreateVideoFrameGpu() into its only caller CreatePlatformVideoFrame(). No functional changes intended. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/chromeos/BUILD.gn;l=11 Bug: 1040291 Change-Id: I7559346f032f2cd9b935f767e9bbcb27cdd796f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993402 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#729839}
-
Kenneth Russell authored
This reverts commit b4099b2c. Reason for revert: new image has been triaged in Skia Gold. Original change's description: > Revert "Remove Pixel_CSSFilterEffects_NoOverlays failure expectation" > > This reverts commit 7076daa4. > > Reason for revert: The test started failing again after this CL was landed. More details on crbug.com/1040202 > > Original change's description: > > Remove Pixel_CSSFilterEffects_NoOverlays failure expectation > > > > Test was producing a minor image diff, has been triaged. > > > > Bug: 1040202 > > Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564 > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Commit-Queue: Brandon Jones <bajones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729597} > > TBR=kbr@chromium.org,bajones@chromium.org > > Change-Id: Id637b25550ce9f423e448d0b332c0dbbf34b9eb9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992367 > Reviewed-by: sebsg <sebsg@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729736} TBR=kbr@chromium.org,bajones@chromium.org,sebsg@chromium.org Change-Id: Ief8494871a1a32571d7526ac313f7cbbc0d78d69 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993113Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729838}
-
Andrei Polushin authored
The histogram created in r729463 is actually sent with the name that differs from that was registered in `histograms.xml`, so the name in `histograms.xml` file is fixed. In addition, according to my experience, there exist many error codes reported by DPAPI functions CryptProtectData() and CryptUnprotectData(). The codes could be added to `enums.xml` to make the aforementioned histogram more useful. The symbolic names were collected from "winerror.h" and "ntstatus.h". TEST=manually review the histogram OSCrypt.Win.KeyDecryptionError BUG=1036277 Change-Id: I4cc688c2d93447f00776e6d9a171ede733620caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992065 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#729837}
-
Xing Xu authored
Bug: 1036490 Change-Id: I5bd567c66f43e5c8c1b4149e6f05125c7ccf9700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988717 Commit-Queue: Xing Xu <xingx@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#729836}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/73bcece48b0c..368d39c30c42 git log 73bcece48b0c..368d39c30c42 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 bclayton@google.com C++14: Use std::make_unique where possible. Created with: gclient setdep -r src/third_party/swiftshader@368d39c30c42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8d5e3b02a240f8d2a9b822ad17c43fef8646e2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729835}
-
Ana Salazar authored
During screen rotation we create a copy of the current screen as a layer and stack it in the LayerTree to ease the animation between the screen before and after the rotation. However, some elements in the shelf are obscured by the copied layer. The new layer is set to be transparent as a workaround so it doesn't occlude these elements. Bug: 1025400, 1040279 Change-Id: I003cc149fca54cc821f65bc2f476c57c61d1788b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992689 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729834}
-
Xiyuan Xia authored
The crash is because MultiProfileSupport::Init code path accesses MultiUserWindowManagerHelper instance via GetInstance getter, which returns nullptr until MultiUserWindowManagerHelper ctor finishes. This CL moves "multi_profile_support_->Init()" into a Init() method to fix the crash. Bug: 1038300 Change-Id: I81260ac227ccf16b5784e492060eb27c2590be03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989702Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729833}
-
Luke Zielinski authored
TBR=robertma Change-Id: I36893e46811729a349797162d8dc1e8bb127cc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993491Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729832}
-
Johannes Henkel authored
New Rev: 32a87e9a751db8f2903532134a7c8fc6932620ba Removes protocol::SerializedValue Upstream Review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1991952 TBR=caseq Change-Id: If5b5b5f895c27dd6e0d966f869729a265f962178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993024 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#729831}
-
Hesen Zhang authored
- Add ContentIndexingDownloadHome fieldtrail Finch config. - Add ContentIndexingNTP fieldtrail Finch config. TBR=dtrainor@chromium.org Bug: 1040170 Change-Id: I571bd1b840b2527080b3e39807cb91bc0e33c021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992241Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729830}
-
John Budorick authored
Bug: 922145 Change-Id: I2cd7494cdea9fc7ff2c920889926f20058305998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992810 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#729829}
-
Elly Fong-Jones authored
Historically official builds were always done exactly at mac_sdk_min, to protect against official bots having new SDKs deployed on them before the SDK roll was ready. However, this forces any upgrade of the official bots to also change mac_sdk_min, which affects all other builds. This change adds a separate mac_sdk_official_version gn variable, which is the exact SDK version to use in official builds. This will allow us to roll the SDK without forcing downstream users to upgrade to the 10.15 SDK immediately. Bug: 1023913 Change-Id: I7a9f3069456edabf51db1b0f91bf85b8a0907410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992195Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729828}
-
Thomas Lukaszewicz authored
Removed the call to GetThemeProviderForProfile() from the webui tabstrip and replaced it with a call to GetThemeProvider() accessed through its embedder object. The intention is to ensure colors are obtained via the ThemeProvider object accessed via the widget hosting the given ui element. This paves the way forward for the rolling out of the color pipeline project. Bug: None Change-Id: If298faae91f509c8448ef6b2bdd81b24fa2074c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990337 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#729827}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/85c4a438f6f1..ae4bbcda1a91 git log 85c4a438f6f1..ae4bbcda1a91 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 brucedawson@chromium.org Avoid infinite loop in updateMajorMarkData Created with: gclient setdep -r src/third_party/catapult@ae4bbcda1a91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039830 Tbr: oysteine@google.com Change-Id: I7d394652544e70f937c26de235ccaca7f974c8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993486Reviewed-by:
-
Michael Crouse authored
This change enables processing of URL-keyed hints that are returned from the remote optimization guide. It also add an in-memory cache for these hints within the hint cache for their use by the optimization guide and its consumers. Future changes will allow the fetch of hints based on the current navigation and enable their use for future consumers. Bug: 1036490 Change-Id: I843043ff26541cad687a65899e9542c32823dde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987226Reviewed-by:
-
Luke Zielinski authored
The biggest change here is the increment of the manifest version, caused by https://github.com/web-platform-tests/wpt/pull/20459, which changes reftest computation logic. This roll also introduces crashtests to the manifest. The rest of the changes are relatively small (new browser support, bug fixes etc). Change-Id: I72dc0901e42ae81c4a5db0e8435574578afe53c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987915 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#729824}
-
Lucas Furukawa Gadani authored
Bug: 1032139 Change-Id: Iac59a5e6c8452da0cf7e7ebc549a10d8970cc8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988684Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729823}
-
Andrew Grieve authored
finalize_apk.py changed in 7d191755 Bug: 1040240 Change-Id: I70b73881098aa7b1b5f0375052d62cb7b0d61624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992249 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729822}
-
Fabrice de Gans-Riberi authored
Bug: 1040247 Change-Id: I22671b5e97b5dba49f467cf734b41b773e2a2872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992982Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729821}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/081c5b597968..b92d20526b83 git log 081c5b597968..b92d20526b83 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 ehmaldonado@chromium.org vpython3: Add Python3 bin dir to PATH on Windows Created with: gclient setdep -r src/third_party/depot_tools@b92d20526b83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003139 Tbr: agable@chromium.org Change-Id: I55c94cc4de00434c66e7f661d3e98090e6dfb542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993437Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c18d96f563fb..caa32a553682 git log c18d96f563fb..caa32a553682 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 hjd@google.com Merge changes Id83e6be8,I120166cc Created with: gclient setdep -r src/third_party/perfetto@caa32a553682 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic52393f5bf26ff376ec3759f5950e51c217ff83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993484Reviewed-by:
-
Piotr Bialecki authored
This change will make Chrome for Android stop using DFM to ship the ARCore SDK. This is done to enable us to provide AR experiences for apps using WebView. The changes are introduced in a way to enable us to switch back to using AR DFM if need be. Changes summary: - chrome_java target (defined in chrome/android/BUILD.gn) now also compiles ArCoreShimImpl.java (see java_sources.gni) - this means that java parts from ARCore SDK have to be added to its deps - libarcore_sdk_c.so needs to be listed in loadable modules - this is done in monochrome_public_common_apk_or_module_tmpl (only if target is a base module when ARCore is enabled) - AndroidManifest.xml no longer needs to contain the min_apk_version and InstallActivity entries explicitly - they will be brought in auto-magically by the build system and were needed only because manifest merging did not work for DFMs - ArCoreInstallUtils (java) should never report that we can request installation of AR DFM - ArCoreConsentPrompt (native) should never think it needs to request installation of AR DFM - Added a DCHECK and graceful handling of null jstring for java_path (path to ARCore SDK .so) - it can be null if loadable_modules do not contain correct entry - with the DCHECK, debug builds will still crash but the release builds should just report that the WebXR specified session configuration (session mode == "immersive-ar") is not supported Binary-Size: Tracked in crbug/1040289 Bug: 1031623, 1040289 Change-Id: Ia2f305d1685f1c7207cc187d253f59a6331c36fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988834 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#729818}
-
Connie Wan authored
Previously this was using TabGroupModel::ListTabGroups(), which pulls from a map: https://cs.chromium.org/chromium/src/chrome/browser/ui/tabs/tab_group_model.cc?l=50&rcl=1158206625559148ac779e86e5d53da50ebf39b4 The consistently ordered experience is better for users, even if it's slightly more expensive. Tested as part of crrev.com/c/1990423, which adds color bubbles that make it more obvious when groups are out of order with the tab strip. Change-Id: Ie6081130f310b1e2501b1fbd50c7848cc5d815ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992344Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#729817}
-
Sasha McIntosh authored
Enable WebP YUV decoding by default and remove the field trial testing config. Bug: 900264 Bug: 966008 Change-Id: Idfaf993fda19bf22e71986ba8410ffd84e254ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986029Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
This method with a stale todo will probably never be implemented. Remove it to not confuse new people :) Bug: none Change-Id: I8f91a021158d7c275e8230a65746e692d780a1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993461 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729815}
-
Wez authored
Debugging issues in the GPU process with zxdb is easier without the watchdog running. Change-Id: I9ff0e7fa8f00360ddf2b88475c17051207e6e5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992539 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729814}
-
Nate Fischer authored
This swaps out the app package name for the application "label" (the user-friendly name for the app) and the version number (to disambiguate between similarly-named apps). This is for consistency with the system's webview chooser dialog (which the user is likely to go into next by clicking the dialog button). Fixed: 1040336 Test: manual - click icon when this is not the current provider Change-Id: Iacb73cd2f0ca41844f2ff668230b3b95bb4ed472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991745Reviewed-by:
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I92c343d9ca09cc429fb4b6fa1723534c43beb317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992691Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729812}
-
Andy Paicu authored
There is no notification channel when the notifiction permission for the origin is merely embargoed, so it is not possible to intent to notification channel settings. This CL updates the SingleWebsitePreferences page on Android, so that when the automatically blocked setting is changed for the first time, a synthetic CONTENT_SETTING_BLOCKED is directly written just-in-time. This will trigger lifting embargo, and create an initially disabled notification channel, and finally we intent into channel settings. Bug: 996201 Change-Id: Ice838b1ca971c9d8117f1c56ecc107bf41417550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970473Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729811}
-
Joshua Peraza authored
This is a reland of 9747ecdd Original change's description: > linux: Enable Crashpad for content shell > > Bug: 942279 > Change-Id: I221431e352f11b40c3bc39bbcd8297b431dd8f0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763346 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699880} Bug: 942279 Change-Id: I7ced7adacbbe585f5ea47d00163b69953912b99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847882Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#729810}
-
Ahmed Fakhry authored
This is only supported on ChromeOS, so make it conditional and follow the example of Browser::ShouldShowStaleContentOnEviction(): https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?dr=CSs&q=Browser::ShouldShowStaleContentOnEviction&g=0&l=1453 BUG=1036760 Change-Id: Idcf003483600046a4e64ebe0b681bbdb30b8449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992515Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#729809}
-
Mike Wasserman authored
Bug: None Test: Manual Change-Id: I08f2dd1b7925ba2ab5136470a029e6ac462d0698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992623 Auto-Submit: Michael Wasserman <msw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#729808}
-
Mike West authored
Based on the discussion in [1], we should change the spec to support nameless cookies parsed from headers like `Set-Cookie: foo`. This patch updates the WPT expectations accordingly. [1]: https://github.com/httpwg/http-extensions/issues/159 Bug: 1037996 Change-Id: Iefabea524377857d524c74457153347a107401ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982551Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#729807}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c40e03a4215..bf8bd8052673 git log 1c40e03a4215..bf8bd8052673 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e70b009b0f1e..fb2e819819ef (14 commits) Created with: gclient setdep -r src/third_party/angle@bf8bd8052673 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I69cbbb812473412403ef2d9bdc13db4e2f658023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992256Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eca1091a52a8..a88cab1ad9f2 git log eca1091a52a8..a88cab1ad9f2 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 brianosman@google.com Add CachingHint to makeRasterImage, default to kDisallow 2020-01-09 mtklein@google.com add back src-in-gamut tracking Created with: gclient setdep -r src/third_party/skia@a88cab1ad9f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I61d9f24777b0756af928937898931f25f0d3903e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993425Reviewed-by:
-
