- 12 Nov, 2020 40 commits
-
-
Wenyu Fu authored
Support skipping ToS on Lightweight FRE. Add loading view into ToS dialog in Lightweight FRE. Bug: 1108549 Change-Id: Idf28657e896e7586c8d0070f1d95ace70961a3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510549Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826815}
-
Garrett Beaty authored
The builder is frequently timing out due to variance in build times, this should give it sufficient headroom. Change-Id: Ifea4b7df61b2961d6f097f44397855b8c23900e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533195 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#826814}
-
sandromaggi authored
Replaced by WaitUntilDocumentReadyState (which is WaitForDocumentReady State with ignoring the result data). This also changes the settings from being round based to using a single timeout. Bug: b/172542134 Change-Id: I339f698cc37f9c028bb25a8a04c4248404b21b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529101 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#826813}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011120600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/zEk7od1CGIAvNadYXhYDI7qpfAAM33azYj-p5y578RUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159267911,b/168069888,b/169821019 Tbr: media-app@grotations.appspotmail.com Change-Id: I756020e1accdaec6fc5392b9cb2f7b0fa039752b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534799Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826812}
-
Shimi Zhang authored
We should check |event.data.scroll_begin.cursor_control| flag after we are sure this event is a GestureScrollBegin event. Bug: 1126778 Change-Id: I99aa795d09600618fb92b5bfaad200dda3d23e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533237 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826811}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I6418c277524475d7f3f2bae2a09d988e309e40c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533406 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826810}
-
Omar Morsi authored
A KeyPermissionsService instance needs a KeyPermissionsManager instance responsible for the private token for the user profile to be able to do user token operations using this instance. But there is no private token corresponding to non-regular user profiles (e.g. sign in profile, lockscreen profile), which means that there will be no corresponding KeyPermissionsManager instance provided for the non-regular user profiles from the UserPrivateTokenKpm factory. This CL allows KeyPermissionsService to be used without a KeyPermissionsManager instance in case of non-regular user profiles. Bug: 1148290 Change-Id: I8dfd29732adcee4ebfc3f208b9dbf73713b274b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534852 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#826809}
-
Jesse McKenna authored
This change makes the following small cleanup changes: * remove unused variable |quit_closure_| * use default initialization rather than member-list initialization for int member variable * remove constructor no longer needed after the above change * replace empty destructor body with "= default" Change-Id: Idb14db66dbc2131fe8bc3fffbdedce265e8b513a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532537Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#826808}
-
Eugene But authored
Update method and argument names to follow Coding Style for Cocoa: - make word before the argument describe the argument - use all caps for acronym in the argument name Bug: None Change-Id: Ice41e237985eb1ad0251c4ec96ebd970f9639c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524040Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#826807}
-
Jesse McKenna authored
This change migrates uses of base::Bind to BindOnce/BindRepeating, and uses of base::Callback to OnceCallback/RepeatingCallback. Please see crbug.com/714018 for full details about the migration. Bug: 1147284 Change-Id: Ia12d78b875b9853f8b23ac23b8ff0f36df9867bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530252Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#826806}
-
Friedrich Horschig authored
These flags are covering inherited UI projects that improve the autofill experience. By next year, we can probably make a call to deprecate at least one of them. Until then, they are inactive but still in consideration. Bug: None Change-Id: I551b2b14b41b25ebf7946ecfb1530633e50d5274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534854Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#826805}
-
Bartek Nowierski authored
He might know this and that about PartitionAlloc. $ git log base/allocator/partition_allocator/ | grep Author | grep bartekn | wc -l 43 $ git log base/allocator/partition_allocator/ | grep Reviewed-by | grep bartekn | wc -l 58 Change-Id: I8f6ccec8d82e1950db26b4d7ad7c8f554d63fd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534356Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826804}
-
Clemens Arbesser authored
This will allow trigger scripts to automatically hide while the keyboard is being displayed. Example video of the interaction is in the linked bug. Bug: b/173038438 Change-Id: I874f40c359710d7dd63886f703c5448df2636a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532464 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#826803}
-
Takashi Toyoshima authored
As we still have a plan to change CORS related minor behaviors, we keep Net.Cors.* metrics until the next change is safely launched. Bug: 1104952 Change-Id: I6aa219981846f5a6a78c298d8ac121318ffb453f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532144 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826802}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26cd974abfad..f0517095b853 2020-11-12 tandrii@google.com git cl: remove check for likely wrong identities. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1148065 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I73f89360862ca58bdd91d10c21ad78640fe49bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826801}
-
Takashi Toyoshima authored
This should be the last OOR-CORS related minor clean up in the ThreadableLoader. - Remove redundant kDisallowedByMode checks from the ThreadableLoader as this is checked at the CORS checks in the network service. - Remove unused methods, ReportResponseReceived, GetSecurityOrigin, and GetFrame. - Add Resource* and client_ dchecks to methods that haven't had such checks to be consistent. - Remove ThreadableLoaderTest.*DidFailInStart as Start never fails after this change. Change-Id: Ie91586c56c6d3cf37ec28a9c3f0ea199b95056a2 Bug: 1053866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525384 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#826800}
-
John Delaney authored
What: Adds some early exit/flow control logic in the backing filter function which prevents doing registerable domain lookups when they are not necessary. Why: Currently these lookups are performed for every origin, even if there are no registerable domains to compare against, and if it is already matching an origin rule. These lookups are somewhat expensive and require several string operations. Change-Id: I79e2af8baf9c884b7de7811080e970bcc364d274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521101 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#826799}
-
David Dorwin authored
Although PolicyBlocklistNavigationThrottle uses Safe Sites, blocklists and Safe Sites are conceptually different. Also, Safe Sites does not require Prefs, which makes it easier to use outside //chrome. Also extract SafeSearchService from PolicyBlocklistService. Bug: 1147231 Change-Id: I4e2714478177bebcf26a07ed0e6230aa67e0792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530145 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826798}
-
Eugene But authored
Add BreakpadServerParameterPrefix_ prefix to the key Bug: 1103752 Change-Id: Ieb4b33d600a57571fb0bbf87326d8c60cc18b800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533841 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826797}
-
Mark Mentovai authored
In order to avoid a delay (15 seconds is typical) the first time the Widevine CDM is loaded, ask Rosetta to translate the Widevine CDM and other required modules when Widevine is first registered. This happens at browser launch, and probably also when Widevine is component-updated. Bug: 1142017, 1145672, 1145792 Change-Id: If5e52f7e08e987dc5da57dd0b1476d25a467b152 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533506 Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826796}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Id3b5163a21a8896bb80de37999a5d8a33f4c164b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533408 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
rajendrant authored
Robots rules should consider the path and query parameters of the URL to decide whether the URL is allowed. Bug: 1144836 Change-Id: I15caeedfdc498cb361491ba66fe12956065daf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533418 Auto-Submit: rajendrant <rajendrant@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#826794}
-
Bartek Nowierski authored
As of crrev.com/c/2522934, |commit| is equivalent to |accessibility!=PageInaccessible|. Change-Id: Ia6b665017f4c06240922d1aa1a5764caf4b40c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522933 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
Bug: None Change-Id: I07f79c46658bb206a084a21a09e7b2c1b9308a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532724Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#826792}
-
Sami Kyostila authored
Replace the explicit memcpy loops for converting between Skia and Java bitmaps with SkBitmap::{read,write}Pixels. We also adjust some fields of JavaBitmap to make their data types more obvious. Bug: 1144462 Change-Id: Ibc07ec546b38cb5650dc9a1e272e834b3579216a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532250 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#826791}
-
Nico Weber authored
This is a reland of ca288e0c chrome/browser/component_updater/widevine_cdm_component_installer.cc is only built if ENABLE_WIDEVINE_CDM_COMPONENT is set, so we should reference functions therein in that case. Fixes the unbranded arm build. The reland is exactly the same as the original change for branded builds. Original change's description: > Offer to install Rosetta for Widevine if it's not already installed > > If a page wants a CDM and it's unavailable, show an infobar. If > the user agrees, install Rosetta for them. > > Bug: 1145792, 1142017 > Change-Id: I92f030c2dbb5d9b092b84252fddee6f7ad55a436 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527771 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826636} TBR=xhwang Bug: 1145792 Bug: 1142017 Cq-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I73404d403df152ef8d5738368e094c24ae250128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534392Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826790}
-
Nazerke authored
This CL adds webStateObservers into the TabStripMediator to update tabs titles in the TabStripViewController. Bug: 1136834,1128249 Change-Id: I7fa4c9a73a35a719dcbbf7d26278a497e9d16cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521186 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#826789}
-
Alexander Dunaev authored
Bug: 1109112 Change-Id: Iceda57cc2e066dbc1c7c6cb9a0957854a1173547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530995 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
-
Chris Sharp authored
Updated the following policies: BackForwardCacheEnabled BrowserNetworkTimeQueriesEnabled CloudPrintWarningsSuppressed CommandLineFlagSecurityWarningsEnabled ContextualSearchEnabled Bug: 1139306 Change-Id: I1448966a521c38d64b27d7cca05cc52f7e8964b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522170 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826787}
-
Mark Mentovai authored
Bug: 1142017 Change-Id: If168a204fe418043292952aa1d3edbf257f53c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533587 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826786}
-
Chris Sharp authored
Updated the following policies: AbusiveExperienceInterventionEnforce AccessibilityImageLabelsEnabled AllowFileSelectionDialogs AllowScreenWakeLocks AllowWakeLocks Bug: 1139306 Change-Id: If656ba0095e11a54cb94997d8d1f751792a10e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521491 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
If GigaCage is disabled, PartitionAllocGetSlotOffset() triggers a DCHECK which checks if the pointer is in the GigaCage's normal bucket pool. Change-Id: I9ea2683944ee308b9055a2c182e7bb5387c5fc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534992 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a2ac3a70. With Chromium commits locally applied on WPT: 50d5488e "Revert "webauthn: move create credential tests for residentKey/credProps to WPT"" c0e73fce "[webcodecs] Make sure callbacks aren't called after encoder.reset()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3600388ccad0872bd368e55697cbf9deb3343fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534710Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826783}
-
Antonio Sartori authored
The content::PolicyContainerHost is a class containing some policy data and implementing a mojo interface to change that data. As we add more policies to the PolicyContainerHost, it becomes cleaner to separate the raw data (the policies) into a separate struct (DocumentPolicies), which the PolicyContainerHost owns. This will also make it easier to store the DocumentPolicies in places where we don't need the mojo logic (for example, in the FrameNavigationEntry). Bug: 1130587 Change-Id: Ic46a3189f9f6939fbdb279916a9c1288942ce271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529165 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826782}
-
Liquan (Max) Gu authored
PRService#updateWith() lets mSpec parse and save the updated details. Now that the details have been saved to mSpec, we should use mSpec's details instead using the original details. This would make the code more logical and less error-prone as we use mSpec's details as the single source of truth. Bug: 1131059 Change-Id: Ib36e9a67880097ea6be14a2148b57b59b6c6bdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533144 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826781}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53d3c085a784..4fb2d48fe563 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic866784dec4ae1fde6827032841608ee58d170a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534692Reviewed-by:
-
Benoit Lize authored
TLS access on Windows sets the last error, even in case of success. This is causing issues with calling code which expects malloc() to not change the last error. Work around it by saving the last error. Issue found by tasak@. Bug: 998048 Change-Id: I64fa7dc44abfae39d3d91d9d8e6dbb9e2721d136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529150 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85179e8d9484..8e6646c31e9d 2020-11-12 jec@google.com [devtools] Fix typo in release notes 2020-11-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5e2b755fcb2321e9a8354b66f9508188674d3fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534795Reviewed-by:
-
Christoph Schwering authored
Autofill uses lots of hard-coded regexps for parsing. PatternProvider provides a cleaner API with page-language-dependent patterns. This CL migrates the existing parsing code to the new pattern provider in an equivalence-preserving way. The behaviour is only enabled if either of the following features is enabled: * kAutofillUsePageLanguageToSelectFieldParsingPatterns * kAutofillApplyNegativePatternsForFieldTypeDetectionHeuristics The code is not entirely ready for use because of an infrastructure issue: all relevant tests must mock a PatternProvider that synchronously loads the JSON. Otherwise they're prone to race conditions. In a follow-up CL we'll solve this issue. Change-Id: I235d2b599585522e1a1bea1cd25185ae209f5965 Bug: 1147624, 1147608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465847Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#826777}
-
Maksim Moskvitin authored
Bug: 1138388 Change-Id: I49409684460a7890b8f82547d1b887c76e676ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532077 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
