- 02 Oct, 2018 40 commits
-
-
Scott Chen authored
This CL preemptively fixes closure annotations for all NUX-related JS files, there will be a follow-up CL to actually enable closure compiling on these files. Bug: 874151 Change-Id: I67d56d7b0cffc2c8fa8134c03bf748eaaf79c376 Reviewed-on: https://chromium-review.googlesource.com/1256362 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595707}
-
Xing Liu authored
This CL hooks the video thumbnail backend to the UI layer of new download home. Bug: 826021 Change-Id: I190ad09e8231d94d7546128bd1d22dc39f4d5f35 Reviewed-on: https://chromium-review.googlesource.com/1247529 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#595706}
-
Fergal Daly authored
Bug: 864900 Change-Id: I9228f1d475e19786ce675da93210c08b54bc3988 Reviewed-on: https://chromium-review.googlesource.com/1250523 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#595705}
-
rbpotter authored
Add a new mixin for the new input container, which is needed by the PDF viewer. Also move background-color styling to the existing --cr-input-background-color so it is applied to both the container and the input. Bug: 888985 Change-Id: I60e1dfe6828ba2d198984ed9ca33d0753aaa1308 Reviewed-on: https://chromium-review.googlesource.com/1244831Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595704}
-
Luciano Pacheco authored
This fixes the perception to users that the dialog is taking too long to disappear. Test: No change in behavior, so current test suite should cover it. Additionally, manually tested file manager file deletion confirmation. Bug: 883659 Change-Id: I414a7282f70a64c0826954ef850a16e0bc37182e Reviewed-on: https://chromium-review.googlesource.com/1242725Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#595703}
-
Scott Wu authored
This check is needed since iOS Chrome is returning nullptr in GetPasswordAutofillManager() https://cs.chromium.org/chromium/src/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm Bug: 890655 Change-Id: I33951b54d0e618f861284df7aeabcbf3d9e1681b Reviewed-on: https://chromium-review.googlesource.com/1253164 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595702}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I48c405c71f7fbe5ca57912f970ab5b271750dc6c Reviewed-on: https://chromium-review.googlesource.com/1253212Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595701}
-
Steve Anton authored
Bug: 864871 Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286 Reviewed-on: https://chromium-review.googlesource.com/1208961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#595700}
-
Nico Weber authored
Bug: 832676 Change-Id: I1ca68200cd3555fe6ff77ca63eb5d5a61dccfdc3 Reviewed-on: https://chromium-review.googlesource.com/1255862 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#595699}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9cb89c11. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25735 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I80101b075d8390707bdd52c9e67d594fff9771a8 Reviewed-on: https://chromium-review.googlesource.com/1255454 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595698}
-
Theresa authored
TBR=huayinz@chromium.org BUG=891089 Change-Id: I4d4c6fbdb2d845b0639f0eab05f4b043a2a9a15e Reviewed-on: https://chromium-review.googlesource.com/1256108 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595697}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce342184e625..e8b02fb54234 git log ce342184e625..e8b02fb54234 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 rharrison@chromium.org Add XFA BMP pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF Deflate pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF PackBits pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF LZW pixel test 2018-10-01 rharrison@chromium.org Add XFA PNG pixel test 2018-10-01 rharrison@chromium.org Add XFA TIFF pixel test 2018-10-01 thestig@chromium.org Remove checks for impossible situation in CPDFXFA_Context. Created with: gclient setdep -r src/third_party/pdfium@e8b02fb54234 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id6d2f742b7ae49d81c56acce5ca096da1d4bc3c2 Reviewed-on: https://chromium-review.googlesource.com/1255569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595696}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f45e6651864..957c62e0d63e git log 5f45e6651864..957c62e0d63e --date=short --no-merges --format='%ad %ae %s' 2018-10-01 kron@webrtc.org Use timestamp instead of seq_num to distinguish between packets. 2018-10-01 nisse@webrtc.org Move call of stat's OnPreDecode to VideoReceiveStream::Decode 2018-10-01 ssilkin@webrtc.org Set key frame request in VP9 enc wrapper on init. 2018-10-01 oprypin@webrtc.org Revert "Tidy up and increase exception handling in compare_videos" Created with: gclient setdep -r src/third_party/webrtc@957c62e0d63e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id09937ffef84650fa06ce34eed3107d0b5bce174 Reviewed-on: https://chromium-review.googlesource.com/1255510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595695}
-
Scott Chen authored
This adds the back-end functionality of setting default for the NUX set-default module, by subclassing a very similar handler from Settings. There will be follow-up CLs to match front-end with mock. Bug: 874122 Change-Id: I2e54ed7846e036cf48f4d6b22f2a7b867d65baa6 Reviewed-on: https://chromium-review.googlesource.com/1222914 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595694}
-
Koji Ishii authored
This patch fixes AddOutlineRects to include continuation when the first line is empty. In such case, NGInlineLayoutAlgorithm suppresses box fragments, and thus we cannot reach to the continuation by traversing fragment tree. This patch detects such case and traverse the first LayoutInline instead. Bug: 889721 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0e3bbd895501231b76775b074b35310037a3e113 Reviewed-on: https://chromium-review.googlesource.com/1252484Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595693}
-
Tiansong Cui authored
Continuous Bluetooth scan may cause scan results to accumulate. This can result in large memory usage if there are other devices advertising with randomized MAC addresses. We limit the scan result cache to 1024 entries to prevent this situation. We kick out the least recently used entry when limit is reached. Bug: internal 116650055 Test: cast_bluetooth_unittests, manual. Change-Id: Ife0161a6edbc4354133dc158d0901ddce6ef876a Reviewed-on: https://chromium-review.googlesource.com/1255630 Commit-Queue: Tiansong Cui <tiansong@google.com> Reviewed-by:
Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#595692}
-
Carlos IL authored
Starting implementation of go/auto-upgrade-mixed, adds the variations flag and auto upgrades all mixed content (with no fallback) if it is set. Further CLs will filter by mixed content type (blockable vs optionally blockable) depending on variations parameters, and will add fallback. Change-Id: Ic14124fe21ba08dc34738fdedebe2a37fb73ac3d Reviewed-on: https://chromium-review.googlesource.com/1249094 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#595691}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a44a65dc4a9..399029db4a18 Created with: gclient setdep -r src-internal@399029db4a18 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5e1c76695c9b8d79767e2669e9afe5f70d04a263 Reviewed-on: https://chromium-review.googlesource.com/1255513Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595690}
-
Kevin Marshall authored
The issue which prompted reverts on "mac_upload_clang" and "linux_upload_clang" had to do with incorrect platform-specific paths to the GN tool. Summary of reverts: Reland "Revert "Roll Fuchsia SDK from 98ba6c8440c2 to b9dd8279f122"" This reverts commit 6be9416c. Reland "Revert "[Fuchsia] Remove namespace_path parameter from FIDL targets"" This reverts commit c354aa9a. Reland "Revert "[fuchsia] Reland "Generate BUILD.gn from SDK metadata...""" This reverts commit 712b3456. TBR=sky@chromium.org Bug: 889839 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I46650fb6c7887393c409bd13d9f0851a5630c88e Reviewed-on: https://chromium-review.googlesource.com/1252013 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595689}
-
Parastoo Geranmayeh authored
Using the Autofill Profile Validation API, we can validate some data on the CLIENT side, and set the validity states in the Autofill Profile. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I144117287972587ae2c99afded0b792d3ed58874 Reviewed-on: https://chromium-review.googlesource.com/1239175Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#595688}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7a52b9de36c..083bc1576a0e git log a7a52b9de36c..083bc1576a0e --date=short --no-merges --format='%ad %ae %s' 2018-10-01 michaelludwig@google.com Update parameter generation for randomized gradient tests 2018-10-01 thakis@chromium.org Remove a few exit-time destructors. Created with: gclient setdep -r src/third_party/skia@083bc1576a0e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:101600 TBR=mtklein@chromium.org Change-Id: If414a9f2810aa659d750b2b6548ef28433ffcb82 Reviewed-on: https://chromium-review.googlesource.com/1256223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595687}
-
mark a. foltz authored
r594911 added unguessable_token.mojom as a dependendy of origin.mojom. This imports the JS bindings for unguessable_token.mojom into the Media Router component extension bindings to prevent a JS exception when validating a message that includes an Origin. Bug: 890916 Change-Id: I83426296abbf911587367ffbd0b002a6c1525522 Reviewed-on: https://chromium-review.googlesource.com/1255585 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#595686}
-
Yoichi Osato authored
Design doc: http://bit.ly/2Njo0zR This patch introduces |SelectionInDOMTree ComputeLayoutSelection (const SelectionInDOMTree&)| for replacing CreateVisiblePosition at ComputeLayerSelection. The new adjustment algorithm is based on LayoutSelection and really simple: pick SelectionState::kStart/kEnd nodes. They are the start/end nodes of selection painting. For caret, caret positioning should be done before LayoutSelection, thus ComputeLayoutSelection() returns as-is. Though ComputeLayoutSelection is targeting to replace CreateVisibleSelection, there is difference because of simplicity: it doesn't consider contenteditable, block-end BRs nor any InlinBox matter. The difference is also tested at layout_selection_test.cc Bug: 789870 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9de9fef6e76ff65c1b2575c47d39e156d8e56380 Reviewed-on: https://chromium-review.googlesource.com/1182710Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#595685}
-
gogerald authored
Bug: 806868 Change-Id: Iffbbac28a2712e59e2c5a59c733c18b46b90f9ef Reviewed-on: https://chromium-review.googlesource.com/1256015Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#595684}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: I439602d0a330f87efc14e384c56df343b60d2a50 Reviewed-on: https://chromium-review.googlesource.com/1256210Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#595683}
-
Daniel Rubery authored
This was used to evade referrer chain attribution. However, the problem was already fixed at HEAD by the time we discovered what was wrong, so this CL just adds a browser test to ensure that we don't regress. Change-Id: I69b3189a873288509fb8bdad02c248598819e07c Reviewed-on: https://chromium-review.googlesource.com/1256105 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#595682}
-
Ahmed Fakhry authored
This CL changes the default app order according to PRD at go/default-apps. It also introduces a mechanism to add default page breaks that are part of the default sort order so that we're able to make default apps span multiple pages if desired. Default page breaks should only be installed for first-time users, or users who already have them in their remote sync data. BUG=880506 TEST=Manually by installing an image on device, also added a test. Change-Id: I4882e3a6b76b81862686b2eba0d1bd76d0ec4b35 Reviewed-on: https://chromium-review.googlesource.com/1212704 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595681}
-
Andres Calderon Jaramillo authored
This CL moves RecordJpegImageArea() from JpegImageDecoder to BitmapImageMetrics to centralize the recording of UMAs for JPEGs and to be consistent with the color space UMA. The method is renamed to CountJpegArea() to be consistent with other methods in BitmapImageMetrics. Bug: 886914 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idd0dc443a7e742065a158ee19adeb242479a245f Reviewed-on: https://chromium-review.googlesource.com/1249399 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595680}
-
Istiaque Ahmed authored
runtime.onInstalled depends on Dispatch*WithLazyListener. For Service Workers, this wouldn't dispatch the event as the event listener doens't exist. For event pages, this works as we manually add a listener before calling Dispatch. This CL does the same for service worker based extensions. Bug: 888798 Change-Id: I75dddc32613862464ba2bb73fd972ec1b0d2b03a Reviewed-on: https://chromium-review.googlesource.com/1247190Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595679}
-
Jordy Greenblatt authored
Screenshots from both tablet and standard modes on PixelBook: https://drive.google.com/drive/folders/18lSB22-hWttyVZxNI7ASAE6m1Qvub8vI?usp=sharing Bug: 890088 Change-Id: I9367c87dc85a61b076d0db4ed1997980a308da86 Reviewed-on: https://chromium-review.googlesource.com/1256162Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#595678}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d7c52f8..4b7de4a5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84169c88a268ff4499a2824423975f5d241430fb Reviewed-on: https://chromium-review.googlesource.com/1256056Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595677}
-
Dan Sanders authored
VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED must be retained until all reads have been completed. Such frames are produced when software frames are uploaded to GpuMemoryBuffers. The VideoResourceUpdater handles this, but PaintCanvasVideoRenderer implemented only sync tokens. As a result, WebGL reads of software-decoded frames can tear when the storage is reused for later frames. This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to the VideoFrame until it completes. This ensures that the memory is not reused until after the reads complete in the GPU process. TBR=pfeldman@chromium.org Bug: 819914 Change-Id: Id181a476b78e2799bdbff149c9655427ae552743 Reviewed-on: https://chromium-review.googlesource.com/1252962 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595676}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/624fbdcf55b0..d082819ca2ad git log 624fbdcf55b0..d082819ca2ad --date=short --no-merges --format='%ad %ae %s' 2018-10-01 ynovikov@chromium.org Fix format support conditions 2018-10-01 jie.a.chen@intel.com Vulkan: Vertex buffer should be format aligned. 2018-10-01 geofflang@chromium.org Vulkan: Expose the unimplemented GL_EXT_occlusion_query_boolean extension. 2018-10-01 jgilbert@mozilla.com Stream support for R16*_UNORM and P010/P016. 2018-10-01 fjhenigman@chromium.org Remove PixelPackState from PackPixelsParams. 2018-10-01 oetuaho@nvidia.com Improve test coverage of constant folding Created with: gclient setdep -r src/third_party/angle@d082819ca2ad The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I33954d0598a45faa205139c5019379fcdce4b8a4 Reviewed-on: https://chromium-review.googlesource.com/1256222Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595675}
-
Ken Rockot authored
== First some background: The NavigableContentsView client library by default uses views::RemoteViewHost to support embedding of a remote view within a client's own UI on platforms that support both Views and the Window Service. This is fine unless the client is running in the same process as the Window Service, which is in the case for out-of-process Ash. That is, when running Ash outside of the browser process on Chrome OS, we have it share a process with the Window Service. The Window Service implementation defines a ws::ServerRemoteViewHost which serves essentially the same purpose as views::RemoteViewHost but which actually works within the Window Service process. We obviously cannot tolerate the Content Service client library having a dependency on the Window Service (let alone its private implementation!). == What this CL does: Introduces a static NavigableContentsView::SetRemoteViewFactory API which can be called by a client to provide process-wide alternative View creation logic for remote views. If unset, the client library will continue to use views::RemoteViewHost for remote views. Ash uses this static method when setting up its in-process Window Service instance, providing a factory which emits ws::ServerRemoteViewHost objects. No Content Service implementation changes are required to support this, as it's really just a detail of how clients interface with the Window Service to support remote views. Bug: 854367 Change-Id: Ic6b09502ea2f84c3a4594e69e2a531a4efc1e3da Reviewed-on: https://chromium-review.googlesource.com/1237376 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595674}
-
rbpotter authored
(1) Fix an issue where icons were shrinking with browser window size (2) Related: To make the fact that the destination-list-item uses display:flex more clear, move all styling for this item into its own HTML file, rather than splitting with its parent list. (3) Remove margin which was not needed since the item uses padding. (4) Ensure max-height never gets set below min-height, and set a min-height for the list container. Bug: 890700 Change-Id: I4f91e43024faea494dbc5a48f6590ca3b863136e Reviewed-on: https://chromium-review.googlesource.com/1256004Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595673}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69f64b270397..2ba11d1c2b02 git log 69f64b270397..2ba11d1c2b02 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 eakuefner@chromium.org [Dashboard] Key histogram uploads by revision timestamp if necessary 2018-10-01 benjhayden@chromium.org Add option-group for v2spa 2018-10-01 sadrul@chromium.org trace-viewer: Add a close-button to hide a process. 2018-10-01 benjhayden@chromium.org Add column-head for v2spa 2018-10-01 simonhatch@chromium.org Dashboard - Add a diagnostic for the build url. 2018-10-01 benjhayden@chromium.org Add cp-toast for v2spa. 2018-10-01 mlippautz@chromium.org tracing: Fix Blink metrics and add unified GC total sum Created with: gclient setdep -r src/third_party/catapult@2ba11d1c2b02 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884961,chromium:889396 TBR=sullivan@chromium.org Change-Id: Ica59de5ef959096a97c5d76b961b0bd56d06df0a Reviewed-on: https://chromium-review.googlesource.com/1255570Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595672}
-
David Trainor authored
- We currently prune out cancelled and non-resumable failed/interrupted downloads from downloads home. In the V2 version this didn't happen, so this adds the filter to address this. - In the process of adding the filter, I realized that the filter's onItemUpdated() logic does not handle items updating to/from a filtered out state. So this also adds that support as well as tests for it. BUG=889213 Change-Id: I5ae6b836abf77f914bd3f106a2d21b015e03aad2 Reviewed-on: https://chromium-review.googlesource.com/1244123 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595671}
-
Weilun Shi authored
When changing the font size on the settings, changing on the remove button is different than changing on the right span container for the other two buttons, that's why we see the inconsistent behavior. Therefore, adding additional left span for the remove button. Screencast: https://screencast.googleplex.com/cast/NDkxMzQ4OTQ4NzMzMTMyOHw5N2Y4MzQzMS0yYQ Bug: 883192 Change-Id: I398402cfdec9d8a93e95802fb4d99f6ded552cd0 Reviewed-on: https://chromium-review.googlesource.com/1255612 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595670}
-
Eric Aleshire authored
This enables selecting a value from a drop-down. As part of this: * I move "execute javascript against element" to a common function in Automation actions, since we use it in this action also. * I add a unit test for this action, and modify the web page we serve for unit testing to contain a dropdown. Bug: 881096 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0dfdef2f94c2c5e2e5523e50ba3f89de2d420870 Reviewed-on: https://chromium-review.googlesource.com/1240913 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595669}
-
Sammie Quon authored
Test: manual Bug: 890493 Change-Id: I6dc5b284e27ae3861cbcfda0736a37c318f596a3 Reviewed-on: https://chromium-review.googlesource.com/1255609Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#595668}
-