Commits · ecab7921131a4c2c37ae27dad912126f5bdb196f · eriksson monteiro / tangled

23 Jul, 2018 40 commits

Switch shader_translator from khronos GL to ui/gl · ecab7921

Daniel Bratell authored Jul 23, 2018

In jumbo experiments build targets using both ui/gl+mesa and khronos
at the same time fail to compile because the two GL libraries
declare the same constants and functions.

This happened in gpu/command_buffer/service because ShaderTranslator
used khronos GL when it should have been using ui/gl. This patch switches
that code over to ui/gl.

Bug: 864986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I522243374eaf0416df58d84e20585c11aef3de32
Reviewed-on: https://chromium-review.googlesource.com/1145306Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#577236}

ecab7921

[Extensions Click-to-Script] Adjust icon grayscaling behavior · 516528f8

Devlin Cronin authored Jul 23, 2018

Currently, extension icons in the toolbar are grayscaled when the
extension action (i.e., the page action or the browser action) is
disabled. However, this can be confusing, because it makes the extension
look disabled when it might be running on that page.

With runtime host permissions enabled, the extension icon should only be
grayscaled in the toolbar only if the action is currently disabled *and*
the extension cannot currently inject on the page. This addresses the
confusing "disabled" look, as well as preventing the strange case of
"clicking on the extension icon and it immediately becoming disabled."

Bug: 866170

Change-Id: I00c239c6b4a35f52398e433d0a6ed357298e08c6
Reviewed-on: https://chromium-review.googlesource.com/1145630
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577235}

516528f8

Revert "Reland "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread"" · 771b50f5

Gabriel Charette authored Jul 23, 2018

This reverts commit 5c7b464c.

Reason for revert: oops, didn't mean to auto-CQ PS1.

Original change's description:
> Reland "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread"
> 
> This reverts commit c512937e.
> 
> Reason for revert: change is correct, fixed test flakiness
> 
> Original change's description:
> > Revert "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread"
> > 
> > This reverts commit 81626592.
> > 
> > Reason for revert: MetricsOnlyFromUILoops test appears to be flaky (see https://crbug.com/866299).
> > 
> > Original change's description:
> > > [MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread
> > >
> > > Addresses crbug.com/860801 in time for the M69 branch while keeping the
> > > diagnosis signals which will be used to assess future improvements
> > > (MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is).
> > >
> > > Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've
> > > learnt everything we needed from this one, that is :
> > > We now know that while 99% of tasks are posted with a delay under 30s,
> > > 95% of users post at least one task in every portion of the 0ms-3hours
> > > range at least once per day:
> > > https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > >
> > > Removed MessageLoop.ScheduledSleep.* metrics as we've also
> > > learnt what we wanted from it, that is :
> > > The maximum sleep a MessageLoop ever completes is 1 hour (and
> > > even then 99% of completed sleeps are under 1 second), all
> > > longer delays are reliably always interrupted.
> > > Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > > Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > > Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > >
> > > Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle
> > > but it appears to be broken on MacOSX (prior to this CL). Added a note
> > > to investigate on the metric but it shouldn't block this CL which
> > > doesn't make it worse.
> > >
> > > R=kylechar@chromium.org, rkaplow@chromium.org
> > >
> > > Bug: 860801, 850450, 786597
> > > Change-Id: I7a693886ab4e1b9c8e9fbe8a64d906a95019a609
> > > Reviewed-on: https://chromium-review.googlesource.com/1142589
> > > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > > Reviewed-by: kylechar <kylechar@chromium.org>
> > > Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#576686}
> > 
> > TBR=gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org
> > 
> > Bug: 860801, 850450, 786597, 866299
> > Change-Id: I848621acf9ddbec69d72649d16a459910ffa937e
> > Reviewed-on: https://chromium-review.googlesource.com/1146300
> > Commit-Queue: Wez <wez@chromium.org>
> > Reviewed-by: Wez <wez@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577133}
> 
> TBR=wez@chromium.org,gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org
> 
> Change-Id: Idb53da9b8b40b407ece6cf6c81b95bcb7072d76c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 860801, 850450, 786597, 866299
> Reviewed-on: https://chromium-review.googlesource.com/1147360
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577228}

TBR=wez@chromium.org,gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org

Change-Id: I29dec465bd2a29c3aa16940664ba5e1d3d005c0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860801, 850450, 786597, 866299
Reviewed-on: https://chromium-review.googlesource.com/1147380Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577234}

771b50f5

Fix occasional squared left tab edge at 150% scale · f6b99e93

Taylor Bergquist authored Jul 23, 2018

I don't (yet) know why this fixes the issue, but it certainly does. This
diff *should* be a no-op, changing an rLineTo to the equivalent lineTo,
but I guess the former runs into a bug in skia.

Stepping through this in the debugger reveals that there is some
floating-point error in the path's point sequence that the rLineTo
propagates and the lineTo obviously does not.  Apparently 0.5000015259
vs. 0.5 or 53.0000038 vs 53 makes a difference to skia when it's
calculating the path intersection.  ¯\_(ツ)_/¯

Bug: 864280
Change-Id: I06ba430f7f62f075102975e1e3db4b8a3292c879
Reviewed-on: https://chromium-review.googlesource.com/1141292Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577233}

f6b99e93

[Sync::USS] Reorder bookmark remote updates before processing them · a0aa7ae8

Mohamed Amir Yosef authored Jul 23, 2018

There are no order guarantees in the remote updates received from
the server.
However, for hierarchical types such as bookmarks, it's important
to process updates in the correct order.
For example parent node creation should happen before child node
creation.

This CL implements the following reordering rules for bookmark
remote updates in USS.
1. Creations and updates come before deletions.
2. Parent creation/update should come before child creation/update.
3. No need to further order deletions. Parent deletions can
   happen before child deletions. This is safe because all updates
   (e.g. moves) should have been processed already.

Bug: 516866
Change-Id: I059224b897ea51a4a0321124b082e76be824d28f
Reviewed-on: https://chromium-review.googlesource.com/1141870
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577232}

a0aa7ae8

[LPM] Fix issue with plugin use for component builds. · 3fa50872

Jonathan Metzman authored Jul 23, 2018

Change-Id: Ic4533523c8d1e335a41c0fe3a46f39feea8257c9
Reviewed-on: https://chromium-review.googlesource.com/1146995Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577231}

3fa50872

Overview: fix the animation regression. · 6c86f168

Xiaoqian Dai authored Jul 23, 2018

If one side of the screen is occupied by a split window, and the other
side of the screen is occupied by overview, select an overview window
should only animate the selected overview window to snap, and the other
windows should not animate.

Bug: 866178
Change-Id: I1cb243ad61791a240227c6395770643603726a33
Reviewed-on: https://chromium-review.googlesource.com/1145836
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577230}

6c86f168

Remove unused appcache.JobStartDelay.* histograms · 6edc96d8

Joshua Bell authored Jul 23, 2018

The histograms generate significant data and haven't been actively used.

Bug: 627320
Change-Id: I8e8175af29658e55828b32bcc070ca59b11bf21c
Reviewed-on: https://chromium-review.googlesource.com/972150Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577229}

6edc96d8

Reland "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread" · 5c7b464c

Gabriel Charette authored Jul 23, 2018

This reverts commit c512937e.

Reason for revert: change is correct, fixed test flakiness

Original change's description:
> Revert "[MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread"
> 
> This reverts commit 81626592.
> 
> Reason for revert: MetricsOnlyFromUILoops test appears to be flaky (see https://crbug.com/866299).
> 
> Original change's description:
> > [MessageLoop] Remove heavy diagnosis metrics and leave others only on UI thread
> >
> > Addresses crbug.com/860801 in time for the M69 branch while keeping the
> > diagnosis signals which will be used to assess future improvements
> > (MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle that is).
> >
> > Removed MessageLoop.DelayedTaskQueue.PostedDelay as we've
> > learnt everything we needed from this one, that is :
> > We now know that while 99% of tasks are posted with a delay under 30s,
> > 95% of users post at least one task in every portion of the 0ms-3hours
> > range at least once per day:
> > https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.DelayedTaskQueue.PostedDelay&fixupData=true&uniqueUsers=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> >
> > Removed MessageLoop.ScheduledSleep.* metrics as we've also
> > learnt what we wanted from it, that is :
> > The maximum sleep a MessageLoop ever completes is 1 hour (and
> > even then 99% of completed sleeps are under 1 second), all
> > longer delays are reliably always interrupted.
> > Win : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > Mac : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CM%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> > Android : https://uma.googleplex.com/histograms?endDate=20180717&dayCount=1&histograms=MessageLoop.ScheduledSleep.Completed%2CMessageLoop.ScheduledSleep.Interrupted&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
> >
> > Added a test for MessageLoop.DelayedTaskQueueForUI.PendingTasksCountOnIdle
> > but it appears to be broken on MacOSX (prior to this CL). Added a note
> > to investigate on the metric but it shouldn't block this CL which
> > doesn't make it worse.
> >
> > R=kylechar@chromium.org, rkaplow@chromium.org
> >
> > Bug: 860801, 850450, 786597
> > Change-Id: I7a693886ab4e1b9c8e9fbe8a64d906a95019a609
> > Reviewed-on: https://chromium-review.googlesource.com/1142589
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: kylechar <kylechar@chromium.org>
> > Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#576686}
> 
> TBR=gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org
> 
> Bug: 860801, 850450, 786597, 866299
> Change-Id: I848621acf9ddbec69d72649d16a459910ffa937e
> Reviewed-on: https://chromium-review.googlesource.com/1146300
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577133}

TBR=wez@chromium.org,gab@chromium.org,rkaplow@chromium.org,erikchen@chromium.org,kylechar@chromium.org

Change-Id: Idb53da9b8b40b407ece6cf6c81b95bcb7072d76c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860801, 850450, 786597, 866299
Reviewed-on: https://chromium-review.googlesource.com/1147360Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577228}

5c7b464c

Update content/renderer:renderer public deps · 14f718b7

jonross authored Jul 23, 2018

content/renderer:renderer has public dependencies on content/common:mojo_bindings
but it had only been picking that up implicitly.

This has broken on the waterfall in the past. This adds it to the public deps.

Bug: 859324
Change-Id: I546280c175f3b857466f0f8de4b0aac64766acda
Reviewed-on: https://chromium-review.googlesource.com/1145715Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577227}

14f718b7

RELAND: vaapi: decode on client NativePixmaps · ae29b155

Miguel Casas authored Jul 23, 2018

This CL relands crrev.com/c/1021675 that got reverted as predecessor
to crrev.com/c/1104394 (but was otherwise innocent AFAIK). The said
predecessor situation has been corrected by crrev.com/c/1117606 (that
landed in ChromeOS 10840.0.0 [1])

[1] https://crosland.corp.google.com/log/10837.0.0..10840.0.0

TBR=dcastagna@chromium.org (same code as reviewed before)

Original CL description -----------------------------------------------
vaapi: decode on client NativePixmaps

This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving
a buffer copy and removing a costly blit (DownloadFromSurface) on the
GPU Main thread.  Three groups of changes:

1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a
 VaapiPicture with a VASurfaceID, we use those to decode onto and set a new
 flag: |decode_using_client_picture_buffers_|

2. When the decoder calls CreateVASurface(), instead of giving it the first
 |available_va_surfaces_|, we need to figure out the first VASurfaceID in
 this |available_va_surfaces_| such that the corresponding VaapiPicture in
 |pictures_| is available (i.e. in |available_picture_buffers_|).
 Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one
 correspondence like on ToT.

3. When we're ready to OutputPicture() to |client_|, instead of using the first
 |available_picture_buffers_|, we find the corresponding one for the
 passed |va_surface_id| (we could search all over |pictures_| but there's
 always less |available_picture_buffers_|.

Some other notable developments:

- s/output_buffers_/available_picture_buffers_/
- OutputPicture() loses a parameter.
- |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2
 or the ImportBufferForPicture() path.
- Pictures is made a base::small_map. (Originally from crrev.com/c/988512).

resolutions for a long time. No hickups, no dropped frames.

Bug: 822346, 717265
Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie1fb21a7a302476bceee3dd905278d53f13b1475
Reviewed-on: https://chromium-review.googlesource.com/1021675Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1147143
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577226}

ae29b155

Migrate PrivetTrafficDetector from net::DatagramServerSocket to network::mojom::UDPSocket · bf41b7c1

Lily Houghton authored Jul 23, 2018

As part of the network servicification project, this CL replaces the use
of net/ sockets in the PrivetTrafficDetector class with the UDP socket
interfaces in the network service.

Bug: 811497
Change-Id: I0f0295f032684b0e6a32de222760cfeb409c7d21
Reviewed-on: https://chromium-review.googlesource.com/1127268Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577225}

bf41b7c1

[Video Capture, Android] Catch AssertionError on getCameraCharacteristics · bcde09d4

Christian Fremerey authored Jul 23, 2018

Crash reports indicate that on some devices the call to getCameraCharacteristics
raises an AssertionError inside Android OS level code. The message attached to
it is typically "Supported FPS ranges cannot be null."

On the Chromium side, the best we can do is to catch this, so that instead of
crashing, we fail gracefully. This CL adds the catch clause.

Bug: 860784
Change-Id: Ic5092e98b9497399ac309f00ea3eaecd41512646
Reviewed-on: https://chromium-review.googlesource.com/1145727Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577224}

bcde09d4

Add the flag for the experiment to change "incognito" to "private" · 4b252648

Jian Li authored Jul 23, 2018

Bug: 865140
Change-Id: Id58e74ea8cda672252b5f6abce911ce7d849ee3e
Reviewed-on: https://chromium-review.googlesource.com/1142448
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577223}

4b252648

Remove the current profile from the profile chooser menu. · 4c68d5ce

Vasilii Sukhanov authored Jul 23, 2018

Bug: 854638
Change-Id: I32e08f3f33558f7286f5cd80b05e86aa0dae0dd4
Reviewed-on: https://chromium-review.googlesource.com/1146817
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577222}

4c68d5ce

sql: Enable SQLiteFeaturesTest.TimeMachine · 653b14f2

Victor Costan authored Jul 23, 2018

Bug: 410350
Change-Id: I34cbb3572b1b5202ea2400acaafa68eae47809e4
Reviewed-on: https://chromium-review.googlesource.com/1146494Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577221}

653b14f2

Always stop PrivetTrafficDetector. · 957f866a

Lei Zhang authored Jul 23, 2018

Currently, there are some code paths in PrivetNotificationService where
PrivetTrafficDetector is not stopped. This causes PrivetTrafficDetector
to forget to unregister itself from NetworkConnectionTracker.

BUG=866199

Change-Id: I75721603889a6886b012d439bd6e8f2266083ee1
Reviewed-on: https://chromium-review.googlesource.com/1145888Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577220}

957f866a

Reenable BrowserTest.WindowOpenClose3 on Mac · e8df742a

Jochen Eisinger authored Jul 23, 2018

We no longer should wait for frames in tests, so this should pass again

R=ccameron@chromium.org
BUG=772576,753691

Change-Id: I9ff676c05fff3fa2d79e1a22edb4ec25ef5e5806
Reviewed-on: https://chromium-review.googlesource.com/1146191Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577219}

e8df742a

Add support for bluetooth actions · ffaf6d76

Ryan Cui authored Jul 23, 2018

Bug: b/78189672
Change-Id: Id8716cca1f4cf15a5700a0a4afa822302a829662
Reviewed-on: https://chromium-review.googlesource.com/1142623
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577218}

ffaf6d76

WebUI: move cr-input padding styles out of mixin · fbeda76c

Scott Chen authored Jul 23, 2018

This allows us to not copy every property specified in the mixin when
we want to override just one of them.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I121c5cbf66f8fbdd159a65139d537d92119ea2e1
Reviewed-on: https://chromium-review.googlesource.com/1142482Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577217}

fbeda76c

Moving NoScript savings from CDUA to PLM · 912ebabb

Ryan Sturm authored Jul 23, 2018

NoScript savings was previously recorded on the IO thread using
ChromeDataUseAscriber framework. This framework is being deprecated and
this change is blocking parts of previews servification. The results
from looking at this on real no script pages was not far off from the
results using CDUA, and I believe it is accurate enough.

Bug: 842233
Change-Id: I70057574554fd6717e0837be1a46cb6afa05ce4b
Reviewed-on: https://chromium-review.googlesource.com/1139081
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577216}

912ebabb

ozone: drm: Fix memory leak in IsDrmModuleName() · e3045918

Michael Spang authored Jul 23, 2018

We need to call drmFreeVersion().

Bug: none
Test: compile

Change-Id: I0c819d989a15dc2a5ddda7f9e37311d860f5afa1
Reviewed-on: https://chromium-review.googlesource.com/1146980Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577215}

e3045918

[autofill] Add missing form_structure_browsertest cases to iOS · 1b1820da

Roger McFarlane authored Jul 23, 2018

Tests 148 through 151 were not included in the test case bundle (copy
step for dependendent data) in the iOS build, so these tests were not
being run on that platform.

This CL adds the input and output files to the unit_tests_bundle_data.

Bug: 865864,857488
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib501fe2644c7961f2d6bcee80f7388a7daef8623
Reviewed-on: https://chromium-review.googlesource.com/1146769Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577214}

1b1820da

Enable jumbo for chrome/browser/ui · 9c9b30bf

Oscar Johansson authored Jul 23, 2018

This commit will enable jumbo for chrome/browser/ui. This will
reduce the build time by approximately 90 CPU minutes (more
than 10 % of the total jumbo build time for chromium), compared to
building without jumbo.

Bug: 803406
Change-Id: I7774bd55378ea88dadcbf452679686e383bb15a2
Reviewed-on: https://chromium-review.googlesource.com/1143269
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577213}

9c9b30bf

DevTools: intercept requests resulting from redirects · ac98f842

Andrey Kosyakov authored Jul 23, 2018

This introduces additional interception step into DevTools network
interception logic -- we now pause and report intercepted requests
after browser decided to follow the redirect, but before the request
is sent.

Change-Id: I228e6898d3a28abf80b8b6cc72ff61fac3884279
Reviewed-on: https://chromium-review.googlesource.com/1145946
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577212}

ac98f842

Mac: Disable warnings about having no GLContextCGL · d63a2e68

Christopher Cameron authored Jul 23, 2018

ImageTransportSurfaceOverlayMac is written under the assumption that it
is only ever paired with a GLContextCGL. This assumption has recently
been broken. The ERROR here was, as a result, creating an unruly amout
of console spam.

Bug: 866520
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3f3524f3f45e9e4cdaae09aeb672c9ab3b8edafa
Reviewed-on: https://chromium-review.googlesource.com/1147100Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577211}

d63a2e68

[AF] Update description for expiration date string · 1228df8a

Fabio Tirelo authored Jul 23, 2018

The goal is to make more clear to translators that they are supposed to
choose either YY/MM or MM/YY.

Change-Id: I5c84a566ac83e15e59bbca413506035197553c0a
Reviewed-on: https://chromium-review.googlesource.com/1146665
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577210}

1228df8a

[Feed] Move scroll logic to Mediator · 7f1a5c00

Becky Zhou authored Jul 23, 2018

Bug: 863171
Change-Id: Ibf9c93098fef18bbda60370d6bdd771442debd9f
Reviewed-on: https://chromium-review.googlesource.com/1145788Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577209}

7f1a5c00

Fix vulkan-1.dll crash in gpu info collection · a99a420b

Maggie Chen authored Jul 23, 2018

Due to some bad versions of Vulkan Runtime/Loader, there are crashes when
Vulkan is called for the GPU supported Vulkan versions and extensions.

From the logs, most vulkan-1.dll crashs are from the following versions.
As of 7/23/2018,
0.0.0.0 -  # of crashes: 6556
1.0.26.0 - # of crashes: 5890
1.0.33.0 - # of crashes: 12271
1.0.42.0 - # of crashes: 35749
1.0.42.1 - # of crashes: 68214
1.0.51.0 - # of crashes: 5152

The GPU could be from any vendors, but only some certain models would
crash. For those that don't crash, they usually return failures upon GPU
Vulkan support querying even though the GPU drivers can support it.

The solution of this CL is to skip the Vulkan GPU info collection if bad
Vulkan versions are detected.

Bug:850384,863546

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I80cf1f7a45d6d501db678bdf18d98f5e95930e1d
Reviewed-on: https://chromium-review.googlesource.com/1146984Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577208}

a99a420b

Revert "ozone/drm: No CTM on external monitor on i915" · 18774afe

Daniele Castagna authored Jul 23, 2018

This reverts commit d3408523.

Reason for revert: A proper fix landed with https://crrev.com/c/1141356

Original change's description:
> ozone/drm: No CTM on external monitor on i915
> 
> When using a CTM on i915 with some monitors, for some resolutions,
> colors don't look right.
> 
> This CL pretends external displays don't support HW CTM on i915.
> 
> Bug: 848540
> Change-Id: Ibdf3d2ef4bc8e2fce5669086043d54f715263fab
> Reviewed-on: https://chromium-review.googlesource.com/1128406
> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573140}

TBR=marcheu@chromium.org,dcastagna@chromium.org,afakhry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 848540
Change-Id: I9a0ae39f46e629879f45f1d43e65a2e43da62505
Reviewed-on: https://chromium-review.googlesource.com/1146782Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577207}

18774afe

Fix race condition in OnReceivedThreatDOMDetails. · 302605c6

Daniel Rubery authored Jul 23, 2018

If the window is closed after GetThreatDOMDetails finishes, but before
OnReceivedThreatDOMDetails is run, |sender| is invalid. Instead, we
observe FrameDeleted and track which frames are closed. Then we know
to skip this RenderFrameHost when GetThreatDOMDetails runs.

Bug: 817724, 860445
Change-Id: I2c8ed6c6a160264d91ca9b5a4760e53a7606f487
Reviewed-on: https://chromium-review.googlesource.com/1146997Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577206}

302605c6

[Harmony Cast Dialog] Show dialog for browser_actions-less windows · 754213fe

Takumi Fujimoto authored Jul 23, 2018

In a browser window without BrowserActionsContainer, there is no Cast
toolbar icon to anchor the dialog to. So we anchor it to the top center
of the window.

Bug: 853371

Change-Id: If79016f0bd06e322db8b96621ab058e215ba5364
Reviewed-on: https://chromium-review.googlesource.com/1145237
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577205}

754213fe

OopAsh: Begin enabling browser frame browser_tests · 96fb2db7

Evan Stade authored Jul 23, 2018

Bug: 854704
Change-Id: I00c25bee75cb69d36af1ab022847cf08100f5e88
Reviewed-on: https://chromium-review.googlesource.com/1144640Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577204}

96fb2db7

Remove Tab reference from UrlBar. · b2290f98

Ted Choc authored Jul 23, 2018

BUG=800825

Change-Id: I8aaaf6a3e80cf6a0075fab4e73a60e7610d9b60d
Reviewed-on: https://chromium-review.googlesource.com/1145861
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577203}

b2290f98

Remove getApplicationContext from contextualsearch · f255f21a

Tiger Oakes authored Jul 23, 2018

Continuation of work in bug 646094.
Preparing to activate an errorprone check to flag
context#getApplicationContext calls. The goal is to prevent storing the
resulting context as a class property, and instead use ContextUtils.

Bug: 846456
Change-Id: I2c3efdf6c0de690ee8a9a06a523c773722c07196
Reviewed-on: https://chromium-review.googlesource.com/1095997Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#577202}

f255f21a

Use the Native Certificate Viewer on MacOS even on MacViews · 7fbbd5f2

Robert Liao authored Jul 23, 2018

BUG=766926

Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782
Reviewed-on: https://chromium-review.googlesource.com/1145674Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577201}

7fbbd5f2

[Sync::USS] Introduce about flag for USS bookmark sync · 0178fa89

Mohamed Amir Yosef authored Jul 23, 2018

This allows more easy testing of the feature under development/
experimentation.

Bug: 516866
Change-Id: I8418b9c61ad42214491c8b97edfcfe71f879b14f
Reviewed-on: https://chromium-review.googlesource.com/1146818Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577200}

0178fa89

[Sync::USS] Enable the first two client bookmark browser test · c4e8e8d6

Mohamed Amir Yosef authored Jul 23, 2018

This CL restructures the two client browsers tests to be parameteized
such that different tests can be enabled for USS incremently.

Bug: 516866
Change-Id: Ifc7b8aa39992e30fef876d28b9b29f1419426972
Reviewed-on: https://chromium-review.googlesource.com/1146927Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577199}

c4e8e8d6

[ChromeDriver] Drop support of Chrome v66, add support of Chrome v69 · 66c6fcca

Artur Khachatryan authored Jul 23, 2018

Branching Chrome v69.
We are adding supporting of Chrome v69 and dropping supporting of Chrome v66

Change-Id: Id9b75ef78dd14da34f5165cbc6f64b3a188a5eb9
Reviewed-on: https://chromium-review.googlesource.com/1146993Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577198}

66c6fcca

chromeos: Add LoggedInSpokenFeedbackTest.KeyboardShortcutViewer · efd86b08

James Cook authored Jul 23, 2018

This tests ChromeVox integration with an out-of-process mojo app.

Bug: 851578
Test: interactive_ui_tests
Change-Id: I23a6cbf9bf93d675f5cc774e3df82eb4be5a334f
Reviewed-on: https://chromium-review.googlesource.com/1132555
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577197}

efd86b08