- 16 Nov, 2020 40 commits
-
-
Colin Blundell authored
This CL does the initial bringup of ad tagging and blocking functionality in WebLayer. To do so, we do the following: - Bring up an implementation of SubresourceFilterClient and attach it to WebContents instances - Instantiate subresource filter navigation throttles on navigation - Instantiates and configures SubresourceFilterAgent instances in the renderer The organization and code added is modeled after that in //chrome. We have left TODOs for significant pieces of functionality to be added in followups (e.g., showing of the infobar on Android). One thing to note is that ad tagging/blocking only triggers on Android in WebLayer, as it requires having a safe browsing database instance and WebLayer does not have one on platforms other than Android. This CL also adds browsertests of this initial functionality: - that the subresource filter activation state is computed on page loads - that ads are blocked on activated pages if they are flagged by the ruleset Bug: 1116095 Change-Id: I1db0136709014004c221bb0251551eaeac3538e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526087 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#827735}
-
Alice Wang authored
This CL removes the dependency of account_picker package in the package incognito_interstial to facilitate the modularization of the incognito interstitial package. Bug: 1148718 Change-Id: I155fe25ba66611d201aabd3540e8b6559d6e86ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536441 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#827734}
-
Noel Gordon authored
Add a file_manager/resources/BUILD.gn action('gen_main_html') to use a script to auto-generate SWA main.html from files app main.html. Update file_manager/resources/file_manager_resources.grd file to fetch auto-generated SWA main.html from the generated resources directory. Bug: 1113981 Change-Id: I116d5fb15e63148e3a1cdbe9cf7e179a53165957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536584 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#827733}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ide951861c15b6a4b1b36aff3e6bba1324c30be18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827732}
-
Alice Wang authored
This CL removes mContentWidth update from the root view's OnLayoutChangeListener and updates this variable in onContentSizeChanged. Bug: 1148421 Change-Id: I149b21a83a8145d030221f7c026feeace50fbaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536874Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827731}
-
Morten Stenshorne authored
When processing incoming break tokens as part of block child layout, do not call NGLayoutInputNode::NextSibling(), because: 1: We're not going to use the result 2: It would trigger a DCHECK failure in some cases If we're resuming at a float in an inline formatting context, we'll do this directly from the block layout algorithm. However, the float may have inline-level siblings, and those should be handled by the inline layout algorithm, not the block layout algorithm. NGBlockNode::NextSibling() (rightly) chokes on inline-level boxes, so just avoid it. There will always be an inline break token which will take care of this correctly for us. The attached test used to DCHECK-fail (but otherwise pass) without this fix. Change-Id: I826c30b362f2ae40af12f1b7cf1b0a9e8cd9ccfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537675Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827730}
-
arthursonzogni authored
There is a dedicated function for everything that should be set/reset when committing a new document. It's better adding new stuff inside, instead of immediately outside. Bug: 1113294. Change-Id: I3e076455d46c0658c06eb9452627ff7b38c06da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537684Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827729}
-
Alex Rudenko authored
Bug: 1121900 Change-Id: I579156dd5b9411324fb88b76bbd12bfb17397d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537633Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#827728}
-
Nico Weber authored
This reverts commit d8f7927c. Reason for revert: We rolled in a fixed clang. This workaround should no longer be necessary. Original change's description: > win: Disable CFG in release component builds for a bit. > > After the 2nd-to-last clang roll, release component builds make > chrome crash on launch due to CFG. Disable CFG for component builds > until we roll in a fix. > > This does not affect shipping chrome, which doesn't use component builds. > CFG was already disabled in debug component builds. > > Bug: 1147194,1147445 > Change-Id: Idd2ab6dcc6e89e604d8f0c6f37369f7b389b31c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532875 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826317} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1147194 Bug: 1147445 Change-Id: If377b6d66f1a78105b1d41db8e68a30da9e39fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539354 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#827727}
-
Ce Chen authored
after launching feature to non-Incognito Mobile & Incognito all platforms. Bug: 925072 Change-Id: I564833f2051b4b5b04980a119b121f2ee2e6da18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537521 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827726}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1cda495274bb..1f2fcddd3963 2020-11-13 afdx@google.com spirv-opt: Set parent when adding basic block (#4021) 2020-11-13 jaebaek@google.com spirv-opt: properly preserve DebugValue indexes operand (#4022) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I4db3b49a0ad2c6b0bd2940777d3b013e5db2a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539729Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0d31e3de37910bf71d8ea5481ec4ad1b4893c7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537147Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827724}
-
Jérémie Boulic authored
JS Modules for the following files: //ui/file_manager/file_manager/foreground/js/metadata/: - exif_parser.js - exif_parser_unittest.js //ui/file_manager/externs/: - exif_entry.js //ui/file_manager/gallery/js/image_editor/: - test_util.js - image_util.js - image_encoder.js - image_encoder_unittest.js - exif_encoder.js - exif_encoder_unittest.js - exif_parser.js - exif_parser_unittest.js Bug: 1133186 Change-Id: I696fde015e7f8bbea44544ef8721aed2e9a1a59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536660 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605484714-0506bb900efd9e0694325713b333ba7d388746e8.profdata to chrome-linux-master-1605506334-8e819d7371bb25516f19d1591aa22eeb3af9fbfb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5e7d18be09463dadcfec882f6f56c2308e05c57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539728Reviewed-by:
-
Mason Freed authored
When fragment-parsing HTML from a context that has not opted in to declarative Shadow DOM, and a <template shadowroot> tag is encountered, issue a console warning. An example would be: ```javascript element.innerHTML = '<div><template shadowroot=open>`; ``` This should not change any behavior, besides the console. Bug: 1042130 Change-Id: Iaa3d6c52a44d84fdbbaca18acde65b9c3d513ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538283 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#827721}
-
Noel Gordon authored
Log a "not implemented" message in send-feedback command in the files app SWA case. Bug: 1149265, 1113981 Change-Id: Ie77d65fc12ab1d3a4f0049a3c8410faf8112dc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538869 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Noel Gordon authored
Bug: 1149264, 1113981 Change-Id: I5253f9eba5bd0869d32dd1757c35eb583628ad28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537315Reviewed-by:
-
Nico Weber authored
Bug: 1147069 Change-Id: If01314a9a6a7ba359f79cbd58ed9e732cf70928f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538720 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22f384e6e94..977fe86b8a57 2020-11-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic6229633ea648f1e7876aaa5091831b258eba89b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538568Reviewed-by:
-
Alan Cutter authored
This CL is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2524809/ where the remaining default installed Chrome apps are migrated over to preinstalled web apps: - Gmail - Google Docs - Google Drive - Google Sheets - Google Slides - YouTube This copies the JSON configs in https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/master/chromeos-base/chromeos-default-apps/files/web_apps/docs.json to C++ in the Chrome binary. The JSON configs will be removed in a follow up CL to avoid data duplication in multiple locations and formats. The icons used by these default apps are stored in an internal repository: https://chrome-internal.googlesource.com/chrome/components/default_apps/+/refs/heads/main Bug: 1104692 Change-Id: I51ea68b0d1a9c0d25e1edfb4fc5b3557643b562e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525886Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827716}
-
Swapnil authored
A browser test was missing to validate that the browser does not crash when multiple profiles are added. This browser test validates the same. Bug: 708210 Change-Id: I346b060cc5b20b631411044f71114d7b4603559d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041435 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#827715}
-
Luciano Pacheco authored
Add JS module generation for: //ui/file_manager/externs/background_window.js Add the method forceFileOperationErrorForTest() in the interface FileBrowserBackgroundFull and to its implementation FileBrowserBackgroundFullImpl. This is a preparation to run as JS modules and as SWA; to avoid the integration test harness to reach to global namespace `fileOperationUtil`. Bug: 1133186 Change-Id: Ic5e2d38762b030c827c887021e7e611ba846228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537285 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827714}
-
Maggie Cai authored
This CL refactors the AppsNavigationThrottle and all it's children to only handle navigation cancel and defer case (i.e. found a preferred app that can handle the url and redirect user to the app), and move all other functionality (show intent picker icon and bubble) to be called based on web contents observer from IntentPickerTabHelper. This CL is pure refactor with no functionality change. This is because currently if we automatically pop up the intent picker, it will show the apps from the first url, that we can find any apps, from the redirect chain. This will cause couple of issues: 1. If the apps that can handle the final url is not the same as the the apps that show up at the bubble, we will miss some apps. 2. If user dismissed the bubble and then click the icon again to show bubble, the apps will be different. 3. If the end url has no apps, and user dismissed the bubble and then click the icon to show bubble, nothing will show up. This CL changes the app checking and bubble showing time to when the navigation (and all redirects) is finished to overcome the above issues. (NOTE: Because the chromeos_apps_navigation_throttle code is due to deprecation, so only doing the minimum change to make sure it still works) BUG=853604 Change-Id: I6f83832dec1fdb6627df123ea31f51db8300b4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505689Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#827713}
-
Guido Trotter authored
- Add a WelcomeVideoController.pause() function - Make WelcomeVideoController.play() call play on the active video, too - Add a welcome screen hide() function, and call it from a new observer of the hidden attribute, when the screen becomes hidden - Call hideAllScreens() also when leaving oobe_welcome via onBeforeHide - Mark the active screen as not hidden in the welcome screen onBeforeShow(), to handle going back from the network and debug screens R=rsorokin@google.com Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Change-Id: Id5eecb1fa88bab598ab16e5152051fc8c14a6ca9 Fixed: 1123835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529100Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#827712}
-
Hirokazu Honda authored
This adds a test case of encoding NV12 Dmabuf VideoFrame with down-scaling; the input resolution is twice larger in width and height than one configured to VideoEncodeAccelerator. This can happen in WebRTC simulcast scenario when zero-copy capture feature is enabled. To not hit the smaller resolution's limitation, the test case is skipped if the resolution to be produced is less than 240x180. Bug: 1045825 Test: video_encode_accelerator_tests on atlas and kukui Change-Id: I11eac935aa2c6a03bcef0dfa533c8731d593d3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342535 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#827711}
-
Austin Tankiang authored
The test was flaking because a new banner was added to Drive. This banner has a "Learn more" button that can be used to dismiss the banner, so click it during the test. Bug: 1147306 Change-Id: If241639b7db35fd8a2cd6bfd87776d22c04e2874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538865Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#827710}
-
Fish Lin authored
This change adds a "mutable" option to flatbuffer template, let it using "--gen-mutable" flag to compile flatbuffer with non-const accessors for mutating FlatBuffers in-place. Bug: 1149150 Test: Compile flatbuffer see if it generates mutable header Change-Id: I42ce7dfcac5ee8496db56548391b205d0b056aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534550 Commit-Queue: Fish Lin <linfish@google.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a15da341200e..b8a27ae001c2 2020-11-16 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from f6bc2a9be76e to 907123f96f40 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7969d2219319badd1daf35d46df76799e288ca1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536825Reviewed-by:
-
Hirokazu Honda authored
The number of encoders is three in the concurrent encoder test case in video_encode_accelerator_tests. In the test case and 2160p encoding, creating shared memory for input frames fails on lower end devices due to a shortage of allowed handles. Decreasing the number of encoders should mitigate the fatal. Bug: b:170790027 Test: video_encode_accelerator_tests on cyan Change-Id: I669f026729c355e117b29389f08f66c05bcfa76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532541Reviewed-by:
-
zxliang authored
If a service appears in external_services_to_proxy, it is supposed to be registered and stored in services_ as well. BindInterface() should not query ServiceManager but instead should store this request through ServiceNotFound for later query when that particular external service is registered through RegisterExternalServices(..). Otherwise the binding process to this external service (which only has earlier-registered service_instance) will be silently dropped if the the client doesn't set any disconnection handler. Refer to go/ml-framework-standalone-binary-flakiness for more info. Bug: b/168555534 Test: CQ Change-Id: I2f791c924e1b23518704ad7237fc1e5624eaefd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537975 Commit-Queue: Zhaoxin Liang <zxliang@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#827706}
-
tby authored
We have logic for populating a ChromeUserMetricsExtension proto from JSON storage. This will soon be used in two places, so this CL moves it into its own function. While I'm here, I've also cleaned up the logic a little and added some extra safety to prevent us from crashing chrome in the case of an unexpected JSON format. I've also removed a TODO that isn't relevant anymore. Bug: 1148168 Change-Id: Iedcb514ae950f6a6ffec3690ddc7a82ba0b7616b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536421 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827705}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_SVG_RESOURCE_TYPE_CASTS() to DownCastTraits<> for the following classes, and removes DEFINE_LAYOUT_SVG_RESOURCE_TYPE_CASTS(). - LayoutSVGResourceClipper - LayoutSVGResourceFilter - LayoutSVGResourceMarker - LayoutSVGResourceMasker - LayoutSVGResourceRadialGradient This CL has no behavior changes. Bug: 891908 Change-Id: Ica5c540177b51e2e32d1e7c29518a060c2923c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538859 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ac304ad84192..e22f384e6e94 2020-11-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia840e4bd9bd11ed464c3553023130d59abf3ec4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539646Reviewed-by:
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I0daf571aab4e9dc8a7f270ce64cb2b09b41362ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536582 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#827702}
-
Minggang Wang authored
The mojom interface KeepAliveHandle is used to keep alive the associated render process even after the frame is detached, and content::Context::WebURLLoaderImpl holds a pending remote of the KeepAliveHandle when creating a WebURLLoaderImpl object from renderer. As part of the OnionSoup project, this patch moves it into blink. Also, the method IssueKeepAliveHandle() used to create a KeepAliveHandle is moved from content.mojom.FrameHost to blink.mojom.LocalFrameHost, so we could issue a KeepAliveHandle directly inside blink in the future. Change-Id: I5dd9e4acc4743e83340955dab7cae0c901b2b61c Bug: 1110176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524284 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827701}
-
Luciano Pacheco authored
Follow from CL:2534553 move the duplicated code to app_util.js, satisfy the dependencies and re-use the code from app_util.js. Bug: 1148545, 1133186, 1113981 Change-Id: I7dc089a8cf1c371eb3d59702464839faf3004a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535900Reviewed-by:
-
Anupam Snigdha authored
This fix is a follow-up from a previous fix that changed the way we split the elements wrapped inside inline elements during indenting of more than one paragraphs. In this fix we also include elements such as textarea/input elements which are not inline/block level elements. This was found as a result of a clusterfuzz bug and I've included tests to check these cases. Test: web_tests/editing/execCommand/indent/indent_blockquote_with_inline_nested_paragraphs.html Bug: 1148859 Change-Id: I17b306a684fad185f60a433ab4d264a961ffb11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538532 Auto-Submit: Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827699}
-
David Munro authored
We added the StartLxd step a little while ago but didn't break it out into its own installer state then. Do so now so we can expose more granularity to users about installation and where launch/install is failing and because it'll be useful when we do timeouts. Bug: 1142319 Test: Manual, unit Change-Id: Iab11ecb5f79120e94119e9879b7228246e572b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537817 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827698}
-
Glen Robertson authored
Console errors are also logged to stderr so C++ devs can debug as before. Bug: 1149223 Change-Id: I050ba47184740bb7a08abf1469838f79f616105c Fixed: 1149223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537277 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#827697}
-
Darren Shen authored
It does not affect the test because SystemDecoder runs in a separate process, so setting the fake main entry does not affect SystemDecoder. Bug: 1148157 Change-Id: I99b5fac2da26be833f76063becbf586578d2965f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537253Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827696}
-
