- 19 Jan, 2021 40 commits
-
-
Xida Chen authored
TBR=rainhard@chromium.org NOTRY=true Bug: 1070886 Change-Id: I4bf958456b1602620f479802e0838d2f9dbea380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636875Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844777}
-
Hans Wennborg authored
This speeds up builds when using ThinLTO. The resource leak preventing this from being enabled before has been fixed upstream. The only bots doing ThinLTO builds on Windows are ToT bots that use upstream clang. Bug: 871962 Change-Id: Ie7a250a5bab009a95f919631b5f268aafdcdffab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637620 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844776}
-
Hans Wennborg authored
The SDK was updated to 11.1 in crrev.com/844553. This updates the build script to match Bug: 1168134 Change-Id: Ia9054b5b49e7f24bc9135ccd6024e3c8af8cd518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637477 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/035dfc7b..b28c3b8f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf6a72e6aae8ea915b16c8b1eb3f085fe9a785cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637814Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844774}
-
Xida Chen authored
This test is flaky on a few platforms TBR=rainhard@chromium.org NOTRY=true Bug: 1070886 Change-Id: I5ac13c73ab75be22d34b3f0f5749efa4cb11297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636874Reviewed-by:
-
Antonio Sartori authored
In the Blink Content Security Policy code, we switch from using the internal blink type blink::CSPDirectiveList to using the mojo type network::mojom::blink::ContentSecurityPolicy for storing a parsed Content Security Policy. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: Idb11f4af00bae348140864584d9c522ad361559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602125 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#844772}
-
Nohemi Fernandez authored
This patch fixes a crash that occurs when a user goes through the advanced Sync settings sign-in flow with an account that has a Sync encryption password. Starting from this patch Sync error cards are only displayed after the sign-in flow has been completed. Bug: 1125631 Change-Id: I877e59e25265e78a4220fbb66b7a3855757dceb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637575Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#844771}
-
Sebastien Marchand authored
as discussed in https://chromium-review.googlesource.com/c/chromium/src/+/2621678 Bug: 1153193 Change-Id: Ib5068b627c9e91644857892a57213414b9cfd77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627886Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#844770}
-
Rune Lillesveen authored
Mark it as STACK_ALLOCATED. There's a ComputedStyle which is not refcounted which would be dangerous if TextDecorationInfo gets allocated on the heap. Noticed this when reviewing moving ComputedStyle to Oilpan. Change-Id: Ia3ec8ea0bfa542da817110d6c1b9b6c52315ad21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637834Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844769}
-
Victor Costan authored
Bug: 1163048 Change-Id: I1744df8280e11bc96073415354a0006f49fd6a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628078Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844768}
-
Xiaocheng Hu authored
A previous patch crrev.com/c/2629991 has a bug that it always enters a code path that should be entered only when CSSAtRuleCounterStyle is enabled. This patch handles the flag properly. Bug: 1167596 Change-Id: I15dcdae0d70a716185e5ab376a0c08bcb5f134dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636378 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844767}
-
Guillaume Jenkins authored
Installs the BrowserSignin policy handler by default. It was previously hidden behind the --install-browser-signin-handler command-line flag while the different parts of the implementation were being finished. The policy now fully works, so the command-line flag is no longer needed. Bug: 1155745 Change-Id: I58dda5bdc143cbfbd21cecbea13d184bc60100ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633352Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#844766}
-
Titouan Rigoudy authored
We test 6 out of the 7 possible URLs: - about:blank - the initial empty doc - about:srcodc - data: - blob: - filesystem: We do not test javascript:, since we cannot load in a sandboxed iframe (even with `sandbox = "allow-scripts"`). Fixed: chromium:1167697 Change-Id: I8c4c634bd7c0cc7d1ed9a6c1148f63fa79f7dfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637616 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change extends the PasswordManager.BulkCheck.CanceledCredentials and PasswordManager.OsPasswordStatus histograms. R=chromium-metrics-reviews@google.com Fixed: 1160745, 1167775 Change-Id: I2310afe4516b85fdbe9927cd03df267daf7d30ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637696 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Jarryd authored
Bug: 1165235 Change-Id: I71582edc502c7bdee6b8826c5425de3bf2279d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632854 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
This CL removes the target from the return value of toJSON from a PerformanceEventTiming entry, and modifies the WPT accordignly. Context: https://github.com/WICG/event-timing/issues/97 Change-Id: I2a2f27f845f297157ca9f5ae561a9730dc242d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636058 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#844762}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611035655-254822a7c03cbefbcbdc34527b5136e1083ea204.profdata to chrome-mac-master-1611057528-6f03f3ff553c2040abb87e84fc5d258c023feaa2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I65f892333deacd7754adc18da184979a7cd323da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636925Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844761}
-
Michael Lippautz authored
Treating ephemerons strong during snapshot creation results in strongification of the key, even though the right key->value edge is added. This is a problem when the ephemeron container is closer to a root than the actual object, as it hides the real retaining path. Instead, treat the backing weakly which results in only adding the right key->value edge. In addition, give the edge a name as otherwise regular properties would be indistinguishable from properties added through ephemerons. Example retainer entry: part of key -> value pair in ephemeron table (<blink::WeakMember<blink::Node>, blink::Member<blink::EventTargetData>>) in HTMLButtonElement@38789 Change-Id: Id9cc2fb5b31be6df68ec9d0f63c01c06dbb48bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633264 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844760}
-
Henrik Boström authored
In this CL, VideoCaptureDeliverFrameCB gets an additional parameter. The scaled video frames are versions of the original video frame (existing parameter) but already downscaled by the capturer in the size that the consumer wants. This saves on the consumer having to do SW rescaling or GPU roundtrips. The intended use case is that when frames reach the encoders in WebRTC we can acheieve "zero copy". A prototype CL[1] suggests this might save 0.1-0.5 W in some cases. Consumers like WebRTC can already communicate desired resolutions to the Capturer on-the-fly using media::VideoFrameFeedback. This CL does NOT add in-capturer scaling or updates the pipeline to pass the additional frames, but if we can agree in this CL to update this callback, the rest is "mostly plumbing" to be done in follow-up CLs. In the meantime, the scaled video frames is an empty vector. Changes: - video_capturer_source.h: This is the callback that is changed. - video_capture_impl.cc: This is the entry-point to the renderer process, currently passing in an empty vector. In a future CL, frames will be delivered Capturer -> Browser -> Renderer. - video_track_adapter.cc: This is where scaling is soft-applied today. We still soft-apply, but additionally pass along the scaled frames. - media_stream_video_webrtc_sink.cc: This is the entry point to WebRTC. Shortly after is where soft-applied frames get downscaled. In a future CL we can pass the scaled frames there and skip downscaling the original frame. The rest of the changes is updating all the references to the callback to have the correct number of arguments. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2577366 Bug: chromium:1157072 Change-Id: If806d56fb58022a1f1debace3ccbe7361d79554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632669Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#844759}
-
Thomas Guilbert authored
This CL adds PushableMediaStreamAudioSource, which mirrors the video equivalent PushableMediaStreamVideoSource. This class allows one to easily push audio data into a MediaStreamTrack. Bug: 1157608 Change-Id: I6fe3adc26f257eb6f9a6e7d8ff8dad8929ab2a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625829Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#844758}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id525d2319bc7dd130b94193115241ddde6fcf8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636918Reviewed-by:
-
Jan Wilken Dörrie authored
This change enables the PasswordsWeaknessCheck feature by default and removes the corresponding field trial testing config. Bug: 1119752 Change-Id: I8e0908f796a56c7eed3bc8945b7c741f15a14838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637574Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844756}
-
henrika authored
This change makes WASAPIRawAudioCapture accessible from chrome://flags via the raw-audio-capture flag so that the feature is togglable by consumers in the UI. Bug: 1133643 Change-Id: I5eee5b9568e787283bd21a9aa88cc2ec6473cef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636356 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#844755}
-
Nico Weber authored
The bot always times out and doesn't find anything useful. Let's just not run it. Bug: 1144484f Change-Id: Iabd8150ffd6fef99782de28ad084a4cce80298c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637714 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844754}
-
Sylvain Defresne authored
Bug: none Change-Id: I07c797cab7f97428ea17ec30fe33aa9739553d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632945 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844753}
-
Maya Lekova authored
The feature is disabled by default, as is the current state of the flag in V8. This CL is intended to allow us to start a Finch experiment for enabling the feature over time. Bug: chromium:1052746 Change-Id: I8f7f29fe7661bfeb911c63e0a892905efb3edb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632682Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#844752}
-
Jan Krcal authored
This reverts commit bedb24da. Reason for revert: the test is flaky / failing on MSan Original change's description: > [Profile creation] Add {back,reload} accelerators for navigation > > This CL adds two accelerators into the profile creation flow to improve > accessibility and usability: > - the back action for screens that actually show the back button > - the reload action for the sign-in flow that happens over the internet > and thus loading of the page can fail. > > Bug: 1126913, 1167675 > Change-Id: I3c197dea2859c0136db62249064249e0569a93da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627403 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844695} TBR=droger@chromium.org,jkrcal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I50060ea130339fe25df000ecffaf7e474ba285b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126913 Bug: 1167675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637595Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#844751}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py f1d5cbbdee5526bc86eac0a5652b115d9bc158e5`. Bug: 1166673 Change-Id: Ie034b123905ec30d68db754485b8259311e5dddb Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627087Reviewed-by:
-
Alex Ilin authored
This CL fixes a bug which leads to the guest ephemeral profile not being cleaned up on startup if it has been left over in the previous session. ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true` parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get the full list of registered profiles. Bug: 1167883 Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#844749}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b81bf5f2ec4b..95612c220891 2021-01-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7074156dd73e6c0c0e901b60de1779469ad8f116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636922Reviewed-by:
-
Gyuyoung Kim authored
As a next pre-work to convert the context menu IPC messages, this CL moves MenuItem, WebMenuItemInfo struct to blink/public/common/context_menu_data as below, - Move menu_item.h/cc from //content to blink/public/common/context_menu_data. - Move web_menu_item_info.h from blink/public/web to blink/public/common/context_menu_data. - Merge menu_item_builder.h/cc into menu_item.h/cc. Bug: 1093904 Change-Id: I440f6c2d43701b18b6b8f7abe481287befd7d106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631518Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Certain UI elements, such as the thumbnails and the annotations dialog, require the number of rotations on the PDF content. Currently, that value is tracked both on the UI and the plugin backend, but they can go out of sync because: - The UI value is updated synchronously whenever the rotate button is clicked. - The plugin value updates when a rotate request comes from the UI or the context menu. Therefore, the true value is held in the plugin, as the rotate requests from the context menu do not go through the UI. Furthermore, the number of rotations from the plugin is already sent to the UI on the 'documentDimensions' message. Use that value instead. Fixed: 1166590 Change-Id: Ia7fa111ae338a863828fd1196715684301d7b5c3 Bug: 1166590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630428 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#844746}
-
Viktor Semeniuk authored
This change allows syncing compromised credentials whenever local state of compromised credentials changes. Whenever Compromised credentials are added/removed password_store will notify PasswordSyncBridge about affected PasswordForms. This change also includes updating local state of compromised credentials during merge when remote password is more recent. Integration tests are added to test new behaviour. Bug: 1167109 Change-Id: I4681bf47aaf1376699680dacd502d8e37076a9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626439 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#844745}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee927aaa..035dfc7b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieeb136822d1e1bea0875a823a955900a9b54ce57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637309Reviewed-by:
-
Chinglin Yu authored
The security sandbox forbids making socket connections directly from within most child processes (except the network utility process). Trace data for renderers are missing from a tracing session with Chrome data sources on non-Android Posix platforms. This change introduces a new Mojo interface, SystemTracingService, that is shared between the browser and child processes for making a socket connection to the system tracing service daemon. A child process receives a Mojo remote interface and then invokes the OpenProducerSocket method to open the socket connection in the browser process. The browser process then passes the socket connection to the child in the response. The child process then adopts the connected socket in initializing the connection in PosixSystemProducer. Full design doc: go/crosetto-chrome-producer-dd SystemPerfettoTest.SandboxedOpenProducerSocket Bug: b/147789115 Test: services_unittests: SystemTracingServiceTest.*, Change-Id: Id698dc656b7b9ede723e3a887532c33544914edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435129 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844743}
-
Ben Mason authored
Change-Id: I3071172054097f353d308f723d6deb6fc85ce1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637416 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844742}
-
Alice Wang authored
This CL changes several account picker methods to package private as we already finished modularization of account picker. Bug: 1155123 Change-Id: I33252c72ac37eaa121e35aea59578390018571ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631499Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844741}
-
Finnur Thorarinsson authored
Bug: 1166410 Change-Id: Ifea16684b7d1d653ca2447b907eb217d09ce0abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632764 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844740}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea4488d496b4..b81bf5f2ec4b 2021-01-19 tvanderlippe@chromium.org Fix styling of Developer Resources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1660d580eb253ed6bec165aaf2f588e65eb935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636755Reviewed-by:
-
Kyle Williams authored
Create a new form factor for Meeting Room Hardware Workspace Devices, also known as Chromebox for Meetings, to allow finch support for CfM specific experiments. BUG=b:177442621 TEST=ensure unit tests work correctly and test with basic logging to ensure the correct form factor chosen in chrome. Change-Id: I89af958017dfb2e68c3e423be7832ef0d7dc8a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628108 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#844738}
-
