GitLab

ARC Kiosk bridge is also moved from components/arc into chrome/browser/chromeos/arc
because it uses parts of chrome/browser/*

BUG=b/32370502

Review-Url: https://codereview.chromium.org/2524673003
Cr-Commit-Position: refs/heads/master@{#439775}

This is a follow-up CL of crrev.com/2583083002. Make sure that calling
these methods doesn't take effect when the renderer is foregrounded.

BUG=674784

Review-Url: https://codereview.chromium.org/2583193003
Cr-Commit-Position: refs/heads/master@{#439774}

This is a dev-only, standalone app for Chrome for iOS development. It showcases
(and is restricted to) UI elements used and developed for Chrome for iOS.

BUG=653086
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2592593003
Cr-Commit-Position: refs/heads/master@{#439773}

When stretching we used to pass the wrong available width to
constrainLogicalWidthByMinMax, leading to an incorrect calculation of
percentage max/min widths.

BUG=675333
R=mstensho@opera.com,eae@chromium.org

Review-Url: https://codereview.chromium.org/2585423002
Cr-Commit-Position: refs/heads/master@{#439772}

Revert of Convert NaCl renderer-loader messages to mojo. (patchset #4 id:140001 of https://codereview.chromium.org/2525483002/ )

Reason for revert:
CL does not compile on build bots

e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/106780/steps/compile/logs/stdio

Original issue's description:
> Convert NaCl renderer-loader messages to mojo.
>
> BUG=577685
>
> Committed: https://crrev.com/eb52daa79263d35ea1c62b717427bf68467be04f
> Cr-Commit-Position: refs/heads/master@{#439770}

TBR=mseaborn@chromium.org,bradnelson@chromium.org,jam@chromium.org,dcheng@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=577685

Review-Url: https://codereview.chromium.org/2590853002
Cr-Commit-Position: refs/heads/master@{#439771}

BUG=577685

Review-Url: https://codereview.chromium.org/2525483002
Cr-Commit-Position: refs/heads/master@{#439770}

FileBrowser.Load.ImportElements:
    Time to initialize the polymer elements.
FileBrowser.Load.InitBackgroundPage:
    Time to initialize the background page.
FileBrowser.Load.InitDocuments:
    Time to initialize the background page and the elements.
FileBrowser.Load.InitSettings:
    Time to restore user settings.
FileBrowser.Load.InitUI:
    Time to initialize all UI after all elements are initialized.

BUG=675536
TEST=manually confirmed on Linux that the above values are exported to chrome://histograms.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2589693002
Cr-Commit-Position: refs/heads/master@{#439769}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/75c2c8d4..62479fdb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2593573002
Cr-Commit-Position: refs/heads/master@{#439768}

In https://groups.google.com/a/chromium.org/forum/#!topic/chromium-mojo/PUDEadGMijM,

we decided that mojo::MakeRequest was a more suitable name for this
helper function than mojo::GetProxy.

This CL was created by running mass search-and-replace (suitably guarded
to avoid changing unrelated GetProxy() functions), followed by
"git cl format".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=darin

Review-Url: https://codereview.chromium.org/2589663003
Cr-Commit-Position: refs/heads/master@{#439767}

Previously, |GetCategories()| did not update the order and, therefore,
order changes could not be propagated to UI.
After this CL, |GetCategories()| refreshes the order before returning

+1 test.

BUG=673743

Review-Url: https://codereview.chromium.org/2581163004
Cr-Commit-Position: refs/heads/master@{#439766}

BUG=675907
TBR=jchaffraix@chromium.org, mstensho@opera.com
NOTRY=true

Review-Url: https://codereview.chromium.org/2590163002
Cr-Commit-Position: refs/heads/master@{#439765}

Calling RenderProcessHost::FromID() directly prevents us to write
unittests. Add a virtual method for getting RenderProcessHost so that
testing code can use MockRenderProcessHost to write unittests.

Also, this CL installs a MemoryCoordinatorDelegate in unittests so that
unittests can have wider coverage.

BUG=675811

Review-Url: https://codereview.chromium.org/2594513002
Cr-Commit-Position: refs/heads/master@{#439764}

If the password generation popup was accepted by the user, the vote (ACCEPTED) will be always sent (because of automatic saving for generated passwords). If the popup was ignored, the vote (IGNORED) will be sent only if the user presses "Save" or "Update", otherwise the vote wouldn't be sent. This distorts the data about the usage of generation popup. This CL enables sending the votes regardless user's response.

This CL also merges two similar functions UploadPasswordForm and UploadChangePasswordForm into UploadPasswordVote.

BUG=552420

Review-Url: https://codereview.chromium.org/2542093002
Cr-Commit-Position: refs/heads/master@{#439763}

BUG=675902

Review-Url: https://codereview.chromium.org/2595473002
Cr-Commit-Position: refs/heads/master@{#439762}

The PRD has been changed, so now we should not show the "More" button
in the Physical Web section.

BUG=674897

Review-Url: https://codereview.chromium.org/2590143002
Cr-Commit-Position: refs/heads/master@{#439761}

Meaning that the histogram is not actually recorded (yet).

Review-Url: https://codereview.chromium.org/2588813002
Cr-Commit-Position: refs/heads/master@{#439760}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a011eb0a..75c2c8d4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2595433002
Cr-Commit-Position: refs/heads/master@{#439759}

positionForPoint() wants this, but mapAncestorToLocal() requires that no
special behavior be applied.

While this CL doesn't fix bug 663062, it is a prerequisite for fixing it
without breaking existing tests (MulticolWithAbsPosNotContained in
MapCoordinatesTest unit test).

BUG=663062

Review-Url: https://codereview.chromium.org/2590463002
Cr-Commit-Position: refs/heads/master@{#439758}

Fix content settings for hosted apps not displayed correctly after change from http://crrev.com/2525943002. I also changed GetChooserExceptionForPage() to have a displayName to be consistent with the other exception objects.

BUG=671547

Review-Url: https://codereview.chromium.org/2577043002
Cr-Commit-Position: refs/heads/master@{#439757}

registerLoadRequest must take a URL as it is comparing it with a URL.

BUG=671964

Review-Url: https://codereview.chromium.org/2582373002
Cr-Commit-Position: refs/heads/master@{#439756}

FileBrowser.Load.BackgroundScript:
  Time to initialize backend script to wait for events.
FileBrowser.Load.BackgroundLaunch:
  Time from onLaunched event is called to the window is created.
FileBrowser.Load.BackgroundRestart:
  Time to create a window on restart.

BUG=675536
TEST=manually confirmed on Linux that sane values are exported in
chrome://histograms

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2585193002
Cr-Commit-Position: refs/heads/master@{#439755}

EGTests don't have the application group entitlement.
Disable the Receiver in that case.

BUG=675412

Review-Url: https://codereview.chromium.org/2588683002
Cr-Commit-Position: refs/heads/master@{#439754}

Previously, form-not-secure was enabled as its own value of the
--mark-non-secure-as flag. That value also enabled the "Not secure" omnibox
warning. Also, the autofill code that checked for the command-line flag
didn't allow us to enable it via Finch.

This CL moves the form-not-secure warning into its own Finch feature and
corresponding chrome://flags flag. This lets us turn it on and off via Finch,
independently from the "Not secure" omnibox warning that is controlled by
--mark-non-secure-as.

BUG=674320

Review-Url: https://codereview.chromium.org/2588133002
Cr-Commit-Position: refs/heads/master@{#439753}

Specification: https://webaudio.github.io/web-audio-api/#widl-AudioContext-getOutputTimestamp-AudioTimestamp

BUG=619533

Review-Url: https://codereview.chromium.org/2587223002
Cr-Commit-Position: refs/heads/master@{#439752}

Reland of load: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2593533002/ )

Reason for revert:
This is not culprit

Original issue's description:
> Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ )
>
> Reason for revert:
> Caused browser_test failure:
> https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740
> https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090
>
> Original issue's description:
> > Reload: "Request desktop site" feature should ask reposting
> >
> > Now Android Chrome does not confirm if it is expected to repost a form
> > on selecting "Request desktop site".
> >
> > This change modifies to ask it as we do in other cases.
> >
> > If a user reject reposting, the navigation switches to use desktop user
> > agent strings as usuals, but only for the next navigation and
> > following ones.
> >
> > BUG=675522
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704
> > Cr-Commit-Position: refs/heads/master@{#439727}
>
> TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=675522
>
> Committed: https://crrev.com/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d
> Cr-Commit-Position: refs/heads/master@{#439749}

TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675522

Review-Url: https://codereview.chromium.org/2587343002
Cr-Commit-Position: refs/heads/master@{#439751}

See bug for context. This patch begins the implementation of
more limited accessibility modes by only fetching a subset of
accessibility attributes from Blink unless more are explicitly
needed.

Only Windows is affected initially. By default now when
accessibility support is enabled on Windows, only a few
key accessibility attributes are fetched, like role, state, name,
value, and location. As individual APIs are accessed that go
beyond these, Chrome's accessibility mode is automatically
changed to start fetching more.

Screen readers are unaffected by this change. I manually
tested JAWS and NVDA.

Password managers and single-sign-on software should
continue to work fine, but users should experience a
performance boost.

BUG=672205

Review-Url: https://codereview.chromium.org/2581483002
Cr-Commit-Position: refs/heads/master@{#439750}

Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ )

Reason for revert:
Caused browser_test failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090

Original issue's description:
> Reload: "Request desktop site" feature should ask reposting
>
> Now Android Chrome does not confirm if it is expected to repost a form
> on selecting "Request desktop site".
>
> This change modifies to ask it as we do in other cases.
>
> If a user reject reposting, the navigation switches to use desktop user
> agent strings as usuals, but only for the next navigation and
> following ones.
>
> BUG=675522
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704
> Cr-Commit-Position: refs/heads/master@{#439727}

TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675522

Review-Url: https://codereview.chromium.org/2593533002
Cr-Commit-Position: refs/heads/master@{#439749}

The HeapListHashSet<> iterators keep a pair of heap references, which
really should be traced like any other such reference during GCs. This
isn't unsafe for the stack allocated uses of these iterators, but one
Blink object (CSSSegmentedFontFace) keeps an iterator as a field on the
heap, we really have to trace these on-heap part object iterators.

Add the needed infrastructure and use it for CSSSegmentedFontFace.

R=haraken
BUG=672030

Review-Url: https://codereview.chromium.org/2583363002
Cr-Commit-Position: refs/heads/master@{#439748}

This changes the left and right arrow symbols into text (e.g. "left arrow"),
reducing ambiguity.  It also promotes cmd-[ over cmd-left on Mac.

BUG=637547
TEST=On a new profile, have a page in your "back" session history, then hit backspace twice while outside a textfield to trigger the "Use alt-left to go back" UI.  It should say "Left arrow" instead of "<-".

Review-Url: https://codereview.chromium.org/2540523003
Cr-Commit-Position: refs/heads/master@{#439747}

BUG=663601
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2594583002
Cr-Commit-Position: refs/heads/master@{#439746}

This reverts commit 063b9902.

Original comment:
Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739
Committed: https://crrev.com/063b99026eca67b274692d0879bfdbcd0c9b5008
Cr-Commit-Position: refs/heads/master@{#439740}

TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chromium.org,dfalcantara@chromium.org,
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2588323002
Cr-Commit-Position: refs/heads/master@{#439745}

Some of them have already been marked as flaky, but others look also flaky.

BUG=610300
TBR=drott@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2590793002
Cr-Commit-Position: refs/heads/master@{#439744}

joined by ','.
Now, FetchHeaderList::get() is iterating all header list and
append strings to a result joined by ','.

BUG=645497

Review-Url: https://codereview.chromium.org/2587463002
Cr-Commit-Position: refs/heads/master@{#439743}

DataUse.AppTabState UMA is recorded with the following dimensions.
  Upstream.AppBackground
  Upstream.AppForeground.TabBackground
  Upstream.AppForeground.TabForeground
  Downstream.AppBackground
  Downstream.AppForeground.TabBackground
  Downstream.AppForeground.TabForeground

BUG=673820

Review-Url: https://codereview.chromium.org/2583703002
Cr-Commit-Position: refs/heads/master@{#439742}

Using GL_DEPTH_STENCIL_ATTACHMENT in GL_EXT_discard_framebuffer results
in a INVALID_ENUM gl error. Hence, we must prevent InvalidateFramebufferImpl
to generate such an attachment in this case.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2583183002
Cr-Commit-Position: refs/heads/master@{#439741}

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Review-Url: https://codereview.chromium.org/2579823003
Cr-Commit-Position: refs/heads/master@{#439740}

This CL converts push event IPCs into mojo interface:
  ServiceWorkerMsg_PushEvent
  ServiceWorkerHostMsg_PushEventFinished

BUG=629701
TEST=content_unittests

Review-Url: https://codereview.chromium.org/2569993002
Cr-Commit-Position: refs/heads/master@{#439739}

[CrOS Tether] Create ble_constants.h/cc, which include common constants to be shared among multiple BLE-related classes.

BUG=672263

Review-Url: https://codereview.chromium.org/2590553003
Cr-Commit-Position: refs/heads/master@{#439738}

This UI was experimental and is not going to be released.

BUG=562280

Review-Url: https://codereview.chromium.org/2552903003
Cr-Commit-Position: refs/heads/master@{#439737}

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2584893002
Cr-Commit-Position: refs/heads/master@{#439736}