- 10 Sep, 2020 40 commits
-
-
Robert Sesek authored
Under the sandbox, _CSCheckFix() can result in a lot of unnecessary disk I/O. Bug: 1110292 Change-Id: I8507156d75fa046b3d5be1d5b0121abce0967af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401334 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805864}
-
Jordan Taylor authored
This issue was fixed in the following CL by changing the calculation for inherited_time that gets passed to effects in Animation::Update. https://chromium-review.googlesource.com/c/chromium/src/+/2092188 This CL is adding test coverage for the issue. It has been verified to fail without the above changes. Bug: 1082504 Change-Id: I4a15a0dcd23f351fd5fb9e659693d6c803937360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393059 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#805863}
-
Liquan (Max) Gu authored
Change: * Move parseAndValidateDetails() into PRSpec. * Assign id in PRSpec constructor as opposed to after parsing details. Bug: 1102522 Change-Id: Ie292c723ee26c4f6237115f6d1dc367319aa031a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391264Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805862}
-
Ryan Keane authored
This CL adds a new class skeleton, to be implemented in a future CL and used in AudioPipelineImpl and CastAudioOutputStream. Bug: b/167424911 Change-Id: I3dd799f29808a5046b983195120df393b1514510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401305Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#805861}
-
Josiah K authored
Same as original CL below, but with a less flaky test. https://chromium-review.googlesource.com/c/chromium/src/+/2388402 Change-Id: Ie689601521e88affd7569ab1adfaad840660bc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402579 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805860}
-
Ghazale Hosseinabadi authored
DevToolsWindowCreationObserver::WaitForLoad clears its MessageLoopRunner right when DevToolsWindowCreated is called, this means the runner would be destroyed while its QuitClosure is running. This CL fixes the issue by moving the destruction after MessageLoopRunner::Run(). This bug is evident when there is no DevToolsWindow at DTWCObserver instantiation time. This CL adds a regression test for that. Bug: 1126105 Change-Id: I68b122c657abbc9a0ecca7875ed19dc6d33914eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363886Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#805859}
-
Maksim Ivanov authored
This reverts commit 8f840cb8. Reason for revert: The tests, as reported, should pass now. Original change's description: > [Sheriff] Disable graphics.TraceReplay.glxgears_stable > > It has been failing consistently on CrOS bots. > This disables it. > > Bug: 1123872 > Change-Id: I79152a991118af02a215e3f809c50f42c12d24cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387101 > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803459} TBR=emaxx@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123872 Change-Id: I676d000fb95648985a533b1ef860d50dedf7d129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404580Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805858}
-
Eugene Zemtsov authored
Bug: 1124933, 1121794 Change-Id: Ic8089d8793ffdb0bff0cb40da12582bc3b891f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402280 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805857}
-
rbpotter authored
- Change PdfAccessbility tests to validate only the accessibility tree for the embeddedObject (i.e. the PDF), and not other containers on the page. With this change, the tests pass with the update enabled. - Parameterize all accessibility tests to run in both flag states. Bug: 1120279 Change-Id: Ie7ece749af71da48ac39c5ebdd947e26f09f271b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393245 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805856}
-
Ayu Ishii authored
This change removes matchType option from CookieStoreGetOptions. This decision has been discussed here [1], and will be revisited after launch to re-evaluate if the option is good to have or if we should do a full cleanup of the option. [1] https://github.com/WICG/cookie-store/issues/128 Bug: 1124497 Change-Id: I845c6e872aa25d138114ccf0b0a74332adeb650d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402132 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805855}
-
Reda Tawfik authored
1) Adds list all user credentials to the Model from the Mediator. 2) Adds the credential model to properties class. 3) Creates a ViewHolder for the credential view. 4) Implements the Adapter for the RecyclerView. 4) Implements |bindCredentialView()|. 5) Sends focused field type from native to java. 6) Adds a test to check if the model updates the view properly. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c11 Bug: 1104132 Change-Id: I4606a13214f5e815bce41207e72cde6caed60fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370542 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805854}
-
Fredrik Söderqvist authored
This has only one actual user - AnimatedPropertyTypeSupportsAddition() which is only called when the animation has a target. Since a test reads the type add GetAnimatedPropertyTypeForTesting(). Bug: 1017723 Change-Id: Iaada97a2d281c0067f73f44a80f9e84837ca951d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403471Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805853}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/625eb197594e..feb1579dfb25 2020-09-10 treehugger-gerrit@google.com Merge "metrics: Extend metric proto before registering metric" 2020-09-10 treehugger-gerrit@google.com Merge "traceconv: add missing flush in output writer" 2020-09-10 treehugger-gerrit@google.com Merge "Add back reserved lines commented earlier" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4c916d735961aeb4cd154a94e34d6e6543cc33d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805852}
-
Batalov Vladislav authored
Android can throw an exception during checking scheme. https://cs.android.com/android/platform/superproject/+/master:frameworks/base/media/jni/android_media_MediaDrm.cpp;l=987?q=throwExceptionAsNecessary It seems like there is no reason to not catch it neither. Change-Id: Ib6b1e889f3849a24372a0a3f0601c5f5193da9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401099Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805851}
-
Eric Willigers authored
DirectSocketsServiceImpl::OpenTcpSocket() now calls CreateTCPConnectedSocket() on the network context. Browser test DirectSocketsBrowserTest.OpenTcp_Options verifies that the remote address, port, buffer sizes and no-delay flag are passed successfully. NavigatorSocket::PendingRequest has been split into TCPSocket and UDPSocket classes, currently with no web-exposed members implemented. https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#tcp https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#udp Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I7030f73d4863767b3d51a615fd84380148011bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391181 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#805850}
-
Matthew Mourgos authored
Bug: 1080827, 1122723 Change-Id: I8349f698e9c403a53d3c265380337be35c024402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399620Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805849}
-
Mei Liang authored
This CL adds the following a11y support to the TabSelectionEditor: * Adds content description to the TabSelectionEditorLayout and announces the description when TabSelectionEditor shows to screen. * Update the TabSelectionEditorToolbar navigation button content description. Everything introduced in this CL is gated by field trial under the enable-tab-grid-layout flag and the enable-tab-groups-continuation flag. All Java code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The changes in the tab_selection_editor_layout.xml can't be verified by the tool, but it is expected. Without both flags, it is a no-op. Bug: 1124919 Change-Id: I2a4a7ff575808d71e8a4594ee158ca45a87a006f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399314 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805848}
-
Mike Wittman authored
Updates the test expectation to account for the component debug ASAN build using a .cr.so extension on the base unittests module. Bug: 1126928 Change-Id: I49fba26c817d6e2e1b0aeeedadea8f440e4d6a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404301 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805847}
-
Tamir Duberstein authored
The referenced bug never tracked this test. Change-Id: I6c36f578482742bcbcf7b4054b7fadcd62c12a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403701Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#805846}
-
Olivier Yiptong authored
This change logs the time it takes to enumerate fonts on Mac using a UMA histogram. Bug: 1043306 Change-Id: I9bbed21d4004d6c2c30184bf6770360e7cb7c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403589 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#805845}
-
Thomas Tellier authored
Bug: 1066489 Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#805844}
-
Xianzhu Wang authored
These functions are used in DCHECK only. The guards make it clear that these functions don't affect release production. Change-Id: Ia1fb5e1a7208f53a8e120f82340c75057de852e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398914 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805843}
-
Siyu An authored
Bug: 1082013 Change-Id: Ic6736d65ff962a400cd0cd714ca27a25200346c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401849Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#805842}
-
Mark Cogan authored
This CL fixes a variety of issues that will cause crashes or timeouts in EG and unit tests with the multiwindow flag enabled: - InstallationNotifier will keep polling forever by default, and since it's a singleton that lives through the whole test app's lifetime, it can hit DCHECKs when objects it depends on get eventually deallocated. This CL adds a method to stop polling, and uses it in the download manager test (which was triggering the polling). Long-term, this shouldn't be a singleton. - SelectorCoordinatorTest needed to have explicit timeouts added to some waits; it was spinning forever in the simulator with MW enabled. - PassphraseTableViewControllerTest needed to create some dummy state objects, because one of the settings view controllers grabs the scene state. There are several layers of cleaner fixes possible here -- refactoring the view controller to not access model/app objects, etc. - The history and bookmarks EG tests include tests for opening new windows, but they cause various EG test failures when they are actually run with the flag enabled. With this CL in place, there are still numerous unit test *failures* with multiwindow enabled, but not any crashes or timeouts. (Prior versions of this CL enabled multi-window on trunk; it now doesn't do that). Change-Id: Idde141baa4f28d17828367fb359630723c2d12dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310676 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#805841}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b117e76f5dc..fb8d5f7d60cb 2020-09-10 jobay@google.com Typecheck quick_open/FilteredListWidget.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If8f2e3c08d38791c856383f25f4be00dd6bb5d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403942Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805840}
-
Dave Tapuska authored
Synthetic events injected had a static timestamp. In https://chromium-review.googlesource.com/c/chromium/src/+/2235936 static timestamps were used but the real timestamp should be used. This change reverts the code back to the original. BUG=1122950 Change-Id: I52a825365fe658ab8803fea8e6ffb908b77b719b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398971Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#805839}
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123990 Change-Id: Ib1c94aa4980503ab90857f716f334d42a3cb4b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396220Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#805838}
-
Ian Kilpatrick authored
Fixes: 1002815 Change-Id: I0c727fa8714f4a996db6b0d44c39be2a409a4c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404261 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805837}
-
kylechar authored
A crash has been traced back to a deserialization error on the viz.mojom.FrameSinkManager RegisterFrameSinkHierarchy IPC. Add some CHECKs to identify the root cause of bad FrameSinkId(s) being sent. Bug: 1115094 Change-Id: Ie8aaf54bdddfb6d649b1386ac62edfb0df639cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403581Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805836}
-
Luum Habtemariam authored
The URLLoaderFactory interface grabbed from g_process can become invalidated, like on network changes, so we can't save it. This change modifies PpdProvider to grab it fresh before every fetch. Test: chromeos_unittests passes Bug: chromium:1123567 Change-Id: I2718548c45b61b34d78c17966037e8ccb91d654f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389020Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#805835}
-
Peter Kasting authored
Bug: none Change-Id: I391f332af03db0d79877b0983c2060fc3f6bfaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385239 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805834}
-
Andrew Grieve authored
Also update comment about .ndjson->.size Bug: 1123778 Change-Id: I3f7465d5babcb990da23cefee0582589a15e44a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404142 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805833}
-
Owen Min authored
The command line swtiches --device-management-url and --realtime-reporting-url are disabled on Window, Mac, Linux, Android on Beta and Stable channel. They are still allowed in Dev, Canary, trunk and browser tests. The are still allowed on Chrome OS without any additional condition. Bug: 1119515 Change-Id: I8b78b030e06e4339e374387004d4e8e37ab863f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382870 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805832}
-
Charlie Hu authored
This CL fixes a crash caused by having a stand alone default feature(*) in document policy header/policy attribute. Bug: 1124853 Change-Id: I2ac5ef051e19e2b729a7e80724a1deedc1d333da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403584 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#805831}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/498d5ea20aed..9427c97d9c29 2020-09-10 bryan.bernhart@intel.com Fix ASSERT in WindowsDebugLogger again If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id2c0eb72dd979f2da6e83bdb81639fa2201da755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805830}
-
Josh Nohle authored
When the Nearby Share service is created, start the certificate, contact, and local-device-data managers. No manager tasks are run until the managers are started. We also add logging. Change-Id: I9ee592d181f1fbe670318d364b3a5fec4dec45b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370924 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805829}
-
Prakhar authored
Pending build time looks within limits as of now: http://shortn/_knva2rUxM9 (except for a single spike) Bug: 1024915 Change-Id: I48263543636a7d47c02164f183d85e24983dab1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404220 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#805828}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rr3VhMXsq7y_PFGfYuF4xO5k6h8d3dTyYtD20gc4jK8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/128567301,b/138961540,b/159892033,b/161761740,b/162294373,b/162706572 Tbr: media-app@grotations.appspotmail.com Change-Id: Ief0ec7ac5c174ac0de829ff6b2a19deffa470bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805827}
-
Matthias Körber authored
The missing groups result in a DCHECK fail when votes for the new types are generated. Change-Id: Id8000421161b382d7d3d35dcd95c9f8411a19faa Bug: 1126957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403472Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#805826}
-
Alison Maher authored
Handle :visited background-colors in a similar way to the normal background-color property in Forced Colors Mode. Bug: 970285 Change-Id: I1dd0ac2530f3dec7de4b79de459d34e1d2ae193b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393299Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805825}
-