- 21 Nov, 2019 40 commits
-
-
David Van Cleve authored
This adds WARN_UNUSED_RESULT to some methods in //base/strings whose primary purpose is to return something useful (e.g. StrCat). When the results of these methods go unused, it's usually caller error and will be found by the caller later (for instance, when their tests fail). WARN_UNUSED_RESULT makes this fail earlier, at compile time. Precedent: Abseil's StrCat, etc., all use ABSL_MUST_USE_RESULT. Change-Id: I8262b03bd844118c7337861f323417c2bb92ddda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925251Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#717633}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kinuko@chromium.org Bug: 1023677 Change-Id: I5402fab8e9fb1e50fa3f765f956f22feb57f62f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926802 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#717632}
-
Greg Thompson authored
This change introduces RelaunchIgnoreUnloadHandlers and uses it in RelaunchNotificationController when the deadline for a forced relaunch is reached. This new function is to AttemptRelaunch as ExitIgnoreUnloadHandlers is to AttemptExit. This also introduces browser_shutdown::ShouldIgnoreUnloadHandlers(), which is a convenience for code that needs to know whether or not an in-progress shutdown should ignore unload handlers. (cherry picked from commit 2c98cab9) BUG=958865 TBR=treib@chromium.org Change-Id: I291543b924d7b249093297a952ffa5c48f5343fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924197 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717631}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9754ff5ac01931763d75e010459e6480f9d22e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#717630}
-
Mohsen Izadi authored
Last usage of ui::Compositor::SetLatencyInfo() was removed in r564765. Change-Id: I0f93e7bc5e5473040dc3e4c82dcf42cbded28daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925817 Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#717629}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4d15609d269e..0d4a7b0ba5b7 git log 4d15609d269e..0d4a7b0ba5b7 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 cwallez@chromium.org Correctly reset mappedData in MapTwice buffer test Created with: gclient setdep -r src/third_party/dawn@0d4a7b0ba5b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I47b25a9ad7e72b89ce4afe64b1c000d905c1fc26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929131Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6dd488b2e551..e835fc01b1a9 git log 6dd488b2e551..e835fc01b1a9 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 henrik.lundin@webrtc.org Add UMA counter for audio interruptions 2019-11-21 titovartem@google.com Fix writing into closed FrameWriter when dumping video in PC framework 2019-11-21 mbonadei@webrtc.org Remove dependencies on Chromium's webrtc_overrides. 2019-11-20 mbonadei@webrtc.org Preventively fix missing braces warnings. 2019-11-20 jonaso@webrtc.org Split P2PTransportChannel 2019-11-20 kuddai@webrtc.org Add absolute capture time property to rtp sources. 2019-11-20 henrika@webrtc.org Clarifies identification of default communication device in ADM2 2019-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8b5b046f..022da7ca (715044:716991) Created with: gclient setdep -r src/third_party/webrtc@e835fc01b1a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: If0b5bf82f2aabf584ff25d8be29548f267373265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929132Reviewed-by:
-
David Roger authored
This is now enabled by default and can be removed. TBR=jwd Bug: 777774 Change-Id: I6a77e9c160553ea4361be7794ae5a09b7f8f83b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919931 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#717626}
-
Ken Buchanan authored
By supporting the “publickey-credentials” feature policy[1][2], registrations and assertions can now be obtained in cross-origin iframes if the parent frame explicitly delegates that authority. This is gated on a feature flag in order that the UX can be updated prior to this being generally available. [1] https://w3c.github.io/webauthn/#sctn-iframe-guidance [2] https://w3c.github.io/webauthn/#sctn-feature-policy Change-Id: I188731cdc65079ecf287fb62b264b69afe2f3229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725211Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#717625}
-
Gauthier Ambard authored
Updates the icon to the new one. Fixed: 1026303 Change-Id: If0e16da06638b8e7d0504d513777c5d0b441303a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928783 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#717624}
-
byoungkwon ko authored
NDEFScanOptions dictionary spec was changed. So we should follow new spec for it. I updated the dictionary. Bug: 520391,1001507 Change-Id: I427b572e597bd55c719c18922b92c6419b473a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921930Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#717623}
-
Vaclav Brozek authored
CSVPasswordSequence is the new CSV parser for passwords, bound to replace the old one, PasswordCSVReader. While their implementation is different, their behaviour should remain the same. Currently, there is a big difference: while both parsers report the overall status/error of parsing the CSV, CSVPasswordSequence checks whether all data rows are correct representations of passwords, while PasswordCSVReader does not. PasswordCSVReader only checks that the CSV has a valid header row with all necessary columns defined, and then only returns PasswordForms from correctly parseable data rows (possibly none). This is illustrated, e.g., by the test DeserializePasswords_NonASCIIUrl. To match this behaviour in CSVPasswordSequence, this CL removes the data-rows-check from CSVPasswordSequence code for computing the overall status/error. It also modifies the CSVPasswordIterator to skip invalid data rows, similarly to how such rows are not represented among the vector of PasswordForms returned by PasswordCSVReader. The CL also adds appropriate tests and ensures that the remaining test scenarios for PasswordCSVReader are reflected in the tests for CSVPasswordSequence or its components. Bug: 934326 Change-Id: I37d75c5e6ffbcfe3c66f6b3230e541b04093759d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920668 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#717622}
-
Olya Kalitova authored
Initializes DBusThreadManager and CommandLine needed as a part of a policy_fuzzer setup. Bug: 1015318 Change-Id: I76255d093420b0975d5adec2feb50826d6027242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926492Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#717621}
-
Sylvain Defresne authored
Use a raw string to define the pattern passed to re.compile when defining ENV_VAR_PATTERN since it contains a '\\' that we do not want to be interpreted as a C string interpolated sequence (code currently works because \$ is not a valid C string interpolated sequence). Bug: none Change-Id: Iebb3946522ce097813b8904e9dfa0b48bca5cc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928782 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717620}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bb9ade82457a..536c641b7736 git log bb9ade82457a..536c641b7736 --date=short --no-merges --format='%ad %ae %s' 2019-11-21 mythria@chromium.org Update V8 runtime_stats to use different pattern for optimize background Created with: gclient setdep -r src/third_party/catapult@536c641b7736 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: None Change-Id: Ic46c6cb5d9e8c687c141b10d7a6ce5567a4afbe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928021Reviewed-by:
-
Eric Seckler authored
This reverts commit 7a502f46. Reason for revert: patch that caused the failures was reverted Original change's description: > Disable failing tests on android-go_webview-perf > > Disabling the following tests on android-go_webview-perf: > * system_health.common_mobile/browse:media:youtube:2019 > * system_health.common_mobile/browse:news:nytimes:2019 > * system_health.common_mobile/browse:news:cnn:2018 > > TBR=crouleau@chromium.org > NOTRY=true > > Bug: 1026822 > Change-Id: I2581e3c21158edff2563de628bfa41de7349271d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717272} TBR=crouleau@chromium.org,johnchen@chromium.org Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1026822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#717618}
-
Jit Yao Yap authored
A new login_screen_extension_ui namespace is added to replace the LoginScreenExtensionUi prefix (i.e. LoginScreenExtensionUiFooBar is converted to login_screen_extension_ui::FooBar). This namespace will cover code specific to UI presented by login screen extensions on the signin screen. Bug: 988379 Change-Id: I3896b175e195da44703e11c5a824b79c2ab2c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919928 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#717617}
-
Henrik Lundin authored
The underlying metric is added in https://webrtc-review.googlesource.com/c/src/+/160045. Bug: webrtc:10549 Change-Id: I8d4c9e14e4b73ede8021f286bc64c21c32cad120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925066 Commit-Queue: Henrik Lundin <hlundin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#717616}
-
Mathias Carlen authored
Before this patch we used the device/platform locale to set/get things in autofill profiles. That locale is dropped in the autofill code and not used at all. This patch removes the locale logic from two actions. The consequence now is that the mock in tests does not set the full name and that is used in the completeness comparison. The fix used here is to always construct the FullName from the first,middle,last triplet when needed. R=arbesser@google.com, marianfe@google.com Bug: 806868 Change-Id: I0835da87a07c409af8832cd052f6654372b8dcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926487 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#717615}
-
Anatoliy Potapchuk authored
Since we are moving away from good old base::Value in favour of the new one which is not able to do the expansion, we should be reading the data layer by layer, rather that simply concatenating them by a period ".". Bug: 1006230 Change-Id: Ica7298eb44f186adff00b2e565a8c85646806321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926767 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#717614}
-
Raphael Kubo da Costa authored
* Reorder arguments in ScriptIterator's constructor that takes a v8::Isolate. In general, functions that take a v8::Isolate* have it as the first argument. Make ScriptIterator's constructor follow suit for consistency. * Replace the ScriptIterator(nullptr_t) constructor with a default one. Taking a nullptr (as well as not making the constructor explicit) never made much sense in the first place. Change-Id: I19873f5e6c1996279c76029aa3303fe50a890023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928778Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#717613}
-
Sylvain Defresne authored
All private frameworks needs to be codesigned, so ensure they are signed (this is useful when using binary framework pre-compiled). Bug: 1012115 Change-Id: I9953c391bc3c203ce7b34055690a3cccd23d2acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926485 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#717612}
-
Dominique Fauteux-Chapleau authored
Adds round trip time for the user download access point, for each result value and bytes/sec for successful results. Bug: 1020267 Change-Id: I2eab7272afb71d3abf4a37e71da10bbdabcf5911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917464 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#717611}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: If2317def8d94c339c3a3bb8d8c6518347a718da8 Bug: 988343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928817 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
* Rename IDLDate to IDLDateOrNull to reflect the reality * Rename ToCoreDate to ToCoreNullableDate * Change |double| argument of InputType::SetValueAsDate() to base::Optional<base::Time> * Change |double| argument of |BaseTemporalInputType:: SerializeWithMilliseconds| to base::Optional<base::Time> * Rename SerializeWithMilliseconds to SerializeWithDate This CL has no behavior changes. Change-Id: I2d8476821317a4577ddcf26a2c88eb9809425ed9 Bug: 988343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928512 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#717609}
-
Tim van der Lippe authored
The Runtime exists in the Root namespace now. In an upcoming change in the DevTools frontend [1], the Runtime.js is loaded as a proper ES module, instead of injected into the build artifacts by the build system. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1926503 Bug: 1006759 Change-Id: Ifdd4c7329163637bb461d5466ba3efdc38ebc532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928705Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#717608}
-
Yi Su authored
Search engine setting should have the same trailing inset for separators as other settings. Bug: 937015 Change-Id: Ie9f75ebcb06c9fe927901490d4cb3ec607eab013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928776Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#717607}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fdbc1acec72f..bf492e4910bb git log fdbc1acec72f..bf492e4910bb --date=short --no-merges --format='%ad %ae %s' 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2377845dd216..f2c9ce1e08ed (4 commits) 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 40cd2166a446..39b3005ba560 (26 commits) 2019-11-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 720c5deb0244..53902309eda9 (9 commits) Created with: gclient setdep -r src/third_party/angle@bf492e4910bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Ie398ebdeb8500f5859570c045a30db14bdebcdc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928019Reviewed-by:
-
Maksim Sisov authored
Previously, we've assumed that the tooltip manager never shows tooltips if a mouse pointer is hovered over a popup window. This lead to wrongly placed tooltips whenever one was shown right below a popup window (like the one shown when a user clicks on a bookmarks' folder), and as long as the tooltip manager always places tooltips in screen coordinates and the WaylandWindow used that popup window as a parent window, the tooltip has had an offset equal to the position of that popup window in regards to a toplevel window. Basically, it looked like that: toplevel window __________ | _____ | | |popup| | | ----- | | __ | | |tp|| | -- | ---------- Where tp is the tooltip and is a child of a popup surface, but positioned relatively to the toplevel window. The origin of each window looked like this: toplevel - 0,0 popup - 10, 10 (relative to the toplevel) tp - 15, 15 (relative to the toplevel) Instead, the tp must be positioned relatively to the popup window: toplevel window __________ | _____ | | |popup| | | |tp| | | | ---------- And the origin became the following: toplevel - 0,0 popup - 10, 10 (relative to the toplevel) tp - 5, 5 (relative to the toplevel) Also fixed the way how the tooltips are hidden and stopped caching the parent as long as the tooltips may be potentially reused and shown for different parents. Test: WaylandWindowTest.TooltipSimpleParent, WaylandWindowTest.TooltipNestedParent Bug: 1026600 Change-Id: I4a89e70f2e99010b6c76a3f12176d8ff51671bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926318 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#717605}
-
Greg Thompson authored
- Make ShutdownType an enum class. - Introduce browser_shutdown::HasShutdownStarted as a convenience. - Switch from UMA macros to functions for one-shot metrics. (cherry picked from commit 11936b31) BUG=958865 Change-Id: I2c6c018f1b2b298f19cdde819477ab084f2d1c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924192Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#717604}
-
Roman Aleksandrov authored
Add all needed functionality for the new Packaged License screen. Bug: 1024809 Change-Id: Ic7f4a3a8b5d64d414bf317d52e6acd4bc1f79426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904198Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Tim Schumann authored
EnableDisableSingleClientTest are parametrized tests that were missing their instantiation which caused them not to be run. This was an oversight in https://chromium-review.googlesource.com/c/chromium/src/+/1895797 Change-Id: Ib2d44a11dbc3f2fe28818ced27877cd8c4116bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928696Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#717602}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94b4a0baf8bc..7fa83680ccbb git log 94b4a0baf8bc..7fa83680ccbb --date=short --no-merges --format='%ad %ae %s' 2019-11-21 hablich@chromium.org [Infra] Whitespace change for testing Created with: gclient setdep -r src/third_party/devtools-frontend/src@7fa83680ccbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021467 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I97d63b54eeac175acf88a2e72619cca2df7afdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928971Reviewed-by:
-
Clemens Arbesser authored
This CL fixes a bug in the bottom sheet where size change notifications while in SCROLLING state where ignored. See the linked bug for more information. Bug: b/144838045 Change-Id: I825ed22c2078873fcf7295f86e99d4b14b01cc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926479Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#717600}
-
chrome://policyVladislav Kuzkokov authored
Bug: 1018466 Change-Id: I8e1478be2ed448105354fa6dcb15cbfa241be512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926949Reviewed-by:
-
Jonathan Ross authored
This reverts commit 24689a76. Reason for revert: Suspect this breaks SnapshotBrowserTest.SingleWindowTest going to do a trybot run Failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20%28Intel%20HD%20630%29/3704?blamelist=1#blamelist-tab Original change's description: > Use Skia API for Vulkan readback > > This CL switches to using new Skia API for GPU accelerated readback > with the Vulkan backend. Subsequent CL will also switch over GL > backend from (GLRendererCopier). > > Notable changes: > a) Using asynch GPU readback instead of synch CPU readback. > > b) Modified the test infrastructure to use Skia API to force a flush > of GPU pipeline (so that it works on Vulkan). This guarantees that > asynch readback completes. > > c) Instrumented LayerTreePixelTest with a flush. This path did not have > a flush on it previously. This was necessary to make cc_unittests > pass with TSAN builds (which change timing). > > Bug: 1022495 > Change-Id: I35a8d4b9ceab96455d179b91c68528228fbb4962 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917622 > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717143} TBR=penghuang@chromium.org,backer@chromium.org,kylechar@chromium.org Change-Id: I53efac647f62a7bf237af5019fe70df2afcbe923 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927224Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#717598}
-
Francois Beaufort authored
This CL adds UKM counters to NDEFReader.scan and NDEFWriter.push. Bug: 520391 Change-Id: I33e8f8ad90b20871eb24622531c93ce387d873f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910089 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Morten Stenshorne authored
When block-fragmenting, we always need to know the block-start offset before laying out anything. To calculate the block-offset of a float, we need to know its inline-size, to figure out if it can fit beside earlier floats or not. To calculate its inline-size, we have to lay it out. This means that we may need to guess its block-offset and lay it out. After layout we know the inline-size of the float, and then we can calculate its exact position. If our initial guess was wrong, we need to lay out again at the correct position. A different block-offset may lead to different fragmentation inside the float. Bug: 829028 Change-Id: Ibef71d124704116d788cd755467a26d4c26ada4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926315Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#717596}
-
Andrew Bennetts authored
Bug: 998357 Change-Id: I72329cc53c7526d6bb62dc1fd6346c0178bc8785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914590Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Andrew Bennetts <abennetts@google.com> Cr-Commit-Position: refs/heads/master@{#717595}
-
Maksim Sisov authored
To avoid adding more platform specific interfaces, it is better to extract the APIs into platform extensions. The platforms are then free to implement the interfaces and set a property for that specific extension on the platform window they implement. This allows more flexibility and makes ui/views less platform dependent. This change extracts workspace related APIs into a separate extension. Bug: 1016556 Change-Id: Ieed247f908d258f2b6edb93aa263f0433767e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917765 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#717594}
-
