GitLab

Revert of Migrate IME state update flow (patchset #4 id:100001 of https://codereview.chromium.org/2777223004/ )

Reason for revert:
This patchset caused a regression crbug.com/709349: 'cut' option disappeared from webview selection pop up.

Original issue's description:
> Migrate IME state update flow
>
> Refactored the flow for IME state update so it bypasses CVCImpl
> and go straight from RWHVA -> ImeAdapter native -> Java layer.
>
> Other related changes are:
>
> ImeAdapter provides EventObserver to reduce the dependency on CVC,
> based on the suggestion made in https://goo.gl/pdtQCl. It is used
> by an embedder (Chrome) and CVC to deal with IME notification.
> This replaces IME state update done through CVC. Only the necessary
> info (node editability, password attribute) are passed.
>
> ImeAdapter.ImeAdapterDelegate is to delegate some work upon IME
> events. But it is used by ContentViewCore only, and there is no
> clear benefit of having the interface. It was removed for
> simplification. All the stuff can be (and are now) handled inside
> ImeAdapter.
>
> BUG=662908,626765,620172
>
> Review-Url: https://codereview.chromium.org/2777223004
> Cr-Commit-Position: refs/heads/master@{#462419}
> Committed: https://chromium.googlesource.com/chromium/src/+/cc9e77e7d9e05da0f6017f1bdea024f0ce669786

TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=662908,626765,620172

Review-Url: https://codereview.chromium.org/2803203003
Cr-Commit-Position: refs/heads/master@{#463053}

DelayedInvalidationsController stores all invalidations that come while Chrome
is backgrounded. The list of invalidations can grow arbitrarily long even though
only highest versions of invalidations for each object are needed.

In this change I'm making DelayedInvalidationsController discard lower versions
of invalidations when receiving new invalidation.

BUG=705765
R=nyquist@chromium.org

Review-Url: https://codereview.chromium.org/2798613002
Cr-Commit-Position: refs/heads/master@{#463052}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a
|CaretDisplayItemClient| type and a |caretDisplayItemClient| accessor
method in the CaretDisplayItemClientTest class (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |CaretDisplayItemClient| being the name of
both the type and the accessor method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2803363002
Cr-Commit-Position: refs/heads/master@{#463051}

This is in preparation for the launch of MacOSX native notifications
where the property is not supported.

Intent to remove https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/IKGgHJOVMYE

BUG=571056

Review-Url: https://codereview.chromium.org/2803303002
Cr-Commit-Position: refs/heads/master@{#463050}

. Remove unused BrowserGpuChannelHostFactory::AddFilterOnIO().
. Use a weak-ptr to bind callbacks to GpuProcessHost, instead of looking
  up the GpuProcessHost from the host-id (using GpuProcessHost::FromID()).
. Remove some null checks for |gpu_channel_manager_| in GpuService,
  because it is created during initialization, and destroyed only in the
  dtor. None of the other callbacks should trigger before initialization.
  So the null checks should not be necessary.

BUG=none

Review-Url: https://codereview.chromium.org/2801943002
Cr-Commit-Position: refs/heads/master@{#463049}

This adds some basic TEAM and COMPONENT info for the top-level
//testing and //tools files and a few subdirectories, where either
the right owners are in infra or we don't really have good owners
but might as well pick something. This also adds a TEAM entry
for //build.

R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2800973004
Cr-Commit-Position: refs/heads/master@{#463048}

BUG=709271

Review-Url: https://codereview.chromium.org/2799323003
Cr-Commit-Position: refs/heads/master@{#463047}

BUG=709111
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2806023002
Cr-Commit-Position: refs/heads/master@{#463046}

This CL adds the initial wiring to GLib and
NativeNotificationDisplayService to get actions and closes working.

BUG=676220
R=thestig@chromium.org,peter@chromium.org

Review-Url: https://codereview.chromium.org/2805543005
Cr-Commit-Position: refs/heads/master@{#463045}

Changes:
(1) Intentionally remove SetStatusAreaVisible method as it doesn't save much code.
(2) For each screen-related status area visibility call, using UpdateStatusAreaVisibilityForScreen method.
(3) Add UpdateStatusAreaVisibilityForScreen in ShowCurrentScreen() to fix the bug.

BUG=708011
TEST=test that reporter's bug is fixed

Review-Url: https://codereview.chromium.org/2791223004
Cr-Commit-Position: refs/heads/master@{#463044}

The test is already pretty robust, but it mistakenly console.logs the
original orientation. Disabling logging solves the problem.

BUG=709426

Review-Url: https://codereview.chromium.org/2803233003
Cr-Commit-Position: refs/heads/master@{#463043}

Tablet devices don't like using the LocationBarPhone.  Switch
to using the LocationBarLayout as a generic class again.

BUG=708844

Review-Url: https://codereview.chromium.org/2799343005
Cr-Commit-Position: refs/heads/master@{#463042}

This CL implements gutter in the embedder.

In a nutshell, when a Fallback SurfaceInfo is set, the embedder computes
the right and bottom gutter layers if necessary.

It takes the difference between the window size and the fallback surface
size, and computes the position and size of the gutters.

The gutter layers are recomputed on window bounds change.

Window types EMBED_IN_OWNER and TOP_LEVEL_IN_WM always get a
ClientSurfaceEmbedder now.

Note that currently, if surface synchronization is turned on then the
frame rate will always be 15fps because SurfaceLayers may refer (and
block) on hidden windows that don't produce CompositorFrames. This will
be fixed in a subsequent CL.

BUG=672962

Review-Url: https://codereview.chromium.org/2797263002
Cr-Commit-Position: refs/heads/master@{#463041}

This CL enables callers to optionally set transient when starting a download.

BUG=700240

Review-Url: https://codereview.chromium.org/2791453003
Cr-Commit-Position: refs/heads/master@{#463040}

This CL adds a few more methods that cause name collisions when Blink
is rewritten to match Chromium style:
- dragOperation
- locationInBackingMap

BUG=582312
TBR=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2805133006
Cr-Commit-Position: refs/heads/master@{#463039}

BUG=709609

Review-Url: https://codereview.chromium.org/2807773002
Cr-Commit-Position: refs/heads/master@{#463038}

BUG=707651

Review-Url: https://codereview.chromium.org/2804383002
Cr-Commit-Position: refs/heads/master@{#463037}

This fixes a bug where pressing tab would move focus forward by two UI
elements.

There was a workaround in PlatformDisplayDefault that would synthesize a
duplicate ET_KEY_PRESSED for every key down in order to emulate Windows
WM_CHAR synthesis. See https://codereview.chromium.org/1234623004
The workaround isn't needed on mash, so I removed it.

I added a unit test, which required some small changes to
PlatformDisplayDefault and OzonePlatform.

Allowed the ui::ImageCursors parameter to be null because the test harness
does not provide the resource bundle needed for cursors.

Revert a workaround in InputMethodBridge for these synthesized events,
see https://codereview.chromium.org/2576973003/

BUG=706574,707055
TEST=added to mus_ws_unittests

Review-Url: https://codereview.chromium.org/2795503002
Cr-Commit-Position: refs/heads/master@{#463036}

It takes a couple seconds per file, so when you're renaming hundreds of
files it can look broken.

Format is:
[1/234] Moving: my_file.cc

BUG=none
TEST=manual, run it after a git mv

Review-Url: https://codereview.chromium.org/2807813002
Cr-Commit-Position: refs/heads/master@{#463035}

BUG=709208

Review-Url: https://codereview.chromium.org/2806023003
Cr-Commit-Position: refs/heads/master@{#463034}

Prior to this change, when we fetched the variations seed from Java could, it was
not using the correct restrict param in the URL. This change plumbs it through.
See bug for more details.

BUG=708713

Review-Url: https://codereview.chromium.org/2804043002
Cr-Commit-Position: refs/heads/master@{#463033}

We used to handle that through GlassPane, which has problems
with multiple layers of SoftContextMenus. Now we have a single
listener on bubble, and cancel all menus at that point.

BUG=709350

Review-Url: https://codereview.chromium.org/2801373002
Cr-Commit-Position: refs/heads/master@{#463032}

BUG=620517
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2801753003
Cr-Commit-Position: refs/heads/master@{#463031}

Remove CLC::id_to_item_controller_map_; rely on ShelfModel instead.
Skip removing shelf items in CLC destruction; rely on ~ShelfModel instead.

Remove CLC::[Get|Set]ShelfItemDelegate helpers; inline ShelfModel calls.
Remove moot ShelfModelObserver::OnSetShelfItemDelegate.

Rename CLC::LauncherItemClosed -> RemoveShelfItem.
Rename test helper GetAppLaunchers -> GetPinnedAppIds.

Inline ShelfModel::RemoveShelfItemDelegate helper function.
Avoid GetItemIndexForType, use GetShelfIDForAppID instead.
Use ItemTypeIsPinned helper function.

BUG=557406
TEST=Automated; no Chrome OS shelf behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2798173002
Cr-Commit-Position: refs/heads/master@{#463030}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ef8c92ef..7752f76e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2799413003
Cr-Commit-Position: refs/heads/master@{#463029}

R=sky@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2795883002
Cr-Commit-Position: refs/heads/master@{#463028}

This patch releases network blocking.

R=dgozman,pfeldman
BUG=709108

Review-Url: https://codereview.chromium.org/2804053002
Cr-Commit-Position: refs/heads/master@{#463027}

Using wpt-import in Chromium 1c9b66ff.

Not including changes in content-security-policy and service-workers, to avoid squashing any non-exported changes.

TBR=tkent@chromium.org
NOEXPORT=true

Change-Id: Iebb22ed36397fa5b2b6f3be058a3da244ae1a5e8
Reviewed-on: https://chromium-review.googlesource.com/471167Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463026}

This CL does a number of things to cleanup MediaClient's
implementation and usage. This clears the way for an expanded role
in describing MediaCapabilities.

Remove CastMediaClient. Merge methods into CastContentRenderClient.
  ContentRenderClient is now the one-stop-shop for embedder
  customization. I initially  explored giving each embedder its own
  MediaClient, but this ended up splitting media customization
  between ContentRenderClient and MediaClient (some customization is
  too high level to move to MediaClient). The current route is also
  less code.

Remove all Chrome specific logic from RenderMediaClient.
  RenderMediaClient is now the plumbing for *all* content embedder
  customizations to be visible in media/. Chrome is just one of many
  embedders and much of the chrome specific code was stale anyway.

Remove KeySystemNameForUMA from MediaClient interface
  Decentralizing this logic was overly complicated.
  Now centralized to key_systems.cc.

Other little cleanups
  Centralize all media/ Rappor usage in MediaLog.
  Move cast key_systems_cast into chromecast/renderer/media.
  Simplify key_systems_unittest.cc

BUG=695264

Review-Url: https://codereview.chromium.org/2712983004
Cr-Commit-Position: refs/heads/master@{#463025}

Code is changed to use aura directly.

BUG=687656
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2799993003
Cr-Commit-Position: refs/heads/master@{#463024}

for each QuicStreamFactory::Job created.

BUG=702411

Review-Url: https://codereview.chromium.org/2800023002
Cr-Commit-Position: refs/heads/master@{#463023}

This CL extends PictureLayerTiling to support tiles rasterized with scale and
translation. Tilings still use only the scale factor as their key. It is an
error to have tilings with the same scale but a different translation in the
same PictureLayerTilingSet. This CL implements a policy to evict old tiling
when syncing from a tiling set with a slot conflict.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2566613002
Cr-Commit-Position: refs/heads/master@{#463022}

This reverts commit dbce02f6.

Reason for revert:
Breaking cq presubmit step

Original issue's description:
> Update third_party/checkstyle to 7.6.1
>
> This CL updates third_party/checkstyle to 7.6.1 so checkstyle would
> work with Java 8 lambda features.
>
> BUG=703238
>
> Review-Url: https://codereview.chromium.org/2799303003
> Cr-Commit-Position: refs/heads/master@{#462968}
> Committed: https://chromium.googlesource.com/chromium/src/+/dbce02f63421f7d446d6ef317b456f6ae911f63b

TBR=agrieve@chromium.org,nyquist@chromium.org,jbudorick@chromium.org,klobag@chromium.org,jbudorick@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703238

Review-Url: https://codereview.chromium.org/2807753003 .
Cr-Commit-Position: refs/heads/master@{#463021}

Move UpdateCheckMark() from anonymous namespace of tray_accessibility.cc to tray_popup_utils.h
Then, it can be reused by AudioDetailedView and CommonPaletteTool.

BUG=707851

Review-Url: https://codereview.chromium.org/2803893002
Cr-Commit-Position: refs/heads/master@{#463020}

https://skia.googlesource.com/skia.git/+log/4e3abc1ad5f0..149e42ed194e

$ git log 4e3abc1ad..149e42ed1 --date=short --no-merges --format='%ad %ae %s'
2017-04-07 mtklein make SkAutoTMalloc self-move safe
2017-04-07 halcanary SkTypeface:: populate_glyph_to_unicode uniformly across platforms
2017-04-07 mtklein jumper, byte_tables + byte_tables_rgb

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I145bc055173785a462a0141cccfd079b0d74d83a
Reviewed-on: https://chromium-review.googlesource.com/471926Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#463019}

BUG=none

Review-Url: https://codereview.chromium.org/2804463002
Cr-Commit-Position: refs/heads/master@{#463018}

This is the 2nd CL in our 3-sided patches to rename 'ignore_swarming_task_failure' to 'ignore_task_failure'

BUG=709324

Change-Id: I52efa1bbfd57585e5e28abc6876acbf6ca88af41
Reviewed-on: https://chromium-review.googlesource.com/471046Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#463017}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.

BUG=704259

Review-Url: https://codereview.chromium.org/2752523005
Cr-Commit-Position: refs/heads/master@{#463016}

This CL does a refactor taking each encoder implementation into its own
file. Additionally, CanEncodeAlphaChannelForTesting() is removed as it
is no longer necessary.

BUG=700433

Review-Url: https://codereview.chromium.org/2793303003
Cr-Commit-Position: refs/heads/master@{#463015}

https://pdfium.googlesource.com/pdfium.git/+log/6a5c20cd0874..1835a6fb9828

$ git log 6a5c20cd0..1835a6fb9 --date=short --no-merges --format='%ad %ae %s'
2017-04-07 tsepez Tweak CFDF_Font::AppendChar()

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2804363002
Cr-Commit-Position: refs/heads/master@{#463014}