- 27 Jan, 2020 20 commits
-
-
Hiroshi Ichikawa authored
Bug: 1023250 Change-Id: I1a45f712fca7ce79c47f6dd11c858156f7afc8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016785 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#735323}
-
Matt Falkenhagen authored
The response URL is now used without breaking the DCHECK. This function uses |url_list_| and |response| to populate response_data->SetURLList(), with the service worker response url as necessary, but |url_list_| doesn't have the service worker response url. Bug: 553535 Change-Id: Id42bdb3b62d52be6b043ef16ff4a6347d8df1fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016807Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735322}
-
Koji Ishii authored
This patch changes |MoveTo(const LayoutObject&)| to eliminate unnecessary code paths due to the changes to culled inline boxes in r729656 <crrev.com/c/1774425>. More specifically, this patch changes the function not to return descendants when |NGFragmentItem| is enabled. This fix is needed for <crrev.com/c/2016822>. Bug: 982194 Change-Id: Ia9c6a86359543532aa70032c2752100a5878031b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016771Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735321}
-
Kenichi Ishibashi authored
When ServiceWorkerStorage is moved to the Storage Service it wouldn't be able to access live ServiceWorkerVersions directly. This CL moves live version lookup to ServiceWorkerRegistry as a preparation for moving ServiceWorkerStorage to the Storage Service. Bug: 1039200 Change-Id: Ib5458c558d719a004da11159083fc510d19c6bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015864Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735320}
-
Koji Ishii authored
r729656 <crrev.com/c/1774425> sets |NGInlineItem| for inline boxes without |NGPhysicalBoxFragment|, but failed to do so when bidi reordering moved placeholder. This patch fixes to set |NGInlineItem| even for that case. crrev.com/c/2016771 fails without this fix. Bug: 982194 Change-Id: I755b359cc2a177e667ff3f655ac147472707d081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021565Reviewed-by:
-
Victor Vasiliev authored
Instead, add a callback and only call exit in the CLI version Bug: 1044513 Change-Id: Ic0fafb21fea42bf48434c38243f9ba27935eb526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019789 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Eliot Courtney authored
This CL lets WaylandBufferManagerGpu allocate buffer ids for GbmPixmapWayland and WaylandCanvasSurface to make sure they are unique. Bug: 1039806 Bug: 1039429 Test: no collision between buffer ids Change-Id: I9c66c1fe234fac45e20dd8792353c93fa4a1cb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006907Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#735317}
-
Yuki Shiino authored
It looks only third_party/blink/web_tests/platform/mac-mac10.10/ media/video-layer-crash-expected.png has a different image. Maybe the expected image is mistaken. TBR=michaelludwig@google.com Bug: 1045050 Change-Id: I2d93f6bc49bb8947b33b639077624f6a23992b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022044Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735316}
-
Eric Stevenson authored
R8 has now added support (b/122902374) for this, fixing a few outstanding bugs related to class merging. This also makes build rules a bit simpler. Still need to switch Trichrome synchronized proguard over to using R8 for dexsplitting, then we can remove dexsplitter support entirely. This CL updates R8 with another patch, but does not change the R8 base version used. Binary-Size: R8 patch now keeping extra methods. Bug: 1032609 Change-Id: I79f88736c20d96b718eb129cdbd093fe1cd297b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014309 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#735315}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f93a317ccef9..05d914745a97 Created with: gclient setdep -r src-internal@05d914745a97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0ecb745f7ac01044a5de84c422b13fc861bebb1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735314}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I968c0df974c71c9d85ad457882459e8665e95cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022247Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735313}
-
Takashi Sakamoto authored
We will make UserLevelMemoryPressureSignal feature available on chrome desktop, because MemoryUsageMonitor is available on Linux, Windows and MacOS X now. The feature is disabled-by-default and is enabled only on Android by using GCL. So this change doesn't enable the feature on chrome desktop. Bug: 920922 Change-Id: Idbcdef6693ea3956a3f010065f5d21c5fb4594cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015474Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#735312}
-
Eriko Kurimoto authored
This CL adds WPT for a worker loaded from a data URL. This test is basically same to dedicated-worker-import-data-url.any.js Bug: 824646 Change-Id: I43faf747c9877c431157e2a3b71d3a2bbad05130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016784 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 9204d725. Reason for revert: This patch is suspicious to have made LocalNTPCustomBackgroundsThemeTest and LocalNTPBackgroundsAndDarkModeTest flaky. Original change's description: > Remove BrowserNonClientView::GetThemeProviderForProfile and just use GetThemeProvider. > > Change-Id: I9c458a7fe05c2ed60c1f9498dd0cea3cc3237455 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019923 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735051} TBR=pkasting@chromium.org,kylixrd@chromium.org Bug: 1045829 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I014ef51f6c76a4b461313e969224489f37f340f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022442Reviewed-by:
-
Eriko Kurimoto authored
This CL adds WPT for SharedWorker. It checks the behavior when NaN or Infinity is set to ScriptURL and WorkerOptions. Bug: 10399674 Change-Id: I12d9560ca77e3ed0258ec7ba92af08266ca3bde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015869 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Ionel Popescu authored
Prior to this CL an 2px outline-offset was used by default for links. Because we have seen many cases where the focus ring is seen chopped, this CL changes the offset back to 0px. Bug: 1044899 Change-Id: I1aa2246a0d4df63a3ad112293c9f8ddca26be29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020562 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Rachel Wong authored
Bug: 1014839 Change-Id: I040a679baa9785fd975fabc2253a5d7e9c560608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999973Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#735307}
-
Xing Liu authored
This CL finalizes the URL for announcment notification. TBR=dtrainor@chromium.org Bug: 1042124 Change-Id: I713a7657c525038b5d4685373fc8155a9ae9c09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022342Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735306}
-
Koji Ishii authored
Following bot results are included. 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 32 lines were removed and 20 lines were deflaked by consecutive results since 1124. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I30e9c7cc425f22e5d841e888dda6083fa64faea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019626Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735305}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d92e4e9de7f1..f93a8436cea5 git log d92e4e9de7f1..f93a8436cea5 --date=short --first-parent --format='%ad %ae %s' 2020-01-26 mtklein@google.com support dither in skvm Created with: gclient setdep -r src/third_party/skia@f93a8436cea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I471269a051a1c8496a0fa126e754f09fc0826728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735304}
-
- 26 Jan, 2020 20 commits
-
-
Rahul Arakeri authored
The CL fixes a bug where the scrollbar thumb and arrows were not being invalidated when users clicked on them. The root cause here was, the MouseEvent(s) were not being passed on deep enough into the main thread scrollbar code (where the logic to invalidate exists). Bug: 1040258 Change-Id: I3a1b413aea06b437f07e37822e16fcfcab11aef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008132 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735303}
-
Liquan (Max) Gu authored
Because ExpandablePaymentHandlerBrowserTest.CancelPayment is flaky, disable the test before we find the cause. Bug: 1045274 Change-Id: Iaa253bccc7edc8141061dd8df5aa921ca1bc89bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020570Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#735302}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3963a330245..d92e4e9de7f1 git log d3963a330245..d92e4e9de7f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-26 mtklein@google.com cache only when SkVM has a JIT Created with: gclient setdep -r src/third_party/skia@d92e4e9de7f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I5f60a3506d97f7adde9c1d94062a0653857aa251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021610Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f85fe1366887..d3963a330245 git log f85fe1366887..d3963a330245 --date=short --first-parent --format='%ad %ae %s' 2020-01-26 reed@google.com offer raw-array variant of remaining 44 methods Created with: gclient setdep -r src/third_party/skia@d3963a330245 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Iab6f42609b5514873817dce4c5df1b20e8bacf6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021609Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: Id538e6401c0bb27e206b9288ba8c55a37c5d3d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015254 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735299}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I42300bde4027f3dcb3a75f707fe32dca6b87b53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017407 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735298}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: I801d46c86d1ee02b69135224271f442595601a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017349Reviewed-by:
-
Ben Kelly authored
This CL fixes a mistake introduced in crrev.com/c/2005291. That previous change was trying to ensure that the IOThreadHostImpl was destroyed before other members, but accidentally got it reversed. C++ members are destroyed in reverse order so the IOThreadHostImpl member should be declared at the end of the class similar to the WeakPtrFactory. Bug: 1038019 Change-Id: I66e1ee2e6fc4b02399d82af16cff33f118af671c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019504Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#735296}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: Ie802b1bbdc036ff2089a5874286a2b62fdbb4fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014919 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: Ic8e0433afeeabe0b65e8aed99c40b3a8ff513abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017426Reviewed-by:
-
Yusuke Sato authored
This is a follow-up CL for CL:2016290. BUG=None TEST=try Change-Id: I7965ab61243b5de40c7364ce9678eb403303ffea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019803Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#735293}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I52b9fee727c727d117d7b40c0a17feded176b217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015173 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I4f115443c7eafc2749f5211f797f38028dd2f75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015251 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=danyao@chromium.org Bug: 1042208 Change-Id: I679be34e3d05dfe6b33245832224331226169c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017467Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735290}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I21abc98656bf320207009b9d3b089756eb1222ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017346 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735289}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: Ib1a31e11328581549e15b3c9c696da931458f71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015172 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. SHERIFFS: If one of the tests touched in this CL becomes/is flaky, *please* add it to TestExpectations beneath the section for bug 1035582, and mark it with a *new* bug number. At this point, any further failing tests are flaky on their own, not because of this rebaseline. Thanks! [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I489fc7ddac515567bcd1cb3a889c0f76ed2165b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016291 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#735287}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 1042208 Change-Id: I60da46d57ac3b61e0b291e76f93460781d63dd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017282Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735286}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=kristipark@chromium.org Bug: 1042208 Change-Id: Ib50e257b13da3b118fc4f011b8274f1f9d3d0178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017322Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735285}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=justincohen@chromium.org Bug: 1042208 Change-Id: If3b61d1813d21bd61bda77083fa3b4de3492a9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017368Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735284}
-
