GitLab

Revert of Make the extension's sidebar pane auto-resizable. (patchset #7 id:120001 of https://codereview.chromium.org/1905493002/ )

Reason for revert:
Regression: sources tab extension panels do not render correctly
BUG=622456

Original issue's description:
> Make the extension's sidebar pane auto-resizable.
>
> Setting height of the sidebar pane is a relic from the old design where panes were expandable (https://developer.chrome.com/static/images/devtools-panels.png). In the current design, where panes are tabs, it doesn't make sense.
>
> BUG=438126
>
> Committed: https://crrev.com/7ff544f5fa1d09072def5419d74f8c0e5f42365e
> Cr-Commit-Position: refs/heads/master@{#391965}

TBR=paulirish@chromium.com,pfeldman@chromium.com,paulirish@chromium.org,kdzwinel@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=438126

Review-Url: https://codereview.chromium.org/2155173003
Cr-Commit-Position: refs/heads/master@{#406149}

With this CL, there is no remaining call to these methods on Mac:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::ReleaseSoon
- MessageLoop::DeleteSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

Note that this CL also removes calls to these methods from files that
are not built on Mac.

These calls were not migrated by the clang-tidy script used previously
for various reasons (Objective-C code, templates, macros, header files,
std::unique_ptr<MessageLoop>...).

This CL was generated manually (with the help of a few regular
expressions).

BUG=616447
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=sdefresne@chromium.org (for ios/'s trivial application of this refactoring)

Review-Url: https://codereview.chromium.org/2132593002
Cr-Commit-Position: refs/heads/master@{#406148}

This is part of a larger effort to make all CSSValue::create() methods
return const pointers.

BUG=526586

Review-Url: https://codereview.chromium.org/2047813006
Cr-Commit-Position: refs/heads/master@{#406147}

windowID injection will fail if WKUserScript has not been injected yet
and __crWeb object is not present. windowID injection is critical for
many features to function and on failure it should be retried.

So far injection failure has been observed only in KIF test.

BUG=628316

Review-Url: https://codereview.chromium.org/2161463002
Cr-Commit-Position: refs/heads/master@{#406146}

The renderer process kills with reason RFH_INVALID_ORIGIN_ON_COMMIT are
checking parameters passed from the renderer process. However, we are
lacking a bunch of information since it is in the browser process and
it is hard to reason about what the state was in the renderer.

We can also try to implement similar checking in the renderer process,
so we can catch these mismatches closer to where we have more data.
This CL implements some of the checks performed browser side, but
it is a set that should catch the majority of the cases we have seen
in crash reports.

BUG=628677
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2151323003
Cr-Commit-Position: refs/heads/master@{#406145}

Make ResourceBundle::IsScaleFactorSupported public.
(check when loading ash shell/sysui/tests resources)

Refactor GN's target for ash_test_strings.pak generation.
(can be used to generate locale-specific ash string paks)

Skip renaming of test string/resource paks for ash_sysui.
Update some comments and TODOs.

BUG=628715
TEST=No behavioral changes or regressions; automated tests.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2148363003
Cr-Commit-Position: refs/heads/master@{#406144}

These were temporary metrics intended to understand whether high/low
resolution clocks adversely impact page load metrics. After collecting a few
months of data it was determined that clock resolution doesn't adversely
impact our metrics, and it that these histograms were no longer needed.

BUG=394757

Review-Url: https://codereview.chromium.org/2155143003
Cr-Commit-Position: refs/heads/master@{#406143}

Currently, each page load through data_reduction_proxy will create a
pingback, and sends those pingbacks one at a time. The proto has
infrastructure to batch those page load metrics that will reduce the
request overhead for cases that are slow to send the pingback, but have
multiple page load metrics trying to be reported around the same time.

BUG=628721

Review-Url: https://codereview.chromium.org/2155783002
Cr-Commit-Position: refs/heads/master@{#406142}

BUG=

Review-Url: https://codereview.chromium.org/2154213002
Cr-Commit-Position: refs/heads/master@{#406141}

Just omit the link instead.

NOTRY=true

Review-Url: https://codereview.chromium.org/2151653005
Cr-Commit-Position: refs/heads/master@{#406140}

Review-Url: https://codereview.chromium.org/2121793002
Cr-Commit-Position: refs/heads/master@{#406139}

BUG=629004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2156393002
Cr-Commit-Position: refs/heads/master@{#406138}

Creating a directory for the new language detector called CLD3 and adding OWNERS, LICENSE, and README.chromium files.

BUG=

Review-Url: https://codereview.chromium.org/2110083003
Cr-Commit-Position: refs/heads/master@{#406137}

In order to be able to promote a buffer to full screen overlay on CrOS
the buffer needs to be in an RGB format and resource_size_in_pixels
has to be set on the quad.

This CL makes sure overlay candidates coming from exo satisfy those
two requirements.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2160113002
Cr-Commit-Position: refs/heads/master@{#406136}

This patch is only to ensure when submitting patches that no double
semicolons are submitted.

BUG=none

Review-Url: https://codereview.chromium.org/2153703003
Cr-Commit-Position: refs/heads/master@{#406135}

Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed.

Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted.

BUG=624020

Review-Url: https://codereview.chromium.org/2106903002
Cr-Commit-Position: refs/heads/master@{#406134}

BUG=628374
TEST=manual test looks good on https://webrtc.github.io/samples/src/content/devices/input-output/ when playing plugging and unplugging on chromeos.

Review-Url: https://codereview.chromium.org/2155503002
Cr-Commit-Position: refs/heads/master@{#406133}

Previously it printed nothing because it didn't collect the root nodes.

Review-Url: https://codereview.chromium.org/2157173002
Cr-Commit-Position: refs/heads/master@{#406132}

Because we will may need these values in future commits.

BUG=624366
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105173006
Cr-Commit-Position: refs/heads/master@{#406131}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2162683002
Cr-Commit-Position: refs/heads/master@{#406130}

This test:
virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll-interrupted.html
is flaky under Release as well on Linux.

Please refer to the Chromium flakiness dashboard here:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Ffast%2Fscroll-behavior%2Fsmooth-scroll%2Fmousewheel-scroll-interrupted.html

TBR=ymalik@chromium.org

Review-Url: https://codereview.chromium.org/2156953003
Cr-Commit-Position: refs/heads/master@{#406129}

Compiling w/ clang on CrOS, the compiler caught an unnecessary std::move()
in a CrOS-only file with the -Wpessimizing-move warning.

R=posciak@chromium.org, llozano@chromium.org
BUG=626241

Review-Url: https://codereview.chromium.org/2151483006
Cr-Commit-Position: refs/heads/master@{#406128}

Revert of Add a PGO tag for the PGO builds in chrome://version (patchset #3 id:40001 of https://codereview.chromium.org/2157563002/ )

Reason for revert:
It's breaking a chromiumos bot: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/23038

Original issue's description:
> Add a PGO tag for the PGO builds in chrome://version
>
> Also remove the VS2013 version string as we don't support it anymore.
>
> BUG=309849
>
> Committed: https://crrev.com/cbb31e640ae7ee7a9e03df917d5bba25415c13f0
> Cr-Commit-Position: refs/heads/master@{#406119}

TBR=brucedawson@chromium.org,sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=309849

Review-Url: https://codereview.chromium.org/2160013003
Cr-Commit-Position: refs/heads/master@{#406127}

This is required to show the status area widget in mojo:ash.

* Initialize various service singletons in WindowManagerApplication
* Add ash strings to the window manager pak file

BUG=619636
TEST=ash_unittests, mash_unittests

Review-Url: https://codereview.chromium.org/2155743003
Cr-Commit-Position: refs/heads/master@{#406126}

I remembered some RAPPOR tasks being Janky and looked
at sampling profiler data for this code and noticed there
was a lot of string copies. This CL makes some intermediate
parts use StringPiece to avoid some copies. There's still
more copies to go, but this should reduce how many we need.

BUG=none

Review-Url: https://codereview.chromium.org/2156383002
Cr-Commit-Position: refs/heads/master@{#406125}

https://chromium.googlesource.com/skia.git/+log/034f243c6de4..d876a4b54999

$ git log 034f243c6..d876a4b54 --date=short --no-merges --format='%ad %ae %s'
2016-07-18 fmenozzi Add bounds info
2016-07-18 reed check for culled-out paths inside SkDraw

BUG=629026

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2158953003
Cr-Commit-Position: refs/heads/master@{#406124}

The members on_demand_tile_raster_bitmap_ and on_demand_tile_raster_resource_id_
are never used.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2158183002
Cr-Commit-Position: refs/heads/master@{#406123}

Completes shield opacity animation after overview closes.

This CL deals with the transition into and out of the overview
mode.
When the shelf is in SHELF_BACKGROUND_MAXIMIZED state the shield starts
black and animates to 70% black.
When the shelf is transparent or semi-transparent the shield starts
transparent and animates to 70% black.
When overview mode finishes an observer is installed on the shield
widget that deletes itself and the widget once the opacity animation
completes.

BUG=624443

Review-Url: https://codereview.chromium.org/2141133002
Cr-Commit-Position: refs/heads/master@{#406122}

BUG=

Review-Url: https://codereview.chromium.org/2160083002
Cr-Commit-Position: refs/heads/master@{#406121}

A bit ugly, but mostly functional. I think most changes going forward
should be aesthetic, so this seems like a decent place for an initial
commit.

Enabled with --ash-enable-window-cycle-ui flag.

BUG=626111

Review-Url: https://codereview.chromium.org/2129773002
Cr-Commit-Position: refs/heads/master@{#406120}

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849

Review-Url: https://codereview.chromium.org/2157563002
Cr-Commit-Position: refs/heads/master@{#406119}

Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (patchset #8 id:140001 of https://codereview.chromium.org/2062353002/ )

Reason for revert:
caused regression: crbug.com/628970

Original issue's description:
> Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND
>
> This fixes issues where the ntp background image was
> interrupted underneath the detached bookmark bar.
>
> Also the ntp_background color is now forced to be opaque
> even if a none opaque alpha value is provided from the
> theme. This prevent issues with subpixel AA which does not
> work on none opaque background. (and to avoid falling back
> to grayscale AA)
>
> Also see crbug.com/618278
>
> BUG=618335
>
> R=estade@chromium.org, pkasting@chromium.org
>
> Committed: https://crrev.com/bb4e97590966ba4138b759b8a6450e526a24fa27
> Cr-Commit-Position: refs/heads/master@{#405725}

TBR=pkasting@chromium.org,j.isorce@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=618335

Review-Url: https://codereview.chromium.org/2159833002
Cr-Commit-Position: refs/heads/master@{#406118}

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

Generated with clang-tidy.
See https://chromium.googlesource.com/chromium/src/+/master/docs/clang_tidy.md

BUG=None

Review-Url: https://codereview.chromium.org/2152373003
Cr-Commit-Position: refs/heads/master@{#406117}

BUG=333201

Review-Url: https://codereview.chromium.org/2129413002
Cr-Commit-Position: refs/heads/master@{#406116}

This CL re-lands r405933 and removes the hack that was needed while
rolling in the reworked v8_target_cpu code, but this adds the missing
line that was needed for CrOS to work correctly with their custom
toolchain.

TBR=machenbach@chromium.org, llozano@chromium.org
BUG=593461, 625353

Review-Url: https://codereview.chromium.org/2158143002
Cr-Commit-Position: refs/heads/master@{#406115}

received from the PVer4 service.

BUG=543161

Review-Url: https://codereview.chromium.org/2151953003
Cr-Commit-Position: refs/heads/master@{#406114}

TBR=thestig@chromium.org
BUG=629167

Review-Url: https://codereview.chromium.org/2160783002
Cr-Commit-Position: refs/heads/master@{#406113}

load_flags used to be used in DataReductionProxyDelegate to resolve the
proxy, but it no longer does. load_flags should not be needed to resolve
a proxy for a request.

load_flags was previously used for the CriticalPathBypassFieldTrial:

https://chromium.googlesource.com/chromium/src/+/db1198c5327b5c69b93fafd814b9f516b88a15fd%5E%21/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

BUG=

Review-Url: https://codereview.chromium.org/2110973002
Cr-Commit-Position: refs/heads/master@{#406112}

BUG=414157

Review-Url: https://codereview.chromium.org/2158703002
Cr-Commit-Position: refs/heads/master@{#406111}

This declares a new GN arg save_unstripped_output that can be enabled if
enable_stripping=true. If true, then an unstripped copy of the linker output
will be saved in the output directory with an ".unstripped" suffix.

BUG=628052
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2157573002
Cr-Commit-Position: refs/heads/master@{#406110}