GitLab

Bug: 177475
R=engedy@chromium.org

Change-Id: I38b363d9c53e7b1d1dbf8249838058df2f94fee2
Reviewed-on: https://chromium-review.googlesource.com/889841
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532110}

Bug: 177475
R=sadrul@chromium.org

Change-Id: I165ce28b3358f76329f3b6ea2ef05c566ee6e411
Reviewed-on: https://chromium-review.googlesource.com/889799Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532109}

Fixes a bug where an extra GPU.ContextLost.Unknown was counted for each
GPU.ContextLost.UICompositor.

Bug: 177475
R=sadrul@chromium.org

Change-Id: I5b6ee09b924602d641255a607b96d00e6569df49
Reviewed-on: https://chromium-review.googlesource.com/889720Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532108}

Also move FLAGS_chromium_http2_flag_h2_on_stream_pad_length from
spdy/chromium/spdy_flags.{h,cc} to
spdy/platform/impl/spdy_flags_impl.{h,cc}, and rename to
h2_on_stream_pad_length.

This CL merges server side changes 182949930 by jtoohill
and 182975401 by diannahu.

Bug: 488484
Change-Id: I1dc62b04a0529261bc72f498dd2987a8dd2f748c
Reviewed-on: https://chromium-review.googlesource.com/887903Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532107}

Bug: 177475
R=jdoerrie@chromium.org

Change-Id: I0e191e6b55f3063984bdba319d245bbec3bd55ab
Reviewed-on: https://chromium-review.googlesource.com/889759Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532106}

Bug: 177475
R=meacer@chromium.org

Change-Id: Iaa60724d160144a2aa74c49dca0be44229f29ccd
Reviewed-on: https://chromium-review.googlesource.com/889818Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532105}

Bug: 177475
R=mgersh@chromium.org

Change-Id: I5ed190e0471690772507ba5034154773987d7651
Reviewed-on: https://chromium-review.googlesource.com/889820Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532104}

Bug: 177475
R=estade@chromium.org

Change-Id: I4f3b6133bb2c4ea46f3db57482c96351bdb3e551
Reviewed-on: https://chromium-review.googlesource.com/889763Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532103}

Bug: 177475
R=boliu@chromium.org

Change-Id: I31d7cd6f12d989557283bf3d5004f5310aa813bb
Reviewed-on: https://chromium-review.googlesource.com/889798
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532102}

GpuMemoryBufferVideoFramePool::CopyVideoFrameToGpuMemoryBuffers schedules
copies to GMBs using a Pool thread, so the upload is sliced and run in
parallel, reconvening after all sub tasks are finished.

This CL adds an ASYNC TRACE to track the duration of the full copy cycle,
encompassing all the parallel (and possibly heterogenous) uploads, to
make it easy to reason about how much time the copy-to-GMBs take.

Bug: 803975
Change-Id: Ied827b30b43931ca06996c97dd8f855b75c9ff7a
Reviewed-on: https://chromium-review.googlesource.com/886962Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532101}

Pop all operators with greater/equal precedence rather than just the
top-most.

Bug: 803824
Change-Id: I5f106a0e82ed98ba2510c86ed157bf4b133cb5b8
Reviewed-on: https://chromium-review.googlesource.com/888919
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#532100}

Add ikilpatrick as a core OWNER following successful nomination.

NOTRY=true

Change-Id: I05211c6dc88243a7d2f9bfcc00cb3a86fb8b1a66
Reviewed-on: https://chromium-review.googlesource.com/889622
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532099}

Since the argument |selection_start| is used to compute two LayoutPoints,
this patch salvages them from IsVibisile to the caller CompositedSelectionBound
which already has the LayoutPoints.

Bug: 789870
Change-Id: I43e751d35268466e910ac826820010a719a8298e
Reviewed-on: https://chromium-review.googlesource.com/888338Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532098}

CompositedSelectionBound.is_text_direction_rtl is assigned twice
redundantly.
This patch unifies it.

Change-Id: I6bb3e2a4139de363ec76af03b54f8137f7e8e4fc
Reviewed-on: https://chromium-review.googlesource.com/885679Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532097}

The comment became outdated after r526949.

R=kinuko

Bug: 612308
Change-Id: Ib794fe01bf78ed5f2986843b1ee9f74485ec48d3
Reviewed-on: https://chromium-review.googlesource.com/888098Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532096}

Bug: 806145
Change-Id: Ia3348c5f9c1c589d805fb583890169dc38516e39
Reviewed-on: https://chromium-review.googlesource.com/888160Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532095}

(Link to working run on Win7 bot:
https://chromium-swarm.appspot.com/task?id=3b4d2229fcb0aa10&refresh=10&show_raw=1)

Bug: 805409, 804452
Change-Id: Ieea7271856276162483e9a4240452701a1e062e7
Reviewed-on: https://chromium-review.googlesource.com/889701
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532094}

The use of base::SingleThreadTaskRunner is already allowed according
to audit-non-blink-usage.py, but #include of the header was not
allowed except in Source/platform/.

This patch allows the include in the other places of Source/.

base::SingleThreadTaskRunner will be used much more frequently in
Blink, after we finish the conversion of WebTaskRunner. This change
prepares for it.

Bug: 763980, 794845
Change-Id: Iab0ed63f23efdfcb05df0b219bbed98e53f36f9c
Reviewed-on: https://chromium-review.googlesource.com/888300Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532093}

In jumbo builds, there is no careful inclusion of headers
so files that require very careful handling of when they are
included cause problems. One such file was print_messages.h
because of an undef it did of another include guard.

This patch moves the undef one layer out of print_messages.h
so that print_messages.h itself can be included many time.

Bug: 746957
Change-Id: Ie44fe5dbd4665cc487788fe7b6e42ebcd20cc50f
Reviewed-on: https://chromium-review.googlesource.com/878325Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532092}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I20d6e94f1e192b18814959be24fd8648cefb7fd9
Reviewed-on: https://chromium-review.googlesource.com/884883Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532091}

Modify GpuProcessHost to be able to inject the necessary mojo pipe
creation functionality so that ozone/drm can use mojo IPC when enabled
by a command line flag.

BUG=620927

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I585b1f66cbddb60beea886dda700a37357b89e5c
Reviewed-on: https://chromium-review.googlesource.com/861906
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532090}

(1) A ExamplePreprocessorConfig proto is added.

(2) A ExamplePreprocessor class that build on a config proto and does
    preprocessing including missing feature handling and bucketization.

(3) A ExampleFloatIterator is also added to iterate through all
    features of a RankerExample.

(4) Add a unittest.

Change-Id: I0de0f2fa6d6e9b7ae3b873d8b7b00009cd04ec80
Reviewed-on: https://chromium-review.googlesource.com/872831Reviewed-by: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532089}

Don't list the context snapshot in the mojo manifest's required_files
in builds with use_v8_context_snapshot=false. Tweak existing manifest
overlay functionality to allow merging of required_files lists from
multiple manifests.

This avoids an "Ignoring invalid file v8_context_snapshot.bin" warning
on each browser stratup in use_v8_context_snapshot=false builds.

Bug: 804293
Change-Id: I0f4731811044980b7466887bedcaf115ee1fb288
Reviewed-on: https://chromium-review.googlesource.com/878371Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com>
Cr-Commit-Position: refs/heads/master@{#532088}

This reverts commit 8c08d938:
> Revert LayoutView::StyleWillChange viewport invalidation
>
> This patch is a speculative revert of the following patch:
> "Let LayoutView::StyleWillChange handle viewport invalidation."
> https://chromium-review.googlesource.com/c/chromium/src/+/609984
> r495573
> 1fac40c9
>
> This patch could be responsible for regressions in the following:
> * Blink.Paint.UpdateTime
> * Blink.Compositing.UpdateTime
>
> Bug: 768612
> Change-Id: I8d12b80473afee2eecdb3ff1a8c3538f334eaf59
> Reviewed-on: https://chromium-review.googlesource.com/719336
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Rune Lillesveen <rune@opera.com>
> Commit-Queue: Rune Lillesveen <rune@opera.com>
> Cr-Commit-Position: refs/heads/master@{#509012}

Unfortunately we couldn't observe performance metric recovery from the
speculative revert, thus landing the CL again and we will be watching if
performance fluctuated.

BUG=768612

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I05c2a6bfe0f85cffdbf0b2ea1813a3ff7a83f05d
Reviewed-on: https://chromium-review.googlesource.com/848153
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532087}

Also restrict hang reporting to the Canary channel while uncovered
issues stabilize.

R=asviktine@chromium.org

Bug: 806174, 804345
Change-Id: Ie99b0e7b36d606102642ccab10ef3a30832f08ab
Reviewed-on: https://chromium-review.googlesource.com/888498Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532086}

When showing ElementsPanel, all the tree outlines are not wired
to DOMModels yet, and therefore did not updated root node with a document.
We used to manually do that from ElementsPanel, but removed it recently.

Bug: 805353
Change-Id: I2b15a2368de92bcda090b95f22e912e553badd9b
Reviewed-on: https://chromium-review.googlesource.com/887648Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532085}

BUG=633030

Change-Id: Iaa27af5e6d3b4b55d11e044dc57e23dcf0682b39
Reviewed-on: https://chromium-review.googlesource.com/846356Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532084}

. Use OnceCallback for the 'benchmark done' callback.
. Remove an unncessary callback-runner function.

BUG=none

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib990293e05960755844fd1e5156e459b187c2e1c
Reviewed-on: https://chromium-review.googlesource.com/887163
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532083}

This is to evaluate if the mask DstIn optimization[1] is still useful.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp?rcl=399e97834e0f1b08ee104789a87482fd79712da0&l=383

Change-Id: I85b07a05d156020fe8bf20f38c38b722f6efb7a0
Reviewed-on: https://chromium-review.googlesource.com/882496Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532082}

Partial interfaces do not have constructors, so we can't nominate
them as members of V8ContextSnapshotExternalReferences.


Bug: 806163
Change-Id: I28e20fac326d57851f6443cca7c0c53bc86680fb
Reviewed-on: https://chromium-review.googlesource.com/888181Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532081}

Before this CL,
  we used V8Foo::InstallRuntimeEnabledFeatures() if we don't have V8FooPartial, and
  we used V8Foo::install_runtime_enabled_features_function() if we have.
It was confusing and difficult to call the correct one.

This CL does
 - rename InstallRuntimeEnabledFeatures() as InstallRuntimeEnabledFeaturesImpl()
 - create a new API 'InstallRuntimeEnabledFeautres()', which has same name as before
then callsites do not need to care whether the target interface has partial interface or not.



Bug: 806167
Change-Id: I6f277f2bb254df7cbe0fb193dd2f91c7ac1b1778
Reviewed-on: https://chromium-review.googlesource.com/888380Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532080}

This only affects the client hints that are requested by
origins using "Accept-CH" header.

Before this change, origins can request client hints
using the main frame response. Chrome would then attach
the requested client hints on either HTTP or
HTTPS subresources. With this change, the client hints
would be attached on HTTPS subresources only.

This is guarded behind a WebRuntimeFeature which will
be enabled after external communication on blink-dev.

This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/852863.

Bug: 782381
Change-Id: I462178bd6ed3fe08faa2ee67dcba306468ae1ca8
Reviewed-on: https://chromium-review.googlesource.com/887348Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532079}

Bug: 711517
Change-Id: I78f6c274a62066039f69fcf2ac66f232379b959c
Reviewed-on: https://chromium-review.googlesource.com/887737Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532078}

Merge PaymentRequestTestCommon into PaymentRequestTestRule since there is
no long need for sharing the implementation with other classes

Bug: 711517
Change-Id: I5810b58ac3850a38137d5c7debd782b664862c4b
Reviewed-on: https://chromium-review.googlesource.com/886838Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532077}

use the login password if this substitution variable exists.

BUG=chromium:386606

Change-Id: I8b4a804dbee1ebf38afcbc7a381d5f4df515a8da
Reviewed-on: https://chromium-review.googlesource.com/868507
Commit-Queue: May Lippert <maybelle@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532076}

This CL updates the testing configuration for the in-product help
feature for data saver.

BUG=748574

Change-Id: I782c429d67f04eca00c4a56172e0632f59c056a4
Reviewed-on: https://chromium-review.googlesource.com/885089Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532075}

This CL updates the testing configuration for the in-product help
feature for downloading web pages on Android after taking a
screenshot to the planned launch configuration.

BUG=748574

Change-Id: Iee3f04274649c62d3476539bd04441e6730fbd18
Reviewed-on: https://chromium-review.googlesource.com/884985Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532074}

Got reported by automated linter at:
https://bugs.chromium.org/p/chromium/issues/detail?id=805881

Bug: 805881

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia11917484274dda0c2f3f3914da3dce37376e2fe
Reviewed-on: https://chromium-review.googlesource.com/887748
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532073}

This patch adds test cases about vertical text and overflowing or
underflowing text to LocalCaretRectTest, to help the implementation
of the NG version of LocalCaretRectOfPosition().

Bug: 771398
Change-Id: I21a6a07cf1246b9dd867e7b5a4fe44aa101a2aff
Reviewed-on: https://chromium-review.googlesource.com/887918Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532072}

This CL adds android:host="*" to the intent filter and removes the
AppLinkUrlError suppression.

Bug: 804441
Change-Id: I30dc3f0171fbfb6b4f195b90f7deba0fd43911ba
Reviewed-on: https://chromium-review.googlesource.com/879584Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532071}