- 19 Dec, 2019 40 commits
-
-
Kurt Horimoto authored
This will allow this functionality to be shared between overlay-based and legacy infobar presentation. Bug: 1030357 Change-Id: I3f3182cf41880ba03b5f4257936230238c72f8e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975016 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baf7a8617f37..2627d4d90fac Created with: gclient setdep -r src-internal@2627d4d90fac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: Ia1f46d7fe65dfcc88773ba73d84776565d891a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976450Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726439}
-
Zhongyi Shi authored
Those experimental APIs are consumed by some customers, and needs to be supported indefinitely. Add those APIs to presubmit checklist will help ensure those APIs are never modified or removed. Change-Id: I057fff4cfe30f08f020717f263f7050be399a000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974701Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#726438}
-
Stephen Nusko authored
This reverts commit 42d682b8. Reason for revert: Breaks perf tests crbug/1035865 Original change's description: > Create MemoryManagedPaintCanvas class > > With deferral enabled a canvas rendering context can create an > unlimited amount of GPU resources between frames. This class allows us > to track how much memory is being pinned and to flush the recording > after we pass a certain threshold. > > Bug: 1016727, 1015729 > Change-Id: I3a64dc07cc0239447aa721ea2a7cc808541a0a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960469 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Reviewed-by: Yi Xu <yiyix@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726085} TBR=jbroman@chromium.org,fserb@chromium.org,khushalsagar@chromium.org,yiyix@chromium.org,aaronhk@chromium.org,juanmihd@chromium.org Bug: 1016727, 1015729,1035865 Change-Id: Ia0e7899b4381ae264ed67ae618d245d6a462067b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976003Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726437}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d04ddcd6c518..4ef1ca1d089e git log d04ddcd6c518..4ef1ca1d089e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 michaelludwig@google.com Fix int/uint comparison in TextureOp asserts 2019-12-19 robertphillips@google.com Add glue to link the GrContext createCompressedBackendTexture API to the GL and Vulkan backends 2019-12-19 jvanverth@google.com Clean up GenDistanceFieldFromPath. 2019-12-19 halcanary@google.com public.bzl: add SKOTTIE_IOS_LIB_{SRCS,HDRS} Created with: gclient setdep -r src/third_party/skia@4ef1ca1d089e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia709854bc94447f47a54ebbc58abe10e254ec567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726436}
-
Ian Kilpatrick authored
In https://chromium-review.googlesource.com/1954925 we added a DCHECK to ensure that a LayoutDeprecatedFlexibleBox was only having layout performed when it had "-webkit-box-orient: vertical". This failed external/wpt/css/css-overflow/webkit-line-clamp-026.html as we weren't reattaching the layout tree when we had a "-webkit-box" with "-webkit-line-clamp", which then had its "-webkit-orient" set to "horizontal". This patch ensures that we reattach the layout-tree in this case. Bug: 993813 Change-Id: Ifa176010ce53804fc3d055983564eb126355d4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975307Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726435}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79994d4369cf..7a9153faa00d git log 79994d4369cf..7a9153faa00d --date=short --first-parent --format='%ad %ae %s' 2019-12-19 lalitm@google.com perfetto: expose the tracing header properly 2019-12-19 lalitm@google.com perfetto: allow usage of tracing.h in bazel Created with: gclient setdep -r src/third_party/perfetto@7a9153faa00d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icef6b56dcdb9ae681beecfdaee2f15e03ec398a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976102Reviewed-by:
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=crouleau@chromium.org Bug: 878390 Change-Id: Ia1d357d29c09a1c0f102c5dbb99dfc0c8e296a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975728 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#726433}
-
David Benjamin authored
The default was changed in https://chromium-review.googlesource.com/c/chromium/src/+/1965952, but I forgot the admin policy documentation also needs updating. Bug: 996894 Change-Id: Ib6ddd9a91e0812662a46125c377ab7486180c447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974578 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726432}
-
Wenyu Fu authored
With recently introduced API SharedPreferenceManager. Migrate HomepageManager to use SharePreferencesManager rather than checking SharedPreferences directly; also move the private preference keys into ChromePreferenceKeys.java Bug: 1022108 Change-Id: Id1be4b4f70ec6c070d8ded81a5e98512f995da15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974320 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#726431}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f321db9a8ea2..9dec123fec99 git log f321db9a8ea2..9dec123fec99 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 syoussefi@chromium.org Ignore nameless vim swap files Created with: gclient setdep -r src/third_party/angle@9dec123fec99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I17af6a691de1999a0e6ff260206b22161ce99f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976104Reviewed-by:
-
arthursonzogni authored
This patch is the revert of the diff in between patchset 4 and 5 of: https://chromium-review.googlesource.com/c/chromium/src/+/1947741/4..5 This caused a 4.2% regression in the octane benchmark. The real reasons is still unknown. It must be investigated. This revert can be seen as a temporary bandage until we figure out the cause of the performance regression. Bug: 1031311 Change-Id: Ib22008a4557b6f05cc170e80cf71762b0b45b4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974092Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726429}
-
Mikel Astiz authored
TrustedVaultClient::FetchKeys() has an asynchronous signature, but the Android implementation (and the JNI bridge) adopted a synchronous implementation prior to this patch. In this proposal, the operation becomes non-blocking, based on: 1. The introduction of a dedicated Java->C++ API call, invoked when the operation completes. 2. The adoption of base.Promise in TrustedVaultClient.Backend, which is an idiomatic way to express that keys will eventually be read. Bug: 1012659 Change-Id: I04b9b32549e5a880d8cbe3da1fffb60ddaa1ae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968991Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726428}
-
Leonard Grey authored
In this CL, it's exposed through the Mac tab menu. A follow-up change will also add it to the tab context menu. Bug: 1021551 Change-Id: I3ca1e67fa5a2215a869016c2a2eeb9a946d79ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954178 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#726427}
-
Michael Spang authored
This broke the build of some Nest devices that don't have libdrm in the build environment. Partially revert enabling this on Linux to fix the build. BUG=1031269 TBR=thomasanderson Change-Id: I596f30849da48d44c246983a08a5cd08f2fbff08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976194Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#726426}
-
Jérôme Lebel authored
Moving accessibility string constants into fake_chrome_identity_interaction_manager_constants target. This is to prepare: crrev.com/c/1958118 Bug: 987646 Change-Id: I963103862ae31cb1bd1006eeb2aecbacfa2482a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973818 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#726425}
-
Andrew Grieve authored
Notice this in SuperSize reports. UI>Browser is probably a better catch-all categorization of the code in //chrome than "Build" is. Change-Id: Id57f0eb0bf69c97381ea5ecde39c039ef8fcdba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976131Reviewed-by:
Dana Fried <dfried@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#726424}
-
Alex Ilin authored
This reverts commit ed56d990. Reason for revert: causes test failures on Android https://crbug.com/1035856. Original change's description: > [Autofill Assistant] Split profiles into usage cases. > > Previously the source for contacts and shipping addresses was the same > sorted list of profiles. There may be cases where we want to sort them > differently, which is enabled by splitting the list in two. > On view we transform the profiles into either Contacts or Addresses. > > Note: This change breaks the default selection based on the account's > address. This is moved to native in crrev/c/1954393 and has not been > recreated here. > > Bug: b/144005336 > Change-Id: I1e8e085f1de2fc7710969e778078495b3b54704b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961197 > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Clemens Arbesser <arbesser@google.com> > Cr-Commit-Position: refs/heads/master@{#726331} TBR=arbesser@google.com,marianfe@google.com,sandromaggi@google.com Change-Id: I56c7b11c9e2e100a39c5350529a8e2afce268bc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/144005336, 1035856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976699Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726423}
-
Nicolás Peña Moreno authored
This CL does the following fixes to crossiframe.html test: * Remove slow-image and onload, which are obsolete assumptions. Instead, rely solely on PerformanceObserver. * Use awaits where needed to make the test logic more sequential. * Use coordinates and test_driver.Actions() to target the iframe. Using the test_driver.click directly won't work for elements in iframes. * Updates the test to check reasonable values for the frame and iframe entries and check that they don't receive each other's entries. This CL also: * Removes unneeded variables from the clickAndBlockMain(). * Removes manual test, which is no longer needed. Bug: 831729 Change-Id: Iff50035a216b21f67cd71796023af4f934573086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972249 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#726422}
-
Aya ElAttar authored
Moved the browsertests of media stream policies out of policy_browsertest.cc & added TODO comment to refactor base::RunLoop::QuitCurrentWhenIdleDeprecated() Bug: 1002483 Change-Id: Ia007dfd0a6b30ed4be0e1eb708899b3f47e1376d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930831Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#726421}
-
Andrew Grieve authored
Change-Id: I7fe91b126afdf7b6db18476579002c1ea03774c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976192 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#726420}
-
Marc Treib authored
This CL adds suffixes Sync, Drive, and Policy to the existing histogram FCMInvalidations.FCMMessageStatus. Having all the different senders in a single histogram made analysis tricky. Since the sender_id constants aren't accessible at the place where the histogram is recorded, they're duplicated. This should be okay since existing sender_ids are not expected to change, and new ones are added infrequently. While I'm here, also add myself as an owner of other FCMInvalidations histograms, since the original owner is OOO. Bug: 1023813 Change-Id: I41d24f4d61c22641eb0e599176fcfff45f2740c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972841 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726419}
-
Pete Williamson authored
This histogram is useful for dashboarding system health. Change-Id: I67bfb8a085b683478d27ebfe61f1d8cc734a7e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970739Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#726418}
-
Olivier Li authored
Also switch from SingleThreadedTaskEnvironment to TaskEnvironment to prepare for activation of HistoryServiceUsesTaskScheduler activation. The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. Bug: 546640 Change-Id: I6c9c414794dc86c96721bdd23ccb31765e6a31c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Gabriel Charette authored
See bug for details. Bug: 1035604 Change-Id: I071fce979094d291171a7fba4b90da2bf70ce711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974585Reviewed-by:
Carlos Caballero <carlscab@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#726416}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf788596f480..5217ad51c521 git log cf788596f480..5217ad51c521 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 enga@chromium.org fuzzing: When fuzzing, always ASSERT, and abort() instead of SIGTRAP Created with: gclient setdep -r src/third_party/dawn@5217ad51c521 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I47d945c7ec45d165bef18adac3aafbd09d32208c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976101Reviewed-by:
-
Mugdha Lakhani authored
This change adds an observer class to BrowserFragmentImpl, so we can observer when the first fragment using WebLayer is attached, and when the last such fragment is detached. For this duration, logic has been added to listen to changes using NetworkChangeNotifier. Manually tested using chrome://inspect and navigator.online(). Not able to test a javatest because the instrumentation test and the activity under test use different class loaders, causing two instances of the NetworkChangeNotifier singleton. It's thus hard to force/mock network connectivity state to observe changes to navigator.online() as a result. Bug: 1018848 Change-Id: I4a4c990ee6e98d5b35f91a68c15baa97def7cd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971926 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726414}
-
Evan Stade authored
Bug: 1034609 Change-Id: Ie32dc7e7a92f8286a5ab3357cfc9a1cb51f2d4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972169Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#726413}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4fd7fccd6db5..6d3c7f5526ec git log 4fd7fccd6db5..6d3c7f5526ec --date=short --first-parent --format='%ad %ae %s' 2019-12-19 swiftshader.regress@gmail.com Regres: Update test lists @ 4fd7fccd Created with: gclient setdep -r src/third_party/swiftshader@6d3c7f5526ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1e505489b251c3e228c5af166c637414b2953cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976098Reviewed-by:
-
yilkal authored
This CL does the following: 1. Adds the kite icon to the page. 2. Simplifies the design to have only 2 different modes. 2.1 Mode 1. For view ports with width > 420px and 2.2 Mode 2. For view ports with width < 420 px (mobile devices or iframes) The changes simplify the error page making it easy to modify without breaking it. Bug: 850328 Change-Id: I9138670ffce0e705456eb5cce7d7ff048ef693d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959849Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#726411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/121ebd03..5b70d915 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied21a258e5f5ed536a3c74fc5a10a4b726db8371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726410}
-
Elly Fong-Jones authored
During the refactors in r723559 and prior two bugs crept in: 1) HasOmniboxKeyword() became inverted so that it returned true if there was *no* omnibox keyword (oops) 2) ShouldAnchorToOmnibox() came to mean "has omnibox keyword" rather than "has omnibox keyword *and* shouldn't anchor to browser/page action", which is what the old code had (oops again) This change fixes both of those errors. Bug: 1033856 Change-Id: I3c7a1a24d223b1893b4945a0aff6c79bc49c3ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966360 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#726409}
-
Aya ElAttar authored
Moved the browsertests of component updater policy and all the related stuff out of policy_browsertest.cc & added TODO comment to refactor base::RunLoop::QuitCurrentWhenIdleDeprecated() Bug: 1002483 Change-Id: Id92bc69cf4aea1ed015fb191bffed6cdafa12121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926138Reviewed-by:
-
Xianzhu Wang authored
Increase difference between the test and the ref. Change-Id: I956a4ef3ee304c0ab25b62cebe1185d6c5e3a941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975383 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#726407}
-
Etienne Bergeron authored
This CL is rewriting the ElideText unittests. The goal of this rewrite is to allow adding more unittests. * ELIDE_HEAD * ELIDE_EMAIL * ELIDE_MIDDLE * Eliding with styles It is now using a templated tests to ease debugging. A change to the way glyph_width_for_test_ work was needed. Zero width codepoints will stay zero width, even if a glyph width is provided. This is required to ensures RLM and LRM (directional marker) stay with width zero. Otherwise a DCHECK is failing since the text can be larger with eliding (2 glyphs instead of 1 glyph). Bug: 1025561 Change-Id: I19f18fb99f52edbbb59d170f7b47bef3a3f3de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975056 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726406}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iba1bec6352c6659c0feceb7e20a29f5c03224de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976100Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8519d85b8ea..baf7a8617f37 Created with: gclient setdep -r src-internal@baf7a8617f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981 Tbr: jbudorick@google.com Change-Id: I2be6e9dc422c7fda35813d3a0d23ec36ae58865b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976099Reviewed-by:
-
Nina Satragno authored
As per the spec [1], the attestation certificate must have the C, O, OU, and CN attributes set. [1] https://w3c.github.io/webauthn/#sctn-packed-attestation-cert-requirements Fixed: 1035092 Change-Id: Iff61fe93136e45a0e20d42a0a08ddf5c34f0bc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974703Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726403}
-
Xiyuan Xia authored
- Add --trace-dir=PATH to chromeos/test_runner.py When present, test_runner script passes the switch with device local path (e.g. /tmp) to gtest to generate trace file on device and collects the trace files back to PATH on host afterwards. - Update run_gtest_benchmark.py to map the trace file path in the test result json collected by test_runner script so that processor scripts could find and computer metrics from the trace file. Example usage: For developers: tools/perf/run_gtest_benchmark.py out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests --device=$DUT --gtest_filter=All/OverviewAnimationsTest.EnterExit/7 --output-dir=/tmp/perf_output --output-format=histograms --dbus-stub --stop-ui For perf bots: testing/scripts/run_performance_tests.py --isolated-script-test-output=/tmp/perf_output/output.json --non-telemetry=true --use-gtest-benchmark-script --gtest-benchmark-name=interactive_ui_tests tools/perf/run_gtest_benchmark.py out_${SDK_BOARD}/Release/bin/run_interactive_ui_tests --device=$DUT --output-format=histograms --dbus-stub --stop-ui Bug: 945711 Change-Id: Ia6911921b8354d7763be96c30a8877c9d598f103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974587 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Yue Zhang authored
Some of the tests disabled by https://crrev.com/c/1951894 are due to unexpected device orientation change possibly caused by previously runned tests changing orientation but never resetting back. Now that we have reset orientation in http://crrev.com/c/1972942, re-enable these tests to see if the problem is resolved. Bug: 1033970, 1030561, 1030562 Change-Id: I41c7bfba8d3a8962423d571196190475e821bc20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976014 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
